From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95851ECE564 for ; Tue, 10 Sep 2024 09:21:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F57A8D0048; Tue, 10 Sep 2024 05:21:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A6868D0002; Tue, 10 Sep 2024 05:21:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E61DB8D0048; Tue, 10 Sep 2024 05:21:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C90E98D0002 for ; Tue, 10 Sep 2024 05:21:56 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 733C7A13BF for ; Tue, 10 Sep 2024 09:21:56 +0000 (UTC) X-FDA: 82548286632.19.6796F54 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 1C25320019 for ; Tue, 10 Sep 2024 09:21:53 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=igf1dGE8; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725960012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=elvJWqxu25XTUdzHltZvQLTg7t++bNW/Qq+PzFZlXNc=; b=7mIDMejzi1in8tqybQP3bN/eBvRqD96IPkXCyFiHWNKXUFmBFERp+22K8M0KTCrRkKTQ42 tMImNCq1++y23IOjXbR2GZBWhR5fZ+4m5AuljEaBk8Ox+BEhAsWTAn8xNf8LYaoVEs5zl/ zQ9jIAZhMgLTXYCgePgSrYdAR64kcBU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725960012; a=rsa-sha256; cv=none; b=Zy/coQsKm08OUqI0Jg6IlxDY1rSZZ/WyM6b1PrsaB7rlxvUkluUz7uihE58FoyDmnevN/r s/AFi+0Hi03joEwCYrhe51PNC0hWmS3JVvDAzxsXVMTpyc/IE9dr+6K9EdK8cu/DWEF/No c47y8mlYo0s02rEV1tEYvYfYSfsM8jM= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=igf1dGE8; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725960113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=elvJWqxu25XTUdzHltZvQLTg7t++bNW/Qq+PzFZlXNc=; b=igf1dGE8hdPRE0CMzcfVcFU+rXrkppY24EQvX8RJb/IT1Zu0Pz0OOOPLJu2T5u5wWLV+mb ipm44HsBFDWNi8BwhU0tEobBfrvbMEIFwEiGmlrpMlC0ACHIBHHmIXfFU7sfsW7T9l6W7U VzcLXu0rIsX0EXEta3+kXTu2Jiz69eA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-614-R2lQxgk4PUm7L4LJj3n3NQ-1; Tue, 10 Sep 2024 05:21:52 -0400 X-MC-Unique: R2lQxgk4PUm7L4LJj3n3NQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-42cb808e9fcso13392485e9.0 for ; Tue, 10 Sep 2024 02:21:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725960111; x=1726564911; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=elvJWqxu25XTUdzHltZvQLTg7t++bNW/Qq+PzFZlXNc=; b=rnjH98ubNtkm46pabwoNyFhTofcqSzpPYP9+0rgOJCVYXCG+h3Ry51+gDW3fwqmsd7 D3tV0PElm0SxDnQ1Jby2DGKQ6m6R+h6Hfi2sB5Bs6oCOCYTvmF3cG/qdubEBZRlbxY2r CHQgVTNkPQ3tiKPCIRFZuxvJWiYVLvFrd9p5R5Pauzz0/XFz0Tu/GARBf/Xl5YJV7lM3 we9Pap3ATtcML753zUC+OfhUMFlkcDHWsdhojCC30+q8oBR5gLBjVv9RJAhgW51I5aH/ kc8fr9JJQMjvfsY9oP+4ofBRm+zJsjU395O19YFInen5VBOH/HOL6CNdwKRmG54rtGbq X8wg== X-Forwarded-Encrypted: i=1; AJvYcCVGXsNfj5LXJN8slGVsiDhEiwF+4EvrS1u5ZBCCA17UoTuvM2jaQDbzchCyFdltuybet5jhJ86NJQ==@kvack.org X-Gm-Message-State: AOJu0Yw+cJGzngzFsu4XOsV/RVTeo0tfDC4V77DKqxwHlklp8ck/K4yq pMspOFGpAn9pNDB0SEpvo5oPYQqOp2ZR2qF2k50diwqMT5cXh1Cq6HsugwQ7MptLhLDSZJj2Au0 OgzobA04hNnJLSTtkVrQcxupFrGEBgapKvaFW9r81N8kqTrjl X-Received: by 2002:a05:600c:3ba3:b0:426:616e:db8d with SMTP id 5b1f17b1804b1-42cae70f5famr74245755e9.15.1725960110907; Tue, 10 Sep 2024 02:21:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHz0BFUpVQGbh16AMQLZGh5Axk8G6tFO097zXS3nFjvaGiHVCWQ0w70n3qnN+WsUSWTsBsGiw== X-Received: by 2002:a05:600c:3ba3:b0:426:616e:db8d with SMTP id 5b1f17b1804b1-42cae70f5famr74245395e9.15.1725960110179; Tue, 10 Sep 2024 02:21:50 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:b600:cfda:b383:a116:a940? (p200300cbc706b600cfdab383a116a940.dip0.t-ipconnect.de. [2003:cb:c706:b600:cfda:b383:a116:a940]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42caeb21a7esm104737915e9.4.2024.09.10.02.21.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Sep 2024 02:21:49 -0700 (PDT) Message-ID: <0a23ba16-5a7a-4f8d-bc5a-887bbe42c77e@redhat.com> Date: Tue, 10 Sep 2024 11:21:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Drop unused set_pte_safe() To: Anshuman Khandual , linux-mm@kvack.org Cc: Andrew Morton , Ryan Roberts , "Mike Rapoport (IBM)" , linux-kernel@vger.kernel.org References: <20240910090409.374424-1-anshuman.khandual@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240910090409.374424-1-anshuman.khandual@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1C25320019 X-Stat-Signature: 33jazhfhkz95e4mib51cnooh9rrfde9d X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725960113-741288 X-HE-Meta: U2FsdGVkX19utuqVY0H3md3KKzJgCTPuHes7BgRjFNtLvipganB4aA4NWHQC5NC84dV6aVl4GvjNzYLL6meJ0ekM3O/Zt436pI7fAm8iM2cvWXE5jk9QyIAwYnpdbBEgh8DqQCf11bmhiiFKU4rGThj7lYLZ8hSzOgdiQcOl2YkKFwiA3lwkTeq+QzZiyG5Mv3Nc2B5RgZKyI4P7eZ06yEXLkjtM5bJzsKjXocqyLrNWiRk4TFaSvG2TNGXs+vkU/1gDfrcvCZ5NcbhVuBhvdHz/1fGrP7IX0w3bUTS94e72HJJ381rc2/7tb8bRP/EUfysMpAMYGiCzj1eDI4zt2stPAFJlVbl7GzCxJCurimEQAD2TOWm0XFutz1pGQm+w0nmqJprjRMH1aOm+4wXI5l5FceJo7PX0DWg4sxoNxH5yiouZOXrBjb+UGx2qnFJJK7luLADsXPrk5y9gBxlpd81z7+4m4YxISkSID6bE/M3PaCwBWIQH6jjte8y+t/mm9scbRhCptj1UMFIOlu06OYc7y041sU/P8y5lNbCzBalCaC+niwayQ1y2tG3TjWZDqjIfQ7lBGSnNu5D09HuJrw1rvLLuZExtCt5vynZDaAz4c/gQtrb7mU3HLzpk1nxD3tfF8w/va4IY9SibvWNVLsP1w2+FNpzrTHB1N+xgz/CRT3wex/VbS07BUo5IXwWzdRydFNEMoLUw2x3GOjasGAfAFFpr8ccm/I0pVR96EJH3VEIraNq86UA8YrbhbKq8TEUMY4p7Yo/3VQ3SNBu5rPHT1tV5bTnHbF17Eo59EBx0VVoW/IttJ0SBW6ZoYRarkGNm0UWYJE3SN0X8Slpi5MENsCDm2YInxJqyAfmBTF3mJX7Zh9eaJKFHRf5ClSsiuxt0KmXARJZ4z4LOFpYIvcBseySidaXGGixsdnT4kGxtt7pQBJSpHYCcbHyo380Bkjr0LJ6pM53Q6uIyYY5 6xnnHeHX 10yaijrELqeyjL0p5axFLTg+9yErn1KQqO+toaNUP6wsj90+AIXYVPyKH3MXtkApA5z1zyIqitIIrUg5H0SYp8YtwcoRYn1tsETHtZlrISTnOmV2cdmSUasiyB9e0BX1Zopd7/0X/1Gauh6EZ6ABj8PJmc+K/Rl7gjKoz9NXAinZ5pjYcL87A45naNsR2KXoDuiiN8/CGEZV+gu5kz36sFL2hHApI5TLCny1Jo7nR+O5hXXKWk4vxbYoVYdvIjB3IaD/er95J+sqDp/5rJ+FZlQ3W/pLyxC3HRZp6wGlRTfN7d2ihwE1fahRtwswvpsHXGXR/yGLvZjXgH5hddfaTYR2hUxM5my7PPP4puGFCOYwpNJsu8W/3E64IID4Lws8FSv0lHTSqcv56n+FuChzbKj4eoqbwwvSQfo1vWMQyaaIWNcN6pgFoQfoA5aQjtAX9LCDg9Y51cJ23E3KKB0rqJBM/c6x6Jd++1UdVb/HK+G0RBrAjTSc5ZxVWEklVwDRv9DKLFxJRVUEkswdIQTHOHZRRuefCexYY4ZIefsUjqlTu24Swox0iGv/tWM3GsyTza8JD7CYqFMJLSsU1KysLd3uOu2cf7wPc/2z7Xf+MoVVW1KvLBg+42d3z5kahUUBB9yc0gstNqjkFEVApnIJp5hNFG4c32gSRvQNr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10.09.24 11:04, Anshuman Khandual wrote: > All set_pte_safe() usage have been dropped after the commit eccd906484d1 > ("x86/mm: Do not use set_{pud, pmd}_safe() when splitting a large page") > This just drops now unused helper set_pte_safe(). > > Cc: Andrew Morton > Cc: David Hildenbrand > Cc: Ryan Roberts > Cc: "Mike Rapoport (IBM)" > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > include/linux/pgtable.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > index 2a6a3cccfc36..aeabbf0db7c8 100644 > --- a/include/linux/pgtable.h > +++ b/include/linux/pgtable.h > @@ -1058,12 +1058,6 @@ static inline int pgd_same(pgd_t pgd_a, pgd_t pgd_b) > * same value. Otherwise, use the typical "set" helpers and flush the > * TLB. > */ > -#define set_pte_safe(ptep, pte) \ > -({ \ > - WARN_ON_ONCE(pte_present(*ptep) && !pte_same(*ptep, pte)); \ > - set_pte(ptep, pte); \ > -}) > - > #define set_pmd_safe(pmdp, pmd) \ > ({ \ > WARN_ON_ONCE(pmd_present(*pmdp) && !pmd_same(*pmdp, pmd)); \ Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb