* [PATCH] maple_tree: Remove redundant semicolons
@ 2025-08-13 9:45 Liao Yuanhong
2025-08-13 11:30 ` Dev Jain
2025-08-13 14:02 ` Liam R. Howlett
0 siblings, 2 replies; 4+ messages in thread
From: Liao Yuanhong @ 2025-08-13 9:45 UTC (permalink / raw)
To: Andrew Morton, Liam R. Howlett, open list:LIBRARY CODE,
open list:MAPLE TREE, open list:MAPLE TREE
Cc: Liao Yuanhong
Remove unnecessary semicolons.
Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
---
lib/test_maple_tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/test_maple_tree.c b/lib/test_maple_tree.c
index cb3936595b0d..1433ecc854cb 100644
--- a/lib/test_maple_tree.c
+++ b/lib/test_maple_tree.c
@@ -3562,7 +3562,7 @@ static noinline void __init check_state_handling(struct maple_tree *mt)
MT_BUG_ON(mt, mas.last != 0x1500);
MT_BUG_ON(mt, !mas_is_active(&mas));
- /* find: start ->active on value */;
+ /* find: start ->active on value */
mas_set(&mas, 1200);
entry = mas_find(&mas, ULONG_MAX);
MT_BUG_ON(mt, entry != ptr);
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] maple_tree: Remove redundant semicolons
2025-08-13 9:45 [PATCH] maple_tree: Remove redundant semicolons Liao Yuanhong
@ 2025-08-13 11:30 ` Dev Jain
2025-08-13 14:02 ` Liam R. Howlett
1 sibling, 0 replies; 4+ messages in thread
From: Dev Jain @ 2025-08-13 11:30 UTC (permalink / raw)
To: Liao Yuanhong, Andrew Morton, Liam R. Howlett,
open list:LIBRARY CODE, open list:MAPLE TREE,
open list:MAPLE TREE
On 13/08/25 3:15 pm, Liao Yuanhong wrote:
> Remove unnecessary semicolons.
>
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
> ---
> lib/test_maple_tree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/test_maple_tree.c b/lib/test_maple_tree.c
> index cb3936595b0d..1433ecc854cb 100644
> --- a/lib/test_maple_tree.c
> +++ b/lib/test_maple_tree.c
> @@ -3562,7 +3562,7 @@ static noinline void __init check_state_handling(struct maple_tree *mt)
> MT_BUG_ON(mt, mas.last != 0x1500);
> MT_BUG_ON(mt, !mas_is_active(&mas));
>
> - /* find: start ->active on value */;
> + /* find: start ->active on value */
> mas_set(&mas, 1200);
> entry = mas_find(&mas, ULONG_MAX);
> MT_BUG_ON(mt, entry != ptr);
Reviewed-by: Dev Jain <dev.jain@arm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] maple_tree: Remove redundant semicolons
2025-08-13 9:45 [PATCH] maple_tree: Remove redundant semicolons Liao Yuanhong
2025-08-13 11:30 ` Dev Jain
@ 2025-08-13 14:02 ` Liam R. Howlett
2025-08-14 2:10 ` Liao Yuanhong
1 sibling, 1 reply; 4+ messages in thread
From: Liam R. Howlett @ 2025-08-13 14:02 UTC (permalink / raw)
To: Liao Yuanhong
Cc: Andrew Morton, open list:LIBRARY CODE, open list:MAPLE TREE,
open list:MAPLE TREE
* Liao Yuanhong <liaoyuanhong@vivo.com> [250813 05:46]:
> Remove unnecessary semicolons.
Thanks!
One nit, it would have been good to state that this is a test code
change in the subject. Usually I use "test_maple_tree:" or something
like "maple_tree: Remove redundant semicolon from test code".
Please mention test in the subject next time.
>
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> ---
> lib/test_maple_tree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/test_maple_tree.c b/lib/test_maple_tree.c
> index cb3936595b0d..1433ecc854cb 100644
> --- a/lib/test_maple_tree.c
> +++ b/lib/test_maple_tree.c
> @@ -3562,7 +3562,7 @@ static noinline void __init check_state_handling(struct maple_tree *mt)
> MT_BUG_ON(mt, mas.last != 0x1500);
> MT_BUG_ON(mt, !mas_is_active(&mas));
>
> - /* find: start ->active on value */;
> + /* find: start ->active on value */
> mas_set(&mas, 1200);
> entry = mas_find(&mas, ULONG_MAX);
> MT_BUG_ON(mt, entry != ptr);
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] maple_tree: Remove redundant semicolons
2025-08-13 14:02 ` Liam R. Howlett
@ 2025-08-14 2:10 ` Liao Yuanhong
0 siblings, 0 replies; 4+ messages in thread
From: Liao Yuanhong @ 2025-08-14 2:10 UTC (permalink / raw)
To: Liam R. Howlett
Cc: Andrew Morton, open list:LIBRARY CODE, open list:MAPLE TREE,
open list:MAPLE TREE
On 8/13/2025 10:02 PM, Liam R. Howlett wrote:
> * Liao Yuanhong <liaoyuanhong@vivo.com> [250813 05:46]:
>> Remove unnecessary semicolons.
> Thanks!
>
> One nit, it would have been good to state that this is a test code
> change in the subject. Usually I use "test_maple_tree:" or something
> like "maple_tree: Remove redundant semicolon from test code".
>
> Please mention test in the subject next time.
OK, I will pay attention to similar submissions next time.
Thanks,
Liao
>
>> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
> Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
>
>> ---
>> lib/test_maple_tree.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/test_maple_tree.c b/lib/test_maple_tree.c
>> index cb3936595b0d..1433ecc854cb 100644
>> --- a/lib/test_maple_tree.c
>> +++ b/lib/test_maple_tree.c
>> @@ -3562,7 +3562,7 @@ static noinline void __init check_state_handling(struct maple_tree *mt)
>> MT_BUG_ON(mt, mas.last != 0x1500);
>> MT_BUG_ON(mt, !mas_is_active(&mas));
>>
>> - /* find: start ->active on value */;
>> + /* find: start ->active on value */
>> mas_set(&mas, 1200);
>> entry = mas_find(&mas, ULONG_MAX);
>> MT_BUG_ON(mt, entry != ptr);
>> --
>> 2.34.1
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-08-14 2:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-13 9:45 [PATCH] maple_tree: Remove redundant semicolons Liao Yuanhong
2025-08-13 11:30 ` Dev Jain
2025-08-13 14:02 ` Liam R. Howlett
2025-08-14 2:10 ` Liao Yuanhong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox