From: Sachin Sant <sachinp@linux.vnet.ibm.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: bharata@linux.ibm.com, Nathan Lynch <nathanl@linux.ibm.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org, Michal Hocko <mhocko@kernel.org>,
Pekka Enberg <penberg@kernel.org>,
linux-mm@kvack.org, Kirill Tkhai <ktkhai@virtuozzo.com>,
David Rientjes <rientjes@google.com>,
Christopher Lameter <cl@linux.com>,
Mel Gorman <mgorman@techsingularity.net>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [RFC 1/2] mm, slub: prevent kmalloc_node crashes and memory leaks
Date: Thu, 19 Mar 2020 14:22:13 +0530 [thread overview]
Message-ID: <0F67B5AA-96DF-4977-BDC6-D72959B3F7EF@linux.vnet.ibm.com> (raw)
In-Reply-To: <e060ad43-ff4e-0e59-2e64-ce8a4916ec70@suse.cz>
> OK how about this version? It's somewhat ugly, but important is that the fast
> path case (c->page exists) is unaffected and another common case (c->page is
> NULL, but node is NUMA_NO_NODE) is just one extra check - impossible to avoid at
> some point anyway.
>
I attempted the suggested tests.
Test 1: March 18 linux-next + Patch 1 [1] + Patch 2 [2]
Machine boots fine. numactl o/p after boot:
# numactl -H
available: 2 nodes (0-1)
node 0 cpus:
node 0 size: 0 MB
node 0 free: 0 MB
node 1 cpus: 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31
node 1 size: 35631 MB
node 1 free: 32724 MB
node distances:
node 0 1
0: 10 40
1: 40 10
#
Test 2: Code base as used in Test 1 + 3 patch series from Srikar [3]
Machine boots fine. numactl o/p after boot:
# numactl -H
available: 1 nodes (1)
node 1 cpus: 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31
node 1 size: 35631 MB
node 1 free: 32711 MB
node distances:
node 1
1: 10
#
Thanks!
-Sachin
[1] https://lore.kernel.org/linux-mm/e060ad43-ff4e-0e59-2e64-ce8a4916ec70@suse.cz/T/#mb8d0a358dc5c5fb9661fa45047072a92c510faf2
[2] https://lore.kernel.org/linux-mm/e060ad43-ff4e-0e59-2e64-ce8a4916ec70@suse.cz/T/#mce342e54a95ce2ee3043901e52d70ee2fd94c516
[3] https://lore.kernel.org/linux-mm/20200311110237.5731-1-srikar@linux.vnet.ibm.com/
next prev parent reply other threads:[~2020-03-19 8:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 14:42 Vlastimil Babka
2020-03-18 14:42 ` [RFC 2/2] Revert "topology: add support for node_to_mem_node() to determine the fallback node" Vlastimil Babka
2020-03-18 16:06 ` [RFC 1/2] mm, slub: prevent kmalloc_node crashes and memory leaks Bharata B Rao
2020-03-18 16:10 ` Vlastimil Babka
2020-03-18 16:51 ` Vlastimil Babka
2020-03-19 8:52 ` Sachin Sant [this message]
2020-03-19 13:23 ` Vlastimil Babka
2020-03-19 13:26 ` Sachin Sant
2020-03-19 13:47 ` Vlastimil Babka
2020-03-19 14:05 ` Srikar Dronamraju
2020-03-19 14:10 ` Vlastimil Babka
2020-03-20 7:46 ` Srikar Dronamraju
2020-03-20 8:43 ` Vlastimil Babka
2020-03-20 10:10 ` Srikar Dronamraju
2020-03-19 14:59 ` Sachin Sant
2020-03-20 3:42 ` Bharata B Rao
2020-03-20 8:37 ` Vlastimil Babka
2020-03-20 8:44 ` Bharata B Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0F67B5AA-96DF-4977-BDC6-D72959B3F7EF@linux.vnet.ibm.com \
--to=sachinp@linux.vnet.ibm.com \
--cc=bharata@linux.ibm.com \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=nathanl@linux.ibm.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox