From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFEDDC43603 for ; Thu, 5 Dec 2019 19:19:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B0FF92464D for ; Thu, 5 Dec 2019 19:19:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="ZX6PGbbx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0FF92464D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4CD6D6B11C2; Thu, 5 Dec 2019 14:19:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 47DBB6B11C3; Thu, 5 Dec 2019 14:19:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BA696B11C4; Thu, 5 Dec 2019 14:19:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0074.hostedemail.com [216.40.44.74]) by kanga.kvack.org (Postfix) with ESMTP id 261026B11C2 for ; Thu, 5 Dec 2019 14:19:12 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id C33F1500F for ; Thu, 5 Dec 2019 19:19:11 +0000 (UTC) X-FDA: 76232050902.24.knife08_503bcfc407112 X-HE-Tag: knife08_503bcfc407112 X-Filterd-Recvd-Size: 3969 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Thu, 5 Dec 2019 19:19:11 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id v23so4361773qkg.2 for ; Thu, 05 Dec 2019 11:19:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=X8Tp/XdEXs+TR5v+c9/suhk5h4IbR9LUYJcwVVfa/Uw=; b=ZX6PGbbxLe5/+H4/x+2ZwhNRSL/jP669CQcGGWDNfkkAp8vql6U0uYnfE+QF3sTNPv ExWqhN1gwNF37jPk7G6+k1S5kUO3VRteOuRzWzoejOtvD4hlOjgSANzsdOEnwtpoPWP2 loOo30hlBIleoDQCDU4y3hF0EO+ggo42JD7IEY1LQ3sXyG2NGfunBUTncU2dCY3lVDSI gtynwEONEhLRiHaSOHJOTEorCytRJRJ5RoRTkfc0MAqPEOyDtimybJOX+nJszIUXokJX hkMRmmbU/uLOAZCR+LXJJjZ1B43W3JGvA69m//0OFwTn4AdK/9bKfGlfduMjV9HgiJVC yr7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=X8Tp/XdEXs+TR5v+c9/suhk5h4IbR9LUYJcwVVfa/Uw=; b=lwFrDaXC2Np1g5JiHbauqRV7tHX1g0Q/GhPwrVdXB2y/icbfHSaOLfGlqzh15/hD09 B1M/XSc7pzWZgXjPRvi9hqoalExYJD5vC5mFMo4mkrRKpDtzepHeeQ3g1kEejzq1MzIN 6kGyea2r+QRoRoiMa01cIck0fm6tmEvjWb9B4H28BkuIIEIHZq9R1zhn8V4X30mMzzBq Uluoyz609UHmYbxMws0RBLxi9OXu+8qUXTX1BN0uS7ItxHVYmJkowW1CCCVg5DTPiBRz pumVgrhwAvxr2ZjBKs3NLYMJUJXGv3vJ72aJjsCObzV9UlWWJAhWuBtunmJIa3uPOJMj 62YQ== X-Gm-Message-State: APjAAAWv4dPNM1hbEfnDjUu/1MVE0qMLNfxq9wQovWprRj3eBGltcwEX 9Fm5KpFfJDpGIu05QSjJhKQW3Q== X-Google-Smtp-Source: APXvYqxARhrKeQEoDRAu0FLed91qByNWJosnqUpmhhkBLUwPDj/7VnH8zVcJgktfsRT/sMody/3aBA== X-Received: by 2002:a37:a348:: with SMTP id m69mr10474834qke.474.1575573550513; Thu, 05 Dec 2019 11:19:10 -0800 (PST) Received: from [192.168.1.183] (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id a63sm5180161qkd.37.2019.12.05.11.19.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Dec 2019 11:19:09 -0800 (PST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: [v3 PATCH] mm: move_pages: return valid node id in status if the page is already on the target node Date: Thu, 5 Dec 2019 14:19:08 -0500 Message-Id: <0E1D1C04-5892-438F-9191-F23CBE1A6DC5@lca.pw> References: <1575572053-128363-1-git-send-email-yang.shi@linux.alibaba.com> Cc: fabecassis@nvidia.com, jhubbard@nvidia.com, mhocko@suse.com, cl@linux.com, vbabka@suse.cz, mgorman@techsingularity.net, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org In-Reply-To: <1575572053-128363-1-git-send-email-yang.shi@linux.alibaba.com> To: Yang Shi X-Mailer: iPhone Mail (17B111) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Dec 5, 2019, at 1:54 PM, Yang Shi wrote: >=20 > This is because the status is not set if the page is already on the > target node, but move_pages() should return valid status as long as it > succeeds. The valid status may be errno or node id. >=20 > We can't simply initialize status array to zero since the pages may be > not on node 0. Fix it by updating status with node id which the page is > already on. This does not look correct either. =E2=80=9CENOENT No pages were found that require moving. All pages are either already on the= target node, not present, had an invalid address or could not be moved beca= use they were mapped by multiple processes.=E2=80=9D move_pages() should return -ENOENT instead.=