From: Zi Yan <ziy@nvidia.com>
To: Yu Zhao <yuzhao@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "\"Huang,
Ying\"" <ying.huang@intel.com>,
Ryan Roberts <ryan.roberts@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
"\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
David Hildenbrand <david@redhat.com>,
"\"Yin, Fengwei\"" <fengwei.yin@intel.com>,
Vlastimil Babka <vbabka@suse.cz>,
"\"Kirill A . Shutemov\"" <kirill.shutemov@linux.intel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Kemeng Shi <shikemeng@huaweicloud.com>,
Mel Gorman <mgorman@techsingularity.net>,
Rohan Puri <rohan.puri15@gmail.com>,
Mcgrof Chamberlain <mcgrof@kernel.org>,
Adam Manzanares <a.manzanares@samsung.com>,
"\"Vishal Moola (Oracle)\"" <vishal.moola@gmail.com>,
Suren Baghdasaryan <surenb@google.com>
Subject: Re: [PATCH v4 0/3] Enable >0 order folio memory compaction
Date: Mon, 12 Feb 2024 13:46:28 -0500 [thread overview]
Message-ID: <0DE890C1-3347-43CA-BDD0-25244C8C2799@nvidia.com> (raw)
In-Reply-To: <CAOUHufa5c9592Vc=S=-Bdc4jy0HVRi2SGJkOQEqj6+CGP_uWxg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 12133 bytes --]
On 12 Feb 2024, at 13:44, Yu Zhao wrote:
> On Mon, Feb 12, 2024 at 9:35 AM Zi Yan <zi.yan@sent.com> wrote:
>>
>> From: Zi Yan <ziy@nvidia.com>
>>
>> Hi all,
>>
>> This patchset enables >0 order folio memory compaction, which is one of
>> the prerequisitions for large folio support[1]. It is on top of
>> mm-everything-2024-02-10-00-56.
>>
>> I am aware of that split free pages is necessary for folio
>> migration in compaction, since if >0 order free pages are never split
>> and no order-0 free page is scanned, compaction will end prematurely due
>> to migration returns -ENOMEM. Free page split becomes a must instead of
>> an optimization.
>>
>> lkp ncompare results (on a 8-CPU (Intel Xeon E5-2650 v4 @2.20GHz) 16G VM)
>> for default LRU (-no-mglru) and CONFIG_LRU_GEN are shown at the bottom,
>> copied from V3[4], since V4 is only a code refactoring of V3.
>> In sum, most of vm-scalability applications do not see performance
>> change, and the others see ~4% to ~26% performance boost under default LRU
>> and ~2% to ~6% performance boost under CONFIG_LRU_GEN.
>
> Suren has been testing 64KB THP on Android and seeing regressions
> under memory pressure (a significant portion of client devices are
> always under memory pressure). Hopefully this series will help.
>
> I threw this series into some stress tests we have with both 64KB and
> 2MB THP enabled and didn't see any obvious problems.
>
> Tested-by: Yu Zhao <yuzhao@google.com>
Thank you for the testing.
>
>> Overview
>> ===
>>
>> To support >0 order folio compaction, the patchset changes how free pages used
>> for migration are kept during compaction. Free pages used to be split into
>> order-0 pages that are post allocation processed (i.e., PageBuddy flag cleared,
>> page order stored in page->private is zeroed, and page reference is set to 1).
>> Now all free pages are kept in a MAX_ORDER+1 array of page lists based
>> on their order without post allocation process. When migrate_pages() asks for
>> a new page, one of the free pages, based on the requested page order, is
>> then processed and given out.
>
> And THP <2MB would need this feature (spell it out).
Will add this.
>
>
>
>> vm-scalability results on CONFIG_LRU_GEN
>> ===
>>
>> =========================================================================================
>> compiler/kconfig/rootfs/runtime/tbox_group/test/testcase:
>> gcc-13/defconfig/debian/300s/qemu-vm/mmap-xread-seq-mt/vm-scalability
>>
>> commit:
>> 6.8.0-rc1-mm-everything-2024-01-29-07-19+
>> 6.8.0-rc1-split-folio-in-compaction+
>> 6.8.0-rc1-folio-migration-in-compaction+
>> 6.8.0-rc1-folio-migration-free-page-split+
>>
>> 6.8.0-rc1-mm-eve 6.8.0-rc1-split-folio-in-co 6.8.0-rc1-folio-migration-i 6.8.0-rc1-folio-migration-f
>> ---------------- --------------------------- --------------------------- ---------------------------
>> %stddev %change %stddev %change %stddev %change %stddev
>> \ | \ | \ | \
>> 15107616 +3.2% 15590339 +1.3% 15297619 +3.0% 15567998 vm-scalability.throughput
>>
>> =========================================================================================
>> compiler/kconfig/rootfs/runtime/tbox_group/test/testcase:
>> gcc-13/defconfig/debian/300s/qemu-vm/mmap-pread-seq/vm-scalability
>>
>> commit:
>> 6.8.0-rc1-mm-everything-2024-01-29-07-19+
>> 6.8.0-rc1-split-folio-in-compaction+
>> 6.8.0-rc1-folio-migration-in-compaction+
>> 6.8.0-rc1-folio-migration-free-page-split+
>>
>> 6.8.0-rc1-mm-eve 6.8.0-rc1-split-folio-in-co 6.8.0-rc1-folio-migration-i 6.8.0-rc1-folio-migration-f
>> ---------------- --------------------------- --------------------------- ---------------------------
>> %stddev %change %stddev %change %stddev %change %stddev
>> \ | \ | \ | \
>> 12611785 +1.8% 12832919 +0.9% 12724223 +1.6% 12812682 vm-scalability.throughput
>>
>>
>> =========================================================================================
>> compiler/kconfig/rootfs/runtime/tbox_group/test/testcase:
>> gcc-13/defconfig/debian/300s/qemu-vm/lru-file-readtwice/vm-scalability
>>
>> commit:
>> 6.8.0-rc1-mm-everything-2024-01-29-07-19+
>> 6.8.0-rc1-split-folio-in-compaction+
>> 6.8.0-rc1-folio-migration-in-compaction+
>> 6.8.0-rc1-folio-migration-free-page-split+
>>
>> 6.8.0-rc1-mm-eve 6.8.0-rc1-split-folio-in-co 6.8.0-rc1-folio-migration-i 6.8.0-rc1-folio-migration-f
>> ---------------- --------------------------- --------------------------- ---------------------------
>> %stddev %change %stddev %change %stddev %change %stddev
>> \ | \ | \ | \
>> 9833393 +5.7% 10390190 +3.0% 10126606 +5.9% 10408804 vm-scalability.throughput
>>
>> =========================================================================================
>> compiler/kconfig/rootfs/runtime/tbox_group/test/testcase:
>> gcc-13/defconfig/debian/300s/qemu-vm/lru-file-mmap-read/vm-scalability
>>
>> commit:
>> 6.8.0-rc1-mm-everything-2024-01-29-07-19+
>> 6.8.0-rc1-split-folio-in-compaction+
>> 6.8.0-rc1-folio-migration-in-compaction+
>> 6.8.0-rc1-folio-migration-free-page-split+
>>
>> 6.8.0-rc1-mm-eve 6.8.0-rc1-split-folio-in-co 6.8.0-rc1-folio-migration-i 6.8.0-rc1-folio-migration-f
>> ---------------- --------------------------- --------------------------- ---------------------------
>> %stddev %change %stddev %change %stddev %change %stddev
>> \ | \ | \ | \
>> 7034709 ± 3% +2.9% 7241429 +3.2% 7256680 ± 2% +3.9% 7308375 vm-scalability.throughput
>>
>>
>>
>> vm-scalability results on default LRU (with -no-mglru suffix)
>> ===
>>
>> =========================================================================================
>> compiler/kconfig/rootfs/runtime/tbox_group/test/testcase:
>> gcc-13/defconfig/debian/300s/qemu-vm/mmap-xread-seq-mt/vm-scalability
>>
>> commit:
>> 6.8.0-rc1-mm-everything-2024-01-29-07-19-no-mglru+
>> 6.8.0-rc1-split-folio-in-compaction-no-mglru+
>> 6.8.0-rc1-folio-migration-in-compaction-no-mglru+
>> 6.8.0-rc1-folio-migration-free-page-split-no-mglru+
>>
>> 6.8.0-rc1-mm-eve 6.8.0-rc1-split-folio-in-co 6.8.0-rc1-folio-migration-i 6.8.0-rc1-folio-migration-f
>> ---------------- --------------------------- --------------------------- ---------------------------
>> %stddev %change %stddev %change %stddev %change %stddev
>> \ | \ | \ | \
>> 14401491 +3.7% 14940270 +2.4% 14748626 +4.0% 14975716 vm-scalability.throughput
>>
>> =========================================================================================
>> compiler/kconfig/rootfs/runtime/tbox_group/test/testcase:
>> gcc-13/defconfig/debian/300s/qemu-vm/mmap-pread-seq/vm-scalability
>>
>> commit:
>> 6.8.0-rc1-mm-everything-2024-01-29-07-19-no-mglru+
>> 6.8.0-rc1-split-folio-in-compaction-no-mglru+
>> 6.8.0-rc1-folio-migration-in-compaction-no-mglru+
>> 6.8.0-rc1-folio-migration-free-page-split-no-mglru+
>>
>> 6.8.0-rc1-mm-eve 6.8.0-rc1-split-folio-in-co 6.8.0-rc1-folio-migration-i 6.8.0-rc1-folio-migration-f
>> ---------------- --------------------------- --------------------------- ---------------------------
>> %stddev %change %stddev %change %stddev %change %stddev
>> \ | \ | \ | \
>> 11407497 +5.1% 11989632 -0.5% 11349272 +4.8% 11957423 vm-scalability.throughput
>>
>> =========================================================================================
>> compiler/kconfig/rootfs/runtime/tbox_group/test/testcase:
>> gcc-13/defconfig/debian/300s/qemu-vm/mmap-pread-seq-mt/vm-scalability
>>
>> commit:
>> 6.8.0-rc1-mm-everything-2024-01-29-07-19-no-mglru+
>> 6.8.0-rc1-split-folio-in-compaction-no-mglru+
>> 6.8.0-rc1-folio-migration-in-compaction-no-mglru+
>> 6.8.0-rc1-folio-migration-free-page-split-no-mglru+
>>
>> 6.8.0-rc1-mm-eve 6.8.0-rc1-split-folio-in-co 6.8.0-rc1-folio-migration-i 6.8.0-rc1-folio-migration-f
>> ---------------- --------------------------- --------------------------- ---------------------------
>> %stddev %change %stddev %change %stddev %change %stddev
>> \ | \ | \ | \
>> 11348474 +3.3% 11719453 -1.2% 11208759 +3.7% 11771926 vm-scalability.throughput
>>
>> =========================================================================================
>> compiler/kconfig/rootfs/runtime/tbox_group/test/testcase:
>> gcc-13/defconfig/debian/300s/qemu-vm/lru-file-readtwice/vm-scalability
>>
>> commit:
>> 6.8.0-rc1-mm-everything-2024-01-29-07-19-no-mglru+
>> 6.8.0-rc1-split-folio-in-compaction-no-mglru+
>> 6.8.0-rc1-folio-migration-in-compaction-no-mglru+
>> 6.8.0-rc1-folio-migration-free-page-split-no-mglru+
>>
>> 6.8.0-rc1-mm-eve 6.8.0-rc1-split-folio-in-co 6.8.0-rc1-folio-migration-i 6.8.0-rc1-folio-migration-f
>> ---------------- --------------------------- --------------------------- ---------------------------
>> %stddev %change %stddev %change %stddev %change %stddev
>> \ | \ | \ | \
>> 8065614 ± 3% +7.7% 8686626 ± 2% +5.0% 8467577 ± 4% +11.8% 9016077 ± 2% vm-scalability.throughput
>>
>> =========================================================================================
>> compiler/kconfig/rootfs/runtime/tbox_group/test/testcase:
>> gcc-13/defconfig/debian/300s/qemu-vm/lru-file-mmap-read/vm-scalability
>>
>> commit:
>> 6.8.0-rc1-mm-everything-2024-01-29-07-19-no-mglru+
>> 6.8.0-rc1-split-folio-in-compaction-no-mglru+
>> 6.8.0-rc1-folio-migration-in-compaction-no-mglru+
>> 6.8.0-rc1-folio-migration-free-page-split-no-mglru+
>>
>> 6.8.0-rc1-mm-eve 6.8.0-rc1-split-folio-in-co 6.8.0-rc1-folio-migration-i 6.8.0-rc1-folio-migration-f
>> ---------------- --------------------------- --------------------------- ---------------------------
>> %stddev %change %stddev %change %stddev %change %stddev
>> \ | \ | \ | \
>> 6438422 ± 2% +27.5% 8206734 ± 2% +10.6% 7118390 +26.2% 8127192 ± 4% vm-scalability.throughput
>
> Thanks for the data! Based on the above:
>
> Test case default MGLRU Change
> =============================================================
> mmap-xread-seq-mt/vm-scalability 14975716 15567998 +4%
> mmap-pread-seq/vm-scalability 11957423 12812682 +7%
> mmap-pread-seq-mt/vm-scalability 11771926 unavail N/A
> lru-file-readtwice/vm-scalability 9016077 10408804 +15%
> lru-file-mmap-read/vm-scalability 8127192 7308375 -10%
>
> So it seems that MGLRU regressed for the last test. I'll find someone
> on our team to take a look.
Thanks.
--
Best Regards,
Yan, Zi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]
prev parent reply other threads:[~2024-02-12 18:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 16:35 Zi Yan
2024-02-12 16:35 ` [PATCH v4 1/3] mm/compaction: enable compacting >0 order folios Zi Yan
2024-02-12 16:35 ` [PATCH v4 2/3] mm/compaction: add support for >0 order folio memory compaction Zi Yan
2024-02-12 16:35 ` [PATCH v4 3/3] mm/compaction: optimize >0 order folio compaction with free page split Zi Yan
2024-02-12 18:27 ` Yu Zhao
2024-02-12 18:29 ` Zi Yan
2024-02-12 18:44 ` [PATCH v4 0/3] Enable >0 order folio memory compaction Yu Zhao
2024-02-12 18:46 ` Zi Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0DE890C1-3347-43CA-BDD0-25244C8C2799@nvidia.com \
--to=ziy@nvidia.com \
--cc=a.manzanares@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=fengwei.yin@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=mgorman@techsingularity.net \
--cc=rohan.puri15@gmail.com \
--cc=ryan.roberts@arm.com \
--cc=shikemeng@huaweicloud.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=vishal.moola@gmail.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox