From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A8FDC3F2D0 for ; Fri, 28 Feb 2020 06:13:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 34D94246A2 for ; Fri, 28 Feb 2020 06:13:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XQjMTRze" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34D94246A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DA6BC6B0006; Fri, 28 Feb 2020 01:13:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D56F66B0007; Fri, 28 Feb 2020 01:13:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C93C46B0008; Fri, 28 Feb 2020 01:13:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0115.hostedemail.com [216.40.44.115]) by kanga.kvack.org (Postfix) with ESMTP id B2BFB6B0006 for ; Fri, 28 Feb 2020 01:13:43 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7B7C22826 for ; Fri, 28 Feb 2020 06:13:43 +0000 (UTC) X-FDA: 76538519526.05.earth27_3d9492a0def00 X-HE-Tag: earth27_3d9492a0def00 X-Filterd-Recvd-Size: 4309 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Fri, 28 Feb 2020 06:13:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582870422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xUjFq36SnToq+ayZ1fQh5FQLQeclFb1jvHYYHFcXBUU=; b=XQjMTRzeobx0Hb+s0LwUZNvtA/BiwxOhmLd7yVweFaalSgW4ECNXWUKmpq2cN9ljkJLN+H nyy8FyrUMvvNNXBIl7EJ5GiNpLCRB5CkONGSaZ46JH6sl/AurYCD1tClXS6Evf6U14BKsz VY8yAAtyW02uqJj8XTC+aJfW9r3KFWs= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-467-nVfonyUjPZS2HBx2cU2wsA-1; Fri, 28 Feb 2020 01:13:41 -0500 X-MC-Unique: nVfonyUjPZS2HBx2cU2wsA-1 Received: by mail-wr1-f69.google.com with SMTP id u18so882771wrn.11 for ; Thu, 27 Feb 2020 22:13:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=bQZy9BsnvGs4DJv5PXGxTDbanrd6o8j4AgcuAD33/N0=; b=Mawr/h3A02YmXUcSHeh28hr4ksOBPM8CV2QS5qqFv9/AhTJQCgE07zUc/NxonKJPcK //8/NORTM8Gptn8ImRjoTGewyBGklvHLm23lxngewa/oieWVoWLVmnWUjJziaWUh4oTU 4Vt06g0c63FC+Q0EJtaFytoU9jfbJeetTM4XrpvO9Jh5qELnooBckpdsz/otKVyT6jzc YxaS4EtYdCVSBOFKd4/VL9+yeKUTE/eiagJRWakdw1haBw8OnNRUiQWhl1vJ9RxE6TMh IAkPmvPe+6/ECBkwzGszN4p/1K+II+S63zoD34Emat6Rst9E/4zuNFnqfOS0UF3/d5ta Jy0Q== X-Gm-Message-State: APjAAAW40Z95wYeQzWUTd9fgUBAl3Mr5B6c3FPYlmDdNn0/0Ph4Hrwy0 6c34XwV39bE3JZ/tiX9RPNuyxV2BSj/42YDq0fXsCDR9TntHuE02eN8H/2jhENLthGIwb4Dhp0i OtQ5Ov0Se2gI= X-Received: by 2002:adf:cd11:: with SMTP id w17mr3255784wrm.66.1582870419912; Thu, 27 Feb 2020 22:13:39 -0800 (PST) X-Google-Smtp-Source: APXvYqytLtf3bqBmoH4VSVokPNlQ4OLwr+04hPKM7EP6nAym2oOemd792mZP0+koSwsZr1UOB4jSLg== X-Received: by 2002:adf:cd11:: with SMTP id w17mr3255756wrm.66.1582870419682; Thu, 27 Feb 2020 22:13:39 -0800 (PST) Received: from [192.168.3.122] ([91.12.99.244]) by smtp.gmail.com with ESMTPSA id 25sm682892wmi.32.2020.02.27.22.13.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Feb 2020 22:13:39 -0800 (PST) From: David Hildenbrand Mime-Version: 1.0 (1.0) Subject: Re: [RFC 2/3] mm: Add a new page flag PageLayzyFree() for MADV_FREE Date: Fri, 28 Feb 2020 07:13:33 +0100 Message-Id: <0C8CC772-5840-4F0C-9859-C1D7B8BF6025@redhat.com> References: <20200228033819.3857058-3-ying.huang@intel.com> Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dave Hansen , David Hildenbrand , Mel Gorman , Vlastimil Babka , Zi Yan , Michal Hocko , Peter Zijlstra , Minchan Kim , Johannes Weiner , Hugh Dickins In-Reply-To: <20200228033819.3857058-3-ying.huang@intel.com> To: "Huang, Ying" X-Mailer: iPhone Mail (17D50) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Am 28.02.2020 um 04:38 schrieb Huang, Ying : >=20 > =EF=BB=BFFrom: Huang Ying >=20 > Now !PageSwapBacked() is used as the flag for the pages freed lazily > via MADV_FREE. This isn't obvious enough. So Dave suggested to add a > new page flag for that to improve the code readability. This patch subject and description is *really* confusing. You=E2=80=98re ad= ding a helper function, not a page flag. It=E2=80=98s a fairly easy refacto= ring. (Adding new page flags is close to impossible). Cheers!