From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D166AC4345F for ; Tue, 16 Apr 2024 09:36:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 433CC6B0082; Tue, 16 Apr 2024 05:36:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E3786B0085; Tue, 16 Apr 2024 05:36:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2847F6B0087; Tue, 16 Apr 2024 05:36:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0AE346B0082 for ; Tue, 16 Apr 2024 05:36:27 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C35C2A1CE9 for ; Tue, 16 Apr 2024 09:36:26 +0000 (UTC) X-FDA: 82014889572.10.4DC2FC6 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf30.hostedemail.com (Postfix) with ESMTP id DABBE8000A for ; Tue, 16 Apr 2024 09:36:24 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FJKO8jHV; spf=pass (imf30.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713260185; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DOrASS+GeLuk5Z7lZoVL6cbT4rY+jK9WGpd682BgxR8=; b=kgnef/ZdUSV21PAmjNMt6Pwd51nQhtP4GLK4pBF75gFi2gyoQzlLZfa/0AcWCXoiA/HTYT cJBASytXrpIwoXt8d4q2GV4z9lbNtcJtLdBf8SlVpAfm4eriBjMiJlZ4qnQ2g2xrWfDFfd Wp+VblFtWYbgcP1yQ2GmcOCj/YcMyZw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713260185; a=rsa-sha256; cv=none; b=Jr2P9qpgU6CsyqBj4AFcfvXiZTHeOY3mcvGRVoqLCM8Ybnt/dOAZXb6b6a1ZJurgwyd4ZV 2zFmjnbFafd8xmr3pHo9FOqALVy6rY9ja8YfEdHdnXPTnvmVkKy+zyNDZh0UPRf6sKuLY5 l8XtT6vhV1mLIfw+ZwyrJFnv/QlvULw= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FJKO8jHV; spf=pass (imf30.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-5176f217b7bso7188509e87.0 for ; Tue, 16 Apr 2024 02:36:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713260183; x=1713864983; darn=kvack.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DOrASS+GeLuk5Z7lZoVL6cbT4rY+jK9WGpd682BgxR8=; b=FJKO8jHVbYSZ/w21mE2OYbNcmIFKmsSIZAyCvv5nsZCIMkYsNfjKgY/eizvyN0z1ys Bb0jZ3I30YiNbMYIsVtcPgCMwtcOwM39SWFSaC/NIn64r77YiaXA6DXr7jjKnHtLPg+S 849DoO5VqF616bRNDy4vgNmzvF+9oj2jX20ayHNdiHYrij/PsbjnV9ElhPoGc3SGSR5J FGJ1wNp8zWCJH7qFX15ScssYJTCqDHBZlBlsWuux1tTcUZ2fcm4AI4DoVjmv08+V4Dvg +uXhp4vzo95W/0z5U97JT9HKNJ9PGhrVaAHtzMRU3eCkyvhW+JkAumminTzCiF0PJExf NaUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713260183; x=1713864983; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DOrASS+GeLuk5Z7lZoVL6cbT4rY+jK9WGpd682BgxR8=; b=B1s8tMrFkNx9WUSkWZI1fVGsXIUVQ/9dhIeODjPCntvL/6OHoNQ6daZWyV75IW0dHI UCd2Gg6DE2g2jDmfEKATM761vh3yMUYgOdXaSoJW4gjnaw3UPLxWkd4pwfFXnGp19Y2Z HwGIdyQYva5Z99koiK33buXIetMmAInrSxEEhhZdcTLDWqvhFLLsDz9U3Ofse04ciTu3 OhQegH6iSlIiqUCx3fMP4/sbhNrqxIeJtleuyaxv4yf3mir6UTxmjbCyvAS3rmcp1mwF lwB6vrpiJ7vU7NvXcBlAhCTPMjEX8IZb5DNP1i7bClVUenwsYUfUnZnDikZdbZ7r2WDM C4sg== X-Forwarded-Encrypted: i=1; AJvYcCV28VOLZc0zi8TnDpO4w/6KAciLQPW4BMQBCQN4+kLLBof5FU4nOyAVAvtDU6fVIy9mbaLPy0zi6doNoWJzLceooDA= X-Gm-Message-State: AOJu0YwA3TPn6JlF1fFHNYB+HfF6MrnVWXdiWpTqSIrask46S+tjFA+d eSk7XPN+SbaJ9BBZkJ7ywdYsQTeKgoGj+WjGsrd+zoETr47n7k3r X-Google-Smtp-Source: AGHT+IHJL+kGebuWf568L4j1/19JnbEd5orWvCbxsHgvPeVxrnDNkney9hr1xgtB5xtFbL8mR9qM0Q== X-Received: by 2002:ac2:5f87:0:b0:516:cdfa:1802 with SMTP id r7-20020ac25f87000000b00516cdfa1802mr9934425lfe.63.1713260182555; Tue, 16 Apr 2024 02:36:22 -0700 (PDT) Received: from smtpclient.apple ([132.68.46.107]) by smtp.gmail.com with ESMTPSA id l1-20020a17090615c100b00a524e3f2f9esm4249223ejd.98.2024.04.16.02.36.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Apr 2024 02:36:22 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\)) Subject: Re: [RFC PATCH 3/7] module: prepare to handle ROX allocations for text From: Nadav Amit In-Reply-To: <20240411160526.2093408-4-rppt@kernel.org> Date: Tue, 16 Apr 2024 12:36:08 +0300 Cc: Linux Kernel Mailing List , Andrew Morton , Andy Lutomirski , Arnd Bergmann , Catalin Marinas , Christoph Hellwig , Helge Deller , Lorenzo Stoakes , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Mathieu Desnoyers , Michael Ellerman , Palmer Dabbelt , Peter Zijlstra , Russell King , Song Liu , Steven Rostedt , Thomas Gleixner , Uladzislau Rezki , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "open list:MEMORY MANAGEMENT" , linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, the arch/x86 maintainers Content-Transfer-Encoding: quoted-printable Message-Id: <0C4B9C1A-97DE-4798-8256-158369AF42A4@gmail.com> References: <20240411160526.2093408-1-rppt@kernel.org> <20240411160526.2093408-4-rppt@kernel.org> To: Mike Rapoport X-Mailer: Apple Mail (2.3774.500.171.1.1) X-Rspamd-Queue-Id: DABBE8000A X-Rspam-User: X-Stat-Signature: 6tjaafgr4wjwtzkysab734swti8wz9uj X-Rspamd-Server: rspam03 X-HE-Tag: 1713260184-458975 X-HE-Meta: U2FsdGVkX182nxNcAyp8wjaCd65IElXUY0LZI0R8KiUh712DHX+7bLjsEF77q6lEY/8KTaI2zewSER/kVqpaaVXfp5sYOApG6n3Js/vFMWbsvXooOflWBpmLKZfX731HutimkToF2GCShvn5YPGd5mFfv97XVvLwbVbJRahioaAT5gGqXFOyO2VOCoitURunPr3OeeXWtEPd8t4o5hxHEN4aPs8uoanXtuSPoGNV9VTP6whvjTmGj/Y1ChP2ZTj9ER8lRauLmvHPRN3A9SGbtGtimS/T2GzKC3z4XFui4S9JuAnP8TO2+gzK3FG7HPTzsk1hpGb2x2F4NZRIIiCQH416RfW/Z5aVikgGNcNrGZ5dMLDCIeYcflndiizZ1sHG31oLYu3ucBeiBViTbblib6Aue1cAePsoJHI2DfeauqOHXhLPQPHQlZskXwUEQ6KP0iZJr4mdnlBhVqJpcMrgSRpCgKyfLeSVlZZU9ScnR6kvc+sJjZBPJ4wjbbUpMzowVwmX/53nvhTqBczFasRZWWCQlbhx0UOZBOfyHmWHM9D7UjMdz02Mtnu0+l7vxrcw3pPdoxc1EYecS6wANePpfmWyPpeJyE8hwfMqJP2nuHPlfvwvGhwujyN4NnuRnFwKIHDz0sUVLJKTZmu1Fs0CWc3cjshQo9F/Q/EV0S6P++HV8/8eFWAPF8dr0KNZEF0M2gQhAnlErLANGFNk/SNsdtK1RxjMKpJaSJTjDb4H2kFmpiEl8uWuo3pxVaMBowuFR1/Mm3dBjYx7FAnovrAjSHuWbELOKziLINBSO9jklRlNWMHX018UCv9rT7XcGT70vGEM0h+RoJmevqF4Agc7AUxnstpAwA0rOl1g//cNMOL1zoiMz2OOwINDJg/LlLvjnB/stpkoNGXZ5icOSZmEaZ1UiPrmqoQ2pNZhTjlJLH+hIDOELDNv+HIfwOIvEnmiBRbXufM5DLOEnDJ5q+/ JDg5Ruqh 7Gr/XjiYnabUVjHzLQlU1EWmAVrHC6tBwZBTeM3lnAS+B/UvaoeDMeDWMDU/6ZxF5YAJOdafrLk/C+/BCBv9ByI+G8KFRgWAB1opT6fp/kjL3VIti/4F2pnXtJWno3k0kj5pW/IfaOapvYpbXBGbP61nIcXcOxq21kPUJV1s6ceNqedyi+thE4JjouV1d+Uvs+BLQNvFsj8yNcwXwGUOGBXjCAzQeDjdm0wbcd7wzSLml/WHzBMYpRSUSLNQmrITGhQIfkXPEwWKxhuy/JoONr282+AoRBj4eXieLMHSyQVR1ZE9Yw+gTtId5TFXt9n39u0iVfyz/+8aqnUaOTW3i9XBZKYhpK7/QW7V24dsLTwbvLvvE3Og5o16XEfHIJemgU5HOoIqIWEVYTEC0ekr9rdsQ2wMrTMePewVUj2fkIgcwpHCYP21eZwha2uacUZ+UyiHFpjc54ujGcDfarBei99IqkBV4/0eG8pX+kPgVzygkwx0UaTfzbDr++v1GCRY0Dn7366w/xE44xlVR9EeKbfE9q0c8gcf1sH+YvaAQKVDB6zdl6wfl8RRmRUhmrp9pkQMT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On 11 Apr 2024, at 19:05, Mike Rapoport wrote: >=20 > @@ -2440,7 +2479,24 @@ static int post_relocation(struct module *mod, = const struct load_info *info) > add_kallsyms(mod, info); >=20 > /* Arch-specific module finalizing. */ > - return module_finalize(info->hdr, info->sechdrs, mod); > + ret =3D module_finalize(info->hdr, info->sechdrs, mod); > + if (ret) > + return ret; > + > + for_each_mod_mem_type(type) { > + struct module_memory *mem =3D &mod->mem[type]; > + > + if (mem->is_rox) { > + if (!execmem_update_copy(mem->base, = mem->rw_copy, > + mem->size)) > + return -ENOMEM; > + > + vfree(mem->rw_copy); > + mem->rw_copy =3D NULL; > + } > + } > + > + return 0; > } I might be missing something, but it seems a bit racy. IIUC, module_finalize() calls alternatives_smp_module_add(). At this point, since you don=E2=80=99t hold the text_mutex, some might do = text_poke(), e.g., by enabling/disabling static-key, and the update would be overwritten. No?=