From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4059CC4332F for ; Thu, 15 Dec 2022 03:44:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 690B58E0003; Wed, 14 Dec 2022 22:44:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6417A8E0002; Wed, 14 Dec 2022 22:44:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52F058E0003; Wed, 14 Dec 2022 22:44:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 43DAB8E0002 for ; Wed, 14 Dec 2022 22:44:54 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E89D5C07DF for ; Thu, 15 Dec 2022 03:44:53 +0000 (UTC) X-FDA: 80243149266.21.4F0ED6C Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by imf30.hostedemail.com (Postfix) with ESMTP id 20BAA8000F for ; Thu, 15 Dec 2022 03:44:50 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=e4jSCMHB; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf30.hostedemail.com: domain of muchun.song@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671075891; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ek1AWVDvL3uGjwPmVZLLu6V363bRYpZOhP1Lu8fyRnA=; b=E/3JH7qGcqTD+tgWMqwRRnKSeoTysjO5a7xWei1t/q6wssxcTBeEkMNXJmQfur0cHFMM9v WR8id4jgYCVVXa1qNx4jizhLKbWqGRGxKVDcStyl24L4F46wAPEzOBrcAoi3sSBarORVee Jqc6wHXI8TIX2eRP83VdQUyVKunMLME= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=e4jSCMHB; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf30.hostedemail.com: domain of muchun.song@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671075891; a=rsa-sha256; cv=none; b=Sg97h5FgEUPxmchpK3Wm6qb3nG4eF/qay0KH6nx0QUQFLNVgMPkzuHV2jB8UljUJHvqpfg UBS6eQKiroTt/fKyuId9sEAowU+BrGeyuxrLwJs7DiPwFCnwJnOyHcHVzT0DCwUE47ZwFi My5wrJHwtjUox/nYtIzSAI0VVWyuGlk= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1671075888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ek1AWVDvL3uGjwPmVZLLu6V363bRYpZOhP1Lu8fyRnA=; b=e4jSCMHBjLLS8F5I0zKPVXVejFpN80ydgHO0I78K+igtJzI85DkC/p6bhJPqPeBhgDFmVh tuLiW6iAmFq0IHHAiSV+4XJEvIrk3CxTyb3bVpWoBg3M5kIUpIzYg40NqbZZQWWa9M7zGw BnmA67tsVkOOEsnRrSvbPnxMG1wqgf8= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: [PATCH mm-unstable] mm: move folio_set_compound_order() to mm/internal.h X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20221213212053.106058-1-sidhartha.kumar@oracle.com> Date: Thu, 15 Dec 2022 11:44:14 +0800 Cc: linux-kernel@vger.kernel.org, Linux Memory Management List , Andrew Morton , Muchun Song , Mike Kravetz , Matthew Wilcox , John Hubbard Content-Transfer-Encoding: quoted-printable Message-Id: <0B650D64-1F64-4695-9365-CF695029C50C@linux.dev> References: <20221213212053.106058-1-sidhartha.kumar@oracle.com> To: Sidhartha Kumar X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 20BAA8000F X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: k78tag74uw1zkgc7rs7drokh5rdkje3c X-HE-Tag: 1671075890-112072 X-HE-Meta: U2FsdGVkX19dXWCEjZOKuVjvqj+mmsXNmG2XBsDy2evsg8EE7WIcWEZTNZgO7AxCEa/cK/oRZMcsUxXOXfGtbsP8TsqGERSf/5xCaDBfVDYHTjN971h4hj/407NuDcMidpBZigjhXkaMTgZeLFdCO7sFlPXPZMap6r8oOnH/Z3/94NKkmEXcplghDFKpJkMKSfM2DNgOI/4TIlf8K9Iph+SklD83kyupyoF7wI6wJiAP+5ve89fp19mgE0PSffXgcwihupkd1pcZwHb4iD+oiu85YL0xChN/DGbCuPMYGOrzRRnZzTNCSNQB+BdQR+Y2LYuqmyuCvrezAEwYVRIw384vc9Oj0OAN3/VN/hXDcw0xKEcPqEbIpdpDPj+Uf0+dIvYt70YHZ6f8DlvRryL/A3rlGCK7sgNibKoiWcWXvFAk5wiYoRN6fQ+X9g6/sHPZIEV4q7Magt+p9eH5mGlcFjbGTQsxdQEGg5GS6yLk9Ud68m4Jh0LZ48RqT+P1BAUYtkFj+P0UiuHeaFut1AkE49ajwOT08e8fDWP+gGSL/7ARt4dRCOi++3I3fSAIsAJdJ0pS5DnMvtrCs4AFq4vNKp0XrJkXgmqGpvjQerAAKBPUEVoGrYBl5ZxLVw5VOyjnfrPCC/Sjr1iv8Y7PiW5KKQjlhaoFBY9OEmd0i4CXaMjjEWMIrkBo23aCcneNTp/MD1CnttVcWdo+XvBLTTGr9q5BwByb3LfMJSJ0/mCgFcw389Rg2pN3uTyv2fbfysW7Nc5LdrawSAiEG2gReXXxmwM3clu1czJAyvGuTUCX+QSAJYQp5iu87hrblDKnNRx7BMYvWX2wJnKhJTaJe0j4sjb+yyPk1NJbpu8ByTN/R/pp7fq6jcq+WC5A5unIcdM9A0xkWMxJ8Bc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Dec 14, 2022, at 05:20, Sidhartha Kumar = wrote: >=20 > folio_set_compound_order() is moved to an mm-internal location so = external > folio users cannot misuse this function. Change the name of the = function > to folio_set_order() and use WARN_ON_ONCE() rather than BUG_ON. Also, > handle the case if a non-large folio is passed and add clarifying = comments > to the function. >=20 > Link: = https://lore.kernel.org/lkml/20221207223731.32784-1-sidhartha.kumar@oracle= .com/T/ > Fixes: 9fd330582b2f ("mm: add folio dtor and order setter functions") >=20 > Signed-off-by: Sidhartha Kumar > Suggested-by: Mike Kravetz > Suggested-by: Muchun Song > Suggested-by: Matthew Wilcox > Suggested-by: John Hubbard Reviewed-by: Muchun Song Thanks.=