From: Nadav Amit <namit@vmware.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Xavier Deguillard <xdeguillard@vmware.com>,
LKML <linux-kernel@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v3 00/20] vmw_balloon: compaction, shrinker, 64-bit, etc.
Date: Tue, 30 Oct 2018 16:52:55 +0000 [thread overview]
Message-ID: <0AC59738-06A0-43DC-8622-D4177FDDC1F3@vmware.com> (raw)
In-Reply-To: <20181030165119.GA23017@kroah.com>
From: gregkh@linuxfoundation.org
Sent: October 30, 2018 at 4:51:19 PM GMT
> To: Nadav Amit <namit@vmware.com>
> Cc: Arnd Bergmann <arnd@arndb.de>, Xavier Deguillard <xdeguillard@vmware.com>, LKML <linux-kernel@vger.kernel.org>, Michael S. Tsirkin <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, linux-mm@kvack.org <linux-mm@kvack.org>, virtualization@lists.linux-foundation.org <virtualization@lists.linux-foundation.org>
> Subject: Re: [PATCH v3 00/20] vmw_balloon: compaction, shrinker, 64-bit, etc.
>
>
> On Tue, Oct 30, 2018 at 04:32:22PM +0000, Nadav Amit wrote:
>> From: Nadav Amit
>> Sent: September 26, 2018 at 7:13:16 PM GMT
>>> To: Arnd Bergmann <arnd@arndb.de>, gregkh@linuxfoundation.org
>>> Cc: Xavier Deguillard <xdeguillard@vmware.com>, linux-kernel@vger.kernel.org>, Nadav Amit <namit@vmware.com>, Michael S. Tsirkin <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, linux-mm@kvack.org>, virtualization@lists.linux-foundation.org
>>> Subject: [PATCH v3 00/20] vmw_balloon: compaction, shrinker, 64-bit, etc.
>>>
>>>
>>> This patch-set adds the following enhancements to the VMware balloon
>>> driver:
>>>
>>> 1. Balloon compaction support.
>>> 2. Report the number of inflated/deflated ballooned pages through vmstat.
>>> 3. Memory shrinker to avoid balloon over-inflation (and OOM).
>>> 4. Support VMs with memory limit that is greater than 16TB.
>>> 5. Faster and more aggressive inflation.
>>>
>>> To support compaction we wish to use the existing infrastructure.
>>> However, we need to make slight adaptions for it. We add a new list
>>> interface to balloon-compaction, which is more generic and efficient,
>>> since it does not require as many IRQ save/restore operations. We leave
>>> the old interface that is used by the virtio balloon.
>>>
>>> Big parts of this patch-set are cleanup and documentation. Patches 1-13
>>> simplify the balloon code, document its behavior and allow the balloon
>>> code to run concurrently. The support for concurrency is required for
>>> compaction and the shrinker interface.
>>>
>>> For documentation we use the kernel-doc format. We are aware that the
>>> balloon interface is not public, but following the kernel-doc format may
>>> be useful one day.
>>>
>>> v2->v3: * Moving the balloon magic-number out of uapi (Greg)
>>>
>>> v1->v2: * Fix build error when THP is off (kbuild)
>>> * Fix build error on i386 (kbuild)
>>
>> Greg,
>>
>> I realize you didn’t apply patches 17-20. Any reason for that?
>
> I have no idea, that was a few thousand patches reviewed ago...
>
> Did I not say anything about this when I applied them?
>
> greg k-h
You regarded the magic-number in v2, which I fixed for v3.
Should I resend?
next prev parent reply other threads:[~2018-10-30 16:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 19:13 Nadav Amit
2018-09-26 19:13 ` [PATCH v3 15/20] mm/balloon_compaction: suppress allocation warnings Nadav Amit
2018-09-26 19:13 ` [PATCH v3 16/20] mm/balloon_compaction: list interfaces Nadav Amit
2018-09-28 19:48 ` Nadav Amit
2018-10-17 2:42 ` Nadav Amit
2018-10-30 16:32 ` [PATCH v3 00/20] vmw_balloon: compaction, shrinker, 64-bit, etc Nadav Amit
2018-10-30 16:51 ` gregkh
2018-10-30 16:52 ` Nadav Amit [this message]
2018-10-30 17:05 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0AC59738-06A0-43DC-8622-D4177FDDC1F3@vmware.com \
--to=namit@vmware.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xdeguillard@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox