From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47686C433EF for ; Fri, 14 Jan 2022 15:14:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE6356B0072; Fri, 14 Jan 2022 10:14:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BBCBD6B0073; Fri, 14 Jan 2022 10:14:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A10596B0074; Fri, 14 Jan 2022 10:14:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0145.hostedemail.com [216.40.44.145]) by kanga.kvack.org (Postfix) with ESMTP id 8B8186B0072 for ; Fri, 14 Jan 2022 10:14:57 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 47F2D1820751B for ; Fri, 14 Jan 2022 15:14:57 +0000 (UTC) X-FDA: 79029240234.12.6D12CD3 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2067.outbound.protection.outlook.com [40.107.220.67]) by imf16.hostedemail.com (Postfix) with ESMTP id 1376018000D for ; Fri, 14 Jan 2022 15:14:55 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fUiSyOeBqhUAQNhe3gAfas9oHf1551K7Hcur+ueLTdepGESPU7r92zI3HpyCY0pOI+X0Nfhc5NEQ3x125FJAKChRx/JZ6ETy/1xZ+/Nd4wkAO8a749S2yNi3tr5ZEwjpSZcHiRndaDKzIqPWguwoBIXZD56UZ63MObCacPIx9dTuw7qEN70ax4p8QvpkwjJaWqWRWo6A44au/2NFYeHYKP0BEjkkkDOHlev/Q0a5CBwc9V5AKOHQGGTHAT6r4NETZxRiGEfr/BsVCX1H+QgSzcA203xG3Z8jB97eE2oweqS50P8gQP7iQmO7uXaHfkIm5Suuu8u/JLDjE9RmiTYXtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zy+kTsTEy+0S7nHv/8wZECM8wxZHiCXWhCVJGLbrWvE=; b=TwU21DMtpmt3ZjhKXstP5yZSimyMM4/JJOrlsMMJ53/K+gGSWurP51AoRCArgBXmOS/mGDxqCoKySZwSxPuwPocgrrcr/tRVFC2i/+QB2NfLhMRlQpsVmKgFJLgkakAEMEGt+jYdIBNm7XvLbe/DINGDGmwWcubOGkBInMJm914yRHC4ZccxJgWrZOhvHzPjZ2r492SRu/+J1EguFgVBMiexMcOL5KMxANqP5SnCqUfdU9DksicPbQIxSyq/a+/A1rapdKua8xIY6VdS8+n+i7mSwlGp1CRXEz7qKR8KVz9NSCPnHVt8jiF7mVfPv8uO83d5wrTyhpUIJYW2ZxT+Kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zy+kTsTEy+0S7nHv/8wZECM8wxZHiCXWhCVJGLbrWvE=; b=iNn8gsihZrBB0uLRfXFzIzXqRE5kG8Qb6rdbSdNBnhXntCuL6qkSXfgqWBgcS6kRBNZFBWWwVv++gqshM2lrz8WEFdkARbY8cbyyHVu+X68jWtuSiUmmSyyu7Bm5t1bgVI/OcxeE3rHq7DOm3LZGZaRXiq8HR6v+J/hwdeU0VW2K+sfu/BLQGYoBFSoneGXEhhuNTmF/I2bVG2woJbGQt3IeS7saWySaN4FS0bi5l+w7M5xMpWJZ5YzSBeE6K0C7yEfyLRRkGc+5YACc2nw/GrkT6Ubkt3xTCh8cGwqNVRe04KRS106EirsaCArywdezu7GtG/G2E25a9wYgqjjW8g== Received: from MN2PR12MB3823.namprd12.prod.outlook.com (2603:10b6:208:168::26) by MN2PR12MB3472.namprd12.prod.outlook.com (2603:10b6:208:d2::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.10; Fri, 14 Jan 2022 15:14:53 +0000 Received: from MN2PR12MB3823.namprd12.prod.outlook.com ([fe80::a9db:9c46:183e:c213]) by MN2PR12MB3823.namprd12.prod.outlook.com ([fe80::a9db:9c46:183e:c213%3]) with mapi id 15.20.4888.012; Fri, 14 Jan 2022 15:14:53 +0000 From: Zi Yan To: David Hildenbrand Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Marek Szyprowski , Robin Murphy , linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux-foundation.org, iommu@lists.linux-foundation.org, Vlastimil Babka , Mel Gorman , Eric Ren Subject: Re: [RFC PATCH v3 5/8] mm: page_isolation: check specified range for unmovable pages during isolation. Date: Fri, 14 Jan 2022 10:14:51 -0500 X-Mailer: MailMate (1.14r5853) Message-ID: <0A46DD38-CEB2-43BE-8ED0-71BDD8B87479@nvidia.com> In-Reply-To: References: <20220105214756.91065-1-zi.yan@sent.com> <20220105214756.91065-6-zi.yan@sent.com> Content-Type: multipart/signed; boundary="=_MailMate_EFD96380-E8E7-433E-93B8-B1EB40D69348_="; micalg=pgp-sha512; protocol="application/pgp-signature" X-ClientProxiedBy: MN2PR04CA0019.namprd04.prod.outlook.com (2603:10b6:208:d4::32) To MN2PR12MB3823.namprd12.prod.outlook.com (2603:10b6:208:168::26) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d365d00f-454b-49fd-8757-08d9d7709d93 X-MS-TrafficTypeDiagnostic: MN2PR12MB3472:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3383; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dOblVkDBCJYmh8v5sGwew9+n0Y5KaBSuZRekBSMSleEZHvyAjnEv34+TGlA96gwzN+j9/ab34Nx4lyFylfsBjN3MhKmhvcFEw8Vdo8zJdBdyuSvReB3/0KA4Np6pL4//TS6s+dt2TcnaldmIB22f7hAgmDN3oR/sxPs9LZYtr+O/PN4/gGHKHwwdrQwqMUCdkbl654kSmckvGvJ8fyUN3QB37asZvtzspOSY8MVmD6m4j1VSJRBMYzD9zj5jUpW7PG8CG+yMuwVn6s7kT8hgGBCO+SSvxOp5xN1sMvwLezn6DXhFJXoMX5iQjiCtg9BDjpA92ZR/O5FETsDMG+KpOSZ2cX13OL8Ijgj99Vnviich2LRUQYyC42PAuRyiyflf6Hfoe4Si98R6BxUH/er7OelAl+CxD7XJZs1+g2Hy7AewNlrSQ8oNSXMHLMj+xcG934OwaW0tKQE+PxgXAjZqxQjPiCM1ouVGA3Sx0SpQ/G+D0izHxGb+n0zdpCus4PjdY5viIeGoRy9ztXjLOIhpWGfy2QjwT3HgGIhJIZf4dQ/ra/UoIrXdgxofYvl8zzPKvAwNA9mrNXk4c4jRmZvX1vIOomVNz8p9GX/BZF4dfuEClwDANyLwvgS1rPPIqrrLj6RpeJjgkWgnLi/82UVlxRWSm/NBbcUndNU+Swfh8ine0Eyw+wASAKCVMRE5yi2Szk/iNq8Bdpvqy+IONnATsg78rXOzb035CApzfys6b/M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3823.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(508600001)(4326008)(33656002)(7416002)(66556008)(66476007)(53546011)(6916009)(235185007)(36756003)(2906002)(54906003)(86362001)(66946007)(5660300002)(83380400001)(6512007)(186003)(8936002)(21480400003)(316002)(38100700002)(6486002)(8676002)(2616005)(6506007)(26005)(72826004)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KwZS9TDSkabn+MDZssohHT+OVdfBroyoni3/5mgMmKMbCbzh5oboXnx9nmte?= =?us-ascii?Q?Xt7aGeyyzkuTqcP9IKGsKvI8mLL5wZ7VN9Tk+qC/LuI5Xd6l7J5a85wWpqig?= =?us-ascii?Q?sK3FW4/pIjnXRO/T0c3MN2CFme/VAl5Tr33hqAa8y1jSefStP+453/JQoG71?= =?us-ascii?Q?oXbW93aT3y4PmEsX/PJqEzJQbRckr/vKoKRnNmYicxUrjmMbp08cF8GVmBFo?= =?us-ascii?Q?+AL3zCNZGenr8lKrbzSd2dofUmpA1KjkD8E9SUAB+V8oL7RKMdu7/FmedSEX?= =?us-ascii?Q?wU3kRKjTyQ/k8uRGElqgSeGk2JgBH9LJMO7IFJrw6ykFC/KvnEix/KurS3FP?= =?us-ascii?Q?yvG56Rdpur9wAKwnlaXbKoIo28sbs8kmgQe2YKDfhMc3zd3kfIxUqdUxG0hH?= =?us-ascii?Q?XG6Sg6sG4pKOns43gGWiCS0ILxa3uqhPJPdQ6mkBgzxbr2y3tKbG1VMwfTzv?= =?us-ascii?Q?Hcz1eDnegjdBatowHv/FmW5SXjaPxABYlxG5vo/MR4la9Wu2S8uFOI+COMUS?= =?us-ascii?Q?EkqC72UL1I+sDUCqKJV5Sog7xvP2VLGT78Vx2B5V2U0k1Ld5q4VA387b6buV?= =?us-ascii?Q?xfFfLZicPCzX/XyH7JqIfy9oXZu2Qrhe4Z/aAaton0pf/qEzH5Wr0DieTTj2?= =?us-ascii?Q?mIQb55bhrrxEG0vl0hk0UFqu7kj8+N+2cqKBsNs7pj1pNQZozILeYfQLLjg4?= =?us-ascii?Q?okJMchtoy3pY6lc1e0zXSQ86nwsk4qC6RLl3fE3FRiqV00Hne4an8LbVe4YP?= =?us-ascii?Q?0M2LWsw5uAn0++c0wPZmwpO4HT1MYdZAM1+U1W0SGTTnRG2wT1XKwxOXB+mO?= =?us-ascii?Q?NJDNUCnSQsR+r2tn9dWsyxg8AsMX7H5kuEnnuPSrpV6dtVRTJn0Z66NW8mej?= =?us-ascii?Q?rDGT6dAbg246eoEc3gwlVctg7B0ydyqxyaZClXl98hnFSrBPyDkQGnTx1wSo?= =?us-ascii?Q?559fpe9kPe5fRMkaxPyScNqadpCK5NoS34/JzkeForeBWtAjk2UMbPqFqrhr?= =?us-ascii?Q?8PldcJD4zMcD8JSq1s5gZ/ou1jpbnwtSlLKbl0aU4bIU6cjqdZiLH0IAeZL7?= =?us-ascii?Q?6HKqNwTjI8QQhO2Ztn7qrWmvh4RBzFTAjLIBpHfILTRJSlSmAQU+HFJcjeRR?= =?us-ascii?Q?FaSPqtcAhwUpCCytOlEGltYXfJj7vc7LB9216tGffOTHI8J4iwg9Qy1RO7fD?= =?us-ascii?Q?ziuMvOYM2ZVk5ArIgWUdHwUVUXvA4fCPd0caXz8u9scCTqbz4H4QHyGXmqT1?= =?us-ascii?Q?XuaygxX/uPa4EQWO7jO/UZHiNBqxZzQOT/6EQqU2/GDdOdwSwRkqHqqeM1sg?= =?us-ascii?Q?jjlcQXvzOM2grHo+3TS3R/PHTn1+Li+RWNLFZ1xRTAGYjZeEtZnfH4jwCsVG?= =?us-ascii?Q?XjZM8JTlFUo1tjM7NUtHkaEUYMnJkRU5BkrBqrYZM93RMkN84A8XVRNP9Zpq?= =?us-ascii?Q?6hNua4MdeIEIHuFo9zXtSIykWYWJ7dxxdxQHaQBgT2doOx7Y5eGEaJ/VhSGq?= =?us-ascii?Q?FfdmxwHH5UTybI9pJuzFmVPYrc4qKuVNouddMpkM6+f8xIx+kSfDCmDkqwXh?= =?us-ascii?Q?0wTrORTbFZhlk6E6eQ8=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: d365d00f-454b-49fd-8757-08d9d7709d93 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3823.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2022 15:14:53.2292 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: t6m0gp/dPvJ/AYWD5J2H/q8GqCO1a239TQ0fMT0SsAfsO2JqLtEuHjdINM8iM1+2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3472 X-Rspamd-Queue-Id: 1376018000D X-Stat-Signature: hx1t73tjetup3oeto3ughzsejwcqj43s Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=iNn8gsih; spf=none (imf16.hostedemail.com: domain of ziy@nvidia.com has no SPF policy when checking 40.107.220.67) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com X-Rspamd-Server: rspam07 X-HE-Tag: 1642173295-787257 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --=_MailMate_EFD96380-E8E7-433E-93B8-B1EB40D69348_= Content-Type: text/plain On 14 Jan 2022, at 8:38, David Hildenbrand wrote: > On 05.01.22 22:47, Zi Yan wrote: >> From: Zi Yan >> >> Enable set_migratetype_isolate() to check specified sub-range for >> unmovable pages during isolation. Page isolation is done >> at max(MAX_ORDER_NR_PAEGS, pageblock_nr_pages) granularity, but not all >> pages within that granularity are intended to be isolated. For example, >> alloc_contig_range(), which uses page isolation, allows ranges without >> alignment. This commit makes unmovable page check only look for >> interesting pages, so that page isolation can succeed for any >> non-overlapping ranges. > > Are you handling if we start checking in the middle of a compound page > and actually have to lookup the head to figure out if movable or not? > Yes. has_unmovable_pages() has that check already. >> >> has_unmovable_pages() is moved to mm/page_isolation.c since it is only >> used by page isolation. > > Please move that into a separate patch upfront, makes this patch much > easier to review. Sure. Will do. Thanks. -- Best Regards, Yan, Zi --=_MailMate_EFD96380-E8E7-433E-93B8-B1EB40D69348_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAmHhk2sPHHppeUBudmlk aWEuY29tAAoJEJ2yUfNrYfqKHVAP+wQLmekSmaBLUZyqE6BmgXMxqAuKfHDisuju sQ+K1TITi4vp/Fgyb3qrGtxbEsYSLoTCJ7MrO/hg/oRC4zW3UFtq9jhfX9E/jBnN g616RnbCfmuhRzWAbegxLx7irdhlntNgvrjo/OjOwWRZtdJgF82VZyZYmjoKjCZt kycSHdtVwVF0Ndq6KFuSct8yRXAOug2cNwCnPV/q0Dy6iQG9efK1/r8Q2TOBUcBR QbmSrufndFopmFsbh16slJlH41SbkaChz8lHUUlmganHvRakoFxxQjg4KKcyumTG k28DSYqGeOdhWKu/CgLkdEgB75twNx9aSJ6aFKrxxc1q4P7w9tvPUAOx4cMEZhRW ReV8wSACAj53/oihEt6i9lRDax6Sf+JU4hZjtaQr+Vm/TRmzuttRvtP7EQiA/97d nTazMzHcBgeXB/eSko6GqLkV8VWbvxcnAQkt7XcAQJ+pcRDktym2as3P1Tu4kSrj V1EO6QJtqSD9RRAPWGoZG8XrHcm6O7/knkFil2a0IoFmwW0tTWcz8v2fuct07j+u LR18iJgLhtPwJuKQ5pGcex8iLaeSaTqrX7RJlgcbN/sTuSuiTHwFxYnvPxK03dy6 Ig6pwIHSDmclpRnLFOK0TfoxruMnnj6a5yE3MkTBeG2M/xCJw8CXHAnXmxlrc+mV llVORpAe =emuQ -----END PGP SIGNATURE----- --=_MailMate_EFD96380-E8E7-433E-93B8-B1EB40D69348_=--