From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EDC1C2D0CD for ; Mon, 19 May 2025 14:36:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E9D0F6B00BF; Mon, 19 May 2025 10:35:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E49A86B00D2; Mon, 19 May 2025 10:35:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C045E6B00D3; Mon, 19 May 2025 10:35:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9D8236B00BF for ; Mon, 19 May 2025 10:35:55 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DCF6CE3E54 for ; Mon, 19 May 2025 14:35:58 +0000 (UTC) X-FDA: 83459906796.04.F087C70 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2053.outbound.protection.outlook.com [40.107.95.53]) by imf21.hostedemail.com (Postfix) with ESMTP id 133641C0005 for ; Mon, 19 May 2025 14:35:55 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=ckCArHwT; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf21.hostedemail.com: domain of ziy@nvidia.com designates 40.107.95.53 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747665356; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C61WOlfWFsWHvY8/ZUO57HwsyGGtQGBoqM/apawNPHk=; b=uwHfzJ33zkZXwCuQk7HjDnax3l60AMe7GfhTyhXhaehXXxJtxH9B6/s2zM38f225R9ouSU DiaA8aH/sP+AVtno+MKj7mpHF+oAJrLUeTnJ80vlXP1sokv1d8SgpEUsuykgV8Ytjgcpxm bA7RUrV/5gnjAO0E8DcwqHn+HwjWttQ= ARC-Authentication-Results: i=2; imf21.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=ckCArHwT; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf21.hostedemail.com: domain of ziy@nvidia.com designates 40.107.95.53 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1747665356; a=rsa-sha256; cv=pass; b=wqvg9CharXPM/5IzDDf2U6djoLLKeOxaPCszJKxSUwX2mRX0BG0e5MQJgLYJKdicFvETBo VcS40Hbsxgds2fYJl9krrt0jSMzmvipLxHo3cV5iQ+HBWcWatzbi1+9jye+wgDkDgeg36J nRMNEDnU/+110QoY5zjtizTmgU4IT6U= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ghs6b5Xux8mYlpJdD2nh7qo5415km/Um/O3ChjQC1UR+4iDWTi4MAHqkZNa10RN0++XGAdkHz4r4lV0N2yTJEw8usMRDeWe9MRhwtIgEEL58TvnlknEJon5cTqAKO2tGuvrMPBrwXPXrUxYbTQPjFcV0XWfWEtkKdqXDmiba13FwnSpEEtMeegdVOklvU3o+tkI8SYj78ZW9xYu5O1hfLNVWNq9ZnJGWiSndq8DsRpQ4wmdJLfD2Melu5Q+yE+4YVOxdFAE+taI7Qa3deBDfkuqmkHQB1v9wQVIC9IUbusclCq5USX7wCLW0r5wemLgFa3hM9UGUxInwcfpYK2KRXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C61WOlfWFsWHvY8/ZUO57HwsyGGtQGBoqM/apawNPHk=; b=KqzQOyNkZ528o9W8VSBUhKo1qI3Li7v4bwesfc8gxMIOOqe59ackNmhxmY73t3YwLCVqBMX3QkAkyVT47HONedu1/cE4viTHxMl7SE3DxGTxGTDTdkZF/yK0GuR0dYB7uULaNMm4DpT783Ktp5SuJyw3ndXIiHnEDUZazLxqtWp3IAQsg6VcncG/hOyzWRB3rWE31b2xfwo8Xvek1Il9W1OpqibZo2pdk2yuiuQZvnM04PJMgX3GNr0EgITXkpvswKV2aF8VXN48r6Yo6itY/O7E79yN4okgXkfu3Hn9aw2GWkijhaVfOF+m9PzYEficvB4fOGM0+NBc1MmNF0NzFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C61WOlfWFsWHvY8/ZUO57HwsyGGtQGBoqM/apawNPHk=; b=ckCArHwTU9PAayHOe7cNdVXVfeL1lCpqtWYE+n/X3O2utql/H6sDqHvrNKIUVhd2d7czR/hCsjmafJW/QT60RtsHeVBmy8tqdmyp5zyCspIczvJEJL0U4CppH/XCKiDVzp+6XH9c43c3dD6F3LS/ih8T1nXVrQ+s6ZE4id8DG4oScwZh64GeEyWStzZeufn0UXbShUBb8P1Xg+HEIs0W66PPKoAJ/YaisyiDHuP8gwIZLomoOtEL4DljiC+TyDJ6hDTXTsx6JIkucl0WiQHlXQis757dkhVUTU2tU/JuXGi14sgBCx2HIJcYo7DgCFDcbv6Ea0HaD/LLilfd2Bk23Q== Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by DS7PR12MB6312.namprd12.prod.outlook.com (2603:10b6:8:93::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.31; Mon, 19 May 2025 14:35:52 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%5]) with mapi id 15.20.8746.030; Mon, 19 May 2025 14:35:52 +0000 From: Zi Yan To: David Hildenbrand Cc: Vlastimil Babka , Oscar Salvador , Johannes Weiner , linux-mm@kvack.org, Andrew Morton , Baolin Wang , "Kirill A . Shutemov" , Mel Gorman , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Richard Chang , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/4] Make MIGRATE_ISOLATE a standalone bit Date: Mon, 19 May 2025 10:35:50 -0400 X-Mailer: MailMate (2.0r6255) Message-ID: <0A1FA061-9E8E-4E86-A479-EFA9FF083D4F@nvidia.com> In-Reply-To: <794d741f-44ac-4cd8-97e8-091f12387f39@redhat.com> References: <20250509200111.3372279-1-ziy@nvidia.com> <794d741f-44ac-4cd8-97e8-091f12387f39@redhat.com> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL1PR13CA0337.namprd13.prod.outlook.com (2603:10b6:208:2c6::12) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|DS7PR12MB6312:EE_ X-MS-Office365-Filtering-Correlation-Id: 3734b100-1e9b-49a2-8ef8-08dd96e274f9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|7416014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?dVgUhixI4YsCu1fpb+QFjKNqdkz17VeJeyQvNMR0TgjJqd1eJCReLlOI3kRV?= =?us-ascii?Q?NdhgIjtNCcikl7tyQvq6AlHx5w17hNV196tM4FUxj+qdLWHWsfsjuUcpb0QE?= =?us-ascii?Q?zFAa8zvU1Nz6XAQj9whSpd71UHCArJS0N5fKvdpAlmJkvVxVTYo6grC9UtDO?= =?us-ascii?Q?IGVf/BPOvY6T0QTMm12stODLYJlX3fPSWnQmfU34LEWZ344vnSLPMmc70vAz?= =?us-ascii?Q?YFdkyQDboa08ypmmzOSKdPxtbeULAe/yy4/Nb9cCiTVEbUbJyg125x+tnxnl?= =?us-ascii?Q?rU2W23r9vNHPF9P64fQX4BK+atJeMNvgMMSXDSPgNcTiKZ5ISEoM00Y4NZY8?= =?us-ascii?Q?XPfpUmohvCi5ZUbhYYVCVhHlwUMzmmj7rQ5v90Ov/I3Iy6kkm2v06hBuvVVP?= =?us-ascii?Q?5eDWflA6MVpJFpM8zsHeX7RCCCPFI6ORXnQVxn+Bi5tTD9hmO7C/JrvOMhdU?= =?us-ascii?Q?TnnFjyZgrjbq5gsmyFER/TQY8bS9Nm0cV0QSUXALXm/BCFQy6BYoDNVzTtKm?= =?us-ascii?Q?ngB4ie5i5CxBTIZccTUCO7s5AV4u9tJqpE4yEHEc5KlOZQtv//OGsG8iiD5B?= =?us-ascii?Q?7GxhrhifezG5vP7uf0AvVf52dVCI/u1UZg+Ptdtd4x+iWhjZMR2Mwdjpk6GP?= =?us-ascii?Q?u/r/QHHDnVYXPJlPAx6eMF+622rHSGfRgBFpWijsdiuySC8J6xM9jaS02jsL?= =?us-ascii?Q?MJ3X8r2yNjz282OPO4hnI8AKQEeBr+42iQfdIdGs7STM5z8barVQn3toCG8T?= =?us-ascii?Q?aGuZngd7EUT9nMOMui/a8eANArFAgO7xZGcOcRzJ55T6tdZ3ubsO95BqO9l+?= =?us-ascii?Q?TAD9hzOOXcZPtd24FiG5eZV2yTtsIMMfHD9dxagWh6QmFPrkLaIxpweO2PzZ?= =?us-ascii?Q?Cl45Xkq6KD7e0Uk34xttqyXnoJW7jHQUeCUxPugv7qPPoNw0aytckxoIfkF/?= =?us-ascii?Q?LYXnEbx8EHvN/WCuoF1HPVqv/2ImLAVK4fV4dgyyuFbzWcqswTDogYzuf2eX?= =?us-ascii?Q?jorZcPDpvSecSSa8NP5woUoPrzdQ3aWLPkgDR4r4v+Db+Fmw093nje0V6bIN?= =?us-ascii?Q?fHtlEHaL0gdPvWGXQp0c0sbk+u2vXSAmRg0JyVBogUsmq8xncIJ2djg0BBgY?= =?us-ascii?Q?ew0b3qMHU22cFWyLq19xkU9wPbu7qlCwzgH75hcYn8cU+xwMesqEfhXm43j3?= =?us-ascii?Q?nEqKNljbyggO0wvEgsvokRgZoG12C/1N8HEhI/rqIQBRXJBmmixdv4tS9+p9?= =?us-ascii?Q?5kxe5nKzOi5ckS4W9wrgd3NDGrfB8OsNgMGcpksh1d+7MMnwnvXh5egM23lb?= =?us-ascii?Q?fTwMOmfV97T9N6hhmHRnT46QIi2g9FWk/E1qpvZqndQHDtdqn+TUjoLyHdmX?= =?us-ascii?Q?GRbyO3xO3GJ/hoBYFbREWFk7IBy9O0I2JAx+GpRSXfjvcdgcmr+KEwHP3DfD?= =?us-ascii?Q?N3nskQjifuE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(7416014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6rXxAEsC4quiPw2IAba3wAuGsQOa/ZYsl+MA06aTO3bliMxX9ups3x9ae08G?= =?us-ascii?Q?CX4Dzo02uQaukRA/x8NgqTxRLammbxihqOjgVugzfo9hwFhSkaCMWdOXSJtq?= =?us-ascii?Q?8pJ/60vrfzL3kBv5zpeD5bKvZ3wQJvgEfFndTVDh+mfiBQBDd3L9rlYl4c7p?= =?us-ascii?Q?TRna08D+4vERfYlAFWpZGcmzT1Mk0/+518nAX7xZgRrezle8sYJz1g9dKKY8?= =?us-ascii?Q?/z43mxvIzS5cYBETn19yIGgOVObGAjB4qz8P0nfipr8pZeN2SJv7wnaDfHgO?= =?us-ascii?Q?QDHlI523J8h0SCdmc6tkatZw3/eZIS+n1cTH/eEZmwZjnNxSF49VTqqz9JMb?= =?us-ascii?Q?PB/Kg5hbqjLWYwmOj94n2x9//G+DOjJc8SNf+3SwqFW0YsxYY+Bmm3r8tjyI?= =?us-ascii?Q?nvDvFG2lZjPcKyEjNBZxMKAoIqy5umQRboVdCosANnrnaPAOi278BCl9Lg88?= =?us-ascii?Q?L52J9/1Ko2LOZgrBKOns3H3bTTXmhoBkMsFEj6084WTRN97aJ77GRHCLXhUz?= =?us-ascii?Q?u5/I0STGn9lWTqP2kRK20+EETheKJ+UCBslqzqpjhj0LfV8fJ+owEwpcNf2z?= =?us-ascii?Q?dx508qXxxFvemyhlbPEuKRYZeMLUcX03LtV0cG3LeEQfIwDurJHYDAhAKhC6?= =?us-ascii?Q?08vHkVmrXjU0Z93SroQJ5TsLXs79LJ4bFHopzuPdyhWjnGnldj0rJKVlG3DS?= =?us-ascii?Q?a0zZCxMLQ1TprxYfGtPKY2YgSp1cecatDjakouCQfQd74gzo1QY3HXk4PklR?= =?us-ascii?Q?YJsZIEUj8lUO3cIKkZAzte9lo9a6hKVf2vfqdnu9MGNBdpHOcqKQbr+kCeUI?= =?us-ascii?Q?tLgVMT8QdSnTViAC5Fu8iQ4DLl3BPORcBb8rnAUL6hhcWE7nMC4nfAfFisFG?= =?us-ascii?Q?2kSyT2tTkTQGBstHvTTRQ4yLoIe81IjTuMpzkTRoJ+w5mj90+6lwYilI2Jhj?= =?us-ascii?Q?rlHfgCmCmNcXz0djrv33vYkcAA1FgU9/cz9OrJ8jsJiyz61Rp7sBMGqx5sRW?= =?us-ascii?Q?UBZXNqdz8pcUWpi3MnjaG9BqMXVpVMMcnUbRYS9in/pHpWSnX1v2fEYpsvJK?= =?us-ascii?Q?gGA+KjiwlF3eJbVxNWHW2HhN4aENHB6AYWrCo1+L+/cIlR+o8KcXDFgpgnBN?= =?us-ascii?Q?5wjbfqeKjEWqvB8cEcgy1KmepxUIL9BpyqKmbjTaJsV+SIJAS5gSBkDOVlSP?= =?us-ascii?Q?mFtfyG9CJfumEsUkFZSVHUo0jrI6m7jmGUjaj7lioVdmfBlQwHfJPsdGTvJX?= =?us-ascii?Q?1aWCiqTIDQKxke/nYaoAKcXiRwcRfDHSVsBQ3nI9iHml6A8i1edXr2yCvXrE?= =?us-ascii?Q?V+EGiPWRbbB/ka/tABC/nFbRXgwGLIC3GFpU+wWAl2+LQ+2CKGz5qOBg53Jg?= =?us-ascii?Q?gIP0BqPjupvmPC2sS3s5S6D/H44WpOoeoZ7lL1gurlBKo2CSGg0DG0AMTZxk?= =?us-ascii?Q?cBJQTxGzIq8hPhuI2mqGpwle7+hFBm3/L/Z5+wJLOJpYY2EApi0KL6ynRaPI?= =?us-ascii?Q?hW2S+D/EynL90frdhTXeykdFWGBcN/A7IaW/wtTyY91IC8APwPLSfEIWL0xE?= =?us-ascii?Q?Tp1/LuyiTnf8rv/asNpP13HXR3liHD6hXUBxbfqw?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3734b100-1e9b-49a2-8ef8-08dd96e274f9 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2025 14:35:52.7132 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9EJKCiPCPpu5zzucpOYEPafuN5sQjWyonR5T7lpEZsbGGeJdXwzbKWbfpsvMr4zh X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6312 X-Stat-Signature: oowkmgi9zm7oweahucmyckw7r57i7y4t X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 133641C0005 X-HE-Tag: 1747665355-986393 X-HE-Meta: U2FsdGVkX18/HWZ4kU9FbqoShRVVKEzOddSV8TOJ3QVTxjLmuqVKdQ1Zw/dsvleNYUXpYZLqGLm9d6ISLfaVncR29Z6dWDZijRvIsp9Dk1eBSj8wCN/z+776b1JCEcqtH9TqWOUnnMrYEULBQZFyfsEVZ76FfWu3jvkQt39IagY8j0mhADxEbZnmj6xzOTACMYp/PfbL9vM8fPVo+2C+kCtlIVY3HrPM+2KbChNPD7AunDwong4c7kRKtL9tVQMcIDjwXI/dsQvCWpaMJ/rYVgn8BXLPdztWakSIhPEpCCMBBV5gQpNPZTC8OgFP+U3p18lk5MdITlpdHUrvQQkb2wGpeDNmh6dro3bFCSE89MKZsG5bZKtf0Z8c+OSGtjp9uMOLdi5+TWCPloaYMiLlmJ6MdDoP6Wby2RpNVR+E6iuq/YEFFlNsRnkV3rg0PM+y8EpSSsnvFDNQH919uqahGAgLWJaI29vcaudAVEEZ2aEQI1Gw+FCA4JDe6RRTkWxacnoTEN+hVkbd/YBSXw3pIEsVTTk8IVoo20e8CUtyoCk/hg3mCFbpCECNH3EOaAFPL3ufPggA1JV9+R/VmTTU9y0HfAGbnikc+4diqtynu2qVTcK21FgautDgn4Mxv0NTQcl/prNb8YF8243EP+Dt6mvIFwuPVtUKeEKg7oYvUYwTzuq9hOJUdn6dEEHo+nf4fU/N8Knf2J+qS6ON6FVKZW+afSYSRImHNIupMWpOnnjGCGe65qgPnUBfpL0/cpxJ2VGO5hWO6o48oYTWmiNRS+3blSDu5zUODH0C5jp0LTfvvk2KUt1VXxS+is8EqZV+K7n8b/d/MHhT8nM0D7mYahGJ++zZoxqqzEPE7fuhlir+gesUR86Ua4Fn0GODDh7Tiv7Osuj5TNlJcuCDhXJ90V0oJk+Yzz1naBSJ3gDSXHFb02m+ta0I7XVdY5ASsoEGDwPolAOV4fxtsH5NlaD SeTKwMZo qDptrN1/mKBfWuoURAyi/DIkmFN3dgZG0oVtUs0yExMZSsX0qE25/M8gcbU5ZBfO33i+lhcMfJflNhXS7jE9HloLZR2QvIcFF1aoxHuazWatmgw1Pc8rOXnFGi9RCGHrd9LyDN3mItUBkFJZLMQjs5mBtolWdoqKpc9YDh66SjDSOvOjC0or37U6Yt/LugTBpPq0YOq6C/xsJ98aOP+gmc27azua5T020RbQQJiVfIF+FC0R1Z6vA4SUdKMHnsGzYbqgFF3bTBZlo+sp8FIN8f/Js0xXTbY/HMJwypaJaEn/mRjtlusD/D7rP3ep2kzd9MDr90vCTcKpHwD8UxEoLrsL8lucxA+eTXjc8ouWJZiaSVlMDf4QDQDNgQY3uGLE0ng8xoquLMwY7d3j55Mbvu6znF+zzvUUuRf8D X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19 May 2025, at 10:15, David Hildenbrand wrote: > On 18.05.25 02:20, Zi Yan wrote: >> On 17 May 2025, at 16:26, Vlastimil Babka wrote: >> >>> On 5/9/25 22:01, Zi Yan wrote: >>>> Hi David and Oscar, >>>> >>>> Can you take a look at Patch 2, which changes how online_pages() set= >>>> online pageblock migratetypes? It used to first set all pageblocks t= o >>>> MIGRATE_ISOLATE, then let undo_isolate_page_range() move the pageblo= cks >>>> to MIGRATE_MOVABLE. After MIGRATE_ISOLATE becomes a standalone bit, = all >>>> online pageblocks need to have a migratetype other than MIGRATE_ISOL= ATE. >>>> Let me know if there is any issue with my changes. >>>> >>>> Hi Johannes, >>>> >>>> Patch 2 now have set_pageblock_migratetype() not accepting >>>> MIGRATE_ISOLATE. I think it makes code better. Thank you for the gre= at >>>> feedback. >>>> >>>> Hi all, >>>> >>>> This patchset moves MIGRATE_ISOLATE to a standalone bit to avoid >>>> being overwritten during pageblock isolation process. Currently, >>>> MIGRATE_ISOLATE is part of enum migratetype (in include/linux/mmzone= =2Eh), >>>> thus, setting a pageblock to MIGRATE_ISOLATE overwrites its original= >>>> migratetype. This causes pageblock migratetype loss during >>>> alloc_contig_range() and memory offline, especially when the process= >>>> fails due to a failed pageblock isolation and the code tries to undo= the >>>> finished pageblock isolations. >>> >>> Seems mostly fine to me, just sent suggestion for 4/4. >> >> Thanks. >> >>> I was kinda hoping that MIGRATE_ISOLATE could stop being a migratetyp= e. But >>> I also see that it's useful for it to be because then it means it has= the >>> freelists in the buddy allocator, can work via __move_freepages_block= () etc. >> >> Yeah, I wanted to remove MIGRATE_ISOLATE from migratetype too, but the= re >> is a MIGRATE_ISOLATE freelist and /proc/pagetypeinfo also shows isolat= ed >> free pages. > > The latter, we can likely fake. > > Is there a reasonable way to remove MIGRATE_ISOLATE completely? > > Of course, we could simply duplicate the page lists (one set for isolat= ed, one set for !isolated), or keep it as is and simply have a That could work. It will change vmcore layout and I wonder if that is a c= oncern or not. > separate one that we separate out. So, we could have a migratetype+isol= ated pair instead. What do you mean by a migratetype+isolate pair? > > Just a thought, did not look into all the ugly details. Another thought is that maybe caller should keep the isolated free pages = instead to make it actually isolated. We might need to keep per-order isolated fr= ee page stats to fake /proc/pagetypeinfo. -- Best Regards, Yan, Zi