From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A72A1C433F5 for ; Thu, 26 May 2022 13:05:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 015438D0003; Thu, 26 May 2022 09:05:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F055C8D0002; Thu, 26 May 2022 09:05:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E16568D0003; Thu, 26 May 2022 09:05:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CF7D78D0002 for ; Thu, 26 May 2022 09:05:01 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9DF386066E for ; Thu, 26 May 2022 13:05:01 +0000 (UTC) X-FDA: 79507914402.30.121A5CA Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by imf03.hostedemail.com (Postfix) with ESMTP id A2D4B2002E for ; Thu, 26 May 2022 13:04:46 +0000 (UTC) Received: by mail-pg1-f170.google.com with SMTP id e66so1272809pgc.8 for ; Thu, 26 May 2022 06:04:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=pBzDjNM+NIKrQwzz6yoXDKmfszuTKOxi+7+JN/0QvnU=; b=RYYRlQm8mMja6NCqEmTYUzwWQzF8s9wysfsvug3GrnVY6UaaQEwJ7hilPDM6zY4Ekz NP+VQzOI+ku/PYKSbFsJ7EdcoapEqjDGliUIWWnN0lyR7EvknmBYVVWuTpl0MJmIFkZs 9UH+r6eyPOXlbJjqIk4JMqpe3nh9qG928VTyNnDEsG/6kEsvPghzIXFb/JIWpk4ipQ8e Gk4My12oty0cIGixSF8vPpc5L0EZ2C51j/I6w6pWo0xgZv1GXZL2iZwyBu27UnNzGvWF wWtwA3pZv5Aq6TfpBr76ZD/aYnttA04WZuveVZal+HS7Nq8ojp/mhD9vCTO26i/aUevw 8OOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=pBzDjNM+NIKrQwzz6yoXDKmfszuTKOxi+7+JN/0QvnU=; b=ngHI9B56Tml+9M1TKQqgMxGgYclkpGv1lRqUHgM4j0BzGI/EVb7FAzGPScy13Dt05r Kx1VUA5LcJlvkK7beNmVKREkZUZMoj49LsAeRXh92cALkyteJOqIUXE6OlZ9TwDjTt/Y sJdymASrDMZTFQXhOINyWedD8rK7ZB0B0iQFjXh2L3rxO9Ksy5eJquwVMczLNhefORZn g5VEAVc7r9xDWOeMFEtehBoagq2aj0s/cjQuFWAMr8/aruSb4gI6Z+Rq3He3XkFJHdAQ VdEdqRkb2QytDOXo6lSTVsGHUxh/CWvmAqcjJ22lSN+O/Wb5Ik5/kjLBKbfx+UEw2YKm DKpw== X-Gm-Message-State: AOAM5306MoK/oKZRO6UrzuxLIVrxEXN0NmIYwMIAXrJDnQh+E+jFsTIj CW/kgnSTgC8e9MOMrgMmCOlt5Q== X-Google-Smtp-Source: ABdhPJyI+Gw9YzU040OsLcgsCaXngKdpfhzznfZfcU8k9dTvc3YHSPNd4XgLYgnxtJ/BHuCRqqgbVQ== X-Received: by 2002:a05:6a00:1a11:b0:512:6f59:f5cf with SMTP id g17-20020a056a001a1100b005126f59f5cfmr25386849pfv.45.1653570297993; Thu, 26 May 2022 06:04:57 -0700 (PDT) Received: from [10.5.103.226] ([139.177.225.237]) by smtp.gmail.com with ESMTPSA id t9-20020a170902b20900b001621ce92196sm1470044plr.86.2022.05.26.06.04.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 May 2022 06:04:57 -0700 (PDT) Message-ID: <09f38cf3-282a-61fa-9916-057b01b57d30@bytedance.com> Date: Thu, 26 May 2022 21:04:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] mm/page_table_check: fix accessing unmapped ptep Content-Language: en-US To: Miaohe Lin , akpm@linux-foundation.org, pasha.tatashin@soleen.com Cc: rientjes@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220526113350.30806-1-linmiaohe@huawei.com> From: Qi Zheng In-Reply-To: <20220526113350.30806-1-linmiaohe@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A2D4B2002E X-Stat-Signature: 83mz8k848zi4do9ony7heya5u6i7n3hx X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=RYYRlQm8; spf=pass (imf03.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.170 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-HE-Tag: 1653570286-493937 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/5/26 7:33 PM, Miaohe Lin wrote: > ptep is unmapped too early, so ptep will be accessed while it's unmapped. > Fix it by deferring pte_unmap() until page table checking is done. In the beginning, page_table_check only supported x86_64, so there is no problem. But then the commit 3fee229a8eb9 ("riscv/mm: enable ARCH_SUPPORTS_PAGE_TABLE_CHECK") added support for riscv-32, it is indeed a problem in this case. So: Reviewed-by: Qi Zheng > > Fixes: 80110bbfbba6 ("mm/page_table_check: check entries at pmd levels") > Signed-off-by: Miaohe Lin > --- > mm/page_table_check.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_table_check.c b/mm/page_table_check.c > index 3692bea2ea2c..971c3129b0e3 100644 > --- a/mm/page_table_check.c > +++ b/mm/page_table_check.c > @@ -234,11 +234,11 @@ void __page_table_check_pte_clear_range(struct mm_struct *mm, > pte_t *ptep = pte_offset_map(&pmd, addr); > unsigned long i; > > - pte_unmap(ptep); > for (i = 0; i < PTRS_PER_PTE; i++) { > __page_table_check_pte_clear(mm, addr, *ptep); > addr += PAGE_SIZE; > ptep++; > } > + pte_unmap(ptep); > } > } -- Thanks, Qi