* [RESEND] tools/mm: Use calloc and check the memory allocation failure
@ 2024-09-12 3:24 Zhu Jun
2024-09-12 4:28 ` Dev Jain
0 siblings, 1 reply; 3+ messages in thread
From: Zhu Jun @ 2024-09-12 3:24 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel, zhujun2
Replace malloc with calloc and add null pointer check
in case of allocation failure.
Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
---
tools/mm/page_owner_sort.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/mm/page_owner_sort.c b/tools/mm/page_owner_sort.c
index e1f264444342..8c78265cef67 100644
--- a/tools/mm/page_owner_sort.c
+++ b/tools/mm/page_owner_sort.c
@@ -368,9 +368,10 @@ static __u64 get_ts_nsec(char *buf)
static char *get_comm(char *buf)
{
- char *comm_str = malloc(TASK_COMM_LEN);
+ char *comm_str = calloc(TASK_COMM_LEN, sizeof(char));
- memset(comm_str, 0, TASK_COMM_LEN);
+ if (!comm_str)
+ return NULL;
search_pattern(&comm_pattern, comm_str, buf);
errno = 0;
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RESEND] tools/mm: Use calloc and check the memory allocation failure
2024-09-12 3:24 [RESEND] tools/mm: Use calloc and check the memory allocation failure Zhu Jun
@ 2024-09-12 4:28 ` Dev Jain
0 siblings, 0 replies; 3+ messages in thread
From: Dev Jain @ 2024-09-12 4:28 UTC (permalink / raw)
To: Zhu Jun, akpm; +Cc: linux-mm, linux-kernel
On 9/12/24 08:54, Zhu Jun wrote:
> Replace malloc with calloc and add null pointer check
> in case of allocation failure.
>
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
> ---
> tools/mm/page_owner_sort.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tools/mm/page_owner_sort.c b/tools/mm/page_owner_sort.c
> index e1f264444342..8c78265cef67 100644
> --- a/tools/mm/page_owner_sort.c
> +++ b/tools/mm/page_owner_sort.c
> @@ -368,9 +368,10 @@ static __u64 get_ts_nsec(char *buf)
>
> static char *get_comm(char *buf)
> {
> - char *comm_str = malloc(TASK_COMM_LEN);
> + char *comm_str = calloc(TASK_COMM_LEN, sizeof(char));
>
> - memset(comm_str, 0, TASK_COMM_LEN);
> + if (!comm_str)
> + return NULL;
>
> search_pattern(&comm_pattern, comm_str, buf);
> errno = 0;
Hello Zhu,
It is pointless to resend if you haven't addressed the queries
raised by Andrew. He notes that the callers aren't handling a
possible NULL return, so there is no point in even checking for
a mem alloc failure. I haven't wandered in tools/mm but from a
programming PoV what Andrew says is correct...if you are returning
NULL then you also must decide what to do with that in the caller,
and so on, on which I cannot comment :)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RESEND] tools/mm: Use calloc and check the memory allocation failure
@ 2024-09-06 9:24 Zhu Jun
0 siblings, 0 replies; 3+ messages in thread
From: Zhu Jun @ 2024-09-06 9:24 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel, zhujun2
Replace malloc with calloc and add null pointer check
in case of allocation failure.
Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
---
tools/mm/page_owner_sort.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/mm/page_owner_sort.c b/tools/mm/page_owner_sort.c
index e1f264444342..8c78265cef67 100644
--- a/tools/mm/page_owner_sort.c
+++ b/tools/mm/page_owner_sort.c
@@ -368,9 +368,10 @@ static __u64 get_ts_nsec(char *buf)
static char *get_comm(char *buf)
{
- char *comm_str = malloc(TASK_COMM_LEN);
+ char *comm_str = calloc(TASK_COMM_LEN, sizeof(char));
- memset(comm_str, 0, TASK_COMM_LEN);
+ if (!comm_str)
+ return NULL;
search_pattern(&comm_pattern, comm_str, buf);
errno = 0;
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-12 4:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-12 3:24 [RESEND] tools/mm: Use calloc and check the memory allocation failure Zhu Jun
2024-09-12 4:28 ` Dev Jain
-- strict thread matches above, loose matches on Subject: below --
2024-09-06 9:24 Zhu Jun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox