From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32F6EC021A4 for ; Mon, 24 Feb 2025 10:37:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E3786B007B; Mon, 24 Feb 2025 05:37:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8930C6B0083; Mon, 24 Feb 2025 05:37:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70C336B0085; Mon, 24 Feb 2025 05:37:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 52DAA6B007B for ; Mon, 24 Feb 2025 05:37:33 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CDAB9C10BC for ; Mon, 24 Feb 2025 10:37:32 +0000 (UTC) X-FDA: 83154486744.07.3DA7983 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 2128640003 for ; Mon, 24 Feb 2025 10:37:29 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VqKIy7Bo; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740393450; a=rsa-sha256; cv=none; b=bm7/sOktVpvGx7WdxxKlETm7dAdyG3I98lpHLtqorCqPc0DREvc6hl+JBxu4XoIb2j3DD2 6DLoAsUL+ro8DLLRKdb9D+JVOmef6kf+hPliyGRwhXc4k4h3SI1LGmj4dnoDLo0W8Cwce6 7Uhhd5a24SJKD3bT5J5Sk23HkPzO4Jg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VqKIy7Bo; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740393450; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rO8lIKV122u8A8FjTVOg2+ZxmXBOIm46qqiWIzi0zUY=; b=4zzt3yn465xLp3JOXc24j+tkB5Px+DqF0jad6yZNTQ2JNioelM4WCsMuCz9z5lMu3KUKWc 6ZcEzYnJEWGTGc1Twm9uFCOe11VQmSB6Jf7VHR2it58wgNmMN/cjYFKiNCgmZR9Y7buKFx nvc+VJzKRnn8JGPtsRzRHTlnUt8z42g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740393449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rO8lIKV122u8A8FjTVOg2+ZxmXBOIm46qqiWIzi0zUY=; b=VqKIy7BohXMJyEIVjDyPFPJDllk01lKm7ll2uMH0j/t1uNycuRg/Lj6HxkWR8pQ3cp1BpJ CdAcqd5IeVKuQzXikYvhd9l2txunKaxlv2w0aJZKM/ASOV51JlXnsunTOF4SjmfbGR/Zag dT/IYTBn0Q77xdyaSHbei4C0iwomqBE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-512-Ac8VclPWN7KqsPs15uZVdw-1; Mon, 24 Feb 2025 05:37:28 -0500 X-MC-Unique: Ac8VclPWN7KqsPs15uZVdw-1 X-Mimecast-MFC-AGG-ID: Ac8VclPWN7KqsPs15uZVdw_1740393447 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4399a5afc72so21864305e9.3 for ; Mon, 24 Feb 2025 02:37:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740393447; x=1740998247; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=rO8lIKV122u8A8FjTVOg2+ZxmXBOIm46qqiWIzi0zUY=; b=ZWFi2i6m21FS0qA5Mnuufx2YmCxBeFIbPLzjG4P+XeJhSVfeaMxihu8Bg4/iTiBe5H Zj4cRmDNy9RHsb4ZQPUG/7ox/Kbzm+M6bmXgLYcRxK/Z/DjoNtPjDQ2dtFN3UeW8lb9/ dIvpa49L//UpTGJhVL3yVzz+x6yODcsqCmtsl2vykq55hrPUd3EGiq+h8SyAqJTIFy65 15ke0t36gA0L5KKGMALGUM/j5GGpHkp/mWo8Wk04HaTmdprsyE4xQ2OQuO3nrmtZ8OFb 3NPzcNHaK0JRI/Ds07tD1uWgdNc1988i89f2oEgmX0moA8UIEx/3ldGh2Pqdk1w19Qng 9fxw== X-Forwarded-Encrypted: i=1; AJvYcCW6Im/vQ7V/Cva5C/otcW4kqDoWtO/opiIAPIeIcZz01yLCKIEQhzFDbwXYn76DaSei82kvFUVkIw==@kvack.org X-Gm-Message-State: AOJu0YwlxUEWEb53TfV94PEw10N0jGV1YOdWIyHKkq/dQfNTvfKpcVYB dMakO27ELZvqRkAx4YWmoLAXqFcONJqUPoRPIK2EvXsPAjBf8b8eYHqQ0prRrzkkvOpEjOo7GI8 Xm7i30D8UlmPnxUB2PHeefZqSt0JMe+lfuRDqGrZ/EmFVwgJZ X-Gm-Gg: ASbGnctGRvIMHpBytvRiw1I6kxkr+eeoh6CxFQe5zOYEu5zAU7f1pb47nfDqqUFukpU Xt5n84pTScGKgCkLswxKEm7YdFGSUWM/SF9fxPs89RlSX1u2lvelcpj/LTgQV/F1askSakiOxWB Ji3Dhl+ALNGQZ+nYhpHEL0sUS1/jxRDYV0QLKfXiSEI3bzDFVUS1fpq9ZBekwJBbog0eHO9rVoO uQ19Lgig+UIgj1FAD7ISBI6cpndStAH4/yMr2ey1uk+XsSLKkQZo41FcYfrwQ2d3J78x77IbrF0 Jh76X8T5qcNHbCeFTZ3H9KL5ZxqM9Z9kqL+IOCeLch3tyRod/09g7fEhDlbHCs6XoxcYgAgQTsE 9olCoUg7Gr7W3+3oIByRLiV49pxS2yH81mt8Zyo+yxcs= X-Received: by 2002:a05:6000:1789:b0:38f:3de0:d16 with SMTP id ffacd0b85a97d-38f7085dc1dmr7386615f8f.52.1740393446870; Mon, 24 Feb 2025 02:37:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IHYBbwlOwYkjd2sSmfgkM5zkQutF43Ts1I4C5qCYdEua9tWy0/1u+3jppjIwy2SkS/Xjj4zJw== X-Received: by 2002:a05:6000:1789:b0:38f:3de0:d16 with SMTP id ffacd0b85a97d-38f7085dc1dmr7386582f8f.52.1740393446413; Mon, 24 Feb 2025 02:37:26 -0800 (PST) Received: from ?IPV6:2003:cb:c735:1900:ac8b:7ae5:991f:54fc? (p200300cbc7351900ac8b7ae5991f54fc.dip0.t-ipconnect.de. [2003:cb:c735:1900:ac8b:7ae5:991f:54fc]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f258ddba7sm31622272f8f.38.2025.02.24.02.37.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Feb 2025 02:37:25 -0800 (PST) Message-ID: <09d7ca19-e6cc-4aa9-8474-8975373bdebd@redhat.com> Date: Mon, 24 Feb 2025 11:37:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] fs/proc/task_mmu: add guard region bit to pagemap To: Lorenzo Stoakes Cc: Andrew Morton , Jonathan Corbet , Shuah Khan , Suren Baghdasaryan , Kalesh Singh , "Liam R . Howlett" , Matthew Wilcox , Vlastimil Babka , "Paul E . McKenney" , Jann Horn , Juan Yescas , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-api@vger.kernel.org References: <521d99c08b975fb06a1e7201e971cc24d68196d1.1740139449.git.lorenzo.stoakes@oracle.com> <857b2c3f-7be7-44e8-a825-82a7353665fb@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: QSv8vcDQDD-I3WfIyitIyd5JrjqPvgxK4_Xl0Hc0OIw_1740393447 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2128640003 X-Stat-Signature: fk53nj7q8nyripc7bcofnqkaktkec8o7 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740393449-332449 X-HE-Meta: U2FsdGVkX1+n0ptWrXaNCBYjLPh3qk8UMdlQddjDjSpYFTNucrMdT65QK7X9/junBwm2tKJV+zFZ0ZpN0GbfJrNfit/IC01vyCxIDkyPoTXy/Ti+7kJbah8a7UQ/DLnefqXsaXL1rq1PLXYu43E/saKlHMBKaFzCXGvCAwXHL8o91HAtY+ZgcoGhPKL9vgD70jY03jhfBwJtt9C1O/U0gRmx4sl40k8OIlIn59KMVa6OylZsAJRj/6kQ2ut8mvXaAhWh0/cNyvH+pQYBM85tl3cEJbGAf5rMNSsXR67o9o+Yx2itudey7WNSCsKyE9QmwkmBEnTOmdfwA0HUj1QZRCFjD9m30Ex9OGjmf3PqNDjIJ2s4RCcXc9zuEspRIjN4Vtku6heJlTNxd8HcYvXiqcNreQTzQ62eFr0PP43jUeHSJ90MwmCWhRl3+hn0dci5Ol8isc9bmEQF/O1M+dkRpAAXPFxSgrvyhbGa/6/Dd4XKWiTk3j8bY4uTPaygzPDtAC98EOZuEou8se1Ue8ZOJvso4r4oF8S0W/tspahdJoMRM8YerqwSeH4RBp4mbcZY2YY5NxShHJZOuZ8oEKymF7/djZEuWAZTMAPu+NKicZC8Lmi2aLf2g8gp4AsWZGe6UKjl4pgvoQKjIK0mWrj0IO8S9bYbnQqeHspSTMNGP0iHoYC3NBeE0BZi+ozoWBhqSbM7SI8IDxnuyewyAaVS0FR1oWbPwoWtR+aYg/f830Hf7ftbGpVjriL0phkUKPL/7GphhTNpGMruLb6Qb2hCdSlEQ2XuAccT7+gGpZQxZhtYoprXnzltDfiJXFOJTPWFJtiTm6HogVmYJiJW/EI3zhH4FIbtIADPN3LnTaNa9skhL/zSfSwszZ4J+EsCWa0KoLuTOAx4BUqpoBO7XyZPRhVaRd9o1d3aDHBTpZsGcs94/4A9he+1Ju5bsNCa15mspZF0DhaKO2gMEm89IzC 4ldm98u5 wUBRnYgcIBdWp13BfM/roAY86pkzn8B1+pzmhCDnONZHeX9Uo5pdjvAypXiJ6APfSl7FbLjVdZRHJRJ6/8QgWcxY1Jo515ycbpkUx2Gi8+hbh0ipKeSNBkWMpQrkEgBqidybFZMZD0yEf0oxTF596LP7enoNFfWWUI9d3qVy1FE9zGOLteflZtx/ntBevaGSMbmAR+vbZLFdtRR2AaKU7Zu1KYyJajB0ILEeOHZvgAEJEbk0yqBrmqw/vTYJ6/0ohUOjcCjGLh+koeVfmf4Nzp0r+Bb4oVUo02vNiStEnVRSwKo6zCVEHZ/zF+6CpUi2N0UWKVstjJFZ3gbXKnmzGhB2iatrtKASERGzr44FUfoZRsKn8ExWat13U1Hmz0GhRO5/foTMij9SEss3ujjcJ8o8TDlV5y8zspiS3Q2eGfXhXSJmBggFFF8QgAirS7VuLpORhlgOegHKFmy7v4p4pIIyNYAVqU0mcY6XUOewYLe+CMF1mq5V2XuIdYAwekJ110+dpEqp5Zspr1upIP1Dodj10aEyEpXaauxXW/k7zY8FZZ/lUdYP/SRC00acRzgKWJ1MVqHYsLHlkw4fLRhA9mJeO/KRQFtbuwMkFs2VKIhmUpOI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.02.25 11:18, Lorenzo Stoakes wrote: > On Mon, Feb 24, 2025 at 10:27:28AM +0100, David Hildenbrand wrote: >> On 21.02.25 13:05, Lorenzo Stoakes wrote: >>> Currently there is no means by which users can determine whether a given >>> page in memory is in fact a guard region, that is having had the >>> MADV_GUARD_INSTALL madvise() flag applied to it. >>> >>> This is intentional, as to provide this information in VMA metadata would >>> contradict the intent of the feature (providing a means to change fault >>> behaviour at a page table level rather than a VMA level), and would require >>> VMA metadata operations to scan page tables, which is unacceptable. >>> >>> In many cases, users have no need to reflect and determine what regions >>> have been designated guard regions, as it is the user who has established >>> them in the first place. >>> >>> But in some instances, such as monitoring software, or software that relies >>> upon being able to ascertain the nature of mappings within a remote process >>> for instance, it becomes useful to be able to determine which pages have >>> the guard region marker applied. >>> >>> This patch makes use of an unused pagemap bit (58) to provide this >>> information. >>> >>> This patch updates the documentation at the same time as making the change >>> such that the implementation of the feature and the documentation of it are >>> tied together. >>> >>> Signed-off-by: Lorenzo Stoakes >>> --- >> >> >> Acked-by: David Hildenbrand > > Thanks! :) >> >> Something that might be interesting is also extending the PAGEMAP_SCAN >> ioctl. > > Yeah, funny you should mention that, I did see that, but on reading the man > page it struck me that it requires the region to be uffd afaict? All the > tests seem to establish uffd, and the man page implies it: > > To start tracking the written state (flag) of a page or range of > memory, the UFFD_FEATURE_WP_ASYNC must be enabled by UFFDIO_API > ioctl(2) on userfaultfd and memory range must be registered with > UFFDIO_REGISTER ioctl(2) in UFFDIO_REGISTER_MODE_WP mode. > > It would be a bit of a weird edge case to add support there. I was excited > when I first saw this ioctl, then disappointed afterwards... but maybe I > got it wrong? > I never managed to review that fully, but I thing that UFFD_FEATURE_WP_ASYNC thingy is only required for PM_SCAN_CHECK_WPASYNC and PM_SCAN_WP_MATCHING. See pagemap_scan_test_walk(). I do recall that it works on any VMA. Ah yes, tools/testing/selftests/mm/vm_util.c ends up using it for pagemap_is_swapped() and friends via page_entry_is() to sanity check that what pagemap gives us is consistent with what pagemap_scan gives us. So it should work independent of the uffd magic. I might be wrong, though ... >> >> >> See do_pagemap_scan(). >> >> The benefit here might be that one could effectively search/filter for guard >> regions without copying 64bit per base-page to user space. >> >> But the idea would be to indicate something like PAGE_IS_GUARD_REGION as a >> category when we hit a guard region entry in pagemap_page_category(). >> >> (the code is a bit complicated, and I am not sure why we indicate >> PAGE_IS_SWAPPED for non-swap entries, likely wrong ...) > > Yeah, I could go on here about how much I hate how uffd does a 'parallel > implementation' of a ton of stuff and then chucks in if (uffd) { go do > something weird + wonderful } but I'll resist the urge :P :)) > > Do you think, if it were uffd-specific, this would be useful? If it really is completely uffd-specific for now, I agree that we should rather leave it alone. > > At any rate, I'm not sure it's _hugely_ beneficial in this form as pagemap > is binary in any case so you're not having to deal with overhead of parsing > a text file at least! My thinking was, that if you have a large VMA, with ordinary pagemap you have to copy 8byte per entry (and have room for that somewhere in user space). In theory, with the scanning feature, you can leave that ... scanning to the kernel and don't have to do any copying/allocate space for it in user space etc. -- Cheers, David / dhildenb