From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1AEECCF2E6 for ; Mon, 19 Jan 2026 11:16:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12FA06B0184; Mon, 19 Jan 2026 06:16:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 106E96B0186; Mon, 19 Jan 2026 06:16:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0136C6B0187; Mon, 19 Jan 2026 06:16:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E60126B0184 for ; Mon, 19 Jan 2026 06:16:31 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7CD081406F1 for ; Mon, 19 Jan 2026 11:16:31 +0000 (UTC) X-FDA: 84348460182.01.2D827E5 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf14.hostedemail.com (Postfix) with ESMTP id CBCA8100009 for ; Mon, 19 Jan 2026 11:16:29 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ec02xF3m; spf=pass (imf14.hostedemail.com: domain of david@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1768821389; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V6FUrF8aqghMCgVKm0gfwfjLoPmo90p14gg9CKU5aHE=; b=QPID8nOfu3MBe0p64p7bmnkyDpdJwgw95snfNvuLY3S6TBccZrzR9Dcg9mGZCLST9b4BeC O4wwQypepewdIF+CuKeYhRO5P8N/Z7gf0YNFwfJK+6Bk0Fa0austHw4oDCVHaoSU3Itr3k Msah4crJWwIqv2suI04K1vg5Jm6ZXXI= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ec02xF3m; spf=pass (imf14.hostedemail.com: domain of david@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1768821389; a=rsa-sha256; cv=none; b=7Ssbff6WxGD0FHGvjNe/T8JQTUIulZtdHVmIjL8qciTiH/gYBOP2/DNeoiuCUuRKM3lzkU s7ME6ihDiHGBds2iF2m17IfHXEb0QOqoqYkSRylvsykLk2YB3jKu8gYIoqXJHRXX1nreqQ cgRczFir9KvaeEhLxCWh+plwJpK8/m4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 29D6660153; Mon, 19 Jan 2026 11:16:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47576C19424; Mon, 19 Jan 2026 11:16:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768821388; bh=IUVE3GXM6RFdsSQGwKFqMXdBr5285go1ee4oIqD+IQs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ec02xF3muwf5NwLMrYHzJqg/3ypIIf23/u3Y2IW1l/6ndAQJgW0lZbX2aS2L0VK6x Ogk894YZ6RKbCK/mD1aVu/YWHBKnxlnc+GVjFSYOt4w44iX/J2IEkBKi2oxP68pKuv CJbtP4AF9bf7RHjYc4swjy6n44CpUM/WYU23UeFvXbL8Wc+bNaCiUZjXvmiTdmig3h f3deb0V7NrTP2iozv4kQJnGxxBVvwP02h4gksMo63Y71ffljQ8dXaBjy49TfuUbjT8 1/cvn5ipx1PPKAFvKIjh4Y1/I9tjxv1ligJ6Jxjrru+w9o4+W9kC4Dj9iv/QXixz5N HzGQtc92tcj3A== Message-ID: <09c214df-c3aa-48e4-9587-c54c667c6ce9@kernel.org> Date: Mon, 19 Jan 2026 12:16:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 8/8] selftests/mm: report SKIP in pfnmap if a check fails To: Kevin Brodsky , linux-mm@kvack.org, linux-kselftest@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , Lorenzo Stoakes , Mark Brown , Ryan Roberts , Shuah Khan References: <20260107164842.3289559-1-kevin.brodsky@arm.com> <20260107164842.3289559-9-kevin.brodsky@arm.com> From: "David Hildenbrand (Red Hat)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAa2VybmVsLm9yZz7CwY0EEwEIADcWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaKYhwAIbAwUJJlgIpAILCQQVCgkIAhYCAh4FAheAAAoJEE3eEPcA/4Naa5EP/3a1 9sgS9m7oiR0uenlj+C6kkIKlpWKRfGH/WvtFaHr/y06TKnWn6cMOZzJQ+8S39GOteyCCGADh 6ceBx1KPf6/AvMktnGETDTqZ0N9roR4/aEPSMt8kHu/GKR3gtPwzfosX2NgqXNmA7ErU4puf zica1DAmTvx44LOYjvBV24JQG99bZ5Bm2gTDjGXV15/X159CpS6Tc2e3KvYfnfRvezD+alhF XIym8OvvGMeo97BCHpX88pHVIfBg2g2JogR6f0PAJtHGYz6M/9YMxyUShJfo0Df1SOMAbU1Q Op0Ij4PlFCC64rovjH38ly0xfRZH37DZs6kP0jOj4QdExdaXcTILKJFIB3wWXWsqLbtJVgjR YhOrPokd6mDA3gAque7481KkpKM4JraOEELg8pF6eRb3KcAwPRekvf/nYVIbOVyT9lXD5mJn IZUY0LwZsFN0YhGhQJ8xronZy0A59faGBMuVnVb3oy2S0fO1y/r53IeUDTF1wCYF+fM5zo14 5L8mE1GsDJ7FNLj5eSDu/qdZIKqzfY0/l0SAUAAt5yYYejKuii4kfTyLDF/j4LyYZD1QzxLC MjQl36IEcmDTMznLf0/JvCHlxTYZsF0OjWWj1ATRMk41/Q+PX07XQlRCRcE13a8neEz3F6we 08oWh2DnC4AXKbP+kuD9ZP6+5+x1H1zEzsFNBFXLn5EBEADn1959INH2cwYJv0tsxf5MUCgh Cj/CA/lc/LMthqQ773gauB9mN+F1rE9cyyXb6jyOGn+GUjMbnq1o121Vm0+neKHUCBtHyseB fDXHA6m4B3mUTWo13nid0e4AM71r0DS8+KYh6zvweLX/LL5kQS9GQeT+QNroXcC1NzWbitts 6TZ+IrPOwT1hfB4WNC+X2n4AzDqp3+ILiVST2DT4VBc11Gz6jijpC/KI5Al8ZDhRwG47LUiu Qmt3yqrmN63V9wzaPhC+xbwIsNZlLUvuRnmBPkTJwwrFRZvwu5GPHNndBjVpAfaSTOfppyKB Tccu2AXJXWAE1Xjh6GOC8mlFjZwLxWFqdPHR1n2aPVgoiTLk34LR/bXO+e0GpzFXT7enwyvF FFyAS0Nk1q/7EChPcbRbhJqEBpRNZemxmg55zC3GLvgLKd5A09MOM2BrMea+l0FUR+PuTenh 2YmnmLRTro6eZ/qYwWkCu8FFIw4pT0OUDMyLgi+GI1aMpVogTZJ70FgV0pUAlpmrzk/bLbRk F3TwgucpyPtcpmQtTkWSgDS50QG9DR/1As3LLLcNkwJBZzBG6PWbvcOyrwMQUF1nl4SSPV0L LH63+BrrHasfJzxKXzqgrW28CTAE2x8qi7e/6M/+XXhrsMYG+uaViM7n2je3qKe7ofum3s4v q7oFCPsOgwARAQABwsF8BBgBCAAmAhsMFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmic2qsF CSZYCKEACgkQTd4Q9wD/g1oq0xAAsAnw/OmsERdtdwRfAMpC74/++2wh9RvVQ0x8xXvoGJwZ rk0Jmck1ABIM//5sWDo7eDHk1uEcc95pbP9XGU6ZgeiQeh06+0vRYILwDk8Q/y06TrTb1n4n 7FRwyskKU1UWnNW86lvWUJuGPABXjrkfL41RJttSJHF3M1C0u2BnM5VnDuPFQKzhRRktBMK4 GkWBvXlsHFhn8Ev0xvPE/G99RAg9ufNAxyq2lSzbUIwrY918KHlziBKwNyLoPn9kgHD3hRBa Yakz87WKUZd17ZnPMZiXriCWZxwPx7zs6cSAqcfcVucmdPiIlyG1K/HIk2LX63T6oO2Libzz 7/0i4+oIpvpK2X6zZ2cu0k2uNcEYm2xAb+xGmqwnPnHX/ac8lJEyzH3lh+pt2slI4VcPNnz+ vzYeBAS1S+VJc1pcJr3l7PRSQ4bv5sObZvezRdqEFB4tUIfSbDdEBCCvvEMBgoisDB8ceYxO cFAM8nBWrEmNU2vvIGJzjJ/NVYYIY0TgOc5bS9wh6jKHL2+chrfDW5neLJjY2x3snF8q7U9G EIbBfNHDlOV8SyhEjtX0DyKxQKioTYPOHcW9gdV5fhSz5tEv+ipqt4kIgWqBgzK8ePtDTqRM qZq457g1/SXSoSQi4jN+gsneqvlTJdzaEu1bJP0iv6ViVf15+qHuY5iojCz8fa0= In-Reply-To: <20260107164842.3289559-9-kevin.brodsky@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CBCA8100009 X-Stat-Signature: fp1bfsmcoizx8swu8ssyam7fw9d4gmt3 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1768821389-249769 X-HE-Meta: U2FsdGVkX18lW9xPqjO95YjSevw4GoxHK0YhWoGhSyOQSQbfgXYWrNZQLmIVbDRJqzeLBkkmcMB9W8xdtxpb5kpUz4xzg8CBwOqsrk/kHwDdaIfkj2iMCCG5TZA17hAdzNB/Mns3lW4QAZusW9qVi9A9XHKA06g6ZND1pr54TrRBveHWKxsMX3JUsqd6mYOZ1onYpOSupvyYlnku3PGEoMMr4Q6rec+ccwV73ppqKDh5fqGBL2eW9Mp+49NorMaRX4pWY6Tb0Qnl3pv+uQWrQoNBBqf4Yafzr9pN/ZEJdthIm9/1pONNJemoCPThRUhC3kP1hVSjo2BN6w7vW2eKT3qkA9oNob0v0+dAcyQPVBlI1duWHejK6MDGK8P8LbswwanxjhqL3cPmQ+AFnfkq7c6mjvLrGeZpZK/V35ZXviv6VCHlTgbYhCi3gX+xAxvEtrZqtqET2Uj+5sR6/jSGFxFOP6BXXp1tbtotHpL+EeUNLovKVIc5CyUs0k/w/HTY3CasdQnIh7iORb8h81yi/U3XVzEobUYV2ALsHrRGPTqWP5GMUQa90cFC1IPMT31TevLOcIopv7oc1xf7IlYLb2yxPLSja1qu/+itiprdM1jrESFwoUt8lRhzA49qNEraFOVBjlOocLUaDmHaB39VBHEK/QA9KZhSF8HehP18XgTlScXKyTsp7KzCmVaFu/I8rFVBj4MRT6p+vT8hs9rNOUPRi/QkGT8030lqacoAm8s1Eo8d/zhDlrWnUZoj0tuc/XzLQ5pWDxvCSfaNeKhGFYeyjKo5EO7tpxuQc/5LLUFSUdjdgswkI8XgVzPUFp1joQUTTCuLmjYB688/coJmPB+g2Il8+TOZzlbYKfMZV0hLgOwaWYB90oW5IHbgmW3nDHv9D4lcBKdpf7ypn9+CtjDZQMYWlYWZmkd58Rs26ObgoJ1niFqijyIfDCC3YWRASpMXFlMQ11lLeEapGiZ hEsJsdaf ViditXZ3cSJScXo1l5Mjp3M/CtSTNUFwuOExkVxDvhx4BGlt/DdBgSy2XtAS0nPAteVBLPi7XctZA2e37MHaHIaiFPllTt7rQhsMXY/FxheVDvsKdzKghdHDnriJTcbQGMyHCuFApidAIfDXTSjsJeBOCXg9WAbnljqZMBcngnzWgHPJVarvZFVOR4NYVeKc+4kd+7yV5jkLrrQrg+rYD6No0cYHL8XZbbBX0wN0Vm5/0eRF8hs/bfhkEYsoEtcvDf/h84BOX5VuKfoutJYv156OF7hAwmDeru+QrfsDAWDQqndKhLUsARIpIgA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/7/26 17:48, Kevin Brodsky wrote: > pfnmap currently checks the target file in FIXTURE_SETUP(pfnmap), > meaning once for every test, and skips the test if any check fails. > > The target file is the same for every test so this is a little > overkill. More importantly, this approach means that the whole suite > will report PASS even if all the tests are skipped because kernel > configuration (e.g. CONFIG_STRICT_DEVMEM=y) prevented /dev/mem from > being mapped, for instance. > > Let's ensure that KSFT_SKIP is returned as exit code if any check > fails by performing the checks in pfnmap_init(), run once. That > function also takes care of finding the offset of the pages to be > mapped and saves it in a global. The file is still mapped/unmapped > for every test, as some of them modify the mapping. > > Signed-off-by: Kevin Brodsky > --- > tools/testing/selftests/mm/pfnmap.c | 81 ++++++++++++++++++++--------- > 1 file changed, 55 insertions(+), 26 deletions(-) > > diff --git a/tools/testing/selftests/mm/pfnmap.c b/tools/testing/selftests/mm/pfnmap.c > index 35b0e3ed54cd..e41d5464130b 100644 > --- a/tools/testing/selftests/mm/pfnmap.c > +++ b/tools/testing/selftests/mm/pfnmap.c > @@ -25,8 +25,11 @@ > #include "kselftest_harness.h" > #include "vm_util.h" > > +#define DEV_MEM_NPAGES 2 > + > static sigjmp_buf sigjmp_buf_env; > static char *file = "/dev/mem"; > +static off_t file_offset; > > static void signal_handler(int sig) > { > @@ -88,7 +91,7 @@ static int find_ram_target(off_t *offset, > break; > > /* We need two pages. */ > - if (end > start + 2 * pagesize) { > + if (end > start + DEV_MEM_NPAGES * pagesize) { > fclose(file); > *offset = start; > return 0; > @@ -97,9 +100,49 @@ static int find_ram_target(off_t *offset, > return -ENOENT; > } > > +static void pfnmap_init(void) > +{ > + size_t pagesize = getpagesize(); > + size_t size = DEV_MEM_NPAGES * pagesize; > + int fd; > + void *addr; > + > + if (strncmp(file, "/dev/mem", strlen("/dev/mem")) == 0) { > + int err = find_ram_target(&file_offset, pagesize); > + > + if (err) > + ksft_exit_skip("Cannot find ram target in '/proc/iomem': %s\n", > + strerror(-err)); > + } else { > + file_offset = 0; > + } > + > + /* > + * Make sure we can open and map the file, and perform some basic > + * checks; skip the whole suite if anything goes wrong. > + * A fresh mapping is then created for every test case by > + * FIXTURE_SETUP(pfnmap). > + */ > + fd = open(file, O_RDONLY); > + if (fd < 0) > + ksft_exit_skip("Cannot open '%s': %s\n", file, strerror(errno)); > + > + addr = mmap(NULL, size, PROT_READ, MAP_SHARED, fd, file_offset); > + if (addr == MAP_FAILED) > + ksft_exit_skip("Cannot mmap '%s': %s\n", file, strerror(errno)); > + > + if (!check_vmflag_pfnmap(addr)) > + ksft_exit_skip("Invalid file: '%s'. Not pfnmap'ed\n", file); > + > + if (test_read_access(addr, size)) > + ksft_exit_skip("Cannot read-access mmap'ed '%s'\n", file); > + > + munmap(addr, size); Why not keep the fd open then and supply that to all tests without the need for them to open/close? Then, also the file cannot change etc. -- Cheers David