From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E4D0C36010 for ; Fri, 4 Apr 2025 16:18:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CD4D6B000A; Fri, 4 Apr 2025 12:18:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17D8C6B000C; Fri, 4 Apr 2025 12:18:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F381F6B0010; Fri, 4 Apr 2025 12:18:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D89D56B000A for ; Fri, 4 Apr 2025 12:18:21 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3581DAB3EF for ; Fri, 4 Apr 2025 16:18:22 +0000 (UTC) X-FDA: 83296868844.13.20B552C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 334C1100005 for ; Fri, 4 Apr 2025 16:18:18 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ftn2lre2; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743783499; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8OejXCrxqbnmVsxgWwxh4xnmNEURfQ/aJ6V7K3P+SnU=; b=PVD861wq6jJGlMAh+4fg5sA4aXaxh6Wm6D8wXq0BOJbHcFJNtelP6LFMj6RQFfqFY2PJbO JxlaQBHhxRUs07cKPqpqdZUgDyZErLcCscCLxmCdJGP7yMbDlfsZbqhxNrNsbYKxV24u2F A0Ho7omoLcgy9aThhowfn0UGR4Wpl7E= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ftn2lre2; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743783499; a=rsa-sha256; cv=none; b=EVBzcjc1Lhwl8uHlM7uTVwEbExY+DMuy07P6+0RySN3uzOf5xUKBPYsrHQr7gBSbOk8JHl hCa16ijh+VmSrSpGGY0Oa2RQdUR23hsdwdqxrJG9m+I25jxlczc4YHJrAswscsvm4wW4r0 /tBw2TxmaTbpJuccQuxwYqtgTUf+0N8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743783497; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8OejXCrxqbnmVsxgWwxh4xnmNEURfQ/aJ6V7K3P+SnU=; b=Ftn2lre2zuWgoG/tM3MP+oq127PlYMBNYcuVHCQwoFqTBp3OqcotN0UzMQ2pk/YYWVykNy IDACu5gOFc0qwLmYTjFNA3pAwUEjD/ImX71/t5e23AGrrafp56y1HUEHReBsuz3WFfSF40 RZfgIxQF4iHj4xwOAaXhUPamkqDfNTU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-500-iof5mOrsOqGeCOj8iNTFfQ-1; Fri, 04 Apr 2025 12:18:16 -0400 X-MC-Unique: iof5mOrsOqGeCOj8iNTFfQ-1 X-Mimecast-MFC-AGG-ID: iof5mOrsOqGeCOj8iNTFfQ_1743783495 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43cf446681cso15937775e9.1 for ; Fri, 04 Apr 2025 09:18:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743783495; x=1744388295; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8OejXCrxqbnmVsxgWwxh4xnmNEURfQ/aJ6V7K3P+SnU=; b=mm4qOTLzG8RcQR31ByX6pCXIwnfLPNqavEmyMMlEj5XbNEIzeFMzsTBQgobvbbfKy5 gJ1O5q+FjeRiejNpnVLt4PmeacxmmD6TGV+cvgOQISV7aawpXuXsHHHgK/QJEMCKMNgj gAxVaJJQlKYVvsYXcNZKGvPwpBTEi8i0QDHgk1huw9nhg/D6ve1iX1PcfZEcYq/J2qjQ 3QmDAGLYI/rtNtfYfOTJASpmSObk/uKg92hWliloIKPfICSmIpffXcjo06HC8JBIG+mK nJe9VQrfJDWcggzya1zFDURfSg8gkZAtotqdv1NtZVJTPFgBy8VpnVbxfpPFdU8js6qq /9lg== X-Forwarded-Encrypted: i=1; AJvYcCWPNGgv3KQw3tYRbmu3mgCqZ2zsidWfN3BpWj656aiSHrjuDrSX9rrpR0sG5L5ms+kwg/np2wvDRw==@kvack.org X-Gm-Message-State: AOJu0YxbpH6jiKzj6TFLIZseC3ZdrN8rptigld5kqyYbzYDH+0B2VuJU tDewZ6hF4veyPCCKCSblIjrpHp2yuTUqKX1aV/o2ZHJ3pzQTgcJfp6pawIko9lXW8gcwSISog4B TAQGQfiHU9bQGv0gHDSpNUsVxDoLEqSrZCyHEGofeIGWZDvi+ X-Gm-Gg: ASbGncv9NtQ4fCa7xOclIunilmxtLahYiFE3ES9nvHTFnDUqC5d8t/xZbe36U0rMSXs vHmP5zS9VtwObffkcpg/awp3mkH6EoeQLHW7UqHlwO04oR3BJ71PoKEyT1ZSfg2NVsnczAukz8x uwPMDNTHlSBE6Na8n9NqS9N0ClYI13AKd8uNyaNkHxp5+eif9qzid3YwHv9AA335Osp/J/mpvLM TNm1j+DJbIcqVWXmM5E8SGvYnQ9RIrCzNxqsz8kZezMtn178G8kVWVzOk2o1YPwaPGVyxhX0MkF Ti6kD08jYiS27uvTOGnWbvr4c8apHudTDBK8+CWNEBoOAmfQreEP1rQVIVNMI5Uc+SUS+0hyjPg zh404J+ikd8YsXD7qZsi8qom5LZuRtI3mwqSEaUsrnC8= X-Received: by 2002:a05:600c:46cb:b0:434:fa55:eb56 with SMTP id 5b1f17b1804b1-43ed0b5e180mr29601085e9.7.1743783494855; Fri, 04 Apr 2025 09:18:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGw50XUZ8b0mACVEGPstaSHFt8lZgrm023WRQpvI196XI6AXldQlXHgmz4W+aCZxXfYzFNIPA== X-Received: by 2002:a05:600c:46cb:b0:434:fa55:eb56 with SMTP id 5b1f17b1804b1-43ed0b5e180mr29600805e9.7.1743783494482; Fri, 04 Apr 2025 09:18:14 -0700 (PDT) Received: from ?IPV6:2003:cb:c71b:7900:8752:fae3:f9c9:a07e? (p200300cbc71b79008752fae3f9c9a07e.dip0.t-ipconnect.de. [2003:cb:c71b:7900:8752:fae3:f9c9:a07e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c30226b17sm4765020f8f.92.2025.04.04.09.18.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Apr 2025 09:18:13 -0700 (PDT) Message-ID: <09c13770-4d62-430a-827d-6ad35411d18c@redhat.com> Date: Fri, 4 Apr 2025 18:18:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] docs: update THP admin guide about non-tmpfs filesystem support To: Luis Chamberlain , "Pankaj Raghav (Samsung)" Cc: Andrew Morton , Jonathan Corbet , linux-kernel@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org, Bagas Sanjaya , da.gomez@kernel.org, gost.dev@samsung.com, linux-doc@vger.kernel.org, Pankaj Raghav References: <20250404140657.29285-1-kernel@pankajraghav.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: P9nLwcPI8SMzuSypIl3Wel4CRsTExtzdkjv_fZE7uQg_1743783495 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 334C1100005 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: ak766ao4cxc1hqtpc53ehhz55fp88dk8 X-HE-Tag: 1743783498-567423 X-HE-Meta: U2FsdGVkX18OxZdYdMXytON29P1u43qTTBbnlscbOd/OXio7Ef12ZYxAy4cLu2gzoOJ4YoRtlbUXZZQHGZ/tFcuan/6WpgGmOGfutEWgDEHtf5iI2NJax5/V8wq8js4SusO+1YbnmDvLKvAQYfrooM7a6lMIdPZzTTKEfQ5pKwiNrpM4bW2tyoWurMMZcMWrIrGeTuktSBdcMl8rPyO4YkQxJSUXPahV8tsAR0PC/zbk3lgq+Bt5x404UkwKuvzvpdQ/6OZQmUQT9nGcG2Bsembm2OuNKAcOb0zPatRGhot2knwNXATVNfk0tKLqSJeGLRC/gztwyEuOtqWwzTbkXWJTFGmaSLYpuyU9WgDcAwXXnFA3JaNrM2W7oU2IXTWaza7mq23jE4ALDMk0jJ0g0O82ycORhCZ5Hcm/jePLEzCHISwhu3dz2YIV6k8YMXi1Dlt8a6xOVl306wwNZhRypJrZd1LlxQyRQYKbT50+5kmY5+GYRL0SXjqcKoj6xOOw+jHRpYAAm6CyakLzM4IBsloM/ycxqSunzlgD1Bxt2s/2xapyOPklZLgN3+QZtMjP3SzJ5bdII5GF1y4U+fAbhfetz5U0SEhWm8zgkW7Ry38nju20pGa9ug2vRgqt7UA4YFmzW0DQq6FFhV/wdFJFuj4fbG/tDfa9+5vVaFeq+7hCT2Y2TIYxSqIHTgUMCkw4EZ/ZnFISWC4KkNRJfAKgzvkmQDmYIOI9cOT9poM0xdYmDdXojtl6IzMGYvmllG8iEN6oG5CAir4OJEbSUTmn6WP5UoIckXerp1RfgaLBVxm0QR+GTc78ZRhslgTF5NLx5vn9h5MIthor/bgUXO6mV3b2JYRxJ7ZkIpDEOgh+4DFA7vjQ6+aNMSAXtZFFrUDNM+KOA9iF5k6E9NvuuIibX6jUKQAx4mcntHs7J/iQhV2GbxOfRJ6CzALyOE3PvqGswMaiWv89fe1+qov8LPE XHLde95p d3RjuTBNt4Q3F2Hf6tPVq8Fy79Txp59tmX6WbfNAKiVTzMF3I2Bgte4aFYSb0E+iwsFol9J2iZFx8gtYaqCOjZyX9cJRXD5HLiOps4USFiK0NF2idEcbAIUw5pMpWSo2UDm6Sm141rcGeSrDJkHmP4ZviiLbBlcDHPg1/si1Y6+OcNfxSma1JUVSgNHE5Bq5ocNb900Mka2YE2DK3JfGjAfr8plIsbyCJd7YjoSZsgO4na6KgD/kPhoUD5mwlgDg1cOcgxvAJV0lAQh7aIJNAnsMd651v93K7Q2fQoAn9U65Dcol/BDQ3scyesI9So/gcq/BoLo7y079MqUQvArpXGraN7hlX3E5Qk9erhCzb7uQsAMLudT7MktoKk9ff2uWpf5accjQm2zolJjQEBpfVYv1RdGpfSrxRLFgdt8RoQjofz4qTiIWJyFDoCNiQG0jM7QKIeAGtbJ830cQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.04.25 17:32, Luis Chamberlain wrote: > On Fri, Apr 04, 2025 at 04:06:57PM +0200, Pankaj Raghav (Samsung) wrote: >> From: Pankaj Raghav >> >> THP support for non-tmpfs filesystem has been around for some time now. >> Update the admin guide to reflect it. >> >> While we are at it, move FilePmdMapped to previous paragraph for clarity, >> and clarify ShmemPmdMapped & ShmemHugePage. >> >> Signed-off-by: Pankaj Raghav >> Acked-by: David Hildenbrand >> --- >> >> Changes since v2: >> - Address comment from Bagas Sanjaya >> - Squash commits and Ack from David >> >> Documentation/admin-guide/mm/transhuge.rst | 22 +++++++++++++++------- >> 1 file changed, 15 insertions(+), 7 deletions(-) >> >> diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst >> index dff8d5985f0f..f8aae64e38d0 100644 >> --- a/Documentation/admin-guide/mm/transhuge.rst >> +++ b/Documentation/admin-guide/mm/transhuge.rst >> @@ -12,8 +12,8 @@ using huge pages for the backing of virtual memory with huge pages >> that supports the automatic promotion and demotion of page sizes and >> without the shortcomings of hugetlbfs. >> >> -Currently THP only works for anonymous memory mappings and tmpfs/shmem. >> -But in the future it can expand to other filesystems. >> +Currently, THP only works for anonymous memory mappings, tmpfs/shmem and >> +filesystems that support large folios. > > That seems to allude that THP can be supported on filesystems > that suppor large folios. I don't think we want to call that THP > and that can confuse folks. Leaving "currently" also seems to > indicate that there is more work to be done for THP for filesystems > but that's not true as well. So how about something like: > > THP only works for anonymous memory mappings, and the tmpfs/shmem is the only > filesystem to support it. The alternative to THP for other filesystems is to > support large folios and with it you can end up using huge pages That makes things more complicated without a good reason. See CONFIG_READ_ONLY_THP_FOR_FS as an early usage of the term "THP" for stuff we have in the pagecache. (with large folios we now properly implement this concept, and support more than only PMD size) -- Cheers, David / dhildenb