From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D9AFC25B06 for ; Fri, 5 Aug 2022 00:18:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E9398E0002; Thu, 4 Aug 2022 20:18:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 072C08E0001; Thu, 4 Aug 2022 20:18:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDE3F8E0002; Thu, 4 Aug 2022 20:18:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C988E8E0001 for ; Thu, 4 Aug 2022 20:18:47 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A23F8A0435 for ; Fri, 5 Aug 2022 00:18:47 +0000 (UTC) X-FDA: 79763628294.27.DE89971 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf18.hostedemail.com (Postfix) with ESMTP id BDC961C005F for ; Fri, 5 Aug 2022 00:18:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659658726; x=1691194726; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=shCJfa4n9hrilEWgmtxe/f86ypY23Dti2XJvuhdTgAE=; b=LcVtq61tkcbn7vSSe2dggB5tD4QLEeUwe41oGFR2v73tdesXFT0DyJSy n2dCiJJ1Uwh0cbWlL66geTsx14XbTZIIboib5/4ggEWPAjxDNhifGQXXg QEejYMcEGYqWAjjrJ8AJ8Tkan2AnEbOs9PbZoU4sgbrr//+lLI+oWFsz6 LXogeveiJ/yusA/TrZik09woAcksYq9oePT5CAvY/jOXBh3K4Lh64r7gF RB/iMOxojcd3o1j6oA1wRYdG9R4yYsZlzfXpYGc2O2Zz+w2p3bhvO8Ic2 W+bF6l5JAK6SYN48yqTnEVLOBXYpJbSWfEkTUHwkeybO2+xZSX4MwfsZV w==; X-IronPort-AV: E=McAfee;i="6400,9594,10429"; a="287647410" X-IronPort-AV: E=Sophos;i="5.93,216,1654585200"; d="scan'208";a="287647410" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2022 17:18:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,216,1654585200"; d="scan'208";a="553922394" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga003.jf.intel.com with ESMTP; 04 Aug 2022 17:18:44 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 4 Aug 2022 17:18:43 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 4 Aug 2022 17:18:42 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Thu, 4 Aug 2022 17:18:42 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.109) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Thu, 4 Aug 2022 17:18:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ThW9qITPCby7ZhYDZ/0hRZmkBfMnWrs6F7PSNh84uNNPZ8winq8/+Xwi3MhwkgESm+WUpRgdSRmqJQY+BKxPXNR0kP+k2oOIMjFp2U6a6/uBU987QFi07vpyySQeEr2/6Ow+/eJ+nQdeTW9/+FcKb1tSrYuqKrdsEmZIBu0ys0y6EuLaiq3Ex6Q2OFwZLcUfyLXofo85no0In3av2tPFFtos9w2K+ljkIug/mRAEKyJHBcx5/E2Ffc8ED4eZWc9j4P+0cVf/iBvQ9naezClJicXRul2goVse77PKkKZnraQSbH1kGgptg9Be73ZFjXe38zNmSnVaBKuc76J130d2Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NDM8e+ssT2PlCRaC/EcUaHuKogr5C7LCAJ9Ra4zrl98=; b=NTlFRPn0FMmxrqDw3WTMj9ebBH7fTsIFTCfmpEzi1BdVbN+7JkRf1koAhxA7cutfpTEXDax0uw7du2lkvQZrBwTBVqmD/Q+izQTwsnZ6Nxj629TieEjFOk29gtVjW8Igrj68LwDM2hPNILDIqD1htzJrC7m8x8ttOWn8q9sFjPZgl0awzkzUAvpWA/rszDoe2TPOlM5j0SmhBpHvc0v2yb5QYShKRrafImpadM0LxzsZhPNMyy8wCsUCrUznzihZZz9WnuM0a188NX5Sc62WWjXkpBWCfKIAR94Sd2CU71FtaBogwYI6FI8AN5uW+ZK9vn2PqvKazT4SkufIY7PhEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by DM6PR11MB3163.namprd11.prod.outlook.com (2603:10b6:5:c::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.12; Fri, 5 Aug 2022 00:18:38 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::552f:2392:56f8:ca32]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::552f:2392:56f8:ca32%3]) with mapi id 15.20.5504.014; Fri, 5 Aug 2022 00:18:38 +0000 Message-ID: <09c0d96c-932d-3ce4-95a8-b8c87a6fd3b2@intel.com> Date: Fri, 5 Aug 2022 08:18:26 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] mm/memory-failure: release private data before split THP Content-Language: en-US To: Yang Shi CC: , , , , , , References: <20220804025121.4001361-1-fengwei.yin@intel.com> From: Yin Fengwei In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR06CA0197.apcprd06.prod.outlook.com (2603:1096:4:1::29) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 98b3938d-c087-48f7-26b8-08da76780b16 X-MS-TrafficTypeDiagnostic: DM6PR11MB3163:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: el+84vfjt8AlEOBoo46d4QfcRebM3cHxMD0Zn3uKegskqcHAmZYM3gefkcUms0frZMrU3w1/8YCY/aJGsaya3Axb/oJEfAo7zGn5EKxUFQKw5gIGidvT0DvXOK5yuPI1AgzGiLScnbUU9i0j4OJwL+OKhAmsQ7CuPgKjDfZLeanA9KSARvC/I30qLlcHUbUQYaDPEk+6xBl5gsjBanLLaipYHUBCRdpZs45HSP6RAviWxjuhUGLBRPCyjBOUBHukKYlLRSOFcquXJefr6rIzWsqSEsnHYaHpiziBwLwhnS/+4U2VW83tV2Y8Bf68FMZfhgy8GVr5q9AQ3dOn3ZvRmwvOv1FRxSqpq/cn/H4TBmmkRUU2yoD20u1Hvs9IpbBvwCX22xUcs9t0WTQt+nCQC1+pIkAaV9a6lG11CV2T9Rv/XYk3ybhSogdD9uMY39UBVWaIQT9g7n+yR1aHSR0qBPe5KGa2Xe8x30IAtyPOiof/wupJokTMpoKD8KOrv+dEdGeAK4PtvgJvi9eWuIT4EiziZ/fQp6IAeG/fry0E5nJ9BJFg1KAT+i3UGUdaeirF/QRvY7i1MqHPYacCwaF8Kf5wONScPh8s1MhLg99pGzjmq8XPqf43UfGHg4qRvO6d21dwv4/z05jM8OGWgQH3hNjDcUhQR4+gsGLcxZ+5WMa7I+CL7y2HE50J1yWIFSe5yLJHP0Wsyj2ZrbHnLu5zAe4fcsWymLEDwiTOZP0VQ82J0rB7+6SwrWlEYFoh79xqVluYGwE8DFp4BtP5YAzEAzLDKW9Hn9JHOHLqCwabVT8I0iPxRzyFQ+NcW7kJVIGta1yG13rAqdvCVyxJO88VkQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(39860400002)(366004)(136003)(376002)(346002)(6486002)(316002)(66946007)(82960400001)(5660300002)(6916009)(36756003)(8676002)(4326008)(66556008)(2616005)(66476007)(107886003)(8936002)(31696002)(478600001)(83380400001)(86362001)(2906002)(38100700002)(186003)(53546011)(6666004)(6506007)(26005)(6512007)(41300700001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGdjdTRxVHZ5WFpaQXZEVXM0TVNaYTVJUGp2cDl0ZUY3MXRGL3hjTUJmWXZB?= =?utf-8?B?T085SjV3Q01iTmNiMWtLL1NrYlJxOXR0V2hTOHBKdXJvWm5od051SEJPYlJi?= =?utf-8?B?c05XVGpBNWZ5RkE5azVvQUhTS2EwRnlEeHNyZ0NRRzJBdUpoOU15NytUMm5H?= =?utf-8?B?eWxZSjNFWUZmaVR1dkRJSERCc2Y4RHJJOFdid2dRRDdZbG9vZi9rRUt4bDNa?= =?utf-8?B?eDdtNmVaVlYzQ1VkWVhPMXQxcTJBQVVDWDVQK1psaDgzNENoVFVET1hNSlg1?= =?utf-8?B?YWFPa1NydFVlbi8wNS81ZG9yM2c5Tk5hOHhNQnljTm1NZ0JZeE9hYVZYT1dP?= =?utf-8?B?MG9PUFZqK3FZT3k2Y3I3a2JveWFkWmZSeUhmVTFJdzgyamxYam1SQVI2ZVMr?= =?utf-8?B?RC9TWGJtNGppc2lVNjQreDRPdDBad0VNZUdjZEUyZXhOV3BQenRIRloyYUN1?= =?utf-8?B?WmZ6NWkzbGYxM1JWaG85d2FSVVFGTkM2VHE5WWNMdHorYWtKM3h3bndOQWUr?= =?utf-8?B?bmZ1VjcxTGl4MUxFVkphNUN0ZExzNXdzNUt0TnVwVE4xRWpsVU1WOGFBNE1O?= =?utf-8?B?WENsMG5JUWd1WlZlZEFHdE4wNTJPelNrL05KNEZjejRPOXpLdVhWQjdCUmRy?= =?utf-8?B?M20xQnAzY1B6a2RUTnk0RzZNaEUyVjhGclBaTndjUkkyQjludWV4MTdyTmU3?= =?utf-8?B?bXVyS0J6RlJGUnZlQlAxQStnanArU0JPc29kZ1A1aXRKUTRabFI3UU9zdy84?= =?utf-8?B?ZXl2aS9BRVpHb2dKeEJuc05Jczd2elh1NTdzbHZwZUJzN3A1N2o4VEllcTlI?= =?utf-8?B?WmpQcVcvaU5rYUU4NEx4czdIdjBsb21Cb1FOZHdEcmx3SXliVWx0UVJTWnVi?= =?utf-8?B?cDIrNE9Lakp1S3k3ZVFXQnlZeUl1eEJRMSsxVDhHSkJvNDhnYkkxMVFLcGpj?= =?utf-8?B?dHM5ZlYzV1VjRkhDMGtreU9tRjFsZ0d1dk1aMVozUHhFa0NtT2FjL1IxUW1n?= =?utf-8?B?WktJdzlDTHAxM2ZjMmlacGZ1V2QzQXhDd1FYeFNoVGFvMzZVNm0vZnRLZm5S?= =?utf-8?B?T1ZsRnlydEVpRG45cFZYNW9GRTNDNkdMeUp1UURqKzlLZEhOR3JGUG1RSTFE?= =?utf-8?B?d0lQVzJOeDVveUowRENaWTN2NFpDUE9oU0tlU1FBTDhkU0FBR0drY2tGaXph?= =?utf-8?B?WlQ2NVozVG1KbUZDSnFtU1daZ3FhSDdLSVlVR2JvTHp0b0lzK3dBVERCbm0y?= =?utf-8?B?QUg3bFBWcGFPOGJwMWR0cndQS1lCcGtCcnRvNTNqTTdaMEVWZDVETEdyQno1?= =?utf-8?B?dDBFTUFJc3VPTFZraXpucG02TFJoL0dVRk4wUGhBK0lXRm1UUVBZU096d0JG?= =?utf-8?B?STN3ZFhnUFNJb1lsYzdyRStFeVBmc2xrdVhCa0J1VlFacUZtMlREV3F5MjR6?= =?utf-8?B?M2loamR0YlRHTFI1QVJmVElUM3ZqMkxPYmVNSHF4SDVzOEFJdXY1NWcwcjl6?= =?utf-8?B?TFAzRk1OMlZxNDZZQVVDcjJVZzVaZGM2dk5zOVlmRDNrTkl3bWVoQlpWajFu?= =?utf-8?B?anJhNG1OaU56dnUyYzNZUHo5ZmdROFpGUm1HbytsYXYvd3UwOHluS0RaOXVZ?= =?utf-8?B?NjdOdFBvazRBQ0pFd0wyQ0V4YTF6YVBTdEdGTXRJSUNZNjYvZkxPL09TSDY1?= =?utf-8?B?bGIrdUxZVDVROU5EYXBSVlI2ellwN0NrRFIvOXUvbGhqUHVyc2l6d240TDdS?= =?utf-8?B?cmFEL3RreGJQVUdtMkd1bHVSRTF4ZVpEdXI3dHhsZnl5TmRSaXFBQTA2cVNj?= =?utf-8?B?S0RzL29jSXZrK3B0QzJHaEIrQWg1TTJaZFZTT2FBTDd1Y2JrNzJTUzF5NHRz?= =?utf-8?B?d2VweVBxVi9hSVR6d2htL1dlQ0VnR0J4NWt3TXFpZ0dybVU1WThWeTF4alEx?= =?utf-8?B?VVZOajUvRDRPMitjNFZIbFh1bFNJb0FuTTFIWXovaG04QXVnTGgzclB6c1dS?= =?utf-8?B?NzRUaE9PTVhacUZRb0tnVitLUVV3K2sxMDBMSjBNKytaYjBHVXBRMGV5YzlU?= =?utf-8?B?N3JzOHlxZERtd3FhVEpxVDJTdjVyang4K3hYUmNORWQ5eXcwMTJLSFNOQ2Mv?= =?utf-8?Q?lb9swn4eiuKjNhACIZJxbacBN?= X-MS-Exchange-CrossTenant-Network-Message-Id: 98b3938d-c087-48f7-26b8-08da76780b16 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2022 00:18:38.1437 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DLHw/YqAZEOKbLTQzb4mggdyQ6b9/W4LWyvR5UkTKF9xPGI1cyG9IDN+3i/9MNDjRwUBNuogchXt23Wdqdd0OA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3163 X-OriginatorOrg: intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1659658727; a=rsa-sha256; cv=fail; b=4g3vXTjbD9Mf3vT3pDdLhe6xlAhg61iC4AyaY9h/+a+aePURxwB3m4HwQNgsrspZlB/S9z jaxG/5OBLFw0xKNjJkNWN0TobmNWLTlh4fN9517lz6gP763ueFMcS0FrGz2ZSR5WBMq+67 usi9OSLtouqXL0j0mnoOaAARMmJW4wg= ARC-Authentication-Results: i=2; imf18.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=LcVtq61t; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf18.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659658727; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NDM8e+ssT2PlCRaC/EcUaHuKogr5C7LCAJ9Ra4zrl98=; b=EnqjmB2kuozNvlDEehHYH3O7fa8vcL9HCOYXXksNtaMxOri2fLw9s8mRGFKrgDQ+cXvWDN HqiAhF+aenjI3I9eUTorsGz5n5+E2wZ6UjdbDQTYf4uFVYtEVCZAE4xJP7Ez4HBWu+9vlS pJdreWZN1DVnPurz0lbw+AP896XjHLk= X-Stat-Signature: aghmwtaaok1stu7r6kkaz6oqtxsss8ia X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BDC961C005F Authentication-Results: imf18.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=LcVtq61t; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf18.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com X-Rspam-User: X-HE-Tag: 1659658726-403922 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/8/5 01:39, Yang Shi wrote: > On Wed, Aug 3, 2022 at 7:52 PM Yin Fengwei wrote: >> >> If there is private data attached to THP, the refcount of >> THP will be increased and block the THP split. Which could >> further cause the meomry failure not recovered. >> >> Release private data attached to THP before split it to >> increase the chance of splitting THP successfully. >> >> The issue was hit during HW error injection testing with >> 5.18 kernel + xfs as rootfs, test got killed and system >> reboot was required to re-run the test. >> >> The issue was tracked down to THP split failure caused the >> memory failure not being handled. The page dump showed: >> >> [ 1785.433075] page:0000000025f9530b refcount:18 mapcount:0 mapping:000000008162eea7 index:0xa10 pfn:0x2f0200 >> [ 1785.443954] head:0000000025f9530b order:4 compound_mapcount:0 compound_pincount:0 >> [ 1785.452408] memcg:ff4247f2d28e9000 >> [ 1785.456304] aops:xfs_address_space_operations ino:8555182 dentry name:"baseos-filenames.solvx" >> [ 1785.466612] flags: 0x1000000000012036(referenced|uptodate|lru|active|private|head|node=0|zone=2) >> [ 1785.476514] raw: 1000000000012036 ffb9460f8bc07c08 ffb9460f8bc08408 ff4247f22e6299f8 >> [ 1785.485268] raw: 0000000000000a10 ff4247f194ade900 00000012ffffffff ff4247f2d28e9000 >> >> It was like the error was injected to a large folio for xfs with >> private data attached. >> >> With private data released before split THP, the test case >> could be run successfully many times without reboot system. > > Yes, now we have more file large pages/THP than before. The patch > itself looks good to me. But I'm wondering whether it is better to > release buffer in split_huge_page() itself since other callsites may > experience the same issue. Before only anonymous and shmem THP were > supported so we don't have to worry about the extra pin from buffers, > but it may be time to consider it now. Agree. I will send new patch with the private data release moved to split_huge_page_to_list() if no further comment. Regards Yin, Fengwei > >> >> Co-developed-by: Qiuxu Zhuo >> Signed-off-by: Qiuxu Zhuo >> Signed-off-by: Yin Fengwei >> Suggested-by: Matthew Wilcox >> Reviewed-by: Aaron Lu >> --- >> Changelog from RFC: >> - Use new folio API per Mathhew Wilcox's suggestion >> - Add one line comment before re-get folio of page per >> Miaohe's comment >> - Remove RFC tag >> - Add Co-developed-by of Qiuxu who did a lot of debugging >> work to locate where the real issue is >> >> mm/memory-failure.c | 16 ++++++++++++---- >> 1 file changed, 12 insertions(+), 4 deletions(-) >> >> diff --git a/mm/memory-failure.c b/mm/memory-failure.c >> index b864c2eff641..ef87741b0fea 100644 >> --- a/mm/memory-failure.c >> +++ b/mm/memory-failure.c >> @@ -1484,16 +1484,24 @@ static int identify_page_state(unsigned long pfn, struct page *p, >> >> static int try_to_split_thp_page(struct page *page, const char *msg) >> { >> - lock_page(page); >> + struct folio *folio = page_folio(page); >> + >> + folio_lock(folio); >> + if (folio_test_private(folio)) >> + filemap_release_folio(folio, GFP_KERNEL); >> + >> if (unlikely(split_huge_page(page))) { >> unsigned long pfn = page_to_pfn(page); >> >> - unlock_page(page); >> + folio_unlock(folio); >> pr_info("%s: %#lx: thp split failed\n", msg, pfn); >> - put_page(page); >> + folio_put(folio); >> return -EBUSY; >> } >> - unlock_page(page); >> + >> + /* If split_huge_page success, folio could be different */ >> + folio = page_folio(page); >> + folio_unlock(folio); >> >> return 0; >> } >> >> base-commit: f86d1fbbe7858884d6754534a0afbb74fc30bc26 >> -- >> 2.25.1 >> >>