From: Mike Kravetz <mike.kravetz@oracle.com>
To: Muchun Song <songmuchun@bytedance.com>,
akpm@linux-foundation.org, david@redhat.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, smuchun@bytedance.com
Subject: Re: [PATCH 1/3] mm: hugetlb_vmemmap: cleanup hugetlb_vmemmap related functions
Date: Tue, 31 May 2022 16:58:23 -0700 [thread overview]
Message-ID: <09b60548-0495-5365-2bf7-97cc597100ac@oracle.com> (raw)
In-Reply-To: <ec5eefa2-03f7-5f2e-bd99-24c3ab76a0b4@oracle.com>
On 5/31/22 16:47, Mike Kravetz wrote:
> On 4/4/22 00:46, Muchun Song wrote:
>> The word of "free" is not expressive enough to express the feature of optimizing
>> vmemmap pages associated with each HugeTLB, rename this keywork to "optimeze".
>> And some function names are prefixed with "huge_page" instead of "hugetlb", it is
>> easily to be confused with THP. In this patch , cheanup related functions to make
>> code more clear and expressive.
>
> Some typos in the commit message. Might be better as:
>
> The keyword "free" is not expressive enough to describe the feature of optimizing vmemmap pages associated with each HugeTLB page. Rename the
> keyword to "optimize".
>
> Some function names are prefixed with "huge_page" instead of "hugetlb". These can easily be confused with THP. Change function names to make
> code more clear and expressive.
>
Sorry for the long lines :(
--
Mike Kravetz
next prev parent reply other threads:[~2022-05-31 23:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 7:46 [PATCH 0/3] cleanup hugetlb_vmemmap Muchun Song
2022-04-04 7:46 ` [PATCH 1/3] mm: hugetlb_vmemmap: cleanup hugetlb_vmemmap related functions Muchun Song
2022-05-31 23:47 ` Mike Kravetz
2022-05-31 23:58 ` Mike Kravetz [this message]
2022-06-01 9:28 ` David Hildenbrand
2022-06-01 10:48 ` Muchun Song
2022-06-01 10:49 ` David Hildenbrand
2022-04-04 7:46 ` [PATCH 2/3] mm: hugetlb_vmemmap: cleanup hugetlb_free_vmemmap_enabled* Muchun Song
2022-06-01 0:01 ` Mike Kravetz
2022-06-01 9:29 ` David Hildenbrand
2022-04-04 7:46 ` [PATCH 3/3] mm: hugetlb_vmemmap: cleanup CONFIG_HUGETLB_PAGE_FREE_VMEMMAP* Muchun Song
2022-05-27 7:39 ` Vlastimil Babka
2022-05-27 7:47 ` Muchun Song
2022-06-01 0:20 ` Mike Kravetz
2022-06-01 9:32 ` David Hildenbrand
2022-06-01 9:54 ` Muchun Song
2022-06-01 10:10 ` David Hildenbrand
2022-06-01 11:56 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09b60548-0495-5365-2bf7-97cc597100ac@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=smuchun@bytedance.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox