From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 813C1C48BF6 for ; Wed, 21 Feb 2024 06:28:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EFDD76B0085; Wed, 21 Feb 2024 01:28:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EADBB6B0087; Wed, 21 Feb 2024 01:28:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D75A16B0088; Wed, 21 Feb 2024 01:28:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C86196B0085 for ; Wed, 21 Feb 2024 01:28:34 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9751F4090D for ; Wed, 21 Feb 2024 06:28:34 +0000 (UTC) X-FDA: 81814832148.28.E93D3B2 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf09.hostedemail.com (Postfix) with ESMTP id C7C8A14000A for ; Wed, 21 Feb 2024 06:28:32 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=mb7s4AcY; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf09.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.218.48 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708496912; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CcPstB2bYO4HD/z5bA6bWdOkdEkTV183NUIU2ddVXl8=; b=AceRt1Vb8b7fzu9JZ+NeKdoksm1MMk8RNsyP7uOuxVlM1j8HaJf/jy9kBlnqtZVqWSn0tp fuRZVcKOQDob7MS0Eo9llPIil1bLpuWzHjKyJQCO1HDoTDeNNWrrn2wkkqbwdSM2ry3v82 fAdzce88F1qay66YOZaKxRAnA18SYB0= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=mb7s4AcY; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf09.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.218.48 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708496912; a=rsa-sha256; cv=none; b=jceaP88YRAPPbS4bneVYddQlhaXhgPjkfHERBBz3exd+Nb1Wpz1T8m7XGCbIoTXhLE08nZ FXYLsFI9yaDjcoSffQe/o+3Gnzeb9Op+tAf6XC/crq1iTiKfoijpTbkpDbP4TvhEGAKNqU PK745XU2+zqlq4cOm9+AIEPLKLGuxjQ= Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a3e75e30d36so555479066b.1 for ; Tue, 20 Feb 2024 22:28:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708496911; x=1709101711; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CcPstB2bYO4HD/z5bA6bWdOkdEkTV183NUIU2ddVXl8=; b=mb7s4AcYgJ119ITiojYbPSCRfqw6TdZn7x4bTUio3xx2g3nnoYx0Exs2ulgmmJEkoG rgkXaNQQ9GwEkbsvBjCgodHK46pxtoXVgq1pfVrSgOXuD1s8YreewxUL7OFecJ83FAIS z0KtN0edKYzBl9VWgmi7jdlDamgGGCIXBggnSBqp7whkJAfJY/6gqFUwag0p1kkU5zz3 XAy9SnchH0IlKIDYxTT6JUfqStGf13DPbYsID8RGYkRasF3271y3ZjfYdPkdhU+X9vqX k4eZN/16+AtYIQT0QkKXiJy49lkVSHUlgLNUyND/GlQlUNKG2FEfxRg3ypgHnHQFa5dt od2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708496911; x=1709101711; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CcPstB2bYO4HD/z5bA6bWdOkdEkTV183NUIU2ddVXl8=; b=hDZ1/5xehszYmSYBhhcJHUN88xmYNR20lY1Fv/kmjviTQB2sONRFj4otRHuhWuhDKY RDoNbSKEuoVgxGgkZ47HNVW7QFsSHMermfxVvFQ1D1MYMlTlubZteGoyZU8+XS08lBBL pvD6jadhRyiNTyWg5xduQWqE5OBv9DI8o2w4G4DnbXdmmPbp/pqqLzuMImlgCOPONZ0v InFjSSDQANjTdp1GGg98i5vYMOEFkkEwfpIMO6n1WBFD/GAMtA75aED/6S/KiZOAijIu kEvWMhYR800F5H5Am6z+5g14tmVMbb7NUb4R9MWMRN7unC35TMYkj0MyYqSYE730gHZ+ uyrw== X-Forwarded-Encrypted: i=1; AJvYcCVPqAEUnNfQgW1DV4bAqVSvFJHTtvs3shF9fuYKAQR30ph/4W9QOH8L7jRU+9SjZKaJJ8jfWVtCyT8Y7isIE6yHNYU= X-Gm-Message-State: AOJu0YyA5BKxxMLwpP8aL5In0nyC6KTpK15qv2LEusoDm57TUAucWLoj X1PTQQL2C6dwP8OWWr03qjzW8nPVDzX47kk3e1nvzrgLzbRbFJPw6w8v2agzkmU= X-Google-Smtp-Source: AGHT+IHpriMxroIGBhzF108/XlOwjGc2BsiHpH3gAeVQM0JFaftGLnX8WFuMK3Yp3VE7RBr+jZd/6Q== X-Received: by 2002:a17:906:4558:b0:a3f:c32:7b0c with SMTP id s24-20020a170906455800b00a3f0c327b0cmr3887561ejq.22.1708496911341; Tue, 20 Feb 2024 22:28:31 -0800 (PST) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id tj9-20020a170907c24900b00a3ca56e9bcfsm4652264ejc.187.2024.02.20.22.28.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 22:28:31 -0800 (PST) Date: Wed, 21 Feb 2024 09:28:27 +0300 From: Dan Carpenter To: Matthew Wilcox Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mm: use ERR_CAST() as a cleanup Message-ID: <09aadb26-88cf-4f3e-bebb-dcbc1fdadeeb@moroto.mountain> References: <5a64b69a-40a6-4add-b758-ec3a9d93eb11@moroto.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C7C8A14000A X-Stat-Signature: hhu4i54zisazfw7cza9mti1uth31it7k X-HE-Tag: 1708496912-223222 X-HE-Meta: U2FsdGVkX19pYL8G6LRJ4HbgT1Rvvcqo6Er8caUoZI54IGTRzVG98G89JP8BBE7KsGl+SqwZuhMNxNRMS9IERjSYvIXclb8Oa/tv+nLfPlUiq3yesvvjJT3Z+1ElIsSiCHe2xZ7qtHXthZA+ND1W2ZUztOQu9ABG2phYmEUs4V8lv5DuufY3GiPmpIeFiRyJFeFJNELzhFYNBCUHdWtUsBywiEnlQgMZuH4bjVXDYqK0dFM8lo78+EloCvyOyaaCMQO3N8Pwt/oVUhnnEi8aE/TK6Fxc1+mXLbaM0rp2waHxu1CUQE8YOS4elJOVCaBAdS/OVJYkEvpEjvWM9iV1d8kH71TMjgku6tSoRZNw+w/L4wATH7x+4iF8SBpgC190C+LTJa8fP9nmL/S4J8mP2+FB+Sy68FuZj9Fu3ejXBzK15toelBXdCchSwvH1E7WMMP1BShwPE4pttggO54YUFDlfAkWNQZo3WDlJEQRaf5CRJlbayosP773BHpdd2EVmuNh+mFePPdeKHzxsrZZIx77d6/6bS59Vr2XsS9UDQAq2cRYPAbNck2s50/WkGecDzi/Wf2LBAZ262g3I3yimCXwW8YhN3rbqnsGNA94ehMxkjeoNOYwKTDjDs8rVzMHu/Upj4vfAT0ErmDYU3t8NnFS95p0SCVFAMt8HeDRE9X9Z2nbJgjZ02GL66W7bnMpWdxr3dC9kSxu8Sar05qHMmki/IOwgYyUmGJmk63tpRyUBCG8gadSEuqEYI5lppnbCkm8j8tBZHfwWqpdU9rsfs1BWJdVtHhgrXyIMxs2YttJQZ1SwT8nAfdI9o3zs/0v9qRhPDPrwEBOaRpjfhYMGmCWFKsZbXCjyvo9I+EzqfWCL8IIMAWiHKwuvBuCdsOv2Og2pkWXXMI2C2oC2bKc8/NHnhGoO5QgUd8bGxx+USz3prTlIkW3aEXCQgD54LSZNfm3JM9Da/zYGw2jk/Wp ziHl4+si 2YLbpWcfnETvW3xEPKYWZVW/HkYrJcQuydjE3E+mBzyna4GWz43bcR3zZPuSoKbW8AKZ7LdCPYLT52ok= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000012, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 21, 2024 at 06:23:06AM +0000, Matthew Wilcox wrote: > On Wed, Feb 21, 2024 at 09:22:13AM +0300, Dan Carpenter wrote: > > The ->page is the first and only member of the folio struct so this code > > works fine. However, if we use ERR_CAST() then it's clearer that > > this is an error pointer. > > NAK. &folio->page is an indicator that this code is in need of cleanup. > I use it in my scripts. Ah. Fair enough. regards, dan carpenter