From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4B62C0218A for ; Tue, 28 Jan 2025 10:31:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 558C5280228; Tue, 28 Jan 2025 05:31:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 50828280226; Tue, 28 Jan 2025 05:31:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 381DC280228; Tue, 28 Jan 2025 05:31:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1A71C280226 for ; Tue, 28 Jan 2025 05:31:43 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 263551A100A for ; Tue, 28 Jan 2025 10:31:42 +0000 (UTC) X-FDA: 83056494444.17.3980B15 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by imf14.hostedemail.com (Postfix) with ESMTP id F4178100015 for ; Tue, 28 Jan 2025 10:31:39 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=Ky+yAWm6; spf=pass (imf14.hostedemail.com: domain of petr.pavlu@suse.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=petr.pavlu@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738060300; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2XyAQrOTcI19ilumWSMw1hLrZQh31wPEOX9kHRV/Kjk=; b=jdPhLUb80NS7LXSFGyTEG9+ICP45EeojSRxgujehtrpFMzuOGa82RFDMUg8Dn2s2mSCzXB VtF6KOWJPTLEodC2V5RRPrHYE1d3xPfyjCp+hCR1M9PSaj7j11i5KqKpUZKhGRpPKRLgBS p43rG/y0Lii1cUjo9s4H9E+DRbsdvtQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738060300; a=rsa-sha256; cv=none; b=1JIKVi1wBjHkkzclAJ4d9/kUbbnn4D6bE6WXM1am0cdeWFbvkZIZn65/cFyPG74dNLl8kw 7C9ogowNSYjGYpZliDYKE0Z+ZF121wNYrRc1fnw4Es1rSJwvM0ZH93JIIyFjvMt0jKYhzO tjI2IntcYjmQEQWk/kGAQleGzkAb8N4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=Ky+yAWm6; spf=pass (imf14.hostedemail.com: domain of petr.pavlu@suse.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=petr.pavlu@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-385ddcfc97bso4623452f8f.1 for ; Tue, 28 Jan 2025 02:31:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1738060298; x=1738665098; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2XyAQrOTcI19ilumWSMw1hLrZQh31wPEOX9kHRV/Kjk=; b=Ky+yAWm68vnsB1aRBUeeIIH0fwUeCBz5sM92c2+ozytZ+H0mfw+Mjh6ZymGLErm1N+ CkJhZatNgtKNF0mNqYQQrku2Yicgd3yoPu+7gK1FaHXURpCF35L6oqp5thrDWudgaXjw xVkQdHKlBMXupY4ECEuLqWZg6YppL2Xcqkpu13vh+cFoR1GB0nAq1FvMDlOVlw9jdODk CEGmr98vsH+grQwRwMHM2llJ1z7zgmSJveIlqpZwBW7wCeDHP6UV3K38xeFaUBaT5dm3 m6lrsm0NKsTKgtkjX4/wdjZG/iPaeMmX4ltt+6x490iM+aXGxwCmLGEfdaFfstUJiQdL 07Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738060298; x=1738665098; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2XyAQrOTcI19ilumWSMw1hLrZQh31wPEOX9kHRV/Kjk=; b=Z5M1Rn7PXgtAxHf+1Rr8auBAqF9Wu7H8pY+c4IsdhAn7OcTYlTzLZUQ1xHiorIGroq SxAGK1QCzCI0V6DmZsp3GbpHEzAJ5Y7Gp8bcPlhIlyQwtE1dLRFqljce0HNeuoKawLcz iJSC1cugafiWyk5hF0qUEbEKYXzr5bqRaw0+bot7qXhk/UwRE+zcJVo1cR7CBbxzrBOw Rp2SNmO9XCvr4GiGwFzaulMgmAnSLzr2Q+0ttlbboSWbeFH6N79hqz16B61sca91InIe 3bt5UiN0aGHjbUQMBOs4sCZvzsdWHKasNzgZ53aGw3TLIiglc9lzdaj3cIZNAqcdW2d/ odkw== X-Forwarded-Encrypted: i=1; AJvYcCWk13J1WJ9D6ydklnH77/OvveNjmN1m8Frgs//K+ycVJczTrg43eocZDFsZyRBWqtLAyzdVR0dwwg==@kvack.org X-Gm-Message-State: AOJu0YyKGvCB5IeRqa9mRSv0TIlIR+A3znNt2Bc6JtLGlTWv2djBTjRf hqEMCncOttILW5VWUYv4hL9AVsLKe6hteDTgBrXBKvr34CD52hm7tKX4MfxWsao= X-Gm-Gg: ASbGncsSRO6+H2yfEn8OrxKZZbgb5PpbRPp1QJVs3VfoTiox0a5MWjjSn1UCChokeCe Way9gSHtA2b0HYZxu8Kc1ToqG9A4HzInwTMcP6fMoe3e5WwvqEbTi9ohJCYwDTpB/O+tIvEDro0 HAevJqABInZducr5xCN4YjM78vloumjNweJ7sXLqSKEKWO0M4M+Ep3mWUreKIqjvdtE7I2HIn/E 4fd56000UngvFB7CCmloQfkm+uvE1Fxa+VrhFUz20ylZxU21J+bDgnKKYO6NSqE1I7AvHK7fJJf wJnLaIj54fG1dc6aMCo= X-Google-Smtp-Source: AGHT+IF66ZZk/rhZtGcWoNDXw91fpPKUDEMFBtm8dpseiNoX9eGm2cyqqMp6iJGiup5xykF6TH0wXg== X-Received: by 2002:a05:6000:1788:b0:382:3c7b:9ae with SMTP id ffacd0b85a97d-38bf56633damr43631218f8f.16.1738060298374; Tue, 28 Jan 2025 02:31:38 -0800 (PST) Received: from [10.100.51.161] ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c2a188d5dsm14110246f8f.55.2025.01.28.02.31.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jan 2025 02:31:38 -0800 (PST) Message-ID: <099b8e0b-2c64-482f-8c22-32afc5b21beb@suse.com> Date: Tue, 28 Jan 2025 11:31:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 6/9] module: switch to execmem API for remapping as RW and restoring ROX To: Mike Rapoport Cc: x86@kernel.org, Andrew Morton , Andy Lutomirski , Anton Ivanov , Borislav Petkov , Brendan Higgins , Daniel Gomez , Daniel Thompson , Dave Hansen , David Gow , Douglas Anderson , Ingo Molnar , Jason Wessel , Jiri Kosina , Joe Lawrence , Johannes Berg , Josh Poimboeuf , "Kirill A. Shutemov" , Lorenzo Stoakes , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Miroslav Benes , "H. Peter Anvin" , Peter Zijlstra , Petr Mladek , Rae Moar , Richard Weinberger , Sami Tolvanen , Shuah Khan , Song Liu , Steven Rostedt , Thomas Gleixner , kgdb-bugreport@lists.sourceforge.net, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, live-patching@vger.kernel.org References: <20250126074733.1384926-1-rppt@kernel.org> <20250126074733.1384926-7-rppt@kernel.org> <021665c5-b017-415f-ad2b-0131dcc81068@suse.com> Content-Language: en-US From: Petr Pavlu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: z9d1y87x5dww59mrqdzt8jycr9ut6psb X-Rspamd-Queue-Id: F4178100015 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1738060299-202401 X-HE-Meta: U2FsdGVkX1/XoD7c3/atl7J9fzj0yBzuDc9mbNWIuZCMm7x494zCwlv2wd156IjIPtcLOyTczDwLbDXr5poxCyg62ubFL5KLIjC6qT885zY88qB3pRX1jvbdYMo/cU7kgrAcZktkHq62tAXnZ/6sjbUuLvhV0//FlnhL8gBx2QqRD7ShtpWNkq9iPSENuTXc9uLxo3vGFg6SzSRSdjZifLq7Y1kG1xZVS4A5NJP3ZBRC1BrKkCk+6VBm9CU1uUdm+LMzZnvCVHosOyAXQVJTOsXxZa+0ATIdRzJEzxqc/+CeZ9JtEmQ6bDQttYcQGpOWVMxQWlMiw7SIQpEdUto+w0pBQO9koQ6YW/NrJ8ao4rkEblLJDYW1MHtCfhxUbLAgn+qFajw+nHhEWWBl2f2rmvm0HHS8oldvuvAfCM9RHfnoxYxb9yfAkIXi5612jyyTBOm2VxqtS5xCNU5CAKUHIVRChF9izVqZQ2DjrW/TnRRaJkz2PYODTWqHX3s1T/OA3/RuXLlJosEnJZPGPaAsS67Qt7+tOoq/MFtoItZP8EPi+B5WFEJ2bhsCz95dnvb8OulAA7LxRD/9AS71BrSHo1GHl/qWSofhDwFfcupbVhlSTNPVnBbN8qEZtM18B8XbiVEICnKbkWELzr8k+O8n7d9MI7Yux0ydPuU5gjFShVMHsquPlpYBPGeBLP6nAbTXb7OM9qGKxV7JhjJUSofTfPai8iTDR3pw/NvuHPg1y0Zu6ipGlLYBnHc9Kkl77bCG/VjlL8PIim0BWRL+TEfvg6PgD0LyDG4pqqE2RQnxzNku57l9nj+PWGhKbEoIC2uGCGMiOPuQ6PJWylAw8odBCQg6i34ER10KDy9+hdAHrMl2685OCSppvmF60BnKQABY/CFdQ4739ZSzu20x6LborEtUEfbypeD853NExgLF5RljHmUNk52DXI1dalHMYxN85LGdqE/ARoGgPDVvsDH ONdSvHg9 0IOFjtUJrCoGS9DbE/YUBQMJ5yAJHDiIwSMbEObkvOUomKpVaeSos7p3pFa7lnMqy3x87H6w/NI16zE0dKOTjKwPFfxCjm0SDqs5Jw7cyZHFzTRDJ9kwGPdedVrX0HKIDY7sNdsmMeAmrcpn//BNg37fRxNw9Hh04pkXQszULMf2Xstn/qpP+wOjSChN6jHW/IOTQld+1GW3yDQ2kPCCompL3y71RS3Faj2kUFBgpgIE0Il0DWduv3dVKsZwT6HO5v1mf3xmkgp/Pr7xMgasX0qeBT76Ag3jjew4o5DAYqB0jHvUukD6B4RTfo3mhGQ9qpWyJzjMgrnC6t9cPXHjM90Hl6ec8XS14c+tQUP6pT9NMBgPEWX2/DQ69kMZCq9PiQScSUlbYUq0ESXL6Rza8u9ckHw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/28/25 11:00, Mike Rapoport wrote: > On Mon, Jan 27, 2025 at 01:50:31PM +0100, Petr Pavlu wrote: >> On 1/26/25 08:47, Mike Rapoport wrote: >>> From: "Mike Rapoport (Microsoft)" >>> >>> Instead of using writable copy for module text sections, temporarily remap >>> the memory allocated from execmem's ROX cache as writable and restore its >>> ROX permissions after the module is formed. >>> >>> This will allow removing nasty games with writable copy in alternatives >>> patching on x86. >>> >>> Signed-off-by: Mike Rapoport (Microsoft) >> >> [...] >> >>> +static void module_memory_restore_rox(struct module *mod) >>> +{ >>> + for_class_mod_mem_type(type, text) { >>> + struct module_memory *mem = &mod->mem[type]; >>> + >>> + if (mem->is_rox) >>> + execmem_restore_rox(mem->base, mem->size); >>> + } >>> +} >>> + >> >> Can the execmem_restore_rox() call here fail? I realize that there isn't >> much that the module loader can do if that happens, but should it be >> perhaps logged as a warning? > > It won't fail at this point. set_memory APIs may fail if they need to split > a large page and could not allocate a new page table, but here all the > splits were already done at module_memory_alloc() time. Ok, thanks for the explanation. Acked-by: Petr Pavlu -- Petr