From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47689C4167B for ; Mon, 30 Oct 2023 16:38:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D43FC6B0208; Mon, 30 Oct 2023 12:38:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF4B16B020B; Mon, 30 Oct 2023 12:38:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B94F96B024D; Mon, 30 Oct 2023 12:38:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AA9406B0208 for ; Mon, 30 Oct 2023 12:38:18 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7AAB61206C3 for ; Mon, 30 Oct 2023 16:38:18 +0000 (UTC) X-FDA: 81402685476.06.89FDF12 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 4538280023 for ; Mon, 30 Oct 2023 16:38:16 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Tp6aR8oh; spf=pass (imf30.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698683896; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hJI+hdEWXbKa+M8W7tfHy5n3N8xPX6O0WbfIPeXfRTc=; b=kZah4vSvXxcM4nAwVEcYHX6o62U8vymto4bdL4ZxCVcDfznbPZoP6asnGonTBSTaxuC2QC aLdtPKlOZOeH8ds2NPT2O3Iq3jqK4BW6iOkdjU/V9SBOKQz9SyExaL/feIldklzyW8WCay 7dUGK1pktXvzLj/1n3RoPLhLgacTUZc= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Tp6aR8oh; spf=pass (imf30.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698683896; a=rsa-sha256; cv=none; b=KXX2k/XYct+rERM4injhVco0JwoRbnv1Ph8kiUa8ZyjIP/XNrFXxS44yxEhhhKI/qj7+cu cDzsRuBOsMH3AuIE9Rgl4FL0avya6NsCFGd7dicV7R4UoujFljjFfzpKoKDM4QTe4roq4+ zndbeaS5JEAAXPUEB6DwZ4pT6zVj/kc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698683895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hJI+hdEWXbKa+M8W7tfHy5n3N8xPX6O0WbfIPeXfRTc=; b=Tp6aR8ohxrW+RLcTY6yVva70Q5oTRT+gLxSomER+lZjsOu9qKo12fxWhxGl7C6Byj4ikEm GL6LZ7LnGm5hxLJopzouQGwSEusG5dzzY3jxaWelvz37S7WH8SLqP7k3AAGAuHST9oM+nL RYrhTe+32nEKDhS1Gfay5bJDfDSAdGI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-177-DOonxRLYMPOK5joXLsGYfQ-1; Mon, 30 Oct 2023 12:38:14 -0400 X-MC-Unique: DOonxRLYMPOK5joXLsGYfQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4084d08235fso35834335e9.3 for ; Mon, 30 Oct 2023 09:38:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698683893; x=1699288693; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hJI+hdEWXbKa+M8W7tfHy5n3N8xPX6O0WbfIPeXfRTc=; b=CaVyOPxg3Zym8NXVmCMZKDwgdWUx/ZVAOKz8FxnLn4IlRNopsfl8llfTydO1TNSmlv fnVTRwgq5Xt0Hm2OZLrMnwJLW4PNNB5K4ajEf8DdxXUG+T44mfrRqxOKS/JCfZFIcDWp xRuh4257OwliXXgub7gauJ+D0FrHW6leRanqZOyCdPGAncXwcWGJvGBJdiyhIqRQJheU khuY1wjbf6mk/AwYQWX9OzLfKGb+M+aOBdNdDPjPdrtNtDVk69mWWnOaEl+lWgA4Ikg8 eJ3kzsSDuL0QP1mYD/vd0fdqqKrmpir5rJdh2OObn/ytfIK80R2bpGwBcRdpVn0eMeMH BqPQ== X-Gm-Message-State: AOJu0YyGaZ4k20uXJVf9CYVgCQ7NVOaETVZVuHlW5vVerPoqwYrAWZ1i PYQBYfxogjighFp8qj7/LASI+dEfjkYBbNNk/ggUofaxrRAZSeGBNLIg+1VD3NH3Fm9OfqC/mqD 8dw/fI3UFfzk= X-Received: by 2002:a05:600c:4f53:b0:3fa:934c:8356 with SMTP id m19-20020a05600c4f5300b003fa934c8356mr8459632wmq.10.1698683892960; Mon, 30 Oct 2023 09:38:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGZEMK/0a4y6GRranfUYFosow/+q05YMqexgnrNudyg+ulCeoJJOVHXdjy3BiTQsTruKVMBhA== X-Received: by 2002:a05:600c:4f53:b0:3fa:934c:8356 with SMTP id m19-20020a05600c4f5300b003fa934c8356mr8459576wmq.10.1698683892541; Mon, 30 Oct 2023 09:38:12 -0700 (PDT) Received: from [192.168.1.174] ([151.81.68.207]) by smtp.googlemail.com with ESMTPSA id m1-20020a05600c4f4100b004063d8b43e7sm13252825wmq.48.2023.10.30.09.37.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Oct 2023 09:38:11 -0700 (PDT) Message-ID: <09966596-397a-47c6-8f43-610a1013d34a@redhat.com> Date: Mon, 30 Oct 2023 17:37:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 07/35] KVM: Convert KVM_ARCH_WANT_MMU_NOTIFIER to CONFIG_KVM_GENERIC_MMU_NOTIFIER To: Sean Christopherson , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8?= =?UTF-8?Q?n?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-8-seanjc@google.com> From: Paolo Bonzini Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: <20231027182217.3615211-8-seanjc@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4538280023 X-Rspam-User: X-Stat-Signature: cijkaezbk4ojb3z3rszx9srcwk7n9gm3 X-Rspamd-Server: rspam01 X-HE-Tag: 1698683896-14159 X-HE-Meta: U2FsdGVkX1/++5MjTzkbVMYU+AdPqmMqPlkuAr4o4Vh+duSQnjJodsdl/a6fglEmp83tJ93gtVyqMkIvD4qx/jJW6twnH8mPjypTeFcnHEqnhou0m96KIyRqHYaCT85+lTBNiEbZTc3y3rAXlTI7dJjtx2pT9pcriLCY3wQumP1l5Hc5VLfq2Y4PMyRwmduGsj+WmyGyV9BGsN0oebawHSoAxGlul6rm6l3NZRHElmLInTdXEQtgGq392ijhrj+fR4uE3IkTN9N+gPGXVtadt+qq/sb6ld9wZM6svsO9gg/LhfoI+fZGunWcTUf33Yc5PeVD9P2eyubCzzl5GWfOutrXyDxN9i9Kr/7RnnAhGIWRp3Imv7gO+HduZa4wVJuGC+rl+gOvsIlYNDuBbOZ56kbRyHDCOgUJ4tss2r1mWzoryAU29mWnbHYveG6M1atWjTklppo2Q/vmkuc99ApbYX0sUXcDO8HyFM9R6mTbFhWMTUerYZsGMZlF8iy0oZ0TwQ/5c3kTeIIEpat3IKjGBRrPGPF+EZMRcdJiv521apDSJ/uXRIXPWtegc2zZhR/jI0ToQc5RRBEPnoKcGensvM7MU1lP1UBOQnEX1gGRyEwMz/CO9c7iBd4C5KhHiXLI3oA4pAA46Vmws3PiBBtdImO0VRjWFAZcEuK8YAhNexgpulERrX6HSvb7VhiWxV5NpnYVt0aSbgXsCKYz23Ic2Shz5ENH9feSWD/4sr3vG+UEUgzB832CkmpGuZkJx5AcXG8nnur+4/76uoCLy1nYoh6Ie6RCnIflKQ3zJqgc9rV5B6jUHNgYDyqExxKmcpLlpGbRLTMzm8AHiz90nZdrER3i4eQuprDDGXV46qJCFh8rhCIaXLdJMvILJfIGOGCg6QpHnQF1HuA7rghyVndUEtQTfFVqONylcR8PeHcwXCW7FWr/qmom/tHNmd5sExMIpcxBB8l/c9draREF7on /4qieb7w dvqV4G2NPt1Lfmlo23Nyp23ml0hrz2FircvuoljLmizTZdqiV7aAt5yF+4WPD2TWwinV56HBfc2svX4LI1WI8kttqWqZdBf2ROmRoIilaWGVFDOMW5wIwovos6WTFQOFNvI1lTPqI3VKs2ZsCs3Pne2rA3bpwaVtHI6lzpPE0gPC5YclRBkoh8gG24vVa3u7uG3oEzMX+lvjMjuc4H5wN5bbFfDn2ZrTtv0NdiaTMi8slXERdbpxJJy8ofjSRiMM1j8by33T6V3pUzZ0tEBlJK3E9IovbmKl1BIJwOX7DMmZx912ciikNOfORBpiXpoUwpcDLRHZ9GTU/I1gFXSnYW7XYDeD/5jzRnAEvLyHBYdK1qa0WuuFxUkSjZ/rVZJRim2+fhAi/L8jXzwM3xl4EL1+HdIJ/nrS5DzKTjRHDpWog84Zf5VliEkMCiDJlk1ZNZQ+ph94QAdiT2nfroPXb+6el1tNy+EJojsrqKenSokku4NTRK4CtTlJEGMZtcyx1jOq1jqhwW8wCGIVPi7agyi1DNAHqopbzjrLq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/27/23 20:21, Sean Christopherson wrote: > Convert KVM_ARCH_WANT_MMU_NOTIFIER into a Kconfig and select it where > appropriate to effectively maintain existing behavior. Using a proper > Kconfig will simplify building more functionality on top of KVM's > mmu_notifier infrastructure. > > Add a forward declaration of kvm_gfn_range to kvm_types.h so that > including arch/powerpc/include/asm/kvm_ppc.h's with CONFIG_KVM=n doesn't > generate warnings due to kvm_gfn_range being undeclared. PPC defines > hooks for PR vs. HV without guarding them via #ifdeffery, e.g. > > bool (*unmap_gfn_range)(struct kvm *kvm, struct kvm_gfn_range *range); > bool (*age_gfn)(struct kvm *kvm, struct kvm_gfn_range *range); > bool (*test_age_gfn)(struct kvm *kvm, struct kvm_gfn_range *range); > bool (*set_spte_gfn)(struct kvm *kvm, struct kvm_gfn_range *range); > > Alternatively, PPC could forward declare kvm_gfn_range, but there's no > good reason not to define it in common KVM. The new #define should also imply KVM_CAP_SYNC_MMU, or even: KVM_CAP_SYNC_MMU should just be enabled by all architectures at this point. You don't need to care about it, I have a larger series for caps that are enabled by all architectures and I'll post it for 6.8. Reviewed-by: Paolo Bonzini Paolo