From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF09AC61CE8 for ; Fri, 13 Jun 2025 03:06:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7878B6B0095; Thu, 12 Jun 2025 23:06:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 747B86B0096; Thu, 12 Jun 2025 23:06:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65EDE6B0098; Thu, 12 Jun 2025 23:06:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 453DF6B0095 for ; Thu, 12 Jun 2025 23:06:31 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 021951D42F8 for ; Fri, 13 Jun 2025 03:06:30 +0000 (UTC) X-FDA: 83548889382.12.5DFCB7A Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) by imf16.hostedemail.com (Postfix) with ESMTP id 5258A180006 for ; Fri, 13 Jun 2025 03:06:29 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=VmrD+p0k; spf=pass (imf16.hostedemail.com: domain of hao.ge@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=hao.ge@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749783989; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FK5GViGeaS0eKXb1CGklOs8Lcazv9ig1sTbfs/WnUDs=; b=41C7J0z7XgKh7CsHCj6bLFKJ5fEBsLIOrrkxdMkZ34FBrlynI0G5P5ywlGM7hBrKOaWcJ6 e/w24yqemzo7M15bFLhiHIG7+xpWj9NCiaXejbXKFwxCc99400H1pXUYFSuV6jw2AvsP1V dRjgnxa4792QuJFhYlw5I2HpDGSPdeE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=VmrD+p0k; spf=pass (imf16.hostedemail.com: domain of hao.ge@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=hao.ge@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749783989; a=rsa-sha256; cv=none; b=DVHBgWvfejmM9Oo8Q/U8PMmWSoiCeVdG1qSWSj4u/+0llS+OyuRMjXCIowgLIak03IH4Bm vTs/u123PjA0vJ2UXaQdzuecZh2bZtpXqjEH26T/tU/Rma9BoZu0lyrIPTjKSJcsq4PYzD mVE9LTzsCYwx4/kNVXyQ4dTIW1GsNkY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1749783986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FK5GViGeaS0eKXb1CGklOs8Lcazv9ig1sTbfs/WnUDs=; b=VmrD+p0k1+hGglgFMyD3kLFYXh+SMTmVlSrsl5nL5sfKCHcBwrkI++kzMSRi0v0hWA09jU Awtwc4OjwwnWnH73KWQTYi0o6jxXhNdzlAKgW0UJDfP8s6cB0zbAizCjx0Z9fBoQOYtHrV eO24fkJuo68McBVD7RaFUCIN/zpBRWU= From: Hao Ge To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Mike Rapoport , Richard Henderson , Matt Turner , Dennis Zhou , Tejun Heo , Christoph Lameter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Kent Overstreet Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-s390@vger.kernel.org, Hao Ge , Hao Ge Subject: [PATCH v2 3/3] mm/alloc_tag: add the CONFIG_ARCH_NEEDS_WEAK_PER_CPU macro when statically defining the percpu variable _shared_alloc_tag Date: Fri, 13 Jun 2025 11:05:07 +0800 Message-Id: <099651f46b0b57f6c7890a64608dc7ca44df7764.1749779391.git.gehao@kylinos.cn> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5258A180006 X-Stat-Signature: i9ep9wx6t38fepso93phkgnmzwhj5miz X-Rspam-User: X-HE-Tag: 1749783989-474855 X-HE-Meta: U2FsdGVkX18LYFl/S0XWkloU6mkVh9pjGpIS7d+NQO34sBE1MHNnBDWZAzQ6tZ1yC8vtl0QHQPKjeRS6sje05sp4hdPoqLVk81q2LCAnqPtRXxvFYauV7ytNfEfrSD2diAbAX86xnrBqH1bS0hsYEqBmncWzAsDnIfZf2tB1g68IrX8up2p4Jd9CyBSssf+I/+OK8zI8JR935IO0gCtpKQdYI8b6OTNDU9HJOZ1s+4fyQ4TU4nP6sW7M2PoANdEB3xnkYYvXF+W+J0FtVf2u2LeSwHkrvYHeyKhbyPli5O4a/kk0ZDF/FdDNJdpHmKShA+bvqKnDsX8BzPqcBgWreuD98iFUGhOu13QWsfWLtublLgh/KiOjdWwW0i7EhaZMa1W4saV9GnbfJYkGGkvb4senjrsHKVtvIRPcPkBGTMOU9mm/zmJb4ywVOe1X5DKw5/ahOFi6StpB1gbBdmvAE8oqS0SRFjgxdFKCtMbxJBbePvmQm8xxdj3caxljx1Kkicg9xjkdcDQFrfQMPPbJnhfwqTO7EtwUIYqh4Bx3XOjaaBY7HbbJrDMUUQl3CFfFhE3VHTZkcDnl7q12R8WZzkicPL48HzaKlZtk52UT8LUeXq1VJWRpNIIz1kTSFMhnysvN2H01dOQ52lbrBpkT5bJ8uqRCewa4Oet110w2FytitBpZ+7pqHOACDTrAQu3rwe6br6NGnAvePDSklkxfTgL/AilTRYUY2iTMGtAM1JD1V+vUWBYWWrYZs8y1SaYvZbdiam1tPQ9Z7n0ddliUK+cRm+VUjKF8mXLJta1BTaWEw3TuumljH+tEeoaaHOwH1jm8q/ryIyFTgZNU2JhltGHoxeXursrVdnxf83BnvCgL0GAMrnx3lpjLApN0lur+HwiFUsBz30nQClngvkZyoB/9Yb5eKKG5DPABRcdhF3WEwbkffDqL6dWGOXfKbGdb13gmgxwAxwwFX153PBp 2dOKGFmY eNFRJkBl31oYlg9EzTMjfD8DQ6W7PmynUmhYxLpp2/Saxuel4KD+Nx7nCAca1BCMd8BIILLWs8YOSlCYSJk7OfDBZ1QdDjtfGL1VKq8gRQLh7vqiOr0rLKvai7pVO3THg/pu18uO+Jkefb8NK5RY3f74pIZW35cTj7Fcr9PmvupLJJ19B93mZrmbbOJKC4xOT8e5NnLVAQsMNOX8JYDyjwR+E+fXKKAPmqKnDlxhR1LJRMEg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Hao Ge Recently discovered this entry while checking kallsyms on ARM64: ffff800083e509c0 D _shared_alloc_tag If CONFIG_ARCH_NEEDS_WEAK_PER_CPU is not defined(it is only defined for s390 and alpha architectures),there's no need to statically define the percpu variable _shared_alloc_tag. As the number of CPUs increases,the wasted memory will grow correspondingly. Enclose the definition of _shared_alloc_tag within the CONFIG_ARCH_NEEDS_WEAK_PER_CPU condition. Suggested-by: Suren Baghdasaryan Signed-off-by: Hao Ge --- lib/alloc_tag.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c index c7f602fa7b23..14fd66f26e42 100644 --- a/lib/alloc_tag.c +++ b/lib/alloc_tag.c @@ -24,8 +24,10 @@ static bool mem_profiling_support; static struct codetag_type *alloc_tag_cttype; +#ifdef CONFIG_ARCH_NEEDS_WEAK_PER_CPU DEFINE_PER_CPU(struct alloc_tag_counters, _shared_alloc_tag); EXPORT_SYMBOL(_shared_alloc_tag); +#endif DEFINE_STATIC_KEY_MAYBE(CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT, mem_alloc_profiling_key); -- 2.25.1