From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1B88C369B1 for ; Wed, 16 Apr 2025 03:28:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 94BDF28000F; Tue, 15 Apr 2025 23:28:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DDB66B00A4; Tue, 15 Apr 2025 23:28:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 725FC28000E; Tue, 15 Apr 2025 23:28:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 506516B020F for ; Tue, 15 Apr 2025 23:28:44 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7C300C1BAB for ; Wed, 16 Apr 2025 03:28:45 +0000 (UTC) X-FDA: 83338475010.10.A8B043A Received: from box.fidei.email (box.fidei.email [71.19.144.250]) by imf22.hostedemail.com (Postfix) with ESMTP id BBB3DC0009 for ; Wed, 16 Apr 2025 03:28:43 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=dorminy.me header.s=mail header.b=Escj1yUC; dmarc=pass (policy=quarantine) header.from=dorminy.me; spf=pass (imf22.hostedemail.com: domain of sweettea-kernel@dorminy.me designates 71.19.144.250 as permitted sender) smtp.mailfrom=sweettea-kernel@dorminy.me ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744774124; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aC2SYdcPaAe47LahmiXhwpUkmhYFr+R9K5RN6ISKxnI=; b=at4GAYRVy5b0luNoc3gn+GSqww2MHNAv/zRbUXz/y3BZkaIPcpftdjmmt4p8qaOqJ64gu5 5WZOVYbEy2Z0VMLiZOZ5zqZlPKbTJpJzNzwmIuXXYaJTeP+X0zW2jVUpduX+HE/1y5Trl7 pK/LuCbg2Qz2NWGJpoclWJq6w2fmEww= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=dorminy.me header.s=mail header.b=Escj1yUC; dmarc=pass (policy=quarantine) header.from=dorminy.me; spf=pass (imf22.hostedemail.com: domain of sweettea-kernel@dorminy.me designates 71.19.144.250 as permitted sender) smtp.mailfrom=sweettea-kernel@dorminy.me ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744774124; a=rsa-sha256; cv=none; b=1FE1sW3yuAChej1EKhi1qFSU5MBNXNwwE6QtndRSw6I6O04fb9fXSe6gwJJuC/DXa3DyQi dvHO3HjNvUvHPMclveSWCexd4A1N9U/P1l/IHmv5hqDLZJnbJ3HL9cLmxcWKNoiNrswMeS KqPSigTd+weiKDuzrnGin/k80nBhvP4= Received: from authenticated-user (box.fidei.email [71.19.144.250]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by box.fidei.email (Postfix) with ESMTPSA id 4595F81761; Tue, 15 Apr 2025 23:28:42 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=dorminy.me; s=mail; t=1744774122; bh=6vQH1CB4a3bJsItvGCdq4/8gsUWdHbTwwn/6tj0lSFE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Escj1yUCXXo2gjM/0SzRe6CVrewC0pVNiuOS0GzX6WhqQx0CjCmgNBI7leRGcDIW+ AeuhH39aL/DdlxQxxxtEzJbtjK8rVev+icY7jZbQWOPhnYgNQmdyQJHt//2fGuyThC lr8zFx8vSB+XI1fzFtfWhoOfM9rTbOZHmhJsxC0IV29VwjtK4WHCE6Kmjyj3PiXE9k XIZ6vqoS/8K7/pU3VwweqVyrCgoio0bSTWAE9hL7Fy788R0EICQxgsec5W68SwFq1g u5AqPgkWlnoGXgd5518i7Qe5T7kLoVP2jAEAYct5TGUlUJXQIi16lekhObgdtb3pP4 bHIfZXeWTJVkQ== Message-ID: <098e977c-55cd-498b-bd36-725333c06210@dorminy.me> Date: Tue, 15 Apr 2025 23:28:41 -0400 MIME-Version: 1.0 Subject: Re: [PATCH] tools/drgn: Add script to display page state for a given PID and VADDR To: Ye Liu , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-toolchains@vger.kernel.org, linux-mm@kvack.org, Ye Liu , Omar Sandoval References: <20250415075024.248232-1-ye.liu@linux.dev> <20250415191414.a64de2d228ab5f43a5390acf@linux-foundation.org> <42f50a48-10da-4739-9e51-f865fbf04bdd@linux.dev> Content-Language: en-US From: Sweet Tea Dorminy In-Reply-To: <42f50a48-10da-4739-9e51-f865fbf04bdd@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: srpu5yhmnbforhkrmm6z89nye6m5sxh1 X-Rspamd-Queue-Id: BBB3DC0009 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1744774123-322091 X-HE-Meta: U2FsdGVkX1/fLSjuMn+IjK8MBWIrRF/h9xowK/1TzN9ORyZidIRMHWaHKHINV2JzenDGyUctHwCHoHnoppL4DOmYUGex5DE/se/UcOcpLvYeqaRhL2Qk8bkPJQn4eg2QsIFMr2xM0V5xekc9gXmXBFGNLR+Eu04YzleZEh1VRM4wzh+q+E/dWZx23beTxIIo11ePBI6O3jZST1RUCNpE48GBwymsisuAJoaN7GcFbN23Odu/92Fmn3qQs0PCHk9/y7gT0LCCHAuQ717L+MqRT5g6S3wDNVUByVByx29z/8Pc9sPoFzLYkVMwr3uZ1cbMVtgXnxg1WT5TfhAwCvSeD9rWWiw/O+W68uvA9MB1BqhdvienGSGu4ClEqCskPMproK2sYux7HRTiMxWprwMd+hjUXmYzfsquDrEVESvV3CQQZJoZUlLAVeRZbspm8r4lIC+iM9iu/DuntFvrc0NZsY5CSZvuRJjDcEJHcD7Jr086IALAGsBYS5ifwkirD75Yl+bgrHWY6R3cSq98iK8Rx5ByUNBDu5a+jUlGCm9LmqdPjMbDwng9cA4LjnR/sL4Br5ndkIVHfBmxXk/DZXueV0f9M6thDKphBGMOQJ0PUK5EbH23KB5vxgd6c/5cac2aSQOEJOhPf+nUtEi+eFJosi88WES6687BM1rtwFeyws6NLc5Dl+mt0la0AhdEGerJGedqIrwBwyl15pzDCJbJs2pvUER9KIsnJkf+XPum3eOkf1Q5G2MY08BEo8mvKcvjnqYAQkWGrG9eU41WdTVvdaJ6mCYVZekHqwBTw0PRbGLt+My1e+Pd5n2QS/+7DlUCzPqx/cXc3GaeKSqBGJObyVRI7nltRKUT9UkIHG7Q34OcDZuOJ2Lu0NR4ApZi7LYGqZd9x42XS8ekUC/BJC+S8HC0oMgMiqSvdxtyyZ9u8Dz4OfpMhRAEZxLFd+3k3x65cKKhM4O6idKlTSNXdtu I8MoJEZy MJ8D6AROohygLovJi/YM9Ht5kvYKDc29p9k0wdA5PlZJJxxhBAfykvJDcXHPOvtEyggaFmBvnsW8lSYefC+J1dlOUvYbcz54XUsgS+/tBAT9hKxVP2SM3RSbw9EDKmN3VvO5nbBE3d4ciqj0REXbq9RmUX1gvUoGP8dAp1bqnBzChXelsyorasN8R9Mde2EqnbcOtaCtZ+tISirF4nIwuX+CaYyhUuoZIIxDDhChl/qCbQ+sIFJoQIymb+2ImfYJRKVsv2r1TJ6IyLkaWoUWBzI7VZEIScLgSFG+BmYJGlaYpGyM7a9gGCckz/srrpYnwHSF6j9T8fWIoW+M/l0Tuouo29h7FWFX6aPQW X-Bogosity: Ham, tests=bogofilter, spamicity=0.004756, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/15/25 10:46 PM, Ye Liu wrote: > > 在 2025/4/16 10:14, Andrew Morton 写道: >> On Tue, 15 Apr 2025 15:50:24 +0800 Ye Liu wrote: >> >>> From: Ye Liu >>> >>> Introduces a new drgn script, `show_page_info.py`, which allows users >>> to analyze the state of a page given a process ID (PID) and a virtual >>> address (VADDR). This can help kernel developers or debuggers easily >>> inspect page-related information in a live kernel or vmcore. >>> >>> The script extracts information such as the page flags, mapping, and >>> other metadata relevant to diagnosing memory issues. >>> >>> Currently, there is no specific maintainer entry for `tools/drgn/` in the >>> MAINTAINERS file. Therefore, this patch is sent to the general kernel and >>> tools mailing lists for review. >> Help. My copy of linux has no tools/drgn/ > I noticed that the current upstream Linux tree doesn't contain a > `tools/drgn/` directory. > > I'm interested in contributing a drgn script tool as well. > Given that this directory does not yet exist in mainline, where would > be the appropriate place to add new drgn scripts? Would it make sense > to create a new `tools/drgn/` directory, or is there a preferred > location for such debugging scripts? > > Thanks, > Ye I believe the traditional thing to do with new drgn scripts is to add them to the contrib directory in drgn via pull request: https://github.com/osandov/drgn/blob/main/contrib/README.rst