From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 676F2D6EBE0 for ; Fri, 29 Nov 2024 07:08:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACA2A6B0083; Fri, 29 Nov 2024 02:08:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A7A826B0085; Fri, 29 Nov 2024 02:08:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 942166B0088; Fri, 29 Nov 2024 02:08:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7563C6B0083 for ; Fri, 29 Nov 2024 02:08:04 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 140ED80BCB for ; Fri, 29 Nov 2024 07:08:04 +0000 (UTC) X-FDA: 82838252700.20.6A62FC1 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf15.hostedemail.com (Postfix) with ESMTP id C7574A0004 for ; Fri, 29 Nov 2024 07:07:50 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732864074; a=rsa-sha256; cv=none; b=ubABjH0166X9Mb8eIbdiwk8uBqufUJKLaneRSG/WDD/oG6BnUPpaZSw8Sgz1dQRN3GafBC vEH/2EeckHrCm+umUriR+l28lS8nbze+gT+pWazlw1LVwcOZ6BJuLuEYg+8rTLD0O+m1Gc HAUTBL7RNdKn1iV7utXJoNUKypjlVvU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732864074; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7l47RCQ6WPLMR2yf6P1+D18XE7Vh7E0FHii/gxIU1iE=; b=xpYj34NkhG7ZP/0O/bE5W2iS8d3vih0vpUjUlPnFyDRh90TXX+vWipORVbO8hnyw9J23H/ cbX5RG9e2W0PcfQafKcZjAeL+SBpM3xyiqxqswFrI4T1Mf3ctsJO6IejtSXUGUZDURxGC+ JwumZ0r33iT+zqedU1zPhSkW+l+bCr4= Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Y041v6mmrzPpZW; Fri, 29 Nov 2024 15:05:07 +0800 (CST) Received: from kwepemd200019.china.huawei.com (unknown [7.221.188.193]) by mail.maildlp.com (Postfix) with ESMTPS id 6A520180104; Fri, 29 Nov 2024 15:07:55 +0800 (CST) Received: from [10.173.127.72] (10.173.127.72) by kwepemd200019.china.huawei.com (7.221.188.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 29 Nov 2024 15:07:54 +0800 Subject: Re: [RFC PATCH] mm: memory-failure: add soft-offline stat in mf_stats To: "Tomohiro Misono (Fujitsu)" , 'Jiaqi Yan' CC: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , Naoya Horiguchi References: <20241121045504.2233544-1-misono.tomohiro@fujitsu.com> From: Miaohe Lin Message-ID: <098640ac-f1c1-95b6-e367-a2673c3ceaae@huawei.com> Date: Fri, 29 Nov 2024 15:07:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.127.72] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemd200019.china.huawei.com (7.221.188.193) X-Stat-Signature: riao8j9wqn4n1srszfqi1xwyo9u9akdz X-Rspam-User: X-Rspamd-Queue-Id: C7574A0004 X-Rspamd-Server: rspam08 X-HE-Tag: 1732864070-880813 X-HE-Meta: U2FsdGVkX181lMf0XoqzpAS/eA1lnzpJULVJhqQHfLCIWAn4bhqMXVzT4kEzZcjkGEpFrxbJ3gCwawhBvzzZ/D06Ftq+g7Sn66gh4wReHynBIpypxJfoJsK1Xqc9rs5amXGLwazFEyhcDvjOH3fENi3VKTqEEoDF4WOEflNw73sVk9RTo8vSqokkMKou0glhQobSOQfaRhdjr6q+eM7S5jNkQi0+wY7U0y+dbA0koT4BQS+bK2mbuiEcD9Y5PdP8r2z8dS2Sbcztg2rdH/tgy9NpJJ0itfXE1u7JeKuPW9l8JbWrtcF/JJeOJyViPy1jqkyEIx0Q7ODnCx6LLiQWXZo8zsK8+0yY6sN6vcxGnaE9XnXgk7LESboA/s3829ftSGEJ/8tW097cASs21Ix7FRLFce9xnlPrYWah/5cPiI7QsHBBenMjrN+2TLhs3kZ9mYw+7N20fselamW9mOYeJflUFSsqZaTS0YxXIHptCfwIzoFAYn1IJR6i9J8dNukHM+66m7SpZTROUZBhYt7WFbzuGHLk15mhie11J8tEhA9vklANY3trOU8/t2AT1WEwHs1ll+CUWzcepFjUnhOb4mr3vZ6xQdxQ4i7fhUAt5znJb3hqaOVZrKkBgdj9TLmNUWBjhcS3qkRPFesO2ZSEqKPzNnJPg2gQZB6TFJTjUQYEgpjKgL4UfUlKh3amkZm5RX1l3XkvEUKgU3pRRuRe7UmIgQjqlB8KcUacvn6ROvvg1hLafexv9CH4paPy0ItB0YYpB3fmBtDPG1tu52SzlSPIzM2HkdhaieSQlhzAb4pna8dxne7kYWMPaQ4kQaS71+6At7P272VAebDpm7MNZmFRz2JnvanihwsssgZemuxDHW2c2eIMEG1+Aks0q6Gu7QvYQa+UbLi0O9x8iqmunFECRgy6XS1JwCU66cP6By8XAgi4iRV9Rw4ercWUu3tEfaroQBK3wG9JjRQ+Tx5 m8OQGJ1Y ZanvFk+sj35okc98G1xIfAu/hW5KC+/LZPIZZaC4tnPr+sYmrcQ2MbkAjcWE7SNa6c7Viu0i/kzAnflL4qtka5WbLsksQBk/VVGm6moCLGikylfqNxE7kAI4uR4TWbVjsaSaFKNCrH33mIhTyMhwTB38Vg3jRdm5tjI/MSvZhU3f8ulLnMX1ZUdBbvhHU98cBtAP0ay4MlSnZyNW4WglQNcgJj4zUhOX1QMX1WAroQQ7FjEX4GpBXsSkBTQl8Fnfc9S6O6J232Dp3//u+ILjaBzSdT2FyqoKAEinw9bxOys/iQeBU7Iqs9Ks2XDbHymUj6Fss X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/11/28 13:46, Tomohiro Misono (Fujitsu) wrote: >>>> On 2024/11/21 12:55, Tomohiro Misono wrote: >>>>> commit 44b8f8bf2438 ("mm: memory-failure: add memory failure stats >>>> >>>> Sorry for late, I've been swamped recently. >>> >>> Hi, >>> Thanks for your comments. >>> >>>> >>>>> to sysfs") introduces per NUMA memory error stats which show >>>>> breakdown of HardwareCorrupted of /proc/meminfo in >>>>> /sys/devices/system/node/nodeX/memory_failure. >>>> >>>> Thanks for your patch. >>>> >>>>> >>>>> However, HardwareCorrupted also counts soft-offline pages. So, add >>>>> soft-offline stats in mf_stats too to represent more accurate status. >>>> >>>> Adding soft-offline stats makes sense to me. >>> >>> Thanks for confirming. >> >> Agreed with Miaohe. >> >>> >>>> >>>>> >>>>> This updates total count as: >>>>> total = recovered + ignored + failed + delayed + soft_offline> >>>>> Test example: >>>>> 1) # grep HardwareCorrupted /proc/meminfo >>>>> HardwareCorrupted: 0 kB >>>>> 2) soft-offline 1 page by madvise(MADV_SOFT_OFFLINE) >>>>> 3) # grep HardwareCorrupted /proc/meminfo >>>>> HardwareCorrupted: 4 kB >>>>> # grep -r "" /sys/devices/system/node/node0/memory_failure >>>>> /sys/devices/system/node/node0/memory_failure/total:1 >>>>> /sys/devices/system/node/node0/memory_failure/soft_offline:1 >>>>> /sys/devices/system/node/node0/memory_failure/recovered:0 >>>>> /sys/devices/system/node/node0/memory_failure/ignored:0 >>>>> /sys/devices/system/node/node0/memory_failure/failed:0 >>>>> /sys/devices/system/node/node0/memory_failure/delayed:0 >>>>> >>>>> Signed-off-by: Tomohiro Misono >>>>> --- >>>>> Hello >>>>> >>>>> This is RFC because I'm not sure adding SOFT_OFFLINE in enum >>>>> mf_result is a right approach. Also, maybe is it better to move >>>>> update_per_node_mf_stats() into num_poisoned_pages_inc()? >>>>> >>>>> I omitted some cleanups and sysfs doc update in this version to >>>>> highlight changes. I'd appreciate any suggestions. >>>>> >>>>> Regards, >>>>> Tomohiro Misono >>>>> >>>>> include/linux/mm.h | 2 ++ >>>>> include/linux/mmzone.h | 4 +++- >>>>> mm/memory-failure.c | 9 +++++++++ >>>>> 3 files changed, 14 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/include/linux/mm.h b/include/linux/mm.h >>>>> index 5d6cd523c7c0..7f93f6883760 100644 >>>>> --- a/include/linux/mm.h >>>>> +++ b/include/linux/mm.h >>>>> @@ -3991,6 +3991,8 @@ enum mf_result { >>>>> MF_FAILED, /* Error: handling failed */ >>>>> MF_DELAYED, /* Will be handled later */ >>>>> MF_RECOVERED, /* Successfully recovered */ >>>>> + >>>>> + MF_RES_SOFT_OFFLINE, /* Soft-offline */ >>>> >>>> It might not be a good idea to add MF_RES_SOFT_OFFLINE here. 'mf_result' is used to record >>>> the result of memory failure handler. So it might be inappropriate to add MF_RES_SOFT_OFFLINE here. >>> >>> Understood. As I don't see other suitable place to put ENUM value, how about changing like below? >>> Or, do you prefer adding another ENUM type instead of this? >> >> I think SOFT_OFFLINE-ed is one of the results of successfully >> recovered, and the other one is HARD_OFFLINE-ed. So how about make a >> separate sub-ENUM for MF_RECOVERED? Something like: > > Thanks for the suggestion. > >> >> enum mf_recovered_result { >> MF_RECOVERED_SOFT_OFFLINE, >> MF_RECOVERED_HARD_OFFLINE, >> }; > > Ok. > >> >> And >> 1. total = recovered + ignored + failed + delayed >> 2. recovered = soft_offline + hard_offline > > Do you mean mf_stats now have 7 entries in sysfs? > (total, ignored, failed, delayed, recovered, hard_offline, soft_offline, then recovered = hard_offline + soft_offline) > Or 6 entries ? (in that case, hard_offline = recovered - soft_offline) > It might be simpler to understand for user if total is just the sum of other entries like this RFC, > but I'd like to know other opinions. Will it be better to have below items? " total ignored failed dalayed hard_offline soft_offline " though this will break the previous interface. Any thoughts? Thanks. .