From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9BFDC282D1 for ; Thu, 6 Mar 2025 15:34:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4EBB9280007; Thu, 6 Mar 2025 10:34:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 49CBB280006; Thu, 6 Mar 2025 10:34:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A1E5280007; Thu, 6 Mar 2025 10:34:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 06F71280006 for ; Thu, 6 Mar 2025 10:34:35 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 59D2EC1B7A for ; Thu, 6 Mar 2025 15:34:36 +0000 (UTC) X-FDA: 83191523352.02.899AAFD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id A2EA61C0021 for ; Thu, 6 Mar 2025 15:34:33 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i5VYLI1k; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741275273; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zFDTaFPgOjNV4XHI4G1otZrO16JWIPtLrzju+UU84Qc=; b=8hv19InwzcpJ3R7ZAjPsz/jco/bbFOXnzVyLah9pCnU6LQC6Ti27LGo0QllKKh9at82M9H wDmYbVQCO3yDeCt2enQLRTjqfBlUiUzrZjq0ufj8N5d0RZZSKEzT6vkVbVZkkfLuq50A7Y WPDEG8w4pSmRk9OAIn6qrranFa+yCm4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741275273; a=rsa-sha256; cv=none; b=Qezs7rn0Y+7vPAdvFBz1Tyk7Prc4vL8frwuAsA6Hj2OUx0WOqTH5zWKjFmkdbiK+0XoVue hlabHA/Rp1kLuhqB9eT85GxG6ZrMgW6I+El1LwbLiUHzrn/IjXgoMuYGhT3TLjk0p7go/u PwxsuIpWMbj06Ms4KNF34NUe5rL52eA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i5VYLI1k; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741275273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=zFDTaFPgOjNV4XHI4G1otZrO16JWIPtLrzju+UU84Qc=; b=i5VYLI1kfYMm3ZMIPyuAQMP0KirqnoXQwTjAccnJGEHXg4/h3qJxHzoSCWdb5JarEpT1iC ptXptnJQ2RQOGV2rmlTF1iySivdjDt6pm5EP6beqLqspJU2W/9RJt1tvld4MeqGtPJ7+Z9 A3Nuy87dl/x7IWtqiBpp3iKm2bEL27c= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-nNH3ldNkNX-E1k97SXQJ4w-1; Thu, 06 Mar 2025 10:34:26 -0500 X-MC-Unique: nNH3ldNkNX-E1k97SXQJ4w-1 X-Mimecast-MFC-AGG-ID: nNH3ldNkNX-E1k97SXQJ4w_1741275265 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3910fcca0c7so356685f8f.0 for ; Thu, 06 Mar 2025 07:34:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741275264; x=1741880064; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=zFDTaFPgOjNV4XHI4G1otZrO16JWIPtLrzju+UU84Qc=; b=cQTJmKBJZLEqx6BQX/jv/bdiLOCiver1ZgH1POlJBmLR1sA5gcwOZDLfk83YQlMnoM 46togBcai/uV3R3dtgeG84a0g/LoDQJLODGQkCnlREaYi6DlG/gmcj1iBmkmP2Jk7h5a UhSIz2JQrJXAJRsll/oOif/LuTzDJawzxf/0/JTjahSKwv8Z/gfon/FEgWeEpJ+27WsV OzA4smv9D5pi2EKn2ZXa+IA2qs+UDFPuKXo9aPJcDlamPPm5Zl69KvXW6q4nywrtg18w 4TwkY8hj6p4scwlXcHAjDJmifEBC/FtpBbK+Iz2scUBbLDSHt7Oj63b7GBBsbFh3j8q+ 2d7A== X-Forwarded-Encrypted: i=1; AJvYcCVHn96H+LoA+w56jvvg81GLUhHE3jeWuOTHuf9SjK75/UOfcrKCE70J5Bqvq56GL/hkVXqmjjE2lQ==@kvack.org X-Gm-Message-State: AOJu0YwxDoy/F/iVeY3I3ppBQkIW/N8aZLF/WbJsxFToaRx8gvuv6lud vul9dh0cvc1kCdMlEDSqis65KTkGpbc0yuMy+2UmyEj5eATduu8KALAd+A6V3prU5gdIGNIkaHA cC1Y6bqA7BtfjR0UDsafoWTFqDLUmdfFkDwrn0QTxzbIPfRtY X-Gm-Gg: ASbGncs7zOVSv+jzhSmfe4r0ZRXmun+NYDrx4IZSD18t7+Y5xsHQgs+Oyx33uEb+b2A IlNQXc/2F4lsFgDX3RoBOFuhpM39ZApsWO50BXYO64ejOaWo8tWPgbDh9Lt5caO//ZKlUCfxfkL mnzfPCx0TKShQrmWlibMhLRFGmYaIi2xXgvGCJJSVke0N0a3YaHKBokObB0V8sWMjT+3Q9pQRUZ jUYLGhzOzzt8ReNw9OBOLZc20ArTAmbFpzHVIPFre3f5XlGI+GtgU98t4uXkJzhHUozw5sAJqZ+ 5jtHT9Vb1NGaigmpPW7wbj+S6cthtEc39gtvRLCN9uBgWEz+9OKvx7anW226aqqoiciI4s9DUGV cDZJA2KYyrGBQL1KRK1UgQC0dvtM58CjC1RFlJozvgOU= X-Received: by 2002:a5d:6da2:0:b0:38f:451b:653c with SMTP id ffacd0b85a97d-3911f72fe43mr5856297f8f.7.1741275264644; Thu, 06 Mar 2025 07:34:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IHNQhp/VRiJ1mX+q4SMp9ErfO69mHChDVohYCZYZAXtItPqxnjoLiHUFehIFb/vxV48tnZXmg== X-Received: by 2002:a5d:6da2:0:b0:38f:451b:653c with SMTP id ffacd0b85a97d-3911f72fe43mr5856279f8f.7.1741275264265; Thu, 06 Mar 2025 07:34:24 -0800 (PST) Received: from ?IPV6:2003:cb:c74d:4400:2f98:9b35:6822:ce54? (p200300cbc74d44002f989b356822ce54.dip0.t-ipconnect.de. [2003:cb:c74d:4400:2f98:9b35:6822:ce54]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912bfba888sm2414373f8f.16.2025.03.06.07.34.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Mar 2025 07:34:23 -0800 (PST) Message-ID: <0983d2b3-aee9-4432-b993-5617a5df0b06@redhat.com> Date: Thu, 6 Mar 2025 16:34:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Remove redundant return in set_huge_zero_folio() To: Dev Jain , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: ryan.roberts@arm.com, willy@infradead.org References: <20250306144315.21907-1-dev.jain@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250306144315.21907-1-dev.jain@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: fmZ0vjWsy4FxbrQYBZXLVctLntGe6LD7sLhswPMaWGA_1741275265 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: aurpawymtbeqs7n3d5rreetej6rh98fh X-Rspamd-Queue-Id: A2EA61C0021 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1741275273-254222 X-HE-Meta: U2FsdGVkX1/9RvQElUJrTdhuQdCjDF6HX4eg4WR4Dia4Ouw+JTOVMZwqkfGPrY3SYuNCIS9miCsFxvdFF1OHYnl0AToQErMe93ZgesNDRzX+jl02850Zrbr7AUvoXkeGTdWLSmpPJgWh3MmeUdPaWlSLZ/1A4k0+ymCI69wTHIH/vSPopXl+lPOdhtZfAM1jKTqmJlPcjHxGVAvqFxKGzCz3Pqoie+sHjzEzSvXfVMjhlN16OHDSe7rqG1V4ukuWQnSeAeBstzF6uUl2PJEsTaHoYmxtS7O3TYLQ7fCX9n6vaX5LevQAFIwwm3jtsJg+5s+eqs3SIz47OkpwjqsuK4jixXFgjVLlPuAQMc6egF9UkJYI6bQZcoMNm8TlUwKXHAfLkybnCSASWXVeF+IKkq0F+uJzyo5MYZAVyXek2RpS82+3/Bzji8KUotlIYzVV1qjAlfLu2qzB07z/x2+BtSAR0+Os7oB2qZ7+81RxGGhBEYaV+YO7zpOz5f/gNyQ+w8IQA4jdBbZPTPuc19e2Yf3AgAKGA7cc+86RLStK3El9IGVutMburo49R4y8noWGBMaFgxA9hYYHwDU8RdVw6y+5GNMWfxzE0z0wJRebGDJZCE3/crI+1u1wtgmm68ul5XwmioP9E30sjzhK1ecQGkvV9fW6AaMy58fTSzaMQDdbs8R2iFhvnMxYHky3MF/jbCPkqwn1FG6MSnDL6I9wJ1P6QyzEivyO7/7e+hgt7Yu6i8+Gufl+tFc4xWsPXj9wYGrZa3AJRUqugLRGRuNkGsrD2w0Ky/o//ZwHwXdZSmhKPycT/YCAz0FgqLbqAy5cokU2NN5UqZI0pCGylXVuaRfpyf49+ughSWXu6aR1LPTnFoW7ASdOFqis91rRHb5lO22F6Jvf5IDOGIbT0dI69zQvPwldatknmXOzwK3d1t2msGd8wqZ6wtH9hC8kMbI1xUk4ZwFhtFufvAyeP6T GnC0z+Ik caZX/Av1YvSBavEKUrN5ehJKys1O5HLsCUJIU0nFwQNiy9JgVqiiOj33xXYcA3N9eTVe9auSIsql12baahM5td6VGb4/3GOMhR9hX+CWCTD08thWV4Ae+XjfxahD/psvHpnVIzpQNUy/UWsOAWsEb7KSZ7lBO+jaGWkATpugkbrS0sDedzDCbd2xotxuHTDklIOFH6Xhoehvd1tTPdqwyQYTNbUHPCyAJSf/0vMDM3qVM4dA/pzhmJfoIb9ul+oEsxdqyI9rrSz+0SSMUYLhQVJ0DlGlyD6d2vJC3pyx9TNn1sEOBmBryiiQBTTK9ymSEAU+x3Pmuas1LPbOKy5HNxOD1sz2JVuZpRlinUUcbFVh4LlaQy7JHXkjFtzY1464yjQM26P60zLGgCMbKZ+cM9VAWGK1lB7xDqsKbdupdIDOohuKeX4VjoTy4+Y289Xnd9XOQNBzPvwVQmv15gw/6uK3/LgRmn7LxtWJji5+IahEslNjLTgu5e0btby+JHOKP6hwQbP3LI2OV1uc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06.03.25 15:43, Dev Jain wrote: > It is the responsibility of the caller to check pmd_none(); in any case, > we are not achieving anything by returning since there is no return value > to tell the caller that we succeeded or not. So remove this check. > > Signed-off-by: Dev Jain > --- > mm/huge_memory.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 3d3ebdc002d5..f64212d674fd 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1309,8 +1309,6 @@ static void set_huge_zero_folio(pgtable_t pgtable, struct mm_struct *mm, > struct folio *zero_folio) > { > pmd_t entry; > - if (!pmd_none(*pmd)) > - return; > entry = mk_pmd(&zero_folio->page, vma->vm_page_prot); > entry = pmd_mkhuge(entry); > pgtable_trans_huge_deposit(mm, pmd, pgtable); Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb