From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A81A1E7719E for ; Mon, 13 Jan 2025 11:32:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AB1A6B007B; Mon, 13 Jan 2025 06:32:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 35B0F6B0083; Mon, 13 Jan 2025 06:32:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D4A16B0085; Mon, 13 Jan 2025 06:32:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F16AC6B007B for ; Mon, 13 Jan 2025 06:32:05 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 984781A1DDB for ; Mon, 13 Jan 2025 11:32:05 +0000 (UTC) X-FDA: 83002214610.21.AD90FED Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf08.hostedemail.com (Postfix) with ESMTP id 904D7160016 for ; Mon, 13 Jan 2025 11:32:03 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=citrix.com header.s=google header.b=n+NrUKQP; spf=pass (imf08.hostedemail.com: domain of andrew.cooper@cloud.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=andrew.cooper@cloud.com; dmarc=pass (policy=reject) header.from=citrix.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736767923; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qybAwYNUNtwL1tURgI2ZNJuttlsIiuGMlzrRAvz7T80=; b=zrCoHm/6Rll3WgnbKaUCXlIgC0DFiQeHIL8i8cIZuEre/B16FaLDHRTu36cuqaEBMXCeX5 qkjPgscEbs/Rb44lBECUnQfBFQBlnKIyE7gbomK1tCHQE60pGGyigLml9WuWwsN8ftcL5m Lb4n3i0JlFTnrnxQ4ZdFzR6jyZmNr2E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736767923; a=rsa-sha256; cv=none; b=wEsQxJPUthmBMtKwFNOPMeqBIhCzE3YCMLjb657qFBbInE9xTynfCIsL+RL6oiY87t9E+p yr6TZrWms+Hv2mB1lszITkZNihsROdT2on7/EqcLnDadzH4tConKiltKWQB70LlPH7ZtEU sSmR18pEgQmEgFn8JwmR+h7VCrjimF8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=citrix.com header.s=google header.b=n+NrUKQP; spf=pass (imf08.hostedemail.com: domain of andrew.cooper@cloud.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=andrew.cooper@cloud.com; dmarc=pass (policy=reject) header.from=citrix.com Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-aa67ac42819so600908666b.0 for ; Mon, 13 Jan 2025 03:32:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1736767922; x=1737372722; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:subject:references:cc:to:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=qybAwYNUNtwL1tURgI2ZNJuttlsIiuGMlzrRAvz7T80=; b=n+NrUKQPdcqWor5Z6IzxXTy4ccarIseCDpbSzKUvohyPQfAJljlzbsxtYMldKn5wF4 +Um7K1eChQhQg9TdAJ7Qu53z1hHgJqGWOA3uK5vsX/5Xm/FD+0EMg1bGFy9sRN/gxSez gRDyWIxmCJbrbRsGZwrjCm6CgzzfdTzuyE+Fs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736767922; x=1737372722; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:subject:references:cc:to:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qybAwYNUNtwL1tURgI2ZNJuttlsIiuGMlzrRAvz7T80=; b=RIqSN1t4fcWg05icBGwBm+HzBFp6vBA3jk2iohPW9kktA/admVIK4qeA5SBZ6Pi8+G MgvCWekpNcuwmTMzEVTA60qzqCSYn3zIvsCME4x0ULUz8cC6r2ZlkyJ2jdUD5wbucVHh vvxAGyO4j/xTdtUFWdy9+s6/rznmPlH9vvupehq8rNMeZhYPUUy5Fh86kiMt+Nm4j736 FEaN5lMxIH80Uk4JZX5GUYpC2oyvb8VLgm1H8AUfRI2c1m+xmaRSN/Rv6rsAR0H5I7pk aqecxup7n1hB7yjQINsjECoTIWvMzvCzeRCMYfTK/9/7omOERUNr1Wjj1piEWBau39F7 gBZQ== X-Forwarded-Encrypted: i=1; AJvYcCVCrgk4LmBA9/W/5q45wBy6Hs3GUtaG7SunBFcrV7nObYwdwCYzvvf2P0Tcr+hr50PB0IysiqIlsA==@kvack.org X-Gm-Message-State: AOJu0YxZW4Bi2iHqFRk+VxUUB0Zrxz4BVZmhVS9mdcetQmYIUf4LzBU6 OA4rwoEZv5CZLShMWbMp/KmJqvrHi+p2Vfndv7mQusKeOjMTMkAj+3vfrjinYCA= X-Gm-Gg: ASbGncuCMYEnv7I5xePFS2p6otccY4J6KvPBkzK3TnAr4IkXcr3saPLozXIFNea5q/B miyjKNdYaymjHDO7jJ6hN+doM3g48aJh/anXXei7a945BoP8tYNwvrEZNoNHwZb8QOyjCn+MlPn lMX5rwIkHH2KC7kWOaKrpZsWONzLA8tLroyqABbWZsNskP7pRZlLtC/ig9vMJITIe9LytPpLQ3h EN7dN1FXH6/a/79Jm0cGWQz48YJcoaO3msTOXTClnBNO3f+uZaHCJLsH6tFIeEBPoU= X-Google-Smtp-Source: AGHT+IFj9Y9v4Zz+HtfGoUoodsqT5Wc/GF/KSfplvSoHf3SqbsgVgZ0e76HyW1pGxykAx0WIur9D4g== X-Received: by 2002:a17:907:9413:b0:aa6:7165:504b with SMTP id a640c23a62f3a-ab2ab709c3bmr1784049566b.31.1736767922025; Mon, 13 Jan 2025 03:32:02 -0800 (PST) Received: from [10.81.35.177] ([46.149.103.10]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab2c9646c51sm494684266b.172.2025.01.13.03.32.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2025 03:32:01 -0800 (PST) Message-ID: <09807556-46fe-46ae-ae3f-7083a1b12253@citrix.com> Date: Mon, 13 Jan 2025 11:32:00 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: riel@surriel.com Cc: akpm@linux-foundation.org, bp@alien8.de, dave.hansen@linux.intel.com, jannh@google.com, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nadav.amit@gmail.com, peterz@infradead.org, thomas.lendacky@amd.com, x86@kernel.org, zhengqi.arch@bytedance.com References: <20250112155453.1104139-12-riel@surriel.com> Subject: Re: [PATCH v4 11/12] x86/mm: enable AMD translation cache extensions Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <20250112155453.1104139-12-riel@surriel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 904D7160016 X-Stat-Signature: fkjauybb4cxa9twa3ofw9pm96cqx16xz X-Rspam-User: X-HE-Tag: 1736767923-819122 X-HE-Meta: U2FsdGVkX19XQnSIYoh6JG/5itBx2L9jc/Bkc9IwEG0cyDZ4Alj/NG85ivQuw87I+vrRDjYvbYwOlMlsaxQXi6icb6qYFY6dQlTULf4lVX4kuwSzjtWdwIp2/GKNCHLqTMrySjElW/4Rx1nEtAKOjy+NrOqOyrMZPoa0AgQiIZhiXpwx9z6Pp8zQJij3T8e94R00UnzCmCmcoAzLKUHRtz4Lee1dgh9b/jtYDcy7UL9B92gJNSVOYRXzpu6k/d9dr2D0608eNipCSLluo+bknXWBu09/uow+xapXSqTKiCDAvo4luqOZvupAoZN5TNR6nCbnEoW8z84z1V7/vjXo0PajwfzmzgFo7/DVRP8jk+FZ9ssYib1A35dwZeTjG+gYSeviyrmeO+O1MwpSRN2MJ0+NtrlwkO2jIR77YBv9UWpG4w9L3rufv5pdOLJmrGfJ/4vBwzUTRn+ZuiZ/w0+B7dZ0eSslYtueBF7cJSfm2ryhEHq5hqp8vRdIxqw/hQ4+QUcfYvZTbul8UOl2RYQ5vhQg1KAhCpDJerwQdem/hRC92CPUqKRIFYVYU8lgZ1gOUDoizo759hlchp1SeBxQjgCIwv3AH5RbMlqwP5X6Oohrzlmxm+efnPGuoR2GAPPxxox+q+kbFouWfyzpWcZ3G+4UrZqefjkZNg2lGk3LJxc2gcTbcLHxD4UCpgWcl/DmMowjOOxMYBa3rDB0goEdUMnmeoAnOA6+reH2fTD7qldPB+Pt26VE+mKS2QGe60UmMCef8PvkW8Ps7E0JOQ9GFNPz75raLsyx42IeYMnfIPkbjQ8eTUXzS+GN0MQkGF6Q0Me8Wr9WNWOb2yEvxwtIb3GlY2o/PIXkrkAQU94o27cYBXKnbFA5tFrf1SHVVShOx9CAUnBypl2V/Y4tsrxrQof4rSWYbmklJBlTHBME1aba4kfEFaBNHa4nVAi52QIQzrnYmqp/5XGSDCSIfu7 OKUvIHwO r9PAIz7q/j/C0Moav9/TC6UCIDvsDpbnapSzIfsDW259y/D45XK06hVVm+NLomtwSuBnOFfvBRDP9sXiXBnwwK+N2+2ePcfAG5kJqwaU+rnVqNLR3+N82Jt/asY51KN0/hAqXRcN72I3s/o8kTdho2lrxzRTrEtyjdFir1Y5HH8+AAT2SfXO2ZmDX0rWBk+FacqJaItkbaJ8Fe6IN0Xhil0rAKtkeftXQsZt6l2qTKVFOkMj5Tcy1HlqlA3yRFzQwi5RLSrSniap6+eBwJTkh90xOkBH5zdQrcGFtf5O7trXWJn100LnxaS5X9KsHqIsr75FcNFrl5vVKOo8BmAZtQOzbEWBp1O1qzTP0JI1tEYT6q9PYSMLWDfhWe5qSZWwhAG2TJ+EKY1qriVEw9G9kJGL6ceVoHo4HX5YX8GWHbM9GrsEYvCgYemUMjMKBDSbNcilkFDi4b2MTAobdZoobJZZZVurzUqSEcVqUy9q6yP4Vbf1lW1f3VSQlSyxnWK6sI+Dy+We7uG+zg+0b0g9mtiSLB9dABxhi5YY2dfBPggXLw4kyweAD15iUZkjfb5D3eQCYQTJkbVGism4lEjQgXwrBDK9oLAT6x3LW6TwzfDO+7C3+mMLUJhzlY1CGsmuuAQ2sld+DRmOiF5r6439Q1O7evd1hGZSliKM7sZWaUqrFqJTUhAqtn5CeqxkDhpak/nrxrvqIO6CeHwW9svo/pMFTQQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > diff > > --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c index > bcf73775b4f8..b7e84d43a22d 100644 --- a/arch/x86/kernel/cpu/amd.c +++ > b/arch/x86/kernel/cpu/amd.c @@ -1071,6 +1071,9 @@ static void > init_amd(struct cpuinfo_x86 *c) > /* AMD CPUs don't need fencing after x2APIC/TSC_DEADLINE MSR writes. */ > clear_cpu_cap(c, X86_FEATURE_APIC_MSRS_FENCE); > + + if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) + > msr_set_bit(MSR_EFER, _EFER_TCE); } > > #ifdef CONFIG_X86_32 I don't think this is wise.  TCE is orthogonal to INVLPGB. Either Linux is safe with TCE turned on, and it should be turned on everywhere (it goes back to Fam10h CPUs IIRC), or Linux isn't safe with TCE turned on, and this needs to depend on some other condition. Or, is this a typo and did you mean to check the TCE CPUID bit, rather than the INVLPGB CPUID bit? ~Andrew