From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9663FCA0FF3 for ; Fri, 30 Aug 2024 13:44:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C469E6B0152; Fri, 30 Aug 2024 09:44:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF6F06B0153; Fri, 30 Aug 2024 09:44:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABDFA6B0154; Fri, 30 Aug 2024 09:44:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8C4AC6B0152 for ; Fri, 30 Aug 2024 09:44:10 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 20EFCA4B2A for ; Fri, 30 Aug 2024 13:44:10 +0000 (UTC) X-FDA: 82509030660.13.7878FC6 Received: from mail-4316.protonmail.ch (mail-4316.protonmail.ch [185.70.43.16]) by imf29.hostedemail.com (Postfix) with ESMTP id 443F7120009 for ; Fri, 30 Aug 2024 13:44:08 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=proton.me header.s=protonmail header.b=O2k0hWVq; dmarc=pass (policy=quarantine) header.from=proton.me; spf=pass (imf29.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.43.16 as permitted sender) smtp.mailfrom=benno.lossin@proton.me ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725025348; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=djdNbVmrsW6hw8WUj/Mlg46zFCWw3zbmK3wHUsqxZrQ=; b=ba1t+lqFFnfiwRpdigmPH7Dl6oAq8oIa7CXoegLfNZc2lijl4uaFdcV+z/vbIJTY1K40DB L/ro9IvgZB2NgMjR0MP5pUqauMnrEfBkUxz1FLn0Y8c2ES6yxyFJqktw+nV53O/5y9myWV qE6r/MINoNIvfDcRWde6rn+2W935L1s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725025348; a=rsa-sha256; cv=none; b=RBTOIy+sxTtU7dIVCKbo+zssOJXiSAgzOkdNh45IkJCyttj4ZirmLAreZgOdbXsnrYkCUh qfof5Hq/d/jghCO2nf4H5A+378VEqYPxRe0KBcBBL65Rw3gEFauBAOM/gBUzWf9uWKUKaS 0SEucGuKnTqRvU6oMw2Bx541wMVeH+Y= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=proton.me header.s=protonmail header.b=O2k0hWVq; dmarc=pass (policy=quarantine) header.from=proton.me; spf=pass (imf29.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.43.16 as permitted sender) smtp.mailfrom=benno.lossin@proton.me DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1725025446; x=1725284646; bh=djdNbVmrsW6hw8WUj/Mlg46zFCWw3zbmK3wHUsqxZrQ=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=O2k0hWVqhq8TMzWrtg0Zx0rjM0N6EwyUo9dJeYEnA44tPUt5JAS+yn50H1g8isKWX GjQ+4FBomSLb157NXqpBlaPCJhDpHTVvBuMndGSVBZ8+vrV6JOtQBfqT5JAKwMIe6L 5gLRnxGCOgHWBEJpywLas+0m0L/steoQEJmh6uoUAi7EyQ4mPDo6BY7Zaq1pDR9c33 FMRjfenAzeWAU2SHKk+20FyAxUA6c9Dlg17E8LABBcNEjABAblNN0I2bVPipujitMo c25uNvuV2VtwtXUrd+rvok6WCxSgVg+mx/noG3ojDLBI5dplLGMzNiPJWpug7tz/29 s4lRbFT7wWPyQ== Date: Fri, 30 Aug 2024 13:44:00 +0000 To: Danilo Krummrich , ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org From: Benno Lossin Cc: daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v6 01/26] rust: alloc: add `Allocator` trait Message-ID: <097db593-d25c-4a87-97e1-b7214b4606da@proton.me> In-Reply-To: <20240816001216.26575-2-dakr@kernel.org> References: <20240816001216.26575-1-dakr@kernel.org> <20240816001216.26575-2-dakr@kernel.org> Feedback-ID: 71780778:user:proton X-Pm-Message-ID: 22877c4c02f7adf62ef126904bffd48369a0b00c MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 443F7120009 X-Stat-Signature: zdpb9nsijgijhub4b88nd7zytrsbqdch X-Rspam-User: X-HE-Tag: 1725025448-199096 X-HE-Meta: U2FsdGVkX1/wPS3+cH/Qmk31lk5/IGqa9SGcCbq+faK3wZpcJK4919MlJNOk9tP3qf+XCFNLZpx7ZXyG5NHE4FCn6aA8U5DO1UQhp3AFNoeOB4eirntmj4aeEMkzwI4b6e6/8/R7IRnaHqv1zk/CRTnU2wSdQPfIz49jGYsm06f26L3SMEKJEJWbJ7QQi0Bom4+szej7tjGaky7Oy/5qLkoq4JRxoSpZQG38lH2easNK7m+jLEaTCF+Y+S3MGPFTLpLMujeYkbgPuubSzI2bIItcQ+JrLThEJom8SavyPjt6rJc2bg3atMm+kzVMWqAkxpufk5/aLUxOMszItAzyLTE+U/0f3RLDdCWkfCkZVeEWxL6mJ8QYkuryqgdQk0HJqdhvvHe6ZvQNtrh/fkMgtzhqz8/0Nb3eRtdeEXB8fCqYxOQRVMzq2PoE8DIBnDDshDG5vAwYxZh0yrfJ7XzkPHYzytmU/nCOU5l9PAG8wvjEHpjJ+uJm7WzMK9P84pA5nMYPESlmoTdk1xejY39iUc3f9Ca0IMpuBPzeOAIIde5IrZTXq47OPQLe3218R1zf0MiTBi43iaY4cJYr4CuECLfVsHK5nsWq7VAf399Y1V3bzVmof01ZLLoEHmVErXwRaVvN1nx5KwyNczai/o/MB02ZqKT035ogZeQGLXrylYu9GcjIC6jgbV7ZRXr4XHb1C0q7pCphAl+huPA3YPYw+AftS3Z02YZKqvTUZyRIWRnJaq9EFn+pHfWx0qsGf3e+DkG8uQjc2swCwVaDjJZtJEfbwxv/EmVtImVGdnSKjA7F3duLYooQw53sLF4jeRExcr5Bc5o5R3DNQAFkS+H9w1iTTF6oqmuLaaPYnh4rbr1AXavuaXkZrg0y6nSW0xMzYJxTQabqA9St8V8/5A+gi2h6Xg7JP4IsO+e4OjzVLYUIa7Q0qRtdMK+OPmX0RJuAFy2Qb8U8B5Y3G82yDGP nq3BhUhi vSUgMcLiS9QQwkSXat/Z3MkLumzLui1YxnbvXa2L2e/X6NISCrcXHEV/gr1HxiwN3koR2+59i6WNMoktKJ3FThiTlMiTzHjtsnLRhdRm5cAxtCmiim55kZdpkqEHvFDaaYxoch5L9d+ke0BiMBRwfeyITOW+h+kjEk9pG/TU8Du3d1caz6A1cpzJ1JSiDZCN1TJHVNno+jnmxadTfnQsIQ7S1PatVYkEa24+BOxCpazFDhrjFuIGuUIKz99N8lMs7yti+vwiRCQmmyyWo8sQ7i0jcRZ8lLvHNaBAGb6W1u3VcUHhhzKY/nq6ch3qmDcYIjS1u1jefLaAHU7YnsHa/C3mYiw5YLhKRr54m0ktgqTAlqgixKIIzp3gg8+i8bx+j9Ldu X-Bogosity: Ham, tests=bogofilter, spamicity=0.001153, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.08.24 02:10, Danilo Krummrich wrote: > +/// The kernel's [`Allocator`] trait. > +/// > +/// An implementation of [`Allocator`] can allocate, re-allocate and fre= e memory buffer described > +/// via [`Layout`]. > +/// > +/// [`Allocator`] is designed to be implemented as a ZST; [`Allocator`] = functions do not operate on > +/// an object instance. > +/// > +/// In order to be able to support `#[derive(SmartPointer)]` later on, w= e need to avoid a design > +/// that requires an `Allocator` to be instantiated, hence its functions= must not contain any kind > +/// of `self` parameter. > +/// > +/// # Safety > +/// > +/// A memory allocation returned from an allocator must remain valid unt= il it is explicitly freed. > +/// > +/// Any pointer to a valid memory allocation must be valid to be passed = to any other [`Allocator`] > +/// function of the same type. > +/// > +/// Implementers must ensure that all trait functions abide by the guara= ntees documented in the > +/// `# Guarantees` sections. Can you make a bullet point list out of these three paragraphs? --- Cheers, Benno