From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1168CD11C2 for ; Wed, 10 Apr 2024 11:53:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BA8E6B0085; Wed, 10 Apr 2024 07:53:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 645346B0087; Wed, 10 Apr 2024 07:53:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E5E56B0088; Wed, 10 Apr 2024 07:53:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 23BB96B0085 for ; Wed, 10 Apr 2024 07:53:31 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E4D471207F2 for ; Wed, 10 Apr 2024 11:53:30 +0000 (UTC) X-FDA: 81993462180.15.F191EBA Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf21.hostedemail.com (Postfix) with ESMTP id E4D1B1C000E for ; Wed, 10 Apr 2024 11:53:27 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712750008; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0U90kkyaj+lllCO2bfRFuDZ/zALRBKLfvX5q2ml6FCQ=; b=ouq42W9pG/R+DG0lQ0ht0FtHDiZMP5dtDs53Du5iAG82IMbvqCwNOnWewVLZ+ot4SpRRAE SKnuA1rPs/q60boI16h+zxkd1bTzlsQEgZNKFmfalZzEdlcNedbEI6PNTJzPQASIgd7tti nIoFNNCF3oaOLTabPwIhR07+UvI1zZo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712750008; a=rsa-sha256; cv=none; b=4BC+TrSwWanuKLAZx11OQ+u39i/1ilNqpZTRq20cdyu3GSjedZEukJo/qGH+jJoJ4XSFik RTDiZrz/nplJYh85cf+oI+o/yE2q1Jgj+ELQQC0R7PtmTBte94hpynaaoSA/AuMXUTPpK9 lt6exwlZvo1dmBc5U3csBqGPHH5Hnbg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4VF1PQ6LmwzNnWf; Wed, 10 Apr 2024 19:51:06 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 12CA714037D; Wed, 10 Apr 2024 19:53:23 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 10 Apr 2024 19:53:22 +0800 Message-ID: <0977b553-b0ae-4e4b-8cb4-007204381c0b@huawei.com> Date: Wed, 10 Apr 2024 19:53:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: mm: drop VM_FAULT_BADMAP/VM_FAULT_BADACCESS Content-Language: en-US To: Aishwarya TCV CC: , , Will Deacon , Catalin Marinas , Russell King , Andrew Morton , Mark Brown , Cristian Marussi References: <20240407081211.2292362-1-wangkefeng.wang@huawei.com> <20240407081211.2292362-2-wangkefeng.wang@huawei.com> <681e3bf8-dedf-469e-8fd3-0a67b8e6e625@arm.com> From: Kefeng Wang In-Reply-To: <681e3bf8-dedf-469e-8fd3-0a67b8e6e625@arm.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspamd-Queue-Id: E4D1B1C000E X-Rspam-User: X-Stat-Signature: n37zng3w85s8t6cfdnd96i7qye679d6o X-Rspamd-Server: rspam03 X-HE-Tag: 1712750007-401885 X-HE-Meta: U2FsdGVkX18klDThZMR5bxD87hJU2jzryHjCXS41T9V/GCRqu8Rhvzp5+/z6SUSA2eHIOEZmwimpyRQZMmXfl4d/CcFpXrFFzJlz/4zhsHkZitDzFVENI1FFsyaqZW6uG+FaSpLjlX40NoKLzpIVf88p3xcfwn1kejkVQeOaHLDlwVyskER1Z+wwRfrbht0g/jSOTh3e3Hvu683hkhrawIsYYQ+g/5CBeT+yjyYGReQ+Hqvfafm+eSYed5pf6kni1YilyzDSD+Y1/4qthBncJb++FaVakN4w2yTzmV74qTG9IJJcp1lAJopAT3pe3MuNRUzkLOxjbYDkLrBn8JfIn8mtwHMWp/LJFIpogutWVXhdeHe2yYdJoaytZvFu9MdFb5UigF7tTOje6V7uZTWTEex1sBiax/oqsiCHkvUMdfBOwaeSatwPWgkf3Ck+Vvzt7mcCpraK6xaX7xh3Vij5KPl1v0h1cb9Utsqpjn8VRs9jGmhLeaVM/6NnOJlxrSkyWRzGESyxlK2ETXKzWIr5oEaB9lhzjhOIHTIjulvv4YgR2Omcb4d1q04zem+PkBhgztnKI6p8KZcwyJvVi6JSXn9Kvj0aVQraSwGKRqcPiVneGEYeNJYEGUdFajYVSXhgy43rQUbekN4c8UkpAm/dV8JavhMiT79Rd5k5w18SLcMbVDTQXCTma9NCDLgqyheotfkIFhc2YvgN6MO3+GQ6LvAVoJ6iZu7IvX/wszrty80raPvsaZgdbDWYJEubfBNlacl6v/AIXQW8Ww4KGbdfQAwvLR0j91+VIdyNTxkbQ0Ls/btESFKXFhyJY1DDgaFEz6rB0WOn9ry4YIRsL4TDIbmQT4pE773Ywbn9/9gVzIEuwg8E/fMNLSvnQGRyRGmZgvblw6z/6ajLpxzRbZ8Mwz+d++YYW9n/sbDygUpuXPRMNrwoz2qBHzrNJ7DF/wRBXvxNE+qxhvp9O36r/xk qWw5+6Tx x2feAiqGGThcFxMZ3cuGZ0q8mWnHmTEdpwXxqVTi5QWvHkI85u34YrclV21QqUm81Ce2WTUZG7nzxPbCq61CDiFGcPqZa/tfnqigw5qU0jL0tVqKB2yRPi/YYTeZ3rqKEEsUKj1IOL4eNe9HomdQbtHccgCjhcUhyUKE6Uw6tUNMVCjTvhh8wF1TPobg5zw6t8C8roucrrzmms9iQ+qBblPRxLfvy3ENrJBWOMqE7w2ymUuKeuLwF2gGNQvadbfPGVTtc1OIZxQoyAVMxC9nFOu+4uu6Uz3z42pFJ0C8TOWFACn8WGoGhr2Obs5I7Pl9AfCpjJOzHmMlM1uc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/10 19:24, Aishwarya TCV wrote: > > > On 07/04/2024 09:12, Kefeng Wang wrote: >> If bad map or access, directly set si_code to SEGV_MAPRR or SEGV_ACCERR, >> also set fault to 0 and goto error handling, which make us to drop the >> arch's special vm fault reason. >> >> Signed-off-by: Kefeng Wang >> --- >> arch/arm64/mm/fault.c | 41 ++++++++++++++++++----------------------- >> 1 file changed, 18 insertions(+), 23 deletions(-) > > Hi Kefeng, > > While running LTP test suite, I observed that few test cases are unable > to kill exe when run against next-master(next-20240409) kernel with > Arm64 on JUNO in our CI. I can send the full logs if required, but it > doesn't say much. Sorry about it, as Catalin pointed, there is issue in this patch, and I replied today, could you help to test with following changes, many thanks. diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c index 61a2acae0dca..451ba7cbd5ad 100644 --- a/arch/arm64/mm/fault.c +++ b/arch/arm64/mm/fault.c @@ -604,6 +604,7 @@ static int __kprobes do_page_fault(unsigned long far, unsigned long esr, } if (!(vma->vm_flags & vm_flags)) { + mmap_read_unlock(mm); fault = 0; si_code = SEGV_ACCERR; goto bad_area; @@ -632,6 +633,7 @@ static int __kprobes do_page_fault(unsigned long far, unsigned long esr, if (likely(!(fault & VM_FAULT_ERROR))) return 0; + si_code = SEGV_MAPERR; bad_area: /* * If we are in kernel mode at this point, we have no context to > > A bisect identified cf0049a15207a5a78798105eff789c2025bcf652 as the > first bad commit. Bisected it on the tag "next-20240409" at repo > "https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git". > > This works fine on Linux version v6.9-rc3 > > Here are some of the failing test cases in LTP quickhit: > ----------------------------- > chdir01 > link04 > select03 > unlink07 > > > Failure log: > ----------- > 06:06:49.288908 Test timeouted, sending SIGKILL! > 06:06:54.293806 Test timeouted, sending SIGKILL! > 06:06:59.296872 Test timeouted, sending SIGKILL! > 06:07:04.292044 Test timeouted, sending SIGKILL! > 06:07:09.290185 Test timeouted, sending SIGKILL! > 06:07:14.295134 Test timeouted, sending SIGKILL! > 06:07:19.293279 Test timeouted, sending SIGKILL! > 06:07:24.292405 Test timeouted, sending SIGKILL! > 06:07:24.292790 Cannot kill test processes! > 06:07:24.296564 Congratulation, likely test hit a kernel bug. > 06:07:24.301315 Exiting uncleanly... > > > Bisect log: > ---------- > git bisect start > # good: [fec50db7033ea478773b159e0e2efb135270e3b7] Linux 6.9-rc3 > git bisect good fec50db7033ea478773b159e0e2efb135270e3b7 > # bad: [a053fd3ca5d1b927a8655f239c84b0d790218fda] Add linux-next > specific files for 20240409 > git bisect bad a053fd3ca5d1b927a8655f239c84b0d790218fda > # bad: [4eb0063b031ea720cd8971e3e3d2426d27c5d7a6] Merge branch > 'mtd/next' of git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git > git bisect bad 4eb0063b031ea720cd8971e3e3d2426d27c5d7a6 > # bad: [24dde11bfadd5f38c6cca3cea6f16971bd10dc86] Merge branch > 'for-next' of git://github.com/Xilinx/linux-xlnx.git > git bisect bad 24dde11bfadd5f38c6cca3cea6f16971bd10dc86 > # bad: [bef23348d7e75c502399ba1a24627aa447b816dc] Merge branch > 'mm-everything' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm > git bisect bad bef23348d7e75c502399ba1a24627aa447b816dc > # good: [3317f7faabc24b500c26d02615ac75ca2786e272] mm: swap: > free_swap_and_cache_nr() as batched free_swap_and_cache() > git bisect good 3317f7faabc24b500c26d02615ac75ca2786e272 > # good: [541970e62546ff5c96622669f2796d43b1a406e3] Merge branch > 'gpio/for-current' of > git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git > git bisect good 541970e62546ff5c96622669f2796d43b1a406e3 > # bad: [1df265717e0f9d96079073189f6e6c52a48e493c] > __mod_memcg_lruvec_state-enhance-diagnostics-fix > git bisect bad 1df265717e0f9d96079073189f6e6c52a48e493c > # bad: [19ab4054346474c2b456f9bff6a98e41e5e46224] hugetlb: Simplify > hugetlb_wp() arguments > git bisect bad 19ab4054346474c2b456f9bff6a98e41e5e46224 > # good: [75ef450aa9828ca20817c46c5b99f131156f6eee] x86: mm: accelerate > pagefault when badaccess > git bisect good 75ef450aa9828ca20817c46c5b99f131156f6eee > # bad: [c6b5a19e679bb713efd57d82f9080f780e0bb60a] mm/treewide: rename > CONFIG_HAVE_FAST_GUP to CONFIG_HAVE_GUP_FAST > git bisect bad c6b5a19e679bb713efd57d82f9080f780e0bb60a > # bad: [01446d1e9e627945664f2a1daa53e8720946d0cd] mm: remove struct page > from get_shadow_from_swap_cache > git bisect bad 01446d1e9e627945664f2a1daa53e8720946d0cd > # bad: [8f9d6a30dd992c44debea3161083a6c2cd3ad87f] arm: mm: drop > VM_FAULT_BADMAP/VM_FAULT_BADACCESS > git bisect bad 8f9d6a30dd992c44debea3161083a6c2cd3ad87f > # bad: [cf0049a15207a5a78798105eff789c2025bcf652] arm64: mm: drop > VM_FAULT_BADMAP/VM_FAULT_BADACCESS > git bisect bad cf0049a15207a5a78798105eff789c2025bcf652 > # first bad commit: [cf0049a15207a5a78798105eff789c2025bcf652] arm64: > mm: drop VM_FAULT_BADMAP/VM_FAULT_BADACCESSgit bisect log > > > Thanks, > Aishwarya