From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A46CAC636CC for ; Mon, 20 Feb 2023 11:21:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 352876B0071; Mon, 20 Feb 2023 06:21:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 302E26B0072; Mon, 20 Feb 2023 06:21:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F2106B0073; Mon, 20 Feb 2023 06:21:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0FC426B0071 for ; Mon, 20 Feb 2023 06:21:15 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EC74AA0FB6 for ; Mon, 20 Feb 2023 11:21:14 +0000 (UTC) X-FDA: 80487428868.20.B77F444 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id BC601A0010 for ; Mon, 20 Feb 2023 11:21:12 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hrdOBgHC; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676892072; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3eNuSXSMwT7K8lYDjXpFROOa9BiqxQfFrSmx+/FDJAs=; b=WxVkQwwcPQvYG81QpLLGvoQ66Fzo4W1qkxr3nJmm6iOQdy/YXe7DMBdYHiFpzKKAk3ASdh dL9FQ4OHtjstuAKlo3cAwz61kun/zaXLhdnsSvBeqemIGXAzd7aH7YV6agOsiVfuZ7Uyf5 VzeV/7v3yQtxWCjVHQ6es0TlAxi27YU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hrdOBgHC; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676892072; a=rsa-sha256; cv=none; b=vo/REHcyFFD9DLHgq5XB+Sowo8IsQGqtkUzCCyuijnC/gxLy0E8SMwhnVBZL3yZXpmlJUI CY8G68YMMo0lU9MQmpbxR0Bs25e6NCZt5IYJ2u1pmmLzsLMVEO8kFS6NXkMBrLhHjR42ua E8gpolvxKeK3kBPACi4cz5z+fHE78dw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676892072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3eNuSXSMwT7K8lYDjXpFROOa9BiqxQfFrSmx+/FDJAs=; b=hrdOBgHCOFlLCMoT5kI9Q3NPT7s/a7E05KyZyNB+Q3Jz9E4LrflROFPqNXySC4onZxEzb0 a9+qoeQ3LpIqUqV0qXV2CNS91U9ScEGvjCWrrEFtOraNSrDCFJHaJu3HUJnREA995x7fVP G3yB/4NqRH0inwNth5jR6jp/NazJOHU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-231-UOpvzwlyOeWc0wbDxqF7xQ-1; Mon, 20 Feb 2023 06:21:10 -0500 X-MC-Unique: UOpvzwlyOeWc0wbDxqF7xQ-1 Received: by mail-wm1-f70.google.com with SMTP id z6-20020a7bc7c6000000b003e0107732f4so478044wmk.1 for ; Mon, 20 Feb 2023 03:21:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3eNuSXSMwT7K8lYDjXpFROOa9BiqxQfFrSmx+/FDJAs=; b=WP1Qxb4UpDlC69I43fmBMwiPbgMA2ULZMO8Zc4Mx49aXHVSZyTXw6lQXOFdGx4I8Rr K79aEw4svmdVLAeU1hzcgiUwnSajW9m3b9ZqrQeUAbHDek7kPTzsst/qVy72nBdXvGp2 hUNY2jQtI0MgsGusDVyPRwwBGUmiB+bmpqHdrCA4I2AS4ky2W/6M2HMWIzCAJyjw+wqf KHgCo5HQxMBJZ2MCnjv/ux41XQfUq26kkWKGlVhkaZWvT+eBOCMmSkST8AVG42rd0dI+ DowGiSDNddRe0sP4FLeG5BvZUQlgnBwD/A3YwtrTF27L1SDq2ZieJxYgs6ivW/pi82ES qImw== X-Gm-Message-State: AO0yUKXx1+Bq825fpU7UNxaTVMfqoeoUGiRGJ8GzAN2Rqgm6NcpyRNEL YF9sQa/CjwDMhjrqks3dNKoMgaJGwaFfWZwwDUmRCMSwAdqfVF8KN0wqhBqSAwU8PAwNcPD+csh asVYWaH3EHMo= X-Received: by 2002:a05:6000:1a4e:b0:2c6:e824:7a5e with SMTP id t14-20020a0560001a4e00b002c6e8247a5emr259003wry.34.1676892068737; Mon, 20 Feb 2023 03:21:08 -0800 (PST) X-Google-Smtp-Source: AK7set/WJC9Q7hUrS58bH3mA5ByqoqAxQkNSmCC79TeRMp7NDC+620Q0QJhNyWI/4bL39eZvdvEA2Q== X-Received: by 2002:a05:6000:1a4e:b0:2c6:e824:7a5e with SMTP id t14-20020a0560001a4e00b002c6e8247a5emr258956wry.34.1676892068356; Mon, 20 Feb 2023 03:21:08 -0800 (PST) Received: from ?IPV6:2003:cb:c705:8300:e519:4218:a8b5:5bec? (p200300cbc7058300e5194218a8b55bec.dip0.t-ipconnect.de. [2003:cb:c705:8300:e519:4218:a8b5:5bec]) by smtp.gmail.com with ESMTPSA id p15-20020a7bcdef000000b003e21356bddcsm14270316wmj.33.2023.02.20.03.21.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Feb 2023 03:21:07 -0800 (PST) Message-ID: <096f4fba-ec53-0035-02c2-0916833a43c2@redhat.com> Date: Mon, 20 Feb 2023 12:21:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v6 12/41] s390/mm: Introduce pmd_mkwrite_kernel() To: Rick Edgecombe , x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, debug@rivosinc.com Cc: linux-s390@vger.kernel.org References: <20230218211433.26859-1-rick.p.edgecombe@intel.com> <20230218211433.26859-13-rick.p.edgecombe@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230218211433.26859-13-rick.p.edgecombe@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: BC601A0010 X-Stat-Signature: zh37wee7nm37o9c3w6q1bne58y7odaxx X-Rspam-User: X-HE-Tag: 1676892072-618442 X-HE-Meta: U2FsdGVkX18EHqAaXu31nfxrcwQH7TX+0mvoUXa1EU2W9btwldZLs1WUQ3aksTMXdjygsHOfJkC8jBS4YFeUJ2hOvpHoB5Gdi84pzWP2F6Eb5mD2BQRXTY577yjTOEVFOr83Sz7F9GIfmnk6orkH/dJBhViDiReQjMn80Ks7Z09T32e+zETel81ssQTwoRlDig8+jzfe9r2MC17TcelzILehTcmRS3sDsCtyfJM78ccavgbn8ogS6aVuzcybtpc/mz1Gp38AgzbgHqw9twP3eV/wCZjDuavwzVcX1VUZ2thZ0pFQmuXFe7QXnc3lFmV9Cjlah2dd3lATBVznAFa5txsEkcecdmRks+DEpfwMyAL6N5lPTvJd3ce9GM0bwNMIYUgV3rZriBZw1kS6SHAlrktfU1TRO9Gp8zWHbCg9JRYgZGdryGROCTeU+Vu2iEXzaF2zI8WzcAm4pl7pRkOQk/KfDlzC4CyjPjDE3QxjVdMS34NhZWrEJbQROQJUEk2ZotecK7pmXKg88ZtsxhUUEtI4HZxHo2qeBz/cDzAo1iRZeNDE/r5/+PpeqSw4w7tA/XWv3yCDT0JjezxgufKvCYKqZuihVZ/HcS7i8XFiHK7jfcMxQ5RSEu/S49E5TY0tnNp++N2tJ7CmbxvCGzs5+ShVBDva5A0dW/uhuqx7moUIWUXTFs882nvP0niljdYOMXZq89l/Wg1+3Y/IkEVQLa+PCAvG7CSDxODlY00Wp7E4axp+KtseyEQRP956Mn+/lMkIBY35LnCY/60xrShtX0yic9dD7GgVEZUzsVPKkFddGKQOqQV7X5/LoHeTyyjexU/H/gzrvC6btH/hRdHcw+4or4GxoTPzI+ZxO/YwUQuKlGNrVsLcZQgjyGRiNsi3NdmfYdxwTzKTtipYwpfF0v2+5zL8mOpM4g3rhsaHJc78KwZU9ZmG0LefQshI3wT9nH0BKQ4A94R7AvzIQ8T oofWuh3c ribEaF0f0qgGmcSBG22oLghlWo4oHlV5yoYrQTypf0Pr/mMUh4pphR8Rx7fp6aR+T4xzqlW/ubgMk+DQhJzufT+U8qGZ4h+hTJINrvoCzNcsvQOWtj7ip/8yIJZ4+eJNfoG8Lbd+wvDj8NZ/xWJB80nXezbalU70hj4JrOBHDEpsPTd5arihyE/pj3+5Skn598QkJM3zYSc2n1F0AJvJn8q8iEdCNCsZ2zMkglCWujF3UDsco2G+PaXDQWGrEByRPGoi+YUrGv/qVXt8Q0NGkxFwmcK0Gkftw3pfN3tHE+roDHEyBKjs3c4i93eS0gDyr9ttD0Ay7+AkijI9CWXxTrikecAscoXSLZYcKy/TT2WEfelm+AFZ+JnTCXGLAHL9VQxOWzSu1JpTcY2V5wBfmk2NRYD+9c2dHB3DuAeLE1sG1pdMsh8yYAxulJb3TBbwfMJ2GlPr7b/yKt571bv6+AxcsknLCjrjNL9a4lRU+74riRANgqBED1VYg0cXSWI5SMQOLDmT4s0wrAciBzPVXKb+e43af0f6D8HH7VRNpYhnPFqQEknHEr8f0+Vgj5rKzVfy1VxLsQ63UW+E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 18.02.23 22:14, Rick Edgecombe wrote: > The x86 Control-flow Enforcement Technology (CET) feature includes a new > type of memory called shadow stack. This shadow stack memory has some > unusual properties, which requires some core mm changes to function > properly. > > One of these changes is to allow for pmd_mkwrite() to create different > types of writable memory (the existing conventionally writable type and > also the new shadow stack type). Future patches will convert pmd_mkwrite() > to take a VMA in order to facilitate this, however there are places in the > kernel where pmd_mkwrite() is called outside of the context of a VMA. > These are for kernel memory. So create a new variant called > pmd_mkwrite_kernel() and switch the kernel users over to it. Have > pmd_mkwrite() and pmd_mkwrite_kernel() be the same for now. Future patches > will introduce changes to make pmd_mkwrite() take a VMA. > > Only do this for architectures that need it because they call pmd_mkwrite() > in arch code without an associated VMA. Since it will only currently be > used in arch code, so do not include it in arch_pgtable_helpers.rst. > > Cc: linux-kernel@vger.kernel.org > Cc: linux-s390@vger.kernel.org > Cc: linux-arch@vger.kernel.org > Cc: linux-mm@kvack.org > Tested-by: Pengfei Xu > Suggested-by: David Hildenbrand > Signed-off-by: Rick Edgecombe > Heh, that answers my question to patch #11 Acked-by: David Hildenbrand -- Thanks, David / dhildenb