From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E6EBEB64DD for ; Wed, 9 Aug 2023 09:36:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F13EC6B0071; Wed, 9 Aug 2023 05:36:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC3C56B0074; Wed, 9 Aug 2023 05:36:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D64C78E0001; Wed, 9 Aug 2023 05:36:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CA0126B0071 for ; Wed, 9 Aug 2023 05:36:01 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 74BBC80DEB for ; Wed, 9 Aug 2023 09:36:01 +0000 (UTC) X-FDA: 81104059722.02.657D3DE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 5CAE51C001F for ; Wed, 9 Aug 2023 09:35:59 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OxFECfHI; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691573759; a=rsa-sha256; cv=none; b=yxkILdOQEdwkEv5u7A7WxN+L4rAG1uq5wbXz3Qe927IbHnOF08oPsilmgsnK10n6noqf7G hmbKp1gl0SjWV2fwMn6029/+u+WUzgpvH/j9NoN+XNkjs9yOBauAwgIT8wazg2FEE20rgz 2AwVa/dCogUA/z8cvzwnos4uoo9Qi04= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OxFECfHI; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691573759; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qOK1Et7QP5Ycdq1QvIRjlLOTQXbobujlUdPCjAQb+rw=; b=B0mzg+LzrwIKdgSXmhYyurzM1cPtTkjBKhF3DIhbZv5jhKhos0qf69Lh+dRjz+EQtnVb8F L/iyX/Xb8xnSVl+hKEaWTvVGf4JY5jB+OdkEbsYp8LtPpB/0Mf9BJ86PW01qTMDbfuoXDo q34I6iSrJukcgVqpxagPBq13h3uSrAI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691573758; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qOK1Et7QP5Ycdq1QvIRjlLOTQXbobujlUdPCjAQb+rw=; b=OxFECfHIBMas4GXex8PGGTfWH6OXUFeU9OoOhXBRT/7y/pZPTNZCTVfz/TohPSl9F66qCc BsE+7/A0IXOtgIzLphJuAsHCplIzTc9Z+BxSvPVo1j4NNs94kFBe2x9v3Gg8hOA/X9yTkx bNFXs5QKRflbW+RxHjEzAdL/qoCFM9I= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-433-NaokeGIbOOe6b_TMS5YIIA-1; Wed, 09 Aug 2023 05:35:55 -0400 X-MC-Unique: NaokeGIbOOe6b_TMS5YIIA-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-317a84a3ebeso387580f8f.0 for ; Wed, 09 Aug 2023 02:35:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691573754; x=1692178554; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qOK1Et7QP5Ycdq1QvIRjlLOTQXbobujlUdPCjAQb+rw=; b=djMeztxU92tgFBkfhYNrzHk5vTo0s/feXGqLvNsSyoyslPp0bEcQQMqcTgBMppnatU C8xuKvP6uhzwt3bC4qhenp45vM9MQULzd+MsGjWLHShBWqHmqI2Y0K/+tAnUQjqTqTB9 EKAn4wUvG0EYdypDq/7PIkDb4Sb3u2Q5Ke+opPIu7Zjc5C6zPXQUa3IDMkEifa3itpQ2 cuqv7u/QVcZdZVcIzNPlbnkH4mxyic/4Ty/1lMGny9DuIJCYXj87FR6WlNe2gXfOx1v/ IFNHRlRPE3xxK3aMBYLo+FSbICrF0pIZvypbpcnOAe75XYZLJiKtj8OCf0+My5T1VA/X NzuQ== X-Gm-Message-State: AOJu0YyaTjsdyUd7DX3GpWeybsdyPz80vLZqPRH4m8/JYHXnOOAoamoX zlGDUgxb4Lpsz6um7nzgMFNiJXgbXhr+VYxb7rkhxlYe61PEyLVy9fZnWAQhmYOObgOm2gPT7/k f1Iy+k/GSQoE= X-Received: by 2002:a5d:42c1:0:b0:317:60fc:c8d0 with SMTP id t1-20020a5d42c1000000b0031760fcc8d0mr10573884wrr.0.1691573754401; Wed, 09 Aug 2023 02:35:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHa8nYXbA0Ru81KqBdUdZ7o3CorIXBR1S9ugVFZaKtRoFc1+qbYruXT//e4KeNzEiCnuSM/+w== X-Received: by 2002:a5d:42c1:0:b0:317:60fc:c8d0 with SMTP id t1-20020a5d42c1000000b0031760fcc8d0mr10573866wrr.0.1691573753978; Wed, 09 Aug 2023 02:35:53 -0700 (PDT) Received: from ?IPV6:2003:cb:c70e:6800:9933:28db:f83a:ef5? (p200300cbc70e6800993328dbf83a0ef5.dip0.t-ipconnect.de. [2003:cb:c70e:6800:9933:28db:f83a:ef5]) by smtp.gmail.com with ESMTPSA id q14-20020adfcd8e000000b00314329f7d8asm16220654wrj.29.2023.08.09.02.35.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Aug 2023 02:35:53 -0700 (PDT) Message-ID: <0950ca9c-4f39-f56a-fee9-5ee42ede86e3@redhat.com> Date: Wed, 9 Aug 2023 11:35:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/2] selftests/migration: Disable NUMA balancing and check migration status To: Alistair Popple , Andrew Morton Cc: linux-mm@kvack.org, mhocko@suse.com, jhubbard@nvidia.com, ying.huang@intel.com, osalvador@suse.de, baolin.wang@linux.alibaba.com, ziy@nvidia.com, shy828301@gmail.com, ryan.roberts@arm.com References: <20230807063945.911582-1-apopple@nvidia.com> <20230807063945.911582-2-apopple@nvidia.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230807063945.911582-2-apopple@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5CAE51C001F X-Stat-Signature: jsoudn6rnyzwmqx6eykjz91cxepwtubo X-HE-Tag: 1691573759-545535 X-HE-Meta: U2FsdGVkX19VkBMP4G55K2RCf5UzLgvFTNBj433cvKVSONWvYg4gN64YCq5d+b4+3/a+5RtwXd5u1gJpq5nSCfR4Dvo2RHj/zUo8/63XymNaQhT0/bPf7/OGDpj3njG2xUvYUlb0+wPaL0iNotQmOfQ5YdVKpofcRTFP6tGfP0bmuxQ1KTMcu5o5+mo12G4Wn+UCPoVodVtP8gpvRTdmIoSDZVz7JPZX/iaUCV46GfOFBUdDnV9eZqmuYLa1BQ5vUIDRAR1cL4Lh0zWBq/r9TIFZe1JTl2ITrg6v/SR+MkZ/DxXoaM8TS8PEcDZliKFIwBKxD2CWlDCFE//B/V28lzP+iTt38RY2bbTp7B913bXMDhcyqHCwC0kQpfq5wS8svGOMS/zovw+rXbFurs5JkuYnJH/dt//UP5X8xoRLGDfxUCUqSgZGk3P7BMV5CRQofVjOvO10LYMQvDdsRDjqB+yCYKB6kF3Duh6YuJEBWtYqLyP1aO+Q0XXxNjkHiabl/VWSsQxUjyqR4NfjnU6wVOwNL7pwSLHhuBR+cwucOrAdKGJCc7wnFF1hrYnWB7+xf4RNkDuyQhE5GOgXguzGlIdRjCpQx9jjeR4MjDfektIfIGJWZP51EziiAjUJFMCsKYRub9O5y55QWn5xmQf9/3ldlFiUlCpeJm881AWPJ0WwL6vrYIOjwljnf9iqI1dpDMNWhxb41av3ZqFoPyp3pqDgQbW1v8NTsfBhL5Snp0NUFe5Pu3ZwYhJTcCOB7tZPoQah+uhv8BDtwGiaIZx8YiBOX+omvoxhc13AXnuNH2qc3v6R0GbRAAj04/jqSNL2afLsRQ1BvI6x6OyBuVefXBRhpehswHTlVsaz/+miaAH3s/oNTzPh492w2Ik/Ddsf2xUWzN2N0Ry0l1iXTykQL8b6iEtK/ELP4vu0m+nW8VexbhIeiY/97hREMkpBNzOw83iuRaoT80pybi3Zvrk 7cJvsYbT e/CXKysu/03hfwkSef/mdh6MdyhGzPr1SgqxT0vURPMVLeZubW9lpw4zJK3BE9FZRRFDBdYZIjmOUcJsjEF4EaBHDSFSaI5nN/VZL+QoDEvOb9swi0ytXaq/DTllggqxTnD0ae5OPvzI5p91P+tDWpKSD6FJ9D5gBATYetkN9LAbm/6d8OVTlJjMMRAU4IVlJ7aALqyHfvoy11sLNivBWlyzxMtLca271Jz+VaPOTPBz6CGq9vZQ1mhHO/m1PC56Cn3nlG7K8xCZBXnXxJyKzO7joullm1LxFyFjpAIFDcUW5DMZ13J/PIY2irNPg/qVK8uYQUUYe8/My9diCC/jVFSk4a37m5B88Q5zntmcznkKfJTPADkmVDXadcZN1I05iJYRRKO++Y6ZqZoPy8aS+Daj091r6pAFW1qLbN2PvQLmZ6xa/49XRff4Tmg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07.08.23 08:39, Alistair Popple wrote: > The migration selftest was only checking the return code and not the > status array for migration success/failure. Update the test to check > both. This uncovered a bug in the return code handling of > do_pages_move(). > > Also disable NUMA balancing as that can lead to unexpected migration > failures. As raised in a sub-thread, is that still required with the mm-unstable patch: commit 3c471b04db7604974e3bea45e2d9c7c27a905536 Author: David Hildenbrand Date: Thu Aug 3 16:32:02 2023 +0200 mm/gup: reintroduce FOLL_NUMA as FOLL_HONOR_NUMA_FAULT -- Cheers, David / dhildenb