From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DB64C433DB for ; Tue, 23 Feb 2021 13:20:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 09B5B64E60 for ; Tue, 23 Feb 2021 13:20:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 09B5B64E60 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5F1F56B0005; Tue, 23 Feb 2021 08:20:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 57B5C6B0006; Tue, 23 Feb 2021 08:20:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41ACA6B006E; Tue, 23 Feb 2021 08:20:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0101.hostedemail.com [216.40.44.101]) by kanga.kvack.org (Postfix) with ESMTP id 2B6796B0005 for ; Tue, 23 Feb 2021 08:20:37 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E14FD82499B9 for ; Tue, 23 Feb 2021 13:20:36 +0000 (UTC) X-FDA: 77849592072.06.E45B34B Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by imf27.hostedemail.com (Postfix) with ESMTP id 6D84180192F4 for ; Tue, 23 Feb 2021 13:20:30 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11NDJEuU053020; Tue, 23 Feb 2021 13:20:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=S3lKwN2lydh3NmIBkz4R5YsQqPHZQDgZQ9v6rjiqsvU=; b=sWhqF4tUvIzIt3nm9/zN9dtVG9OiNEarYB/U4nrIgWtvj/Nsf8UrRKgwR5lOphGeFWUd xcK4rkhGDYX5ukZgu+DmCH70bn0d+DLZe9I9scDKhONA3OM1mdV+PLqLSxFh+SKMXGVX NxfrkMW2GmsCVnDC28p/17+N4x9thImmtig9bVd555ch1pmROOa44rCdbBZYsJ9zHCx8 JJZm3UeCHYxBr9BOnbTSreV33YUekJZSSZRyRMZR/r3/teIKAYm1j0hqlIx1U9edJXPS 71y226Ym6+MJPF7eBWdPB2c90h15b6w7f1Bg+1eCd/4Sau1rKLeI/mv9laxdUMiabl9+ FQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 36tsuqy6dn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Feb 2021 13:20:32 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11NDKTXE123351; Tue, 23 Feb 2021 13:20:32 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2047.outbound.protection.outlook.com [104.47.66.47]) by userp3030.oracle.com with ESMTP id 36ucbxetvh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Feb 2021 13:20:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iMZVcfNfC/g4hCJDtrIrspkK4Is895+DYHDufkDV4rkOHJuVC1V6P5TiK0s3kUJE9Or1FlQEW3s6TeFDmPQXZZGuACF6QSFNMezAJhGU3Rw0mXhLxfzI2MafPbSiiCckAPVOOporWBFr6qjTC2UN1rLS8mKq2wbZfqwpPt9GsmIg/FD+Rr1xAEF3hyO5Ly9Wk8dXeeNE1kuE1nAT+qvXcsmsxR29aEIKxF3DEL38c2gkLZ0Pq6eYk7RtI7JUA54RGTnbBgLx/VsqlRkcaoSTBTA30o0mte73S9sWyWCp6fZTmN3E64U9Zl+mFyLdqcNQBwVgBP6+LgTRrcb4Fx/d0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S3lKwN2lydh3NmIBkz4R5YsQqPHZQDgZQ9v6rjiqsvU=; b=enJqYbLC5AjXR0JsgEBm8rm6yPXmKedd4dzprFavGBUlonysnbJjMIpsT2wWCct1PHZGioGsgxBhMvvKmzKTaUExIQ4Yr89SWTj9gAoFvUbO/uvsHF97RgUYV0o+iOjv4IvvMfM2pv1OpVWYtT1zWuVT6kCx7okUDgJahymYtKnzFyxBsw3yQvklzAstKSNpfU3EynkjIBWGu3q1n3LnLTIPpqetW603eBvvuTqwPKFk6An8t9XTUUJgLKX4vyVMzlGVvJJIk3h24DvzAQKYESAayJckPzWeMMh9D+CIXvhxTFVNByCRaY/tTs2aBGtjX+jzqr3Jc/QyggizPPkmbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S3lKwN2lydh3NmIBkz4R5YsQqPHZQDgZQ9v6rjiqsvU=; b=NEggw/RbksQ1MP3A7abHf2k0c9urVeeOF6vCO4LmlBhmVIj+D7g+7HMscWIKga6cfiv5DyIK8E+cwFaBCPLfRnqRhazoUUgJvl+eC/+8+RahiLL2ImmRQoA5QG1XzSNK2NJ2aYEeox332EX/hDumVdf0bEoxLXKtiiZ6oAeyBxE= Received: from BYAPR10MB3240.namprd10.prod.outlook.com (2603:10b6:a03:155::17) by BYAPR10MB3061.namprd10.prod.outlook.com (2603:10b6:a03:83::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.32; Tue, 23 Feb 2021 13:20:19 +0000 Received: from BYAPR10MB3240.namprd10.prod.outlook.com ([fe80::7ccb:17c2:c957:65cd]) by BYAPR10MB3240.namprd10.prod.outlook.com ([fe80::7ccb:17c2:c957:65cd%6]) with mapi id 15.20.3868.033; Tue, 23 Feb 2021 13:20:19 +0000 Subject: Re: [kbuild] [linux-next:master 6931/12022] drivers/vfio/vfio_iommu_type1.c:1093 vfio_dma_do_unmap() warn: impossible condition '(size > (~0)) => (0-u32max > u32max)' To: Alex Williamson , Dan Carpenter Cc: kbuild@lists.01.org, lkp@intel.com, kbuild-all@lists.01.org, Linux Memory Management List , Cornelia Huck References: <20210222141043.GW2222@kadam> <20210222155145.50e2d513@omen.home.shazbot.org> From: Steven Sistare Organization: Oracle Corporation Message-ID: <095094b6-f0fe-1c7e-4926-bf1872ddad6b@oracle.com> Date: Tue, 23 Feb 2021 08:20:11 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 In-Reply-To: <20210222155145.50e2d513@omen.home.shazbot.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [24.62.106.7] X-ClientProxiedBy: SN4PR0501CA0148.namprd05.prod.outlook.com (2603:10b6:803:2c::26) To BYAPR10MB3240.namprd10.prod.outlook.com (2603:10b6:a03:155::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.92] (24.62.106.7) by SN4PR0501CA0148.namprd05.prod.outlook.com (2603:10b6:803:2c::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.8 via Frontend Transport; Tue, 23 Feb 2021 13:20:17 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 49cd2846-eb07-46c8-91b5-08d8d7fdc3ec X-MS-TrafficTypeDiagnostic: BYAPR10MB3061: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:139; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HRCOL+BfyxQOz5yXyFVFJJq+0IwZ4Zh4dDbzs6CCihUli3yl7uadW5LkwBC38Xw7sskmT/MAdjHTlc0bwCtYx+EJhc5LbDpTXVC82tDLtfnmM6h06lv3zEmYrSZWm96Du4OreRiUo0FhbiMcjvzzNmewYa5yC0Ujqo1TSCWaJGDbLiv8vaQiuZK6TumiVzm2uWMU1AD+5r6NoVssgC3FOIIr2faO3dkJuI+fobYjLVmdDQXzfH3j0qn89rNXD/7Y/TP/7Z7JL+zWj2e4L5agJP0WJQ8QT0wenZCBsss1Y/k8tXAqEceunlzr/JaqeVYOLUkl3xqhlf1jVLM7B99Z9IJ6bAT8OAlbmiDRcAWBH7g9dGSqJ2ROu/QG0Vi1DjImF228KJ4bnZXe8RXS6NUH7LhQU09TPmFTt8WIbw3Fp9PLYk2gLzInpm7LL04tYHAFvZxjKzOZSSNpdMtD79QYgK4mSrRYSnTzhkugE7OSQ2A/MZxE0PmAkDRx+0TL52KPTYdDtgAJERFIraNieAWRaq8MBRNmjW+lEVpCc6FsjTsbyqM2/KKRmzPH2r91IXaV/P4jpvZ/40V/BTxA7eyOFNwNn6crS8V/Z49IDT1n+WkPoWk9Ov+5kvy+q+qwBn/XYA52ewr/uVKjGM6qvjKDq9B2OzMlL1nWH33La2886FIJBJrGqSf5Xb6HkWIm1wPT X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3240.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(346002)(366004)(396003)(136003)(39860400002)(83380400001)(6486002)(4326008)(31686004)(8676002)(54906003)(2906002)(8936002)(2616005)(86362001)(36756003)(16576012)(26005)(44832011)(110136005)(316002)(66946007)(31696002)(478600001)(36916002)(6636002)(956004)(5660300002)(4001150100001)(186003)(66556008)(16526019)(966005)(6666004)(53546011)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?cDdaaDk1TFUwUEc3MkhJMW5YeXE1M2JQV3Z1SldPUU5VODB3dFhEQkZESkw5?= =?utf-8?B?N1E4T1QyQS9sSU1Ua3Z5UTMxMm1RZThSU2xOV0xSanBhSnJtLzNqbGd2dStV?= =?utf-8?B?c1RadTJCbnN0VG55WEtIbTdxcitJZ0Zpa2U2ZzZheEdZYXZ6K29FOXB4MkNw?= =?utf-8?B?NzFNWGxhb3grK29najNPRkpIdGZNakdQdU1jeDBlNTFodEp3K1d4R2oyKzFW?= =?utf-8?B?M2VZd3lkL0Y1TXdQcnc0bXhFa1laSmZLM2gwcUdPYi9MRVNqbTlKZENFMHVs?= =?utf-8?B?ZGdXM00yT2ozU3BuTXJYTy91SkJtYmJZbVZPZGhEMEJVb2xoN3FFQ2ZFeGxw?= =?utf-8?B?V1duTlhUWlhiV2hNUGl1K3dYSWZ2RHRYUkpHNVpDcUxJRHgzZEgydzNCSXlw?= =?utf-8?B?UzQ0aHpPRnlzUEZPWjVyVFFnRlc5S21CM1BvZk9Ea1pFZ2tKWVdNR2hUUmx4?= =?utf-8?B?V2ZjRmM0NUt5MEVYWVV1ZmU1NWdUUmtvNW9rRnB1cEVsU2M5VWNSQlBtV2tq?= =?utf-8?B?dk1jeWZ3Ymx2RDMzcHlZcVozdC92eU9wK01TbCtqVUwwb2ZtZ3lkTllPZW81?= =?utf-8?B?NDhXYWtaejdwV21QLzlsSDhXQkRqQWhWbnYvRFcxTVNhYnpGbmVoMHloUTIz?= =?utf-8?B?dy9jRUVmaWRkUms2dFI4UE5uZytaVVowbHZhc2wvdE9qQlFQKzRsUElObTNi?= =?utf-8?B?eE5rNUVOUWV0akdSL3ZPYmRBVTZpZG5WWndNQm5MSHl2aUxSc0RxV25GOEcv?= =?utf-8?B?YVBHY0hNTlJrMzdNdWhUQkFIdDVQeTcyNTJ2YVY2S0dPU0ZLYzREQXBJSFky?= =?utf-8?B?dGFTYnpHdlpNUzlxcXE2dFVWOVFzejBOci8wY3ZhNUUva2dHR0JVZEJsaE9p?= =?utf-8?B?VkExdVBKeFFabGJzYmR5SlpCaXRlams0S1E2YnVsdm5zb0RjWUVvRERjSXhD?= =?utf-8?B?ZzRxNGdvRTZibFhHd25RU3k5MkpZSTM0Tk5sOFhKR1o1U2NDaVQyWm91UWlC?= =?utf-8?B?RE0vYk15TndINUI3NXZwejFLOU1MNkJiUlhTVWRiNXd0Z3gwZ1lKMWxLUHRz?= =?utf-8?B?MERlclZhUHZsTHV4TTh4cjdBeHBFeDRWS3FyWHc5RFpldlpoR2FPb0JQZEJq?= =?utf-8?B?alJoWFZTcDhBZkxzeWdJMlJvSWY3QjRhMGNsSDBLRHdqT2JVZ3pxOEpPNzlq?= =?utf-8?B?QlJtYnEycXc0L0krblA2TG53SmxqREE0VnFZMzNGaGE2b0IrRnhBUExxcC96?= =?utf-8?B?SEhqNFk5alBtY2Y5K0FzOXN5ekFpSUMxc09RN2tCVWVNaUR6Mlk3K3B2YjE5?= =?utf-8?B?QStvU3c0T1BKTVBCT0pOU01mQmFBZ3g2aFcvVGcyQ2hVMVpBVGc1ZnJLTkFB?= =?utf-8?B?bFpnTjRncTAveC80K2ZQRnlWUDJ1ck56UjltdlBER1BlYU03QldRQVFCSWU2?= =?utf-8?B?bHkxNzFpd2xaVWRrL3d2WjVvVlJtMCtmYWcrNFZoSmtVNkJEVGNNNVJVTUlz?= =?utf-8?B?cEJ1L1R2NXk2ajl0NE5sMzdlMCtRdjltTUc2S0Y5UHBCWitNNHRzMnR5SWhl?= =?utf-8?B?ZHoraVNIb21ESFlHTGUrYk1sUzVxM2QrdkR3RkdqUGFzRi9DTThjcVRPck4y?= =?utf-8?B?YlN1bk5Nb2tmN2hNOGlyQmdMbU1iVTAxcGpzQ2V2NWF6VDM0ajFHSUtDNVpT?= =?utf-8?B?R3dKcHg2b2JPVDRWbXFNZFBEQk5OdnFLVU8wSlJhSCtuWTROTm5yRmtOOC91?= =?utf-8?Q?fM40oIVoE1HY8Rb5wNSh99MAPE5BE4e+bgfNPO9?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49cd2846-eb07-46c8-91b5-08d8d7fdc3ec X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3240.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2021 13:20:18.9162 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +0bect+I1yI4qXOwM1YqXJhhBmHM2riF/uJOMvvXzW9rTYPFSDc1h/5hkGFpGcMfd8O2QhUmkNfghQdNUTfq33Wz5Rfu6s9A+h2222Ud3yI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3061 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9903 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 phishscore=0 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102230112 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9903 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 mlxscore=0 malwarescore=0 clxscore=1011 phishscore=0 mlxlogscore=999 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102230112 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6D84180192F4 X-Stat-Signature: watxzxnxrzkfw4kfuutnraugdebjkj5w Received-SPF: none (oracle.com>: No applicable sender policy available) receiver=imf27; identity=mailfrom; envelope-from=""; helo=userp2130.oracle.com; client-ip=156.151.31.86 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614086430-635866 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/22/2021 5:51 PM, Alex Williamson wrote: > On Mon, 22 Feb 2021 17:10:43 +0300 > Dan Carpenter wrote: > >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >> head: 37dfbfbdca66834bc0f64ec9b35e09ac6c8898da >> commit: 0f53afa12baec8c00f5d1d6afb49325ada105253 [6931/12022] vfio/type1: unmap cleanup > > It's always the patches that claim no functional change... ;) > >> config: i386-randconfig-m021-20210222 (attached as .config) >> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot >> Reported-by: Dan Carpenter >> >> New smatch warnings: >> drivers/vfio/vfio_iommu_type1.c:1093 vfio_dma_do_unmap() warn: impossible condition '(size > (~0)) => (0-u32max > u32max)' >> >> vim +1093 drivers/vfio/vfio_iommu_type1.c >> >> 73fa0d10d077d9 Alex Williamson 2012-07-31 1071 static int vfio_dma_do_unmap(struct vfio_iommu *iommu, >> 331e33d2960c82 Kirti Wankhede 2020-05-29 1072 struct vfio_iommu_type1_dma_unmap *unmap, >> 331e33d2960c82 Kirti Wankhede 2020-05-29 1073 struct vfio_bitmap *bitmap) >> 73fa0d10d077d9 Alex Williamson 2012-07-31 1074 { >> c086de818dd81c Kirti Wankhede 2016-11-17 1075 struct vfio_dma *dma, *dma_last = NULL; >> 331e33d2960c82 Kirti Wankhede 2020-05-29 1076 size_t unmapped = 0, pgsize; >> 0f53afa12baec8 Steve Sistare 2021-01-29 1077 int ret = -EINVAL, retries = 0; >> 331e33d2960c82 Kirti Wankhede 2020-05-29 1078 unsigned long pgshift; >> 0f53afa12baec8 Steve Sistare 2021-01-29 1079 dma_addr_t iova = unmap->iova; >> 0f53afa12baec8 Steve Sistare 2021-01-29 1080 unsigned long size = unmap->size; >> ^^^^^^^^^^^^^^^^^^ >> >> 73fa0d10d077d9 Alex Williamson 2012-07-31 1081 >> cade075f265b25 Kirti Wankhede 2020-05-29 1082 mutex_lock(&iommu->lock); >> cade075f265b25 Kirti Wankhede 2020-05-29 1083 >> 331e33d2960c82 Kirti Wankhede 2020-05-29 1084 pgshift = __ffs(iommu->pgsize_bitmap); >> 331e33d2960c82 Kirti Wankhede 2020-05-29 1085 pgsize = (size_t)1 << pgshift; >> cade075f265b25 Kirti Wankhede 2020-05-29 1086 >> 0f53afa12baec8 Steve Sistare 2021-01-29 1087 if (iova & (pgsize - 1)) >> cade075f265b25 Kirti Wankhede 2020-05-29 1088 goto unlock; >> cade075f265b25 Kirti Wankhede 2020-05-29 1089 >> 0f53afa12baec8 Steve Sistare 2021-01-29 1090 if (!size || size & (pgsize - 1)) >> cade075f265b25 Kirti Wankhede 2020-05-29 1091 goto unlock; >> 73fa0d10d077d9 Alex Williamson 2012-07-31 1092 >> 0f53afa12baec8 Steve Sistare 2021-01-29 @1093 if (iova + size - 1 < iova || size > SIZE_MAX) >> >> size is unsigned long and SIZE_MAX is ULONG_MAX so "size > SIZE_MAX" >> does not make sense. > > I think it made sense before the above commit, where unmap->size is a > __u64 and a user could provide a value that exceeds SIZE_MAX on ILP32. > Seems like the fix is probably to use a size_t for the local variable > and restore this test to compare (unmap->size > SIZE_MAX). Steve? That is fine, though I think using the same type as the args struct is a more robust fix: u64 size; - Steve >> Is the " - 1" intentional on the other overflow check? As in it's okay >> to wrap around to zero but not further than that? Sometimes this is >> intentional but it requires more subsystem expertise than I possess. > > Yes, since we're dealing with a start + length we need to account for > the -1 in the end value, otherwise the user could never unmap the last > page of the address space. Thanks for the report! > > Alex > >> cade075f265b25 Kirti Wankhede 2020-05-29 1094 goto unlock; >> 73fa0d10d077d9 Alex Williamson 2012-07-31 1095 >> 331e33d2960c82 Kirti Wankhede 2020-05-29 1096 /* When dirty tracking is enabled, allow only min supported pgsize */ >> 331e33d2960c82 Kirti Wankhede 2020-05-29 1097 if ((unmap->flags & VFIO_DMA_UNMAP_FLAG_GET_DIRTY_BITMAP) && >> 331e33d2960c82 Kirti Wankhede 2020-05-29 1098 (!iommu->dirty_page_tracking || (bitmap->pgsize != pgsize))) { >> 331e33d2960c82 Kirti Wankhede 2020-05-29 1099 goto unlock; >> 331e33d2960c82 Kirti Wankhede 2020-05-29 1100 } >> 73fa0d10d077d9 Alex Williamson 2012-07-31 1101 >> 331e33d2960c82 Kirti Wankhede 2020-05-29 1102 WARN_ON((pgsize - 1) & PAGE_MASK); >> 331e33d2960c82 Kirti Wankhede 2020-05-29 1103 again: >> 1ef3e2bc04223f Alex Williamson 2014-02-26 1104 /* >> >> --- >> 0-DAY CI Kernel Test Service, Intel Corporation >> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org >