From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 205B0CEDD89 for ; Wed, 9 Oct 2024 12:38:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80BFC6B00CB; Wed, 9 Oct 2024 08:38:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BBD66B00CC; Wed, 9 Oct 2024 08:38:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65C796B00CD; Wed, 9 Oct 2024 08:38:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4701E6B00CB for ; Wed, 9 Oct 2024 08:38:09 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 040D71A1468 for ; Wed, 9 Oct 2024 12:38:04 +0000 (UTC) X-FDA: 82654016256.08.4E0B8AC Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf22.hostedemail.com (Postfix) with ESMTP id 6AC9FC0011 for ; Wed, 9 Oct 2024 12:38:06 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=bsHUdwj5; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=35nDAW5f; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=bsHUdwj5; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=35nDAW5f; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728477350; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=3q3Nbbg0Iac6Xb0jwfjOv85Zmgm1KXwjzZK5h0dDzyA=; b=OiduDl5PmJV32WUlaPUZp86ZCdUJPsS/TGHGDyLO/YArgn10gycnS6/klJGkVcpqhGbWum 1P+HMJ+AW8jKQIO4HLYXWiI80L8GqaUjJsVU7NDkdiyLujwlqXsDFi7jzRaWVH5WdFwnh5 +gha6kngji9k76VeHoBQIpCraPaY7sU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728477350; a=rsa-sha256; cv=none; b=MMyH/54q6huiu1I/PTloaHKEWKqrDIxyjW9FgOCMamoQtNqVA5EWh/8MkGAjP3MAMmNS8g +/RSybb609UGNqA8oGDpgDVQ4vmMNgp4lFL+X7467zUt5sucmt4w7L9ZttvfCCJEl2rtXW hXykNexUimNK8j9tYnGbGblw0iNLokA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=bsHUdwj5; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=35nDAW5f; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=bsHUdwj5; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=35nDAW5f; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 648A921B3B; Wed, 9 Oct 2024 12:38:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1728477484; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding:autocrypt:autocrypt; bh=3q3Nbbg0Iac6Xb0jwfjOv85Zmgm1KXwjzZK5h0dDzyA=; b=bsHUdwj5GcLcIVse3c0xpTNVrQYMcZoUBcJHpNmwVzuLASs/VcamY5DWbPW202j4kPPzNG VYde79AiB0nUVwKplcCB1gniG5I+sJB//wMkzlVg35dNe2KMMU6Q6OW01KUu1Eh46rbd0j GMP6SutuaPPwy2dOCSyz2X93HPl8/zA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1728477484; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding:autocrypt:autocrypt; bh=3q3Nbbg0Iac6Xb0jwfjOv85Zmgm1KXwjzZK5h0dDzyA=; b=35nDAW5fzWwXbrhtedq9ZUh7F9wMCeDGPpQCfcEwEl1KN1Ai5y8ynma1ISEop62Z25ttQv aLs6I1Dp9doxY0Cw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1728477484; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding:autocrypt:autocrypt; bh=3q3Nbbg0Iac6Xb0jwfjOv85Zmgm1KXwjzZK5h0dDzyA=; b=bsHUdwj5GcLcIVse3c0xpTNVrQYMcZoUBcJHpNmwVzuLASs/VcamY5DWbPW202j4kPPzNG VYde79AiB0nUVwKplcCB1gniG5I+sJB//wMkzlVg35dNe2KMMU6Q6OW01KUu1Eh46rbd0j GMP6SutuaPPwy2dOCSyz2X93HPl8/zA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1728477484; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding:autocrypt:autocrypt; bh=3q3Nbbg0Iac6Xb0jwfjOv85Zmgm1KXwjzZK5h0dDzyA=; b=35nDAW5fzWwXbrhtedq9ZUh7F9wMCeDGPpQCfcEwEl1KN1Ai5y8ynma1ISEop62Z25ttQv aLs6I1Dp9doxY0Cw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 48F77136BA; Wed, 9 Oct 2024 12:38:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id YbUuESx5BmdMHwAAD6G6ig (envelope-from ); Wed, 09 Oct 2024 12:38:04 +0000 Message-ID: <0947ed02-9713-4974-af68-1aacedc97782@suse.cz> Date: Wed, 9 Oct 2024 14:38:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US From: Vlastimil Babka To: Kees Cook , Namhyung Kim , Arnaldo Carvalho de Melo , Christoph Lameter , David Rientjes Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Christian Brauner , "linux-mm@kvack.org" , bpf , Alexei Starovoitov Subject: extend usage of KMEM_CACHE() for cache creation? Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Stat-Signature: cumwrin8cxmwwjasn66mp64mofa7w36q X-Rspamd-Queue-Id: 6AC9FC0011 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1728477486-794853 X-HE-Meta: U2FsdGVkX1/2J+tUe72MbgGDk3HUUWGqraiG0N3/gCgg1cmivUWaKW74IqMRmnMw8ExItN6LQ9QNrIjw2EPoXMvc1gX87o8ZuprI0uTuOZXVeChzs4nUdMlRAeaj+6JqGqG32SMR3OHsDYaNQae34VW+cJQALRLAZAiI+8tmGQ7arrF7jPanwIoAvLWj6wpWj10zYxIcO5eG8viTp+xrCOrEtbhmOa+DxwCQxrUYSk4tyINyXtoTJqzhz1Yma08Q9aM4n26f5C7L+H3zMeW14wHLE9aaI9KUZMK3Y1s8WWRqWayhF3daPXatOxbfvwUM9AIizQI+Hb/XaTuZfS4atPqLjz3aBaq1NmS3yoTbyc+RyZuvnjVv45+iDb/t/BUvCriuVO/wW/vE8tvKBdh6SKd/LNAcELONNSs1/PYJG2rFXKjLs9QE90rF4kAwSLUnb25BVZpEzX17eaBabJuW31qf/vr5ClYwUC1eTMxp/Ara8YqLoVQdjD1ZUDCpLl534X7jJI/eT2sAFqNO8/ftvzS0wwAC8ddY4B2Qn0MUENrhcFh9xVnpKWb4dY2d9djiHBg4A6+XKTElTPVEADlU2Yk9ilFiv+R7k+VGVBbi58xSfyF2jr/cS061voS3uOnneuhRX0gaLmaq0IqdBgUrB+OzgtRNQEG16lBQ9R2JxbO+tme0OgIzLwdOKDpnV3hEYQQj2ZEM/XYbicDGA/oJRvqwjK0VAR+AHUdDwuZ04Z5fCANYMU2slkmMvIr1E6cOTL8aadiuEIFNHz+5YD3U71Apl/RoNEa4qcROBy/3or5UL3XY1jVLQ1GfJSkuuRamvrOV7i1F/RaLlE5bRkLMg8oPVe28E3INEHN+PXSalUwaAAZYYF00jE4D1eOnMugDnNUg+rAn+R5ZWPZ9ztlaWGRzh5v42Us8gWPdX+dFyOIlPzlSEFL6yE3hoLTcFuEdvtZZDirQQuCd85Swh55 59QqSqbX bmCHhgPe+KPPYxnLNxUXyIO8tYjyS7CiszfnQDNi3LOWUj6AuISqUE0T2VOaus3pPM4tnVVv+6hJ+Nt9bqRnMVw8Uejfxg8YdxTUU+oQtJIUk98SR2wsKNwusOSVyG1okDyYNdISh14qensn/MjsbOmqBxUl6UeDFVUPwhzoacC3M0P8BQXza8HdDute1mdKVNQGTMX+a/v89PQmCDSI4osoyRkkDhs9iG1ZfZsBwFtwLqOd2TDJKeVF4sOInVnv/KUtMbrb/A4t3MSNxo17raWYDNQrjPC7KvvchXpC+uEOPGsqG529AFxuTzIDA6QlnzeSp0HOoLnWWAw1/s74xvucxCkOQjdDET77LaX/D2I1RUxMTPfu5Zgqp3aLehx5H8hUJouoOGUf8/tTu+8uJTMk++o+P6KsOEzYMj5RMPf0UCk+/VeRy1U5kO+8Wh938ii1JpITG+ABloOFGUb4aWzusAEaQq/meO3Plci1E5gUxB+pYT9Zfbr4buNLM0HlIRBui X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, after Christian's recent refactoring, we have the following APIs to create kmem caches: kmem_cache_create() with new args parameter (and the legacy variant of the same name) kmem_cache_create_usercopy() - also legacy at this point KMEM_CACHE() which takes the type, and has many users, but currently has no support for args KMEM_CACHE_USERCOPY() - like KMEM_CACHE() but with the usercopy parameters, and only two users I mentioned this at LPC when talking with Kees, and during Namhyung's talk. I was only vaguely aware of KMEM_CACHE(), but during the refactoring I became aware of if more. The reason it takes the struct type's name is currently to automatically derive __alignof__ - and it could be an interesting excercise to find out how many caches today exist for structures with specific cache alignment defined for some fields, which then fails to be satisfied because the caches are created by kmem_cache_create() without the proper alignment... Today we might have additionally interest to know the type for security hardening, i.e. like kmalloc_obj does [1], and for perf to help more with cache cpu optimizations [2]. Both got me wondering if it would help if we converted everything to use KMEM_CACHE(), assuming that - is there a way to store the type info somewhere (aside from using it for __alignof__) so that perf can later get it back? I think [2] is currently missing the step from knowing the kmem_cache's name to the type? - could hardening benefit from this somehow, like it is supposed to benefit for kmalloc() in [1] ? So if these questions have positive answers, we could think about extending KMEM_CACHE() to support the new args parameter, making it the primary cache creation API and converting all users to that, while deprecating the other variants. Thanks, Vlastimil [1] https://lore.kernel.org/all/20240822231324.make.666-kees@kernel.org/ [2] https://lore.kernel.org/all/20241002180956.1781008-1-namhyung@kernel.org/