From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 706FAC83F07 for ; Mon, 7 Jul 2025 07:25:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1426D6B03FC; Mon, 7 Jul 2025 03:25:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 119FE6B03FD; Mon, 7 Jul 2025 03:25:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02F4D6B03FE; Mon, 7 Jul 2025 03:25:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E8DBD6B03FC for ; Mon, 7 Jul 2025 03:25:20 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5E7BE10A97A for ; Mon, 7 Jul 2025 07:25:20 +0000 (UTC) X-FDA: 83636632800.18.077D756 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 114F710000B for ; Mon, 7 Jul 2025 07:25:17 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fEqe92tf; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751873118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kyz7rmjVCCJyE9g4jNrqoS5RA+GMrLuCrH03uFwXbSo=; b=DVZuaUKz5IK2poq+DVJwuHGemBB9GeySZtOJtUayu5leIovE1MUf7KPiIZeUYFO+AYq8yf +Ko2xYlHPVhXs63pSb7f+TGpbpvzIMqS4RnayD9Ool3sz5Q0tfZ/tZ8gqii87nTq72nWiu uuCb1win/8LgzCk4Um1dRIZzzknaGco= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fEqe92tf; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751873118; a=rsa-sha256; cv=none; b=OWDC4jXsfniAoNMelHaYmDc2lB4ONM1AfA37H8tJqhQRBTr9q/ZHl9WE5PAqSEa70tzGmZ gHKZZUKwEzzl0OYjepeIutKfqi2hDQpLB+EahIXk9oSIWix4s6FQCT5RDotpm1kAdTg2VV BcwO67gjRkp7FBWA3Q70nxHM+KoBOiQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751873117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kyz7rmjVCCJyE9g4jNrqoS5RA+GMrLuCrH03uFwXbSo=; b=fEqe92tfiRAF+rMGx3LaCGqAqO0Px/KLYAP3rg/eOVrtcSYWnD6KpIZdM2VSZbUo4+FO80 Pb6KqE8rbb9GqMc4aKYqEMC+SicrRGYOIg8Nr9LiPhTZOmyu+0vTH7Bu0ciO6Yw5ftP4lY zP+Yg4duXZuPe5LXQSHfFAIZ2InSuGk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-679-T69UxQdsOa-7aCxdOA212g-1; Mon, 07 Jul 2025 03:25:16 -0400 X-MC-Unique: T69UxQdsOa-7aCxdOA212g-1 X-Mimecast-MFC-AGG-ID: T69UxQdsOa-7aCxdOA212g_1751873115 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-450db029f2aso12160285e9.3 for ; Mon, 07 Jul 2025 00:25:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751873115; x=1752477915; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=kyz7rmjVCCJyE9g4jNrqoS5RA+GMrLuCrH03uFwXbSo=; b=SBYTbsmVXWmzEXac9egGq2UDWrGdL8urzjuR+0P5DVuAvrdPpae0cLMd5Fd7AlyJoH MFsjwyV6LTPMLT/9pcEcmNtjapw+oVx6DHN3a5+cD/QBi6MPN6Wg3Eqf/l+QQpz7kO4P ABL4ookUJxODII1Tq5Q0gblyWiHVwxcOYRPGijA4CHkIumPZUZZnOJXYfmu5BjQTX9f1 S/0NR9QkG594QBm5o6GMYEO9UvzhXqp9+Ct8+RV04Y585GAKbTTVvZN90FuEtEcDOVFH g6BOMga3la1x2paU/gywt9Wo9lSE3gZ45B8cIIWG/URkyf4QC/AVBQJX5G72kLe+RDYL PJkA== X-Gm-Message-State: AOJu0YwrXWj9pWi9c6LC78BR2slkNzR43bW3+gwsG6Zzb5F8MbmuxBBq qWAJTfpVM0dqVkJh5/eg5xN40daAAamY4Z/cvBYgWnjv4zXICqZw6geaa5yNjG06r16XWyJY8vR bubu8o15r+Ax4G5aWfXCUsn3Bqwa3J4skK+2ncu3tekNVKTFah6n6 X-Gm-Gg: ASbGncvAMLG6cEZOckoFTf2cmRHAZYCUsvVLpy8qRxVx6rwG4oHNVaUSWG5RjRkBMlQ kSUxAM4F2t5Fk9yHv7k44qwhJDGT7tYLY+484Mpjn+SMDy9f5Ewx0cKOOoiYL8zcGBj8Syu71RF eBxfgHWuvbKne4yNE8zQaOrg4c0UjIA78tWTRT99Wb187uE/Iyk1gMUHabI+WeWxuTia4xf8/n4 jO9ki890DpIuAD7UzKD0zwf5nwhbBvQBboKSZoO7pW4bmzYNW4j0Uky6ge1Bjf6BZCkR5MYstDD D2t2VOm+uOTN6LUnDipEjuhetYaQVpwTzXPcUP29YxDRlXtmrAJvrK9quIRSP5KfoW2plJEiKqP cVtBAcLETHzp6MabVxD9KwExGwP7Mh3X+h3CL5bYeORTXPfZXhw== X-Received: by 2002:a05:600c:19d0:b0:450:d00d:588b with SMTP id 5b1f17b1804b1-454bb80a536mr62059655e9.9.1751873114693; Mon, 07 Jul 2025 00:25:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEfTfnTmLgZEBVNdgcJLup2i8uGTeLiTjwzqCR7PBLOEgNLBRA64oomLfu2KyWA37LIoOnUPA== X-Received: by 2002:a05:600c:19d0:b0:450:d00d:588b with SMTP id 5b1f17b1804b1-454bb80a536mr62059335e9.9.1751873114248; Mon, 07 Jul 2025 00:25:14 -0700 (PDT) Received: from ?IPV6:2003:d8:2f38:1d00:657c:2aac:ecf5:5df8? (p200300d82f381d00657c2aacecf55df8.dip0.t-ipconnect.de. [2003:d8:2f38:1d00:657c:2aac:ecf5:5df8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454b188d8e6sm102603085e9.36.2025.07.07.00.25.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Jul 2025 00:25:13 -0700 (PDT) Message-ID: <0936d663-8de3-40d1-97e0-927edbbb47f6@redhat.com> Date: Mon, 7 Jul 2025 09:25:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/migrate: remove the -EEXIST conversion for move_pages() To: Wei Yang , akpm@linux-foundation.org Cc: linux-mm@kvack.org, John Hubbard , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple References: <20250707065711.18056-1-richard.weiyang@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250707065711.18056-1-richard.weiyang@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hlinZBn0eM-PDpoP_x-87I9x_PFt2pcEw2jVxcICF0k_1751873115 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 114F710000B X-Rspamd-Server: rspam09 X-Stat-Signature: npei1aqejthr41w3erfazbru6dx7o9up X-HE-Tag: 1751873117-601518 X-HE-Meta: U2FsdGVkX1+hGYFzXQWnOZnm0xgAbwuvVI+Dlm/ELFiAhhQ/jmIyvAd6/MG04iUTMOgpQW1BgGThHydyOhdp3X2cKee9SgKGm9sHQWISb9WS3IepO768FI8zVdRE11BxDngthrE6xTy5F2DvUMw+lUn93/VnRmelB4xiuW40CTp+nsERYhWJ+hf/zjVaz7pxpTgJiEDzU0Ld/U4vFMqaGX77CFmE73rtOutDGK9+DXnDLRbp6S55OJG0K+ZjkRxEVB2mn7Mrfa/nvvBVqpDgIoFGHdQnsZd48re57O+ZKtAjNbW/W+IbQrOi1hqK3q/ZvaNb22dX/spxUV7Xxm10CMNmh0nkM1T5G/JRKmbwzHDQRe7DNElUlI3+iIPjJjpglspi9euchAn57cT9F3dHEFPGHX1MSjwOgi5gEv3mrCQQtwSXAJ7BTKsGVCXYrDae3Fc5gJWjtxlJ/UJn0+3C6CjNgtBezl4Adpgqg2fqZFgIe4wjEjSbykWABXrb3IEMJ52g8WYLnJ8APgtEjLY9b2Rl199H+ll77nNg+4TMSsaSIP+/A1AkLcKMMxqjJHufJkoZUWuUsjoCbjPUW9maHnJ9k/2CcP65oCeui22qhem+/ITEWpwkyxyAxEumCTNXRRQnGHSltwiWhmoJJQcAJEt0G2mb8fiMEVdfFCEuBlniUp+aM6A7D5ccotp7KATOiADOBFg/ZrPs1zdJMYgTMvM++KY/A5ULEzDu9xpUaJ65U9goX9x4WrvHlA/au7uG0XvVp1GLCEXL+5B19omCOmPiRK0bSec+/HMWx0OrKXcKk/3zh/FIjq5VyLRJDGA+/O2Ca8ReLaSm4LejjBSDjkcW3kDAGs342iPCqsFJsLDLxonox+ofNW7FvAyqFtB+sjwbmELjpvVpbNxlzoNreL5LDYhzydS/fzn365dgm7KdF6DU1BK44b/Xx/Bn3e6BQFxmRKitNb5RtRRfEwg AtbDCICL nZIQ5RmYAERMnrz+jgl5rtxweDDUTdfHMjpk9pDC/u1LJ43dZU49VZl9YBCb8q0z0fsFEpdy78H28Kb/PFHJHKvN+A9eLCRtNm65Ul+qoz0N+aKZf6MxKkOD/NHv8+/v4WYHS4B58Q+/J0tAyFLyJHpuiU6NhwZN9yYbEPuHU9qmu7bcikOAtfhTh7sqmxrk1LEwO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.07.25 08:57, Wei Yang wrote: > The -EEXIST conversion is introduced in commit 65462462ffb2 ("mm/gup: > follow_pfn_pte(): -EEXIST cleanup"), since follow_page() may call > follow_pfn_pte() which may return -EEXIST. > > But after commit 7dff875c9436 ("mm/migrate: convert > add_page_for_migration() from follow_page() to folio_walk"), it use > folio_walk instead. This limit the error code and won't return -EEXIST. > > Remove the error code conversion here. > > Signed-off-by: Wei Yang > Cc: John Hubbard > Cc: David Hildenbrand > Cc: Zi Yan > Cc: Matthew Brost > Cc: Joshua Hahn > Cc: Rakie Kim > Cc: Byungchul Park > Cc: Gregory Price > Cc: Ying Huang > Cc: Alistair Popple > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb