From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 483D5C3F68F for ; Sat, 14 Dec 2019 01:55:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1DD2324125 for ; Sat, 14 Dec 2019 01:55:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eb40YQJx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DD2324125 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 968198E0005; Fri, 13 Dec 2019 20:55:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 918F08E0001; Fri, 13 Dec 2019 20:55:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E11E8E0005; Fri, 13 Dec 2019 20:55:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0188.hostedemail.com [216.40.44.188]) by kanga.kvack.org (Postfix) with ESMTP id 6842C8E0001 for ; Fri, 13 Dec 2019 20:55:21 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 0DD5B180AD81A for ; Sat, 14 Dec 2019 01:55:21 +0000 (UTC) X-FDA: 76262079642.20.fruit44_4bbd7649bbe50 X-HE-Tag: fruit44_4bbd7649bbe50 X-Filterd-Recvd-Size: 5613 Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Sat, 14 Dec 2019 01:55:20 +0000 (UTC) Received: by mail-ot1-f66.google.com with SMTP id o9so1400644ote.2 for ; Fri, 13 Dec 2019 17:55:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=cc:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=k+FqWQhg3zsQBz5OPBQ/f5P4w/hRAvhzjNsTIeI4VMs=; b=eb40YQJxxFI9nsr+8ZM6C6CNG9Kg++mk4g6aGxotH/5OAQqcVfJYawtKyUfsu4hymC nY1eR6f4dO235g/EebJLzVPWPps3gzeLlT5ilj2pnKiE8hEtqaGza2H38dPa0gAV+6DX liPMCf1DXr9pa0gV9e9sjaQTpIsiaGTziQoU7aCss0OD8ZSjAp4fB1PzU81p5Mkgx5Vb 3nsfFiGMmeRrtATBDaAdsfOdrxGP/jiz0mT3Fsuhz0XYtj4xxmj11ljeuuWRx7q91myX cdXu8KQIkGdX1Yxg5sbOEFiaK4P0R+pYz8llSH65XJmqxihk4cDWI9XS6NRqBXUeyGG/ 04BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:cc:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=k+FqWQhg3zsQBz5OPBQ/f5P4w/hRAvhzjNsTIeI4VMs=; b=qGzGLUMM9SWXzjpcJpOaZV+vYIDwsY7yPipOZ1lbe0m7Wqe/thioEeyG6wjbmmb5u1 TQIWtjLLzymDUGKkMpntJs5goiSAOqwIadP/oUOU57jGnDQW4ePKNaGr72VeT/sBBa/b q843sNy5ECbb9vccOaCg5jRoQAbx2L9RAJBYlJI7IQ0DfG7RDkrNC2TMWayAlQ8J+8qd 4NK+TrDNoKPLf82bqHx212P2BvPaYVinVT4PsVEKhNYtDxtMxCbT8AJ7nVdr/v8lBmfL YAG7A9ny4r2WHzkf2sYjv2EisvvFSWYskKzuHdk8nNWIgTViYdCWuh5oo0IpNH1daBVu 1a4Q== X-Gm-Message-State: APjAAAUOFSj6/qnQI01LR9U21S5VTR7WZClf2eWDSjTohRW8W8D7DKSz r4OIJE4sjw8P8kWZztlNp1I= X-Google-Smtp-Source: APXvYqzR10MlQHC06+el8PqUt6C6XneFN5lEqEgtMDJXXMvHieUzFlqxGcrPDSDiG28/Iyb29eRcdA== X-Received: by 2002:a9d:4d01:: with SMTP id n1mr16983744otf.245.1576288519734; Fri, 13 Dec 2019 17:55:19 -0800 (PST) Received: from ?IPv6:2600:1700:dac0:2450::38? ([2600:1700:dac0:2450::38]) by smtp.gmail.com with ESMTPSA id s26sm4028031otk.43.2019.12.13.17.55.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Dec 2019 17:55:19 -0800 (PST) Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] move_pages.2: not return ENOENT if the page are already on the target nodes To: Yang Shi , John Hubbard , cl@linux.com, mhocko@suse.com, cai@lca.pw, akpm@linux-foundation.org References: <1575596090-115377-1-git-send-email-yang.shi@linux.alibaba.com> <0dc96e40-5f2b-a2fe-6e5f-b6f3d5e9ebde@nvidia.com> <95170ea5-5b62-9168-fcd9-93b43330a1b4@linux.alibaba.com> From: "Michael Kerrisk (man-pages)" Message-ID: <092adc11-7039-9343-7067-0e0199c9dc13@gmail.com> Date: Sat, 14 Dec 2019 02:55:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <95170ea5-5b62-9168-fcd9-93b43330a1b4@linux.alibaba.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/6/19 6:26 PM, Yang Shi wrote: >=20 >=20 > On 12/6/19 12:25 AM, John Hubbard wrote: >> On 12/5/19 5:34 PM, Yang Shi wrote: >>> Since commit e78bbfa82624 ("mm: stop returning -ENOENT >>> from sys_move_pages() if nothing got migrated"), move_pages doesn't >>> return -ENOENT anymore if the pages are already on the target nodes, = but >>> this change is never reflected in manpage. >>> >>> Cc: Michael Kerrisk >>> Cc: Christoph Lameter >>> Cc: John Hubbard >>> Cc: Michal Hocko >>> Cc: Qian Cai >>> Signed-off-by: Yang Shi >>> --- >>> =C2=A0 man2/move_pages.2 | 5 ++--- >>> =C2=A0 1 file changed, 2 insertions(+), 3 deletions(-) >>> >>> diff --git a/man2/move_pages.2 b/man2/move_pages.2 >>> index 2d96468..2a2f3cd 100644 >>> --- a/man2/move_pages.2 >>> +++ b/man2/move_pages.2 >>> @@ -192,9 +192,8 @@ was specified or an attempt was made to migrate=20 >>> pages of a kernel thread. >>> =C2=A0 One of the target nodes is not online. >>> =C2=A0 .TP >>> =C2=A0 .B ENOENT >>> -No pages were found that require moving. >>> -All pages are either already >>> -on the target node, not present, had an invalid address or could not= be >>> +No pages were found. >>> +All pages are either not present, had an invalid address or could=20 >>> not be >>> =C2=A0 moved because they were mapped by multiple processes. >>> =C2=A0 .TP >>> =C2=A0 .B EPERM >>> >> >> whoa, hold on. If I'm reading through the various error paths=20 >> correctly, then this >> code is *never* going to return ENOENT for the whole function. It can=20 >> fill in that >> value per-page, in the status array, but that's all. Did I get that=20 >> right? >=20 > Nice catch. Yes, you are right. >=20 >> >> If so, we need to redo this part of the man page. >=20 > Yes. So where are things at with this? Is an improved man-pages=20 patch on the way, or is some other action (on the API) planned? Thanks, Michael --=20 Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/