From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEFD4C71153 for ; Mon, 11 Sep 2023 20:22:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B79D6B02F3; Mon, 11 Sep 2023 16:22:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 767846B02F4; Mon, 11 Sep 2023 16:22:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62F4F6B02F5; Mon, 11 Sep 2023 16:22:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 541706B02F3 for ; Mon, 11 Sep 2023 16:22:57 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1C027C0AC5 for ; Mon, 11 Sep 2023 20:22:57 +0000 (UTC) X-FDA: 81225440394.10.7D9C4F1 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by imf24.hostedemail.com (Postfix) with ESMTP id EC5F6180029 for ; Mon, 11 Sep 2023 20:22:53 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=d4xkghUd; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf24.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694463775; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MyQ9owSYwu2HExMKI63gcOHVEhoAxzRDCKGrldkjpfg=; b=g1Fuk0JLivAji9q/PVCfHN+BKZx1MAZXNQ8Ot+r1/Ac9VcDQy1dNPeKE6WKA0VfbZ/gMaT +DhPYJgDIi+Ob9HyT1eKJe7v2D/qPr+elNmdDz9MYsA8iIZ6+APhF9GTn2J49u+0/5hHZG l6VWBBDZ4tPyI/qrTVuvkN7C9GdHrqI= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=d4xkghUd; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf24.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694463775; a=rsa-sha256; cv=none; b=x63XvODSKC5E+FCOrxHoJkNMYyHM8tm0efrC6u2RsCURn8OD2uxUquv0SlCv2ZqUovvl3N oHwRppsqAC99SVZmGvWDbVGNY3/4M3O02T8w0TqsGZ7AQH4GaCN+hhfT8WVbaBAFbFq4Uy RlsMB/d9VN76O40aqE9ANUImSQGcmFc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694463774; x=1725999774; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=J/VrWvVCpD4pfFbtFJWIVg32QCmXn6NLI50uns6mNSI=; b=d4xkghUdojUtLdSL+sONiENtzRUK3oQ1CtYNazk2vZU6MTbP30J+loEK G6HMzB1pWY73TEKBwaVbpeMnjkkVlLer5bz+xr6u9UR0kUNFK7EeoxaMM Yo03myJvNmKYcrdx3capKl1DEXLc2Gse2MJjQz4MXk51huNW1QSyzHMxC rCWGIk3QiD5DTDk5TJU6RKJTXq1Bu8q+OKnpAFRmp1NvMNyakvBsQdyi3 H5I46yxXpK7efff94kgKnzUf9UT2DxwwLhJCOLBsM+iLYGrqAh44gemmU ivgNWXsqXrwxcTAN6iVuXKEQmpITKVMuDnXySZLlXmQsgMP3aTK8GqCwL g==; X-IronPort-AV: E=McAfee;i="6600,9927,10830"; a="378106494" X-IronPort-AV: E=Sophos;i="6.02,244,1688454000"; d="scan'208";a="378106494" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2023 13:22:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10830"; a="736890098" X-IronPort-AV: E=Sophos;i="6.02,244,1688454000"; d="scan'208";a="736890098" Received: from cdaubert-mobl13.amr.corp.intel.com (HELO [10.212.203.41]) ([10.212.203.41]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2023 13:22:51 -0700 Message-ID: <092a9bb2-727e-5849-fa4f-18535b998efc@intel.com> Date: Mon, 11 Sep 2023 13:22:51 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [syzbot] [mm?] BUG: Bad page map (7) Content-Language: en-US To: Matthew Wilcox Cc: Yin Fengwei , syzbot , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com References: <000000000000d099fa0604f03351@google.com> <0465d13d-83b6-163d-438d-065d03e9ba76@intel.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: EC5F6180029 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 9sskr3zbbpk34f9qm61hk86sn54shfd5 X-HE-Tag: 1694463773-169432 X-HE-Meta: U2FsdGVkX19Llm9xTA8uW2qMgY7OjZAMGoEzI4e+72WJd/vj+ChLxAH9xmK8C+ZUIjJljrueb+5UrebQZsJvISni602Xs/sngluDSea3wblOmPnc3kDsYcB5Vv6FklEKYOvvx+K7SimKt3IVJpWhD21dpaW1Po4f1WbJNdRZkgHMmbo90LoeC/o1Sv66zgPbjonFwyNumRK1D64+ASs+3PmtImhFBEH4cGAygRV5vkeYd3z3pP2TNXvhe5bVYPlzADw2F0VJRLc6yLnhJDRmIRAA4V9tlmcGruwYE32ja1gi1cnFCIFFgndBZy3qWu66W6BmZKEujZ5906kNBveCYye5XsSHOjZlgHK26HcX4k+kQF3NOHMTVF3D7HoWDKxhR+V1nKt29pAi2LoD83veNcDhQonC6eX4uQtVFs/bjAEnAL0Z7oxBLRW2CK6egpRkfg5/fC/V2QHIa86OozuIhPzDXGQ+5Ma0id6pqoylJZMy/S9VSM6yBVNfKP0SG4zA7Dln4WSSUEez5IazQd+jgTxB7GVTHSpaxWs46CQiyatLtdlK1stp/EpXP1Qkrlkqxk+86VOMmKfI4WJg1ZI6r+oY61TAb39RmTVhXCJPa986ys3DMKEy9uFeUzA/lYSXbYH9ICtSxd/z7c/C6M4PEgah5HSdyxyyR2cawFor1SubygD+xkSBqMqZE6dIo6X4R6big58j559UQEY6JJwjE80rooWentGi1XiDx2REy1UtJQe59V8k+3S4gHZQW0yrWBJhMEJiqnPFBkEDrvyEnjo3Ie9Jw5aCl/6j5RxivHM2qSceJv4B+nz887wljyoNHLzGTjDqsEivbIxywpM7KA0u/0k5pWaUqMByC+r2ex9qpi8g4RDTYRXqS9DUD3G+RMjWxTPhpUR+qY8KSDPqW5IauWRALKetd6trMoxqRDQ40rwj84Q+cV8dOLzewgYv+uKaYcx2NM89Ib6fUTG 8iF+z1oN FPpOSqijcUsCreOHlW+2EAPM1Y5FWRTc8RmYT/LKW/Xiulxs+WWAMNK3tV3T6Cl12SkzRPuOAeS+dbSz3p9LoGJ4Nv4PbV3g6tZuCsmB+AR9EarSXZdpuyVrTDdUFsBH35ToNl8kIp2qrIraV/Ia+1A4Hi/vgdG5KYIyhhmnqmjPFoSX9cDpqtavGBB7GZJiUkp9R6LWv4wCvkcBt9mezyl1E4nOHvFasrWjd5L3f96ta4lT/FSG1G+ZBhzcXsR7dCtWk5Sgr8B6KBrx5Bepn2i1sZpZ37lCPlBoq X-Bogosity: Ham, tests=bogofilter, spamicity=0.004299, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/11/23 12:12, Matthew Wilcox wrote: > On Mon, Sep 11, 2023 at 09:55:37AM -0700, Dave Hansen wrote: >> On 9/11/23 09:44, Matthew Wilcox wrote: >>> After fixing your two typos, this assembles to 176 bytes more code than >>> my version. Not sure that's great. >> Maybe I'm a fool, but 176 bytes of text bloat isn't scaring me off too >> much. I'd much rather have that than another window into x86 goofiness >> to maintain. >> >> Does that 176 bytes translate into meaningful performance, or is it just >> a bunch of register bit twiddling that the CPU will sail through? > I'm ... not sure how to tell. It's 1120 bytes vs 944 bytes and crawling > through that much x86 assembly isn't my idea of a great time. I can > send you objdump -dr for all three options if you like? Maybe there's > a quick way to compare them that I've never known about. Working patches would be great if you're got 'em handy, plus your .config and generally what compiler you're on. I'll see if there's anything silly happening that's causing the generated code to blow up.