From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EE33D49206 for ; Mon, 18 Nov 2024 10:07:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A5DA98D0018; Mon, 18 Nov 2024 05:07:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E70A8D000D; Mon, 18 Nov 2024 05:07:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 814798D0018; Mon, 18 Nov 2024 05:07:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5BE378D000D for ; Mon, 18 Nov 2024 05:07:07 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CB1EDAC45E for ; Mon, 18 Nov 2024 10:07:06 +0000 (UTC) X-FDA: 82798786644.18.336A120 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf18.hostedemail.com (Postfix) with ESMTP id B40741C000E for ; Mon, 18 Nov 2024 10:06:41 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=gf1YuGZO; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="Azyv4/vm"; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf18.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1731924357; a=rsa-sha256; cv=pass; b=vCkYOsrMx0aaAF7tMrTnHuGCG9a0H3tYekqU3/Vww2HATgQQA6qKF1/kRbbUNDScYANawB zGmMOYRElR5stKOZsWoY3pvX6wA420aOEEUw2+2/jMkxPAa5oU5Ef6Yrq7JzSpJXvYyZsE EKegBxWaWAZ90ML8abgTKaqCmIm9fNU= ARC-Authentication-Results: i=2; imf18.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=gf1YuGZO; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="Azyv4/vm"; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf18.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731924357; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=npRlx6R0gcUpmgiqPrH/JDk0maSWYH0Mt8VVN9gDfkY=; b=dShuTAvYH3G4C8bPc2Ne5cl9IFfhvJciYivkR56lPDnOe8wz4bp1eHOHHS3wh5VkSI5oeN EAbsIRwlM2PnMKozKOjsRUBhl7hTtkziwQ7m/Va3G3LESy73gyBBKWF3OVyHB6bSkGvKg7 pCH4DBgnmPXkrC8k8ZrqH1K1LjEkjlo= Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AI8QXnm009201; Mon, 18 Nov 2024 10:07:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=npRlx6R0gcUpmgiqPr H/JDk0maSWYH0Mt8VVN9gDfkY=; b=gf1YuGZOTagnxUHGDQmEjFGapuy+rJI0m2 1wvdQ7SA867ZOUca+aYSDNML7saNlgSqrfiLRfN7a3uGF/fG47ZRtB8QGsS41EwP xXNL9FZW+jnv/ggNqk/h9zpVMuXbnhIa9uVYGu7FJPA0t0xv7Rlr/kUBCFNG6vu6 8yh0TeeJtBDU3M4Mzv0zN3xMDeNlD1sSf+6cVyZnt2lnE5pkvtjvUZnH9okh4d5Y ZjKXTBaUxNyWYSUFP7pNU6T855EUg97RzECHjiFCF5Hu9wuzZs6RJFtCSr8quRK+ d9zoH1RQTzvNckM29nvC80s6MbM3PjtH0NrtpKcS94mBMnXW7Fgg== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42xhtc2bvp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 18 Nov 2024 10:07:01 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 4AI7dDo6037957; Mon, 18 Nov 2024 10:07:00 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2047.outbound.protection.outlook.com [104.47.70.47]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 42xhu74f5t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 18 Nov 2024 10:07:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yoYPvPRvP3ou2JlOp2Jav3qkRG7CIAB380r4trO8B5op/TIIZ76UK1SZ7PVnjFDsXavgHd2p5BkxwVMa3FKMYwbfr20WZpMrU/s9Xi1wtoolhfQc5OQEWhTLkelhPbHUvqhr5XEbuEGbxIRgeHu5mK4V3LA/D9yLKH313H4ACuKeCMp1dk6/gjywsCQdqrZJoTJFZOvxKkAPEWqt2boMClPoFvHelUx3GMh+pDK9mLeb0dhq0IyRyPEpX0pziRmdXi9QWlwfB7GPakwYPl8PxGZSUqhtdnLElAwAEorDiiHDjiy5ln5BfhiuliNNM7MEm6cTV6ydTfNh6OuTMZf7cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=npRlx6R0gcUpmgiqPrH/JDk0maSWYH0Mt8VVN9gDfkY=; b=lSn6qQ/nZUbP3IkxINi8q1jrplS24EFMeLFpOebTKY9vL5MEQ+BB0d9sZk8Mkf6sSA7ll355RDBaQfzDR4AqfugN+TCGewkYk3Zg4nZeqjgkp/yqMhEvqbV8E99xUjgExzGQxjX9uivh8DaHtJivflMTy+uJc+ivhQbIsVfbDSaZPRCaVnQ1PSW9zRAXjfljgJgLHDJiJFCUN96YYTGZyK+0tqUAmhPc/IHzKR12sQJ5bQmf57H9brxOSz1fr3/azQa/zRAKGEAmBx7gJUSATwp7J9Bej6XAbDUoGoMkYRtChm5jUZweEdxtSFpH7lqE1lJ55YmaoIs1kZGcpxojBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=npRlx6R0gcUpmgiqPrH/JDk0maSWYH0Mt8VVN9gDfkY=; b=Azyv4/vmG/mUIpKjj6DVwUUHWLk6EwtP01nxin4rD4InfV44mdROOTRPhZL0aATdFKAaa7VAHsntWBfQcTL1T+mLR6enwVxvLB1SmvyVez0HZ9tGpjKjJaBvtBP8VbmxMaeNvFnNip5pNlT1fxpone76ZqXxsjreL1Zxmux5WbM= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by PH7PR10MB5748.namprd10.prod.outlook.com (2603:10b6:510:131::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.22; Mon, 18 Nov 2024 10:06:56 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%7]) with mapi id 15.20.8158.021; Mon, 18 Nov 2024 10:06:56 +0000 Date: Mon, 18 Nov 2024 10:06:54 +0000 From: Lorenzo Stoakes To: Wei Yang Cc: "Liam R. Howlett" , akpm@linux-foundation.org, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org Subject: Re: [PATCH] mm/vma: check retry_merge only for new vma case Message-ID: <09107f42-8882-4033-a31a-f6aa21e4ecf5@lucifer.local> References: <20241118021823.17386-1-richard.weiyang@gmail.com> <20241118093109.rmfekrv65yfu735t@master> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241118093109.rmfekrv65yfu735t@master> X-ClientProxiedBy: LO4P265CA0257.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:37c::19) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|PH7PR10MB5748:EE_ X-MS-Office365-Filtering-Correlation-Id: fb349c82-c5da-4c70-3c44-08dd07b8bc05 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?lxvqBGn0Bx71i6zql1Qw3wwG+jW+eBW0s/8WChzYLPsGhYUAFLEDh3zJaxms?= =?us-ascii?Q?BDA3cU2bm9837TZXlvMatl5Gkf3SmNOe1wpU+xWqo32rr4mG5h/Kuq7Zipr1?= =?us-ascii?Q?3HYpPdL+8AmsC+ApTVHmSP2R1YLOOTN0/7P7k3szvPFvFPxLJy4XhzW8QDE0?= =?us-ascii?Q?rZM+f9mI9yZzyeBcErH3OM600hGRRhrq0jkSw5/ZS+Xe7Bqmg/K2nApKYqZm?= =?us-ascii?Q?YnheijXHiyIdHXiUAz2rFmgSng0HgNmnnRfueJKI3xTLlBhADC7ozgfuelh2?= =?us-ascii?Q?cWalvzzd8v6vrjUucnjA2/OBjxytf+19NMwP4kk9priSZ950fQvhtTKRgf14?= =?us-ascii?Q?3SApkuWK9xCkIz1XSr7uWCJwbPsh77L5Im/iCnjbRnT5rVnUkeDzWvwH8vLv?= =?us-ascii?Q?isjpRd9DcuyiCUMG99pbcbMp6YBU6cPWeh7WTBm6uJqVrIsFR9gLiqO36PwC?= =?us-ascii?Q?7N08bVzoXOyHAnuMq5wjJQ+UICloCm9TfXOilX/BWVABsGBfpsPJmEYOUNwV?= =?us-ascii?Q?e/1Q14DCD3syV2i8jRUIxGgZRZBuYyXopf/9jNoKwlQzBWlOmBbtrBIg3v+g?= =?us-ascii?Q?cvljEpeUtJ2HsZGTX6+Sx5EAIFK9uUm7kxeMCecMURg6d7tF29Jl94AUYJJE?= =?us-ascii?Q?yBGzJoJQV0emlsyF+6riyePE+kx6nNsBXrzrH7eSRIEVsTBcRhRZCE9btpd3?= =?us-ascii?Q?7isdds5KLH6YSQkznNqzN5bh34Stke1GTkZuoCG7qMNyk8jJpBVb7YA8fhqO?= =?us-ascii?Q?U0tQSQkWwNqOsTeNAWUOZKnOn5cnC2sPWUfRYYRFnO97X23FvAZWajtudNc6?= =?us-ascii?Q?H4frmdYWicaaZoxaJT6wX5022Nsk4Sm6hgM+SzxxWqxdKXhdhsNWXa5OFULz?= =?us-ascii?Q?c89VJE/+USYvyrNp17FJ5cCVssk/JdB0vSyTmmWNvHZVhGkoR7fRTP4qGT4H?= =?us-ascii?Q?uegkko1g/nMA3FfJz7QsXsrKp6YbIYzaI/VtR0z0FSXVEskQMPvXEKBgSSq6?= =?us-ascii?Q?gbbaYNR89A4vGZuwnDmvd0F6pXBCrs0f/Cc/16VS4cfahhH1VuBqYGN69jMR?= =?us-ascii?Q?Y1ByhhfgCijl14XsVDwIj9x9lo4hXHOrL0BNyO72VXed5KFmlK5Q1VnM0PYh?= =?us-ascii?Q?V8qB5t+5UVP/lCVIvr0HsykF8G/jFBHmWfEXXsDO2IkTSwT8Fz7dwceQFrb7?= =?us-ascii?Q?0AijSsWke4ZJceTSnYTWqFi1U6i0xTmfM9ATPEjGdPaBWeiFmrLk9EANDaCf?= =?us-ascii?Q?Xs0sx3DzGAhCa2nd8QzmSkgYdO2YaqbIDZa21Xkm29rABpm+BzAi8GHuHNJT?= =?us-ascii?Q?V+QvZq9EY5fGp0wNbr9kQIS7?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1XerdICJDRm2tip2MuLJ/C2K/lE+v5pV+Jrmy+k40izTEJoCXlIJYywKCtBo?= =?us-ascii?Q?Mvk7QX48QWFPGMBvAXHfuAEHTbYyUP9MWtQbtz+X3/22AYIIOfDrT0iHY2Kd?= =?us-ascii?Q?9JiNJewvvvpHBABwJvEHr4NpL1NEYtWaEAMtinbTNIgn7agChuE2LhHk0cAe?= =?us-ascii?Q?i/0d6JCINI3zLi0oB5N4fvDM3j3hUuap5sDugYFAk66UgOCWkLDR1qPY6kQW?= =?us-ascii?Q?BhfuirzsOCnjpOZ6fiexBhk99WhPbrhufRcWxzkRlkR73IPw9eFk7LuXF95v?= =?us-ascii?Q?quvAIp7gC2c+RKjFeK99Xjz6DkTzjMIQDA7BZINbTo0C5Tzs5/UsK4cEMbxL?= =?us-ascii?Q?Y3clItsL4FQD8xhDnV1F55NGhx/0gde+KXRrBoF2RlP/q82Fnwu/Xtr3mqvw?= =?us-ascii?Q?RXUtXjMSiQhL7A2dY2D1hYhcylHwnCfyAwLalt1FgC4k5f/1qrG+8yjpVU5C?= =?us-ascii?Q?UbiDZw2XTp2m+ze/t9hGCYziq8z9zvhBRcTHwzWylN4dzas9E2io3ZBy57oV?= =?us-ascii?Q?DbyDUVNJh7JBEebRLTe5HMZAIEBDVmW4/SbUc96WEbZ1qIhzP5k5isGMie1W?= =?us-ascii?Q?lrhAV/bdMP+1nOjdEimh9+Ix5oqpkBDwN781RACWyMyWQlD+nrjg9I9ia/SD?= =?us-ascii?Q?PXW6S6X8OT3EHtN+sLdg7CRJf96omVNgmPi8EsCoVeuuTWuuQfzL1FF71Sz0?= =?us-ascii?Q?ZfZgApwLs0gnBS0v9DOtXPUohEj6WqtoIDCwOasjg/ou2Wi3hcx7D48zoDOI?= =?us-ascii?Q?f0ZGEHhklY92mfIXE4cRdpJe43G1/XFK8Z+us4xOvGclfj6jeztIBNGwBvdW?= =?us-ascii?Q?ogyy33qrg7meedjGpXRpT0Nn/Egwi2qohGz2iTiznV8whApZf49g5/P+TN+3?= =?us-ascii?Q?ZZa8xHc0Fdzhsu7Lb3SADcyZfu256uwNhHMYAkNbk/mTQ1jcKsf6yogSjq6Q?= =?us-ascii?Q?j2xKYZuZQnpKTBYVxgk0hp1HZ59GCg8nxP2vVICUXHBMO0xQMXAsnbSXzw9b?= =?us-ascii?Q?0WbuM/dShtm+XY0+sfMWsJlxoPEBlECDPq/Qfpee1k0z2+DUrU5+KcI9/CJK?= =?us-ascii?Q?9L1b0/nO1uXQhi9MRqtEdWLRlCETh0MT4Y+gKidg1w6iLp9ZG/5kcRhCWrZ1?= =?us-ascii?Q?kKoJaRGWZcMDJmEfOUm49Na/a0r12OSCVtEUFizLsbjpqUGiVmIhsRvrYF7e?= =?us-ascii?Q?MSooM27AtVCVdzZsY6+XY5FbmX7XS7E+LStCa0GxesoLc2cr3Bl2+Zy5DXzI?= =?us-ascii?Q?4jPLOzBHnoKBRmu77EN28VO5GRKLww0IArM/+40Tv+YC2wQaWwOnjp6Tq11D?= =?us-ascii?Q?sL8TRmDYWGMMVscs+Hmh0sAYB+Pvg06JQAWFnH7zSDV8spnb9RG+evpDXlhh?= =?us-ascii?Q?94LFsWgYb2i7Zw7TfTtf2Nd3TM9VozvB+ptINmmZ1xb4l6AgtkEDTbOjM83P?= =?us-ascii?Q?+0WxoUumekdt/qu0zYLOKQY8RavU7VoQMVd2c8fInjxbuePeizEcRPL3nQkE?= =?us-ascii?Q?uTTeatF5Niy5m0RHlCRPqAV8AsMaypwTr1LCjGpK1yve7JWIxIgh+1TikyK8?= =?us-ascii?Q?cOogWtbwWZZ6LDlwPCftJQWbsoVjIuRVR9KVGKZxEJUHONBS+VDli6Yd1buJ?= =?us-ascii?Q?8Q=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: b6OazovObEd5f/Ge8h7CGxTSxbM2JmodLRB1eZLg1iZfNDP1Dmn+v6Ot2u9JxqlGVn3PwRtzGorfch76gBTYrkryjdJ8dW69Qu8RHSY4BaorqC9EeVf9tvje0X1TzUg6ML0w0O4ukLG9zOjF2/pY6MdVfPDJAf8DSWumvw2lrIT72i2BAl4Dl4iqoVicfC/cX8vRStZl1i/02v3nrL88+fn12AX8jD9JDwNZ8vCFBWUcZtH7/7j0QDoOupAX0nl/nohkHj8Mm78L+pCdn56nxPOxjdBlhea7EO0S1aDD1lyxhEaX6kCv9mp1Ut5EWy6H8PEnxHBgbLuZ0djKLPeaAexICXm1NR0/MG5lAEqL1YtKuwf4SDZmoyRG+uAzaGbrENgtnFemuEvTfN/ymEJoZXqEtGF6MuDHLjglKrvdXhEYisINhYPPsxuZx0yAQS19EctkY4hckTDaDO3ZiTsu03vqAvjv+oJi+hsiRsNMoSfgFLBoWkXCsW5NuKKEoW32dcUir7dMtCUsxoCMvUB4F4wdWSM6aVXyHs/VNuubhfgmqahC9+jx+xi0nKpHYRewg6/hbegNN6Ic4g/Vyo9G0W99wUrrpTAsDygnWjUFvJQ= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb349c82-c5da-4c70-3c44-08dd07b8bc05 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2024 10:06:56.7376 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R4ftzBycyWNm8wlY7cc7mhrDLM2+Vw5kzLNsTft3Erz/Uzx4u8I24lxxwDGQndfUfNrvR7perbFFzkoifEfcvP2dYJ2dE0S4u2uCrWntmZI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5748 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-11-18_06,2024-11-14_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2411180083 X-Proofpoint-GUID: eUvAb5BLoAXA1aSjZKoVRp5260zwD1PP X-Proofpoint-ORIG-GUID: eUvAb5BLoAXA1aSjZKoVRp5260zwD1PP X-Rspam-User: X-Rspamd-Queue-Id: B40741C000E X-Rspamd-Server: rspam01 X-Stat-Signature: 8aznqwtx3imkwxsy1yjt1kabtt73er6r X-HE-Tag: 1731924401-756501 X-HE-Meta: U2FsdGVkX18VAUjmp/UQizO8hydzvWY1QZDMhOqdwo/3IJ8uvX6tzOu2XkkzXB6j1HQKdf5BloldP2DynZAJ6UqmVLTOlRoUNPnIWw92CXf09zYWbKtbZ8AsRXQxUn2rJLSBKPIJomglcavk4hgp9Up4ae5nq6VCrDDW7jA9utXZOVT5vyy5qlTxFqRtcYgsrkrbHrDLLuCEvYWZdKgbfXe2GrnUq5gpEW/TDB0YpamHtQr5sXGBMRV4W0q6oCRYQkruMMX6SndzInFCDrUqhx2gHMCcGS3i7zgAOhr0iA0bJeKi3MhnROh5+rgZtGeXmtwK8yt+HJBy6HYttyc6kqDwjH0mvhf/dZUWhN0J2e6U6z/Tz1yOS0qox2dXGKHdHa8feO5fsRDaTDpdQWXOxkalbmAZos4LN6a3dSCsgg58sMgDpwUX0vipnoiA6XY7au3GByFXGvwJogm/dQiqFoZvv6HKJr5ZfUrgWR7HrT4BV4k7HSqhWLdcay2L6+yN8TF5lxhow2Te4iEJ+HI2nXtHol6EwpG22u3DYwxKA9zc9wN73sRgfdky+2aCs/5UJwaeettYUb7HXEoiLbQoD9UXT2gjeJPU8ggCDvUdaah/EEe60aAbC69Obh6bgX3IW13zJGJJy48GRJF/6no04Cv6nm+HmQKfKZ33fXRHDg+FuwACRzBMGjqEpdv+BsuDtcT9bbqW7uGqlCjG0hN1lXDUypH8gpFCK0VUHjPbXoN+scsK4uw3bLxx19/lgetFNp0wIN1fIs0HqHzfqbuakjmJ5R7QkKA8PPrvM5ahgPF1/kekE9tte7gVGpkdj77waBdC1t7ZIqTNKF2OvCmpfbaG/xzFbf4nnqijPO21qnDovYrDHw9e5SIiQ9c6MYT25/SpdNxCkyfbN78BWwzAeXB0UFV13vkfPWFF0XZhNGSYu0VBaG5NvSBiUAONUjovDnvzWKufT90xSE2+bAn B2gV9xsl XM4cUsEQhMFyX6iEYFilE1/pquZ2+jLnJ8EbeZfnC28Aa+oAqo6fXiUHzVZusKC81VsnPHCR8oX75eJ6xZ5mK3Pf/w1RzAm/HHowEjC/i1LsGxNA80sc5MIAkrYOsACyWh/zpuT2Va38qsUJIgn1NE/LPJ6XTlPLC/Xv/yNKXUMUE5sk8GoW2jX0R2BKQOMPoOd9YK+9EI0b6IeAhKJzb1Flk7yyKtLhjsQly75YhMbU3ym8L+1ih1enPZtzRt6ZFnEDufg7RJYxafeGkZ3iWh8lwbqtlL7G1Jn4KZNVANx1KJhPOAWePikzqRtJtcyZu7PmFnd09s2e4l2ZNLyO9ROcN10qkSF+ODXIUZDDX5l73wljXC/f/JeUOTskWexw/bFKK0Dk9kBOzrJ9strW9cagu0oCmkcVG/MiF9EVSw/nFWwYEgujihFLtvnkmf8I+aIlzjqZ8g0Uq5hlB5PHDJ1D++Du525eCiu6cUdvQfbCGxijOu2emoO+GSbjbYqWHz/kTxCQEOJhB42TkJJSttP615aWIwoNyQGgRfUcGz7ZmoGDGaeYWi7WpTe5Wsoux7zy0otMiKxjHpNlqdE1xoVtl2G5K0Emfeyixsy+AqSt0sBGqDAsGuPdvB2dJfhxQ6Vhyq8G0G0aPmEBfQ519TgV6PTEv4pTBR1KfoebQA0JTq10= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000052, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 18, 2024 at 09:31:09AM +0000, Wei Yang wrote: > On Sun, Nov 17, 2024 at 10:56:55PM -0500, Liam R. Howlett wrote: > >* Wei Yang [241117 21:21]: > >> Current code logic looks like this: > >> > >> __mmap_region() > >> vma = vma_merge_new_range(&vmg) > >> if (!vma) > >> __mmap_new_vma(&map, &vma) > >> __mmap_new_file_vma(map, vma) > >> map->retry_merge = xxx --- (1) > >> if (map.retry_merge) > >> vma_merge_existing_range(vmg, &map, vma) > > > >Please don't quote code in your commit log. We can see the code in the > >diff section. > > > > Sure, maybe I misunderstand Lorenzo's suggestion in pre-previous review. > > Will not add these in change log in the future. > > >> > >> Location (1) is the only place where map.retry_merge is set, this means > >> it is not necessary to check it if already merged with adjacent vma. > >> > >> Let's move the check and following operation into new vma case. > > > >This makes sense, but this is a complex block of code. > > > >I'm all for optimisations, but there is already a bug in the code that > >you relocated in your patch, and the backport of these changes isn't > >even complete. > > > >Maybe we can give the existing code some time to soak before optimising? > > > > Sure, when is a proper time to re-send it if everything is fine? I've NACKed, so this patch isn't something we want, but to highlight - ideally when new things like this have been introduced that fundamentally change core stuff, keep in mind we may be very busy ensuring it settles down correctly, and really do not want to be constantly reorganising the code. So for things that are rejigs or small improvements, it's better to wait until the thing has landed in mainline and fully settled down. Bugs of course we want to know about asap, and your bug reports are much appreciated! Thanks. > > > -- > Wei Yang > Help you, Help me >