On 27/03/26 23:41, Andrew Morton wrote:
> AI review asks many questions:
> https://sashiko.dev/#/patchset/cover.1774591179.git.sayalip@linux.ibm.com
Thanks, Let me check them.
>
> I never knew about that bash line continuation thing.
>
> hp2:/home/akpm> cat t.sh
>
> foo=\
> 	bar
> 	
> echo $foo
> hp2:/home/akpm> bash t.sh
> t.sh: line 3: bar: command not found
>
> Huh.  But it presumably passed your testing so confused.
>
>
> I don't want to risk breaking selftests so I'll set v3 aside until
> you're confident we should proceed.
>
> Thanks.

This line continuation pattern has been used in selftests for quite some 
time. For example, a similar usage exists in 
|charge_reserved_hugetlb.sh|, introduced here:
https://lore.kernel.org/all/20200211213128.73302-8-almasrymina@google.com/T/#u
<https://lore.kernel.org/all/20200211213128.73302-8-almasrymina@google.com/T/#u>

  echo "$reservation_limit" > \
     $cgroup_path/$name/hugetlb.${MB}MB.$reservation_limit_file

In this case, it was primarily used to keep line length within 100 
characters. I’ve tested the script  and it behaved as expected.

Thanks,
Sayali