Re: undefined reference to `early_panic'

[Chris Metcalf <cmetcalf@mellanox.com>]

On 6/6/2016 4:31 PM, Andrew Morton wrote:
> On Sun, 5 Jun 2016 12:33:29 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:
>
>> [...]
>>
>>     arch/tile/built-in.o: In function `setup_arch':
>>>> (.init.text+0x15d8): undefined reference to `early_panic'
>>   
> This?
>
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: tile: early_printk.o is always required
>
> arch/tile/setup.o is always compiled, and it requires early_panic() and
> hence early_printk(), so we must always build and link early_printk.o.
>
> [...]
>
> diff -puN arch/tile/Kconfig~tile-early_printko-is-always-required arch/tile/Kconfig
> --- a/arch/tile/Kconfig~tile-early_printko-is-always-required
> +++ a/arch/tile/Kconfig
> @@ -14,6 +14,7 @@ config TILE
>   	select GENERIC_FIND_FIRST_BIT
>   	select GENERIC_IRQ_PROBE
>   	select GENERIC_IRQ_SHOW
> +	select EARLY_PRINTK
>   	select GENERIC_PENDING_IRQ if SMP
>   	select GENERIC_STRNCPY_FROM_USER
>   	select GENERIC_STRNLEN_USER

Seems plausible; thanks.

Acked-by: Chris Metcalf <cmetcalf@mellanox.com>

-- 
Chris Metcalf, Mellanox Technologies
http://www.mellanox.com

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>