From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B507DC28D13 for ; Mon, 22 Aug 2022 08:53:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B9B36B0073; Mon, 22 Aug 2022 04:53:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 468388D0001; Mon, 22 Aug 2022 04:53:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 357216B0075; Mon, 22 Aug 2022 04:53:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 254286B0073 for ; Mon, 22 Aug 2022 04:53:32 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E2448AB4A7 for ; Mon, 22 Aug 2022 08:53:31 +0000 (UTC) X-FDA: 79826615022.26.D8EB9DD Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf30.hostedemail.com (Postfix) with ESMTP id BF72080146 for ; Mon, 22 Aug 2022 08:51:31 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MB5bh6LM1zkWLK; Mon, 22 Aug 2022 16:48:00 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 22 Aug 2022 16:51:28 +0800 Subject: Re: [PATCH] mm/hugetlb: remove unused local variable dst_entry in copy_hugetlb_page_range() To: Lukas Bulwahn CC: , , Mike Kravetz , Muchun Song , Andrew Morton , Linux-MM References: <20220822082525.26071-1-lukas.bulwahn@gmail.com> From: Miaohe Lin Message-ID: <08fec67b-788e-1c9e-606e-903db3bcad67@huawei.com> Date: Mon, 22 Aug 2022 16:51:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220822082525.26071-1-lukas.bulwahn@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661158292; a=rsa-sha256; cv=none; b=O8QhNbgNSF0Mkvf6Gv+wqwReK6xAeGRZJWDIQX3t9n1mcUL0fR9p2KZ42II/eUNRu3jMvS gqB4NnXJnwxO0SOhkBcmt9PyRivYIUy26qniUaHdraHS+EIqrHF4CtsDapGNM3DgCl4J1s hySa+l7LWGLTIcUegMCPBW7lJumq0MM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661158292; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X/9KSsG+yOmpcAY0t1SUshjQa8thYufVkAbmf8TGfdk=; b=2YX9VacDK+rjF1MCU+Ar/+LwfHPoyTKPIpnQPkYe3YiAomSQL+pVyprhLISYz3LLwo6TDc lx1QLhkgoc7esfpQkNHYvrOT++QBDsnkV+QZqoU/lLw3hM2/crdVKh9VDuScHdbRfAUQh7 gumAeTWQx2tLMvqDX/ZVRsZD2ZQ3Xto= X-Stat-Signature: hpogobng9gfgu5njpwdtsd9enurh54kp Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: BF72080146 X-HE-Tag: 1661158291-838316 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/8/22 16:25, Lukas Bulwahn wrote: > Commit a0e4f7b82610 ("mm/hugetlb: make detecting shared pte more reliable") > modifies copy_hugetlb_page_range() such that huge_ptep_get(dst_pte) and the > local variable dst_entry is not used explicitly in this function. > > Remove this unused local variable dst_entry in copy_hugetlb_page_range(). > No functional change. > > Signed-off-by: Lukas Bulwahn LGTM. Thanks for your patch. Reviewed-by: Miaohe Lin BTW: I will send a v2 of that series soon. So the above commit id might change. Thanks, Miaohe Lin