From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35CEDC433E8 for ; Tue, 28 Jul 2020 19:20:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E02E32083E for ; Tue, 28 Jul 2020 19:20:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="Y9eOezwV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E02E32083E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6FC8F8D0017; Tue, 28 Jul 2020 15:20:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D4348D0002; Tue, 28 Jul 2020 15:20:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59ADA8D0017; Tue, 28 Jul 2020 15:20:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by kanga.kvack.org (Postfix) with ESMTP id 402DF8D0002 for ; Tue, 28 Jul 2020 15:20:21 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D1E098248D52 for ; Tue, 28 Jul 2020 19:20:20 +0000 (UTC) X-FDA: 77088450600.23.low22_6304fe926f6c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 9825037617 for ; Tue, 28 Jul 2020 19:20:20 +0000 (UTC) X-HE-Tag: low22_6304fe926f6c X-Filterd-Recvd-Size: 5516 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Tue, 28 Jul 2020 19:20:20 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id w126so11339041pfw.8 for ; Tue, 28 Jul 2020 12:20:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6vfxP0xAICcExvQMz/4lQvBsGt+MbkdQCG7TPtmY2IU=; b=Y9eOezwVV/XNy3ss0E8zEQZN46Jwp7Vwk2F4dYKq4GF+o38CPH9bXtrUXOyKXIv0qi IxCEGapawUVePV3q40k2ellTesiBEzVplHJE1NvfhyL5RCl83HKGBpQJX0QM6eO0a6fq K4eY6mGRbq51nbLdHdV0aIyuHM8uJTGXUryQRTt7Lj0uw/Rn/vzZ7q/sGIcO2+P5vKXM D+ek+rXJ/oXKvUiOA/SsGJJtECe80pX2lqhwV2Mek5vNpO9+e9YTmFR2Dc+dekaVJzW8 tm1bitx5pVI4Q4Wm0OEfzMIXB/vw2Lt3V5PNJbWz7GH/REb/D7Ra0sQgFciGhg/c8Ve4 LbsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6vfxP0xAICcExvQMz/4lQvBsGt+MbkdQCG7TPtmY2IU=; b=BE1DtHahspQbSTKMJ72cLtIpRmbzqImRdvYRy0lRDA4i3Uluhf2tEa9HeLsqcMCq2Y YND5MxVEQcgfceLduT9j4l7mRu3waWZINRZ+TZEXGq7ndTzlahZy0tMwXC+rQ0eeE1XH 4cZkZ+NhW7x7mV32SDiGUt8v7M9T8yqeDShSjK2tIAtQwKoK5VoAwW55b2dX6boIqr4d THkby9zIlqZ0IygjBoKVcqY+vngKbvq9Iosy2sBlIZWVRcT2T7mx9n4A10stIz8/kBBa bGQPnd4gvbkL+BU43m/mEs7TzZRmVb9Pm6UzBpvIj35T6nPH285cAnU0zWuXzqfLQFrY jR4A== X-Gm-Message-State: AOAM531ooBRzsKdpsscHZqNQzzWNqJZLIfd1zhRfHCj2Cp6Mm6R+WEYr BaxnQ4Fh0nDyPZEmVjdewHAVVQ== X-Google-Smtp-Source: ABdhPJxBQ70KSlhfE4UBk48wOVO+oTR3dAvGMGkYXZNgophmfDok6SYnNj9+4QpInUFKqraP2ypplA== X-Received: by 2002:a63:3c16:: with SMTP id j22mr26658462pga.335.1595964018789; Tue, 28 Jul 2020 12:20:18 -0700 (PDT) Received: from [192.168.1.182] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id e8sm8642552pfd.34.2020.07.28.12.20.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jul 2020 12:20:18 -0700 (PDT) Subject: Re: bdi cleanups v3 From: Jens Axboe To: Christoph Hellwig Cc: Song Liu , Hans de Goede , Richard Weinberger , Minchan Kim , linux-mtd@lists.infradead.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-raid@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org References: <20200724073313.138789-1-hch@lst.de> <0b2b59d4-da4c-33df-82b4-0d4935b91e6e@kernel.dk> Message-ID: <08ded32a-cf3a-55b0-6a88-19d201edac93@kernel.dk> Date: Tue, 28 Jul 2020 13:20:09 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <0b2b59d4-da4c-33df-82b4-0d4935b91e6e@kernel.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Rspamd-Queue-Id: 9825037617 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/28/20 9:41 AM, Jens Axboe wrote: > On 7/24/20 1:32 AM, Christoph Hellwig wrote: >> Hi Jens, >> >> this series contains a bunch of different BDI cleanups. The biggest i= tem >> is to isolate block drivers from the BDI in preparation of changing th= e >> lifetime of the block device BDI in a follow up series. >=20 > Applied, thanks. Dropped: CC block/blk-sysfs.o block/blk-sysfs.c:608:16: error: =E2=80=98blk_throtl_sample_show=E2=80=99= undeclared here (not in a function); did you mean =E2=80=98blk_throtl_sa= mple_entry=E2=80=99? 608 | QUEUE_RW_ENTRY(blk_throtl_sample, "throttle_sample_time"); | ^~~~~~~~~~~~~~~~~ block/blk-sysfs.c:563:10: note: in definition of macro =E2=80=98QUEUE_RW_= ENTRY=E2=80=99 563 | .show =3D _prefix##_show, \ | ^~~~~~~ block/blk-sysfs.c:608:16: error: =E2=80=98blk_throtl_sample_store=E2=80=99= undeclared here (not in a function); did you mean =E2=80=98blk_throtl_sa= mple_entry=E2=80=99? 608 | QUEUE_RW_ENTRY(blk_throtl_sample, "throttle_sample_time"); | ^~~~~~~~~~~~~~~~~ block/blk-sysfs.c:564:11: note: in definition of macro =E2=80=98QUEUE_RW_= ENTRY=E2=80=99 564 | .store =3D _prefix##_store, \ | ^~~~~~~ block/blk-sysfs.c:657:3: error: =E2=80=98blk_throtl_sample_time_entry=E2=80= =99 undeclared here (not in a function); did you mean =E2=80=98blk_throtl= _sample_time_store=E2=80=99? 657 | &blk_throtl_sample_time_entry.attr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ | blk_throtl_sample_time_store block/blk-sysfs.c:608:16: warning: =E2=80=98blk_throtl_sample_entry=E2=80= =99 defined but not used [-Wunused-variable] 608 | QUEUE_RW_ENTRY(blk_throtl_sample, "throttle_sample_time"); | ^~~~~~~~~~~~~~~~~ block/blk-sysfs.c:561:33: note: in definition of macro =E2=80=98QUEUE_RW_= ENTRY=E2=80=99 561 | static struct queue_sysfs_entry _prefix##_entry =3D { \ | ^~~~~~~ make[1]: *** [scripts/Makefile.build:281: block/blk-sysfs.o] Error 1 make: *** [Makefile:1756: block] Error 2 from "block: add helper macros for queue sysfs entries" This has not seen a full compile test even... --=20 Jens Axboe