From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 266BAC4332F for ; Wed, 13 Dec 2023 10:32:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7AE386B0489; Wed, 13 Dec 2023 05:32:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 75E976B048A; Wed, 13 Dec 2023 05:32:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 626596B048B; Wed, 13 Dec 2023 05:32:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 53A096B0489 for ; Wed, 13 Dec 2023 05:32:07 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0C3CE1607FA for ; Wed, 13 Dec 2023 10:32:07 +0000 (UTC) X-FDA: 81561429894.20.2C121CF Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by imf06.hostedemail.com (Postfix) with ESMTP id 9FD65180016 for ; Wed, 13 Dec 2023 10:32:04 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=OeWmRn2e; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=V2mKFiH8; dmarc=pass (policy=none) header.from=arndb.de; spf=pass (imf06.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.20 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702463525; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2UvyKqBiEwBjmNleMGmhPJQ0z3wl4PHvvlYjmFYg4wM=; b=N6qPb5gj4S/2dyKTc/GbuWrR3PXdSRt1HhClvuFT1ciipapGyHrdMS7G5HeXgjgMwOMw6i a4sHvdVjf/NQTwjV/hiD/R4vbWzu8+k0GENEom9lPMHnjjkNYm5Ej1PVlYOqkCSkqyJ+E5 4RbWP8FOztLD2zOGpawGaaBxmJRGrS4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=OeWmRn2e; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=V2mKFiH8; dmarc=pass (policy=none) header.from=arndb.de; spf=pass (imf06.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.20 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702463525; a=rsa-sha256; cv=none; b=JTZk1MNtgAY/DV0SX6Qa6jrDmutwuhMFZ4Od0Ky3+M2aj7IAI7Mtt/66+nYzf90KZ6Lezi bSqVKR7oQXtvKdfk+FE4YRd3v30jiJy6U4FpvVHylHYW4F/+gD7MQL1+ry2jA2Df/XBMUf rq9eg4JJU8kV/QSi05umKrI6mhwBNDE= Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id A19F83200AA0; Wed, 13 Dec 2023 05:32:02 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Wed, 13 Dec 2023 05:32:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1702463522; x=1702549922; bh=2UvyKqBiEw BjmNleMGmhPJQ0z3wl4PHvvlYjmFYg4wM=; b=OeWmRn2eRERS+5vXxd87VrFnBT YkG04PZvnByEZGYMK1/I/2rT6STj94A3roYeI8GFldEzkhUdqMLnaSKA25BS7ijb ceLu8Wes5LUUkYF/BSdp36U3nJUu1J6Ed56hBmn8Nl4xXgsJmqyzVVN9U/wMgnA3 CNkJFFmeTi6L56pu+hcEO3gxorOzUlCjWAq439QgXCWJfV9o3GDKl6Ko2EngYLk/ Ie3Yexd6fekxx54z2SUxT3e0A5djt33jGVqdW154UqhdPNomoxI6XLEVz+6KH5qn brT4h6orQci5XFbGsoH4J+8KzsdV87oKTKeIp/I/frBOwhAUtby9GXF2S04w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1702463522; x=1702549922; bh=2UvyKqBiEwBjmNleMGmhPJQ0z3wl 4PHvvlYjmFYg4wM=; b=V2mKFiH8RuiJZx7N7rrcWubLfMlHeOaJaGby+ZRuCOGj mhJn0SSRCAsl9C7iNE+VDKHHjMtelSDlrAQi5KDvAi4yP7S9wm850koP6UsuMhUO KQica2zZ7+NEy+qbi+TZiuUcZNuYOSbdPezde9kQplhdLelS4WnqxawYJsIKXJOb HNVYq+PluFPNUtF10wHX4DlA4EAa6bNLEG/L1ZiI7qYjtESisT+Fp1+t4mz4xVs+ 4vfr73QS8uIZPMVYjkOtf4nNteuHUXR45UorBDjBTsg++t1Zap1ZQ6Bsp5EH0aby UgrebKxTTzzrh96EdLLo0GDJgyOuV9KGsfAbJaZjFQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeliedgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepfefhtdegvdfhudetgedvkefgfeeftedvgfelgfeugeeluddvheeiveeiieeh udejnecuffhomhgrihhnpedtuddrohhrghenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id E511DB6008D; Wed, 13 Dec 2023 05:32:01 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1283-g327e3ec917-fm-20231207.002-g327e3ec9 MIME-Version: 1.0 Message-Id: <08daec27-c762-457d-b576-7f8fa722765c@app.fastmail.com> In-Reply-To: <202312131823.hO2NP34f-lkp@intel.com> References: <202312131823.hO2NP34f-lkp@intel.com> Date: Wed, 13 Dec 2023 11:31:41 +0100 From: "Arnd Bergmann" To: "kernel test robot" , "David Howells" Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, "Linux Memory Management List" Subject: Re: [linux-next:master 7115/7300] ld.lld: error: undefined symbol: __bad_xchg Content-Type: text/plain X-Rspamd-Queue-Id: 9FD65180016 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: fbia9iscdeccquqyezhhox5t96g6woa9 X-HE-Tag: 1702463524-127415 X-HE-Meta: U2FsdGVkX1+d4hsZ5yR/LXl05OcZ8MP596nTfglcguz7Ot7jGINgZXCk3MQOgidA3fvsnuLm+AXO69LmqVvrRTDFX3YuQUYBvF5Aey7fuF+imMQI9jILDkdSQNohc3eARyEN2nMNxnayHaWFhzSDECHCzhIc1rJvPExUHo0O6AOmik4PdEmefaOYlxHK9vaUOkWQtdBC8Iz//wOkUVh5MwvYk68Cl02yLLL4nvR6l5rdgj9zjGjhVBkvJwEPTKsjzpudo60IuM0WF+gWDMQMCO2tsaDRfs/ikIgKZvLIQqZO45rYc88u9VJB02xE+GlfmCv0cJnTIeD9Y893aKqJcMG+RqV2lkJXGprxSCdWmo+7h3xDwaL1ZG0FXMS5xJwpyrBQPa5LvlFj6HfQeNcFUffxbwQ5Vo/EzC6speJBfgUofdRCM7W9M9+We+9lPc8qbq6gI3TsQuuhhQAQAB60Kkqd9qKK4nT55p0FESjWwpqjiemzwRKymEt4R3z80rXd1Ku6/2cARzHWdA27wRbjuQKrOnKZSfTU63B5VuHITGJFm2xIn0mnQrBKNkYu5nK5zGfo+4K8O+gUDEIdcgE+eceIv+nmPR2oxUi8RmRedKgEN3MKWVlzGKAux0FH2WPNbYTO4nnbV14PWyM1H+/T2FJlicj6Tgd+sPMzKpVw1Ov8OQ5mLwFKk1uXVN5FT32fpK7Z72mtqN1nlcdOpDBhpvKV2d/ieQRxIrqwoXmqilcj3YJUYK2xTHVwEwzxyRRTVRmMyIUjTkP7gtADOVoHeO8ARSWJSE3i7+IhnNExlGffySeeFaz/yiITMFN1Pfs1tk8kPqPRign0XERncwNvw1Fx7asVqomTla6ysStnlqgnXDaHSA32wSASevY5oS3UFX1sUjZfCl+t66dkmIaFZkMjk4IdQ2fbGS0nNbUASC2zbvWrdc6EbGIV1WDCS2dtkwvI4YxcFCxDmUYpyV/ yrBCYcVA CcgV297830+B/OU2K03HEQUOYE56C2vu3UayGojnrtlj7ql2XLbCG6W/b4xouw97XOhLPiL4Iz4FJs8v4oMo0W4rQ12p77DE52aWDSeeYCdoQRXiaFPWlZSM1lY4FGd8NyXbgtq7wPtIuJJtX9XGOWP9r6oBIJRXaXYDRUwRkub7kw+HZSdtQ8c/cxgGtr94Jp8IJlo18+NhCRBhv7yr663YTCBMWk2nneQyH/6RNdT2elwYRAzyMdleLpu/9ilOZPEBUiJLi9xSrBU5phVFHHDHlft7aWLRriidG5TzVglvIEA0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 13, 2023, at 11:05, kernel test robot wrote: > commit: 4a0d72ea10ce156eb2 [7115/7300] afs: Overhaul invalidation handling to better support RO volumes > config: arm-randconfig-003-20231213 > (https://download.01.org/0day-ci/archive/20231213/202312131823.hO2NP34f-lkp@intel.com/config) > All errors (new ones prefixed by >>): > >>> ld.lld: error: undefined symbol: __bad_xchg > >>> referenced by callback.c > >>> fs/afs/callback.o:(__afs_break_callback) in > archive vmlinux.a > >>> referenced by rotate.c > >>> fs/afs/rotate.o:(afs_select_fileserver) in archive > vmlinux.a I saw the same thing, and this seems to be broken on all 32-bit architectures: @@ -79,9 +79,9 @@ void __afs_break_callback(struct afs_vnode *vnode, enum afs_cb_break_reason reas _enter(""); clear_bit(AFS_VNODE_NEW_CONTENT, &vnode->flags); - if (test_and_clear_bit(AFS_VNODE_CB_PROMISED, &vnode->flags)) { + if (xchg(&vnode->cb_expires_at, AFS_NO_CB_PROMISE) != AFS_NO_CB_PROMISE) { vnode->cb_break++; I tried to replace this with xchg64(), but that only exists on one architectures (unlike cmpxchg64(), which is on most but not all 32-bit ones). If this has to be an atomic operation, the only portable way I see is to change cb_expires_at into an atomic64_t and modify all references to use atomic operations. Arnd