From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F25A0C02193 for ; Tue, 4 Feb 2025 20:41:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85C68280002; Tue, 4 Feb 2025 15:41:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E532280001; Tue, 4 Feb 2025 15:41:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65F54280002; Tue, 4 Feb 2025 15:41:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4425E280001 for ; Tue, 4 Feb 2025 15:41:39 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EA2A9140146 for ; Tue, 4 Feb 2025 20:41:38 +0000 (UTC) X-FDA: 83083433076.07.088576E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 8482EC0013 for ; Tue, 4 Feb 2025 20:41:36 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cQzj4rTY; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738701696; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=756onm9SaiF/RTT8cEu/91K4nMKJxzo0rdjfNMK8HaU=; b=ezeLS/xP3pcWynTjNDLGHnit8Yr5gLpW1c5bpNTu7WpjrtqTD78k5dglWatKvvYYCWAI/C EzTy98Xrc+mZuLmbwYfvgd1zMFNPbfKTTk+901qcQn9RJC9NvAte98hjL/hWI2wmfPROnH Q4JnNVIsxSEAGOsNUS08gDr7U3S+kPI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cQzj4rTY; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738701696; a=rsa-sha256; cv=none; b=gneKwdqaDbYLgr5FPDNjk6GYA+bhYBc/U7+gUMG7BEOVEXlatM269Fj1lKKBmcKmbQqvtl ZdXW2FAn9G5blIOBS8U9SXY1F9uZKEEmBjwVbzbstOH+p2Bp7wS6HjK+iuOX4v3vNn+m+f W7V0+H9LJDvN7N/CcXu8Ivf71C6h25c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738701695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=756onm9SaiF/RTT8cEu/91K4nMKJxzo0rdjfNMK8HaU=; b=cQzj4rTYto9DC0rDg2jacdDmPMIPJMsBKE0AxbX+iHFwg+dVU778MF/fGqkU8fVeQ9F+dA daTzxrsHpN48w1u0G2E1gxLqbplnsCVcSUgalx50V0FbY3w5d3eG4a3ERWpARyurJR7fol cdWZwjQ5J4ZqSwmddNFLhW03MmSSYD0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-329-Ua8TvcqlMviSO7EumqcRtQ-1; Tue, 04 Feb 2025 15:41:34 -0500 X-MC-Unique: Ua8TvcqlMviSO7EumqcRtQ-1 X-Mimecast-MFC-AGG-ID: Ua8TvcqlMviSO7EumqcRtQ Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43646b453bcso30264055e9.3 for ; Tue, 04 Feb 2025 12:41:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738701693; x=1739306493; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=756onm9SaiF/RTT8cEu/91K4nMKJxzo0rdjfNMK8HaU=; b=e+rPSEemRMvc2OJuNOkpchgp5bvAOpqoR55l2CPmCXwQSxs0T7apr1UzGoaLKIBrQZ IZMO/RRVEZSEV62WGiTacl6ezKeGovIUs2C/5CUQs9J6f2z87CkD4icQcLSI8opdfeBn vVU3ISlxoBkJzmhfqLljXyf2Zx33FpbatlVGnGDS5+qhvLb2I3xzMsNEtDaitSh+SKRW lP+YNRfce8UYIqBeOCYde+OrRVRtn7F1h2pvQVqFc29D34tPsuMmMeuHlu3W3pHiGDwA WD3/4z2G4B3pWa+c7qyI3JO1TmjhnX+hspaVf2N6iLgeQTjJZ0QEcSs3HPTkp3k8PMTf Jxmg== X-Forwarded-Encrypted: i=1; AJvYcCWpQGKbAgNA5a373G/6Qr0Lj8VPywSCfQitX37oqJLUprgoZRY49doyjoGlOLEAyh0LKddzZW3lwQ==@kvack.org X-Gm-Message-State: AOJu0YydBQt7cYXsUBBC8GlBNHzfxUUvVewnBosMl+XVRFEBa4yB28dF +WCzhR+tL6xQIQ6creykyB/nsBdt/aVjhIXtBonjmBjUr0MQymp4DkpLlL/Gzb0pZUOBKUiwM3K sfOyh1ff9X25fMw0QvJz8AxTjNYGsxH825T6JHRd+su23iHrf X-Gm-Gg: ASbGncvDEdiCMI5VcGRfAkeRaN/KZbZG/LDrX5rNilq1SHjOBP089gAsbf6WpG7wkE1 U6Pf0N/qZO1UYVk+cW4e9kHf1y6EoSC5bb84kev4eLSxnhOZ2wM+85IkkPmZHAdAMQUu8S5aTQU Fkk3aOS/vIoQo8kppsHtk3nFbagpkVLCIuMzX8QCX8m2WfIKTkN1oX2TR1qzKZ8gxmklHK3OP14 o0hooYlIJArO6TErbFXyrzH/+cRLREsz5l1cJZ7E67A0zS+6zh/gKokkfFI+omUWWiZVlYLmBt7 NSJ4WLVdQkBgBu+4NIwOxsGO4Pv7L1M7CjOePhhbnlbrbUuMQYqaKyQg2zMffksHAiBhF0mRZoK yUBsdXIyFxbzOgEF/3zWwcx1uTQw= X-Received: by 2002:a05:600c:5112:b0:436:fb02:e68 with SMTP id 5b1f17b1804b1-4390d42f7c5mr546385e9.2.1738701693457; Tue, 04 Feb 2025 12:41:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IHcWlZw4eJvcxbYnSulvZuQawICjLqew9irCZxtfosmn3w3Phu8MvPHgrklUczGiYiTiVvfwQ== X-Received: by 2002:a05:600c:5112:b0:436:fb02:e68 with SMTP id 5b1f17b1804b1-4390d42f7c5mr546225e9.2.1738701693147; Tue, 04 Feb 2025 12:41:33 -0800 (PST) Received: from ?IPV6:2003:cb:c70a:300:3ae1:c3c0:cef:8413? (p200300cbc70a03003ae1c3c00cef8413.dip0.t-ipconnect.de. [2003:cb:c70a:300:3ae1:c3c0:cef:8413]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dac5a3e79sm2706524f8f.63.2025.02.04.12.41.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Feb 2025 12:41:32 -0800 (PST) Message-ID: <08ce9562-9ded-4d95-a495-b60f90d75490@redhat.com> Date: Tue, 4 Feb 2025 21:41:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/6] rust: page: Support borrowing `struct page` and physaddr conversion To: Jason Gunthorpe Cc: Asahi Lina , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jann Horn , Matthew Wilcox , Paolo Bonzini , Danilo Krummrich , Wedson Almeida Filho , Valentin Obst , Andrew Morton , linux-mm@kvack.org, airlied@redhat.com, Abdiel Janulgue , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev References: <20250202-rust-page-v1-0-e3170d7fe55e@asahilina.net> <1eaf66ba-b2d3-448f-938b-913f17ca98a4@redhat.com> <20250204183933.GJ2296753@ziepe.ca> <1d379007-97c3-4bb9-93da-1a828f955fc4@redhat.com> <20250204202656.GL2296753@ziepe.ca> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250204202656.GL2296753@ziepe.ca> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: y98Qv7r2Q49qQX2Y3SMTqf06pa-NlEUWgzU96HibRf4_1738701693 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8482EC0013 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: dyruuhkah531umb8w7pa4nfh4841wgma X-HE-Tag: 1738701696-739522 X-HE-Meta: U2FsdGVkX1+xHo1i5OCO8phr1mQEQ0DHaWYalC24vEawXGMV8KcDISiT9QGt2VTDnlc6ZGkkokHIkZKnJPZbCN0XXOktfYmGEL8IYZwQSZgVyzxWeBEbWd7+vMP1dWljv+7cY2XAUmzmvktJFpGat1CrxkRGiJ+4EnfyNZY6aUXaar9+W8v7IOzX96SBO4zp/4DwryghsqJajJDNIA/Wwm66JFlpw4qILELbHVkC2LvILGOrtCkUcsh+lRPiEE6rBMxuVt8M6DqKb5Z9flLfw2/iOFGqULnpmJfpL4CKARNFx+gwaiG2VzqYuPMy6Ae/d+RoUqKVQB6G9xwUsw2SdjmLE8k3BWa3779Ku+Ikp0aG6Lu1C0QlVf4zTcxp57E8US7iKSE3yfb30AmnxePRuKg2VmX+Q+qoc2EmJf1M5K3lGVCnMsR3/iZBZFmODghA3ILWifXc/TaE9cxH34r1nts3FnutFih17dF59jMFMMmRed87KmASj3RUs2x1VS8XZtgf5I/avy+W0X2z2hzPO76vaCtwcv8wShfK1vBUDKt6N6VbkNZiYkiQc7MUKAyVLDjoSiEZLeophFDWBpVqWyaLsjYYcvPTDm6VM3gz4BH7am2ypoVs1IKhMJ189aaJU2RR2+4AJsdfo4vJDjjuAuvC6uxSG7+KOERfBkFWz/OCohW+fmrvSTLIWuBWXmdbZuthzzywTEamWDJ51og3zOGZZ67m0+UvO/gc0kAMmCoyzW1pF9FXL1XtujGJC1ShuHGY3E3UDJsFpnDtCo6Q0Vz8FAeVoVaHqjDjnE59fQ2ugaJLwlzI+XcsPWyPbOvdyfaL5jRR3zuRnk4T6HgJixyk4AQpsOXBmh5p8r+XoCAudF79kkKemRsVrp7IfvVuBuYnsXfsPtbnP4Nq7u42PRMFODWpfhvq0vnl5NlGjURp96TawwHHOVLx5Z23D3jKtr5gDcYzN8cXxrH9BF3 B9z1y1Jn lIclBv9sXBbJ10auyjq4cIPWzW1cPj0sC3CKqqxp84OB872544+hC5WL/+bjcDglLGmoT2ivhTykqA6L6xyt6K9qnltSST7w6+GL6P2XAgHJ/1qGQw8DaPK3hKPn7hix77wyRLx/zXxiuZaX4DafdTru22n24l9osJpZqWxu4wxoMQqwCOi/VDNZFqB78pS+6zR189KP/3bGg5XxBbvkleffqnpy9dZGZ3Q3ajg3s5zIBwvea3TcLEa5f0jfULKzBS/LjZ4y8t/0Fxm2/OqLKHlTEmzjr6wIzwve/+XCwBLnhktMQc5gykT1lrNhl3a4oRqT3Q1vmMKQdOUr6xvcSg76d8Rf4tyg5skAG3Cv//wOnSzCVVDf/FX/WYMnZ3sbxpXFs35Vsv/QNZc6ru4o6ycQ9+/cH/Xpyq2PYIjkWnMrVSS6zdIgx4jFO1Y2miZxvkvgLZLQKOVIhWE8f1y8Z/S93eA== X-Bogosity: Unsure, tests=bogofilter, spamicity=0.499958, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.02.25 21:26, Jason Gunthorpe wrote: > On Tue, Feb 04, 2025 at 09:05:47PM +0100, David Hildenbrand wrote: >> Fully agreed, this is going into the right direction. Dumping what's mapped >> is a different story. Maybe that dumping logic could simply be written in C >> for the time being? > > ? > > Isn't dumping just a > decode pte -> phys_to_virt() -> for_each_u64(virt) -> printk? > IIUC, the problematic bit is that you might not have a directmap such that phys_to_virt() would tell you the whole story. > If you can populate the page table in rust you have to be able to dump > it, surely. > > Or do you mean trying to decode the leaf entires into some struct page > detail? Does a GPU need to do that? Agree that would be better as some > C function to take in a KVA instead of a struct page and populate a > string with details about that KVA from the struct page. > > Jason > -- Cheers, David / dhildenb