From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65AB1C4167B for ; Mon, 30 Oct 2023 17:55:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C6F916B0270; Mon, 30 Oct 2023 13:55:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C200F6B0271; Mon, 30 Oct 2023 13:55:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC06B6B0272; Mon, 30 Oct 2023 13:55:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9E8D36B0270 for ; Mon, 30 Oct 2023 13:55:15 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 526D4160A0D for ; Mon, 30 Oct 2023 17:55:15 +0000 (UTC) X-FDA: 81402879390.06.1C0AC9C Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by imf12.hostedemail.com (Postfix) with ESMTP id B5A374000C for ; Mon, 30 Oct 2023 17:55:12 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=GMR0z6Uc; spf=pass (imf12.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698688513; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bz3E77vipJU/WDyJ2DauiHdFSE2FV6B1cTtCXE/voko=; b=MO9R2LMvonn7hlhg7M2UYo2tIq08uoWSbBl1AaCQaQawz9RLwdUbuVGTHWcGXszGAFT6MH lblonedowDSzAdfSAWCDnPUvahTCfYTM/MEtu31k6T07HmQz9s1a4baPrSZ6G9BV/R1qrL aZ8jRGSt4bVpvDYGJNujjO9hICkY9QA= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=GMR0z6Uc; spf=pass (imf12.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698688513; a=rsa-sha256; cv=none; b=W0Ir7dlFAjy91IgjbG/3NdCD2HxzupcBtagVQ3YNZOddMQnJOavcy0Fc3CUwBf0GkK1djF rOc/wjKDVzo5xDo3NNlNNN2nWaYy1QDsokxq06TQ3Cf2UEeP+NufTFJjvdk423z/CsUOgs EsFQ2vv2wH3A6CjqBMv1mjKQVoMEn4A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698688512; x=1730224512; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=sSi2JtSUsz2H7PKzA6zmKqMWMWKSyJvY1o+BJcdO9Xk=; b=GMR0z6UcoGGR8cYaGwXVmyTTKWJduqOKw0lVDBMu5Zo9enst+jH38dSz ohCNK/NZpkGd5RrBNlw+Fvs/iGKMl9fqAG0A24bSze2zqkY6XbqKlCwQP V561uKuw2xRyMU/2smRgoOSoLRn1ZCt3X3TsIVbPOz/UE4ELmSVN4yBpV S/+TLguVlcIkf8Klz6xNReyyBWiHhj5iAHlCBVdR+94Vb9T9tVLBPvEBe dDEkUIvKuNEotVoHAbVVJj8znOhIVR3umfOXvF7jNrBscH9uKBuffP3WB +MgBldUMrm8N2i5+ccD0/NIxiJsi1ct6SuBmqRvwgmGqOfpyYrY3t/RrG g==; X-IronPort-AV: E=McAfee;i="6600,9927,10879"; a="390993007" X-IronPort-AV: E=Sophos;i="6.03,263,1694761200"; d="scan'208";a="390993007" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2023 10:55:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10879"; a="850991782" X-IronPort-AV: E=Sophos;i="6.03,263,1694761200"; d="scan'208";a="850991782" Received: from rgibson-mobl.amr.corp.intel.com (HELO [10.251.7.5]) ([10.251.7.5]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2023 10:55:08 -0700 Message-ID: <08c82a91-87d1-42c7-93c4-4028f3725340@intel.com> Date: Mon, 30 Oct 2023 10:55:07 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v3 0/3] Reduce TLB flushes under some specific conditions Content-Language: en-US To: Byungchul Park , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: kernel_team@skhynix.com, akpm@linux-foundation.org, ying.huang@intel.com, namit@vmware.com, xhao@linux.alibaba.com, mgorman@techsingularity.net, hughd@google.com, willy@infradead.org, david@redhat.com, peterz@infradead.org, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com References: <20231030072540.38631-1-byungchul@sk.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20231030072540.38631-1-byungchul@sk.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B5A374000C X-Rspam-User: X-Stat-Signature: g6j7s4myc69tajykfp8dfmk9g1iqj4p5 X-Rspamd-Server: rspam01 X-HE-Tag: 1698688512-742369 X-HE-Meta: U2FsdGVkX1+ywLqUz8iEkx7ZaVamMcXnQDC3prT8gDgpc66Sl6/ypoGWSYah9ggQNuFh9FYpSD0QhixyCHsOmGNhfptgfdL++OUUnSJHlgz2G7YL7h6xjGEzJAoRVfSWhNr3IcG+K+S48XrcGXZLjmi516IlPjjndvVcNVHTV6EqYuZL7FqkYNcaBD+EQw+QHPlBc9LpeupGJO14ZN/TtIXDTkDaEXAjxDz7g+c8ujbo5QL6EoVCckHXGUoIc0LadS2WC4FR9zLyxje6OumOx+LtaCoW0eceMHbS8dThrPhNnPJC7Zwv+Kc1SPy6Av3Qs6E/Ajd9FjZCu5ommEH7TnwJJ7TWGU1krVqjHL344+LwaLYbX9a7BGxTQx6rK7MfoHskMQ2ZWa+bZmQ9v8Bl4my99wBaUNDXZkF7utxJSb8G1cfdKxlkOOJGWM+f1p9dvkWtQfpj3bDBy7P6meqBZlDgAflPiOKVu6RiVDUVdVeQQlmSRRV57lYY9cb1dd1/SOMRPsF0508LztmGhWEKLDJHcC3IUVUq9NrCLbJoBWuzTVfSinoqU7HJyvBOwWFAOjB6/3EYIwkZBrWqwiZsZWc0RfTIcfld9zFqH3BEhyDZbQvRYsZfo+TPGNoVxM8W1AOjObS4JhKi4cWPtgXOb2JJcH7JAfBiaPIqWzrLlXw7wEs1dtzvBsSzIkWl7tJO9UR1Jrfl5oNPgywYY6tjzkVVq9wn9GWyyWystbTZa10cu7t0UK0PNBPMj7hhlwInRPKoMAsKSQ2o/E3BbfO50S6SQA5BctJcxaljUdB4ow20cW1XbfKe0R2MG+iQUKZpAH75cqEk5EsMXGGM0DIJHPqYurFyYTFsjkwJtgRYkMSs/OGYHVjzkNTTGdf6LX+lr5S7PSPCByoG1WfMlHPnUiU/DklF4R1V08SAjVkVE54fsUkxtf9ohR27CjhTP1RfXAQsYl3O9inWBkoXTgl p0gljPO8 5vb30UQg+SGKoqWpqdXGx4yodeZLsCDgmKQEn/3tbl7/qC0uTCbgx0UWFbl6DvZctyJe5ZlC3stUd3nyJq/nVIqbiKL+DkB0yf1H6NbfBk7OpJ5D2tSk70flNa88veJKHDKyHRur3XOCe9jshRLy4ZyYLKA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/30/23 00:25, Byungchul Park wrote: > I'm suggesting a mechanism to reduce TLB flushes by keeping source and > destination of folios participated in the migrations until all TLB > flushes required are done, only if those folios are not mapped with > write permission PTE entries at all. I worked Based on v6.6-rc5. There's a lot of common overhead here, on top of the complexity in general: * A new page flag * A new cpumask_t in task_struct * A new zone list * Extra (temporary) memory consumption and the benefits are ... "performance improved a little bit" on one workload. That doesn't seem like a good overall tradeoff to me. There will certainly be workloads that, before this patch, would have little or no memory pressure and after this patch would need to do reclaim. Also, looking with my arch/x86 hat on, there's really nothing arch-specific here. Please try to keep stuff out of arch/x86 unless it's very much arch-specific. The connection between the arch-generic TLB flushing and __flush_tlb_local() seems quite tenuous. __flush_tlb_local() is, to me, quite deep in the implementation and there are quite a few ways that a random TLB flush might not end up there. In other words, I'm not saying that this is broken, but it's not clear at all to me how it functions reliably.