From: David Hildenbrand <david@redhat.com>
To: Sumanth Korikkar <sumanthk@linux.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>
Subject: Re: [PATCH v2 2/4] s390/sclp: Add support for dynamic (de)configuration of memory
Date: Fri, 10 Oct 2025 10:16:04 +0200 [thread overview]
Message-ID: <08baaace-3141-4ef0-869e-c80e216c55ca@redhat.com> (raw)
In-Reply-To: <aOi_PL68QaY2YIAg@li-2b55cdcc-350b-11b2-a85c-a78bff51fc11.ibm.com>
On 10.10.25 10:09, Sumanth Korikkar wrote:
>>> +struct sclp_mem {
>>> + struct kobject kobj;
>>> + unsigned int id;
>>> + unsigned int memmap_on_memory;
>>> + unsigned int config;
>>> +};
>>> +
>>> +struct sclp_mem_arg {
>>> + struct sclp_mem *sclp_mems;
>>> + struct kset *kset;
>>> +};
>>
>> Just one thought: if you keep either as global variable you wouldn't need
>> this. (I would just keep both as globals, but whatever you prefer)
>>
>> Whatever you prefer.
>
Feel free to add my
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers
David / dhildenb
next prev parent reply other threads:[~2025-10-10 8:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 13:18 [PATCH v2 0/4] Support " Sumanth Korikkar
2025-10-09 13:18 ` [PATCH v2 1/4] s390/mm: Support removal of boot-allocated virtual memory map Sumanth Korikkar
2025-10-09 13:18 ` [PATCH v2 2/4] s390/sclp: Add support for dynamic (de)configuration of memory Sumanth Korikkar
2025-10-09 19:13 ` David Hildenbrand
2025-10-10 8:09 ` Sumanth Korikkar
2025-10-10 8:16 ` David Hildenbrand [this message]
2025-10-09 13:18 ` [PATCH v2 3/4] s390/sclp: Remove MHP_OFFLINE_INACCESSIBLE Sumanth Korikkar
2025-10-09 13:18 ` [PATCH v2 4/4] mm/memory_hotplug: Remove MEM_PREPARE_ONLINE/MEM_FINISH_OFFLINE notifiers Sumanth Korikkar
2025-10-09 19:03 ` David Hildenbrand
2025-10-10 8:24 ` [PATCH v2 0/4] Support dynamic (de)configuration of memory Heiko Carstens
2025-10-10 9:02 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08baaace-3141-4ef0-869e-c80e216c55ca@redhat.com \
--to=david@redhat.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=sumanthk@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox