From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5175C2BA18 for ; Thu, 20 Jun 2024 08:15:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 725698D0091; Thu, 20 Jun 2024 04:15:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D5086B0323; Thu, 20 Jun 2024 04:15:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54EF28D0091; Thu, 20 Jun 2024 04:15:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 37A076B0322 for ; Thu, 20 Jun 2024 04:15:28 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A4C0FC18C0 for ; Thu, 20 Jun 2024 08:15:27 +0000 (UTC) X-FDA: 82250557494.14.C16E44F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf23.hostedemail.com (Postfix) with ESMTP id 32578140011 for ; Thu, 20 Jun 2024 08:15:25 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=eQhJKfA0; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=qzwhm4Ss; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=eQhJKfA0; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=qzwhm4Ss; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718871313; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Fvlm3C5vCJy0iEYaOW+YAnAFu3fK55puTAJQWNbdkm8=; b=61FzxAvJ0UBOH2K+GPXP6D0brtRLUOgKOVNQG6F1upK6+wWyEKd0IPcQ8a5ffyLowpEByP i47WxUjDdrAyhjiRR7A+A2K08Ss7GoGR5lAPGJHXtwV63UopzTs5+XnHAlBSuTZxi4S5UO qEqbMrFcXBV4Nv6HEWODGSN5wUw53Bw= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=eQhJKfA0; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=qzwhm4Ss; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=eQhJKfA0; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=qzwhm4Ss; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718871313; a=rsa-sha256; cv=none; b=1gfgQPBNE833q76XtfOAbv1seKQaFecG+k1zvod2SOhth1gNio6odqap8i95oUgvD0/itp d+gSVQh/s6ddsmag7nYloXLe7KFlZQ10sF7oAaIf5VFHEq16i9Q2xe6nXePPCxjE+ig0lF P/SbMFWFLt0gg/2Ue7hB5pBikSaI9nA= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7473421A82; Thu, 20 Jun 2024 08:15:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1718871323; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Fvlm3C5vCJy0iEYaOW+YAnAFu3fK55puTAJQWNbdkm8=; b=eQhJKfA07fvgSF2znsRBUXYjn6epcJCX/c1rMfIPmrVVEmCNk/8ysqfzX3alyoirCZciLd 1XbUodF49yiurilr6AAci7zKf0vseDpg63ioux95o59Gb0Gy/IYTgwekG23XaCmcnqxiAy sXvZQHWYmlPK/dcnq5dzlLRerauiDIU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1718871323; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Fvlm3C5vCJy0iEYaOW+YAnAFu3fK55puTAJQWNbdkm8=; b=qzwhm4SsbhIOIRVqjyQtt07xqic8p3Z6buw21YU+1BxhxQSwiW+8SBdbyRqFhMy75Km5r+ KmZ1rFxhzQ2j8QDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1718871323; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Fvlm3C5vCJy0iEYaOW+YAnAFu3fK55puTAJQWNbdkm8=; b=eQhJKfA07fvgSF2znsRBUXYjn6epcJCX/c1rMfIPmrVVEmCNk/8ysqfzX3alyoirCZciLd 1XbUodF49yiurilr6AAci7zKf0vseDpg63ioux95o59Gb0Gy/IYTgwekG23XaCmcnqxiAy sXvZQHWYmlPK/dcnq5dzlLRerauiDIU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1718871323; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Fvlm3C5vCJy0iEYaOW+YAnAFu3fK55puTAJQWNbdkm8=; b=qzwhm4SsbhIOIRVqjyQtt07xqic8p3Z6buw21YU+1BxhxQSwiW+8SBdbyRqFhMy75Km5r+ KmZ1rFxhzQ2j8QDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 51A4213AC1; Thu, 20 Jun 2024 08:15:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id f06QExvlc2aMXQAAD6G6ig (envelope-from ); Thu, 20 Jun 2024 08:15:23 +0000 Message-ID: <08b38709-16f1-44d5-9808-b135e290d2b7@suse.cz> Date: Thu, 20 Jun 2024 10:15:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/7] bpf: do not create bpf_non_sleepable_error_inject list when unnecessary To: Alexei Starovoitov Cc: Akinobu Mita , Christoph Lameter , David Rientjes , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Masami Hiramatsu , Steven Rostedt , Mark Rutland , Jiri Olsa , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, LKML , linux-mm , bpf , linux-trace-kernel References: <20240620-fault-injection-statickeys-v2-0-e23947d3d84b@suse.cz> <20240620-fault-injection-statickeys-v2-5-e23947d3d84b@suse.cz> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 32578140011 X-Stat-Signature: y4c91n38xkhzs9z7q568bjdfqg9nrchm X-Rspam-User: X-HE-Tag: 1718871324-456679 X-HE-Meta: U2FsdGVkX1/cV8Rs39Qy9ZjZBu7zFhzbjeugVtRBd+E1ovPR4ZgHV3a9YSfR4JnKUNSPrrOgyDLqtQhPfF5kUo2efdm/w+5A8kQ3olBX0nEKlvVz4tStCDmJRdMyAnw9MIwynUzpwgbTLNUex5yftIN4gOgJiCPitExZikjpN2bH5uAah051NSVTSphux9AKFxOQ1EOVyTOLArr1mV7Mo5Gm9mbEmzR8ry5uieG2fI7L8p9AuhP/NFH+HeHteSiOrWB/f/ZPJsw4b7kkccJC7K7SWqgo2gTn2NvV38N8tU/TMIdEoIv26eQX28llnynF9LssuY2sJb1bmsaYibg81awYs82A+ybW0Y3ntGeiTclTXDy7MWOilg+mOeDIfd1czazgvPiUb+TsXlYkVVLQh4pdYMV3eBDdAmS8JKl2F/WzH8NL4jrN4w78yH9UDQwGU1x9Pe0BT6bFx1TOjrzruCQyBkzMgjYLTUAhxIsyRzwPWII44QZ5KfQMvR6JUfIBvfn1dCwEUeW3jKMgi9HMt7lQI+QUKwJWa6+B++ecdwNPmMXAj+dOctX83+AVU9ed5lJ9A3Z6MC2IMIOTIGmU8YVSk6fu5BM8NvugQgkrje6kD5QiWRQVGuEYUfvZAPnpqVxWwNpI+hNIPZhkMEe+npRVlpnT7uQ49pMhvtS0n8rDTyYMaTXAb2nY7YGRxAEBZfaRkHRVw3z2Nhu+zd0BYUBmiMr5DIWVlQZkClo2xC4CSTb226rfpULtlxXB2/+2+oiTJSmIzXHDlJq3pxJjlzW5UtKOECQXWlFLk9+Z4TxCmKt1YEeEIZ7YYMvjrAf2GMDe4xNLJw7knxXgi2QqCFftsoB5QwQpjVcu3LMwUhiXUG92uLlvMqeUA1uBKgXz2EdnFpjOWcmYsxvVLCXFNd2UuyypKpzhVu6ftYwJeB5n/27TNRr6WAA2Il+1+O2+79B+8dzMUfU+VObMdiM ObhSlu73 CW8Eb3XD7kvzmF7j3EbCJ6kTV+iBHPWnMaCT+jMc7ZZbgqGAsZij0J7Nfjxizc9rU/YGcduvZzEsWEgN5rtfy7DIRhwpUkceKkfPoTVDLvkU4xJ33r72Nqnwtrddb9KuSfx5MT6Ep1eRb1swAG7g5cI3f1zrRCS3RFLIYPPokscxoaWF63khaC0XuN4bcNhj8JjShy6sHpws/ATrChYPI/ZL6jXn8Vpeo+ItSNHvh1NUWCyjJ98yxImrWmBAXlAZHv9iNbmCoQghLwwQHmHAzJ7jh3AvPBCw8Z4m+N4FIdTQwQIHKkCMLCjWnmV9+qbxC/pDcN/zqOqh81ujjL/j2rABxX2sOOBsSykmUPZXrMbcwy9nPXbDhHgwyW0nnFXuv3PCVgaFOLYl76PeKK3oQIBuAQA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/20/24 3:18 AM, Alexei Starovoitov wrote: > On Wed, Jun 19, 2024 at 3:49 PM Vlastimil Babka wrote: >> >> When CONFIG_FUNCTION_ERROR_INJECTION is disabled, >> within_error_injection_list() will return false for any address and the >> result of check_non_sleepable_error_inject() denylist is thus redundant. >> The bpf_non_sleepable_error_inject list thus does not need to be >> constructed at all, so #ifdef it out. >> >> This will allow to inline functions on the list when >> CONFIG_FUNCTION_ERROR_INJECTION is disabled as there will be no BTF_ID() >> reference for them. >> >> Signed-off-by: Vlastimil Babka >> --- >> kernel/bpf/verifier.c | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c >> index 77da1f438bec..5cd93de37d68 100644 >> --- a/kernel/bpf/verifier.c >> +++ b/kernel/bpf/verifier.c >> @@ -21044,6 +21044,8 @@ static int check_attach_modify_return(unsigned long addr, const char *func_name) >> return -EINVAL; >> } >> >> +#ifdef CONFIG_FUNCTION_ERROR_INJECTION >> + >> /* list of non-sleepable functions that are otherwise on >> * ALLOW_ERROR_INJECTION list >> */ >> @@ -21061,6 +21063,19 @@ static int check_non_sleepable_error_inject(u32 btf_id) >> return btf_id_set_contains(&btf_non_sleepable_error_inject, btf_id); >> } >> >> +#else /* CONFIG_FUNCTION_ERROR_INJECTION */ >> + >> +/* >> + * Pretend the denylist is empty, within_error_injection_list() will return >> + * false anyway. >> + */ >> +static int check_non_sleepable_error_inject(u32 btf_id) >> +{ >> + return 0; >> +} >> + >> +#endif > > The comment reads like this is an optimization, but it's a mandatory > ifdef since should_failslab() might not be found by resolve_btfid > during the build. > Please make it clear in the comment. The comment just tried to explain why the return value is 0 and not 1 (which would be also somewhat logical) but ok, will make it more clear.