From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50228C00A8F for ; Tue, 24 Oct 2023 02:02:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7C9A6B0168; Mon, 23 Oct 2023 22:02:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D2BA66B016A; Mon, 23 Oct 2023 22:02:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1A9F6B016B; Mon, 23 Oct 2023 22:02:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AF99D6B0168 for ; Mon, 23 Oct 2023 22:02:35 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 528A740A6E for ; Tue, 24 Oct 2023 02:02:35 +0000 (UTC) X-FDA: 81378705870.18.CE7BD81 Received: from out-191.mta0.migadu.com (out-191.mta0.migadu.com [91.218.175.191]) by imf08.hostedemail.com (Postfix) with ESMTP id 0DA9116000C for ; Tue, 24 Oct 2023 02:02:32 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=h3WFxfSJ; spf=pass (imf08.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.191 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698112953; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bJh3VcxlCB6JG6FhFj/zexR9NXgDMv0p5GP4dzs8Byc=; b=J2XQOqb8hs6WPz3z2w3eTmtEWxZ8qD97xI/eDweXVjekosWbiZsqI4lR9M3SlBa78BqypM gbYUveADGzvNAGBg9+FB3HgaVOLAvR06lEmY2scuGAh0CI0izIADE3MZDTf+ISDMRHHPh7 Sq94f3cPSZHkwPOVW158DcF7GEeD84g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698112953; a=rsa-sha256; cv=none; b=bgmAp6vOi6rVr2XDiqynMjfCCw0fI2e5nSRTUozv4nrikNemik/VvjBLKsCfTJ8MrcZRC1 oY29nSZudBgqq4xqy3zTtkgbYszk49ovCUclbFcbc7Vw0XxGG1IN06uq8msE2CQSjRebjN lr2bLIIWTnuXNLiMArTHG0NQsZR2Uvs= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=h3WFxfSJ; spf=pass (imf08.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.191 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Message-ID: <08a9ee64-c27d-4eed-8762-1514c6eb1c88@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1698112951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bJh3VcxlCB6JG6FhFj/zexR9NXgDMv0p5GP4dzs8Byc=; b=h3WFxfSJ6i9QZyGiLFqFgnx6zo1QpSffo0BypECG+9QLwDvjzXEqYauVXJFzKZi1PgLOBQ SxiNqjxZvBNKMBhXqI3rpm8V4LJykKxjOTrm8DXV/FsIRsxkVbVd2fDicJE/bj9+sJ7Ahv lSfuf9pscZqrtw1fWjCkTP+pC/zCUh4= Date: Tue, 24 Oct 2023 10:02:24 +0800 MIME-Version: 1.0 Subject: Re: [RFC PATCH v2 0/6] slub: Delay freezing of CPU partial slabs Content-Language: en-US To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, willy@infradead.org, pcc@google.com, tytso@mit.edu, maz@kernel.org, ruansy.fnst@fujitsu.com, vishal.moola@gmail.com, lrh2000@pku.edu.cn, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chengming Zhou References: <20231021144317.3400916-1-chengming.zhou@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 0DA9116000C X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: kcn4hsku6jz6cnn1p17tj7izxirxywoy X-HE-Tag: 1698112952-527774 X-HE-Meta: U2FsdGVkX1/o0YdkAmNqA8TtshYyHkEXcq6DV98dk8FBrDXFLOD5cgCCC4cdc4ggn/TJrolc8RrkZYj1DPP3K+UevPQSlkrBHnzKH+o8LTBfbEcm0/b8dEchVQTouW32ARuRuHBrfJ9Tp4kuqjBMwOUuJVg4W42ITmihc9EA7kx+jZhoi3dDQMwRfu1Do4/xYhbbFaEgxH4G29ktYdWwTh7KSjJ3SYi4gd2lD0QjSt9q9sPomx9a4oDk8aHpRL8E1HjaU8hps/EJFMigvnzW+lTIt1en+4DW9vcYlI9VmlyD7JCP/YGz08UBK9uI0MuUlTCJtGTKlM07o9e59aDYOsve4+CFPKX2aRmoKnRW57LKHNU7B++a4I09omPjFPF5rXIiSbWsm/OowdeCccKTPARC4PxltsPnP0UnoktVa4lLfE0WCRYeJeuQOIYsjsg5FgUeYBEywacKIfv1/J8B9TYn1KQ6Rwwn0EewIbZKo0lWHfJOw5UQOJq/Xk9WH4BuWiaA37g2Vi7AWPLkdVImE/bf90kOYmnQ1RB/dSqQSUoJY5IhEG2xUdnN6K+jR7yC+0F3FXRQHQ929T7QZOvTIvjWXqOTrARpjAhz8umVql5eIpE0txuRliSWbP4aY3361q17pynKJTNYlovTLQY5w6LfOma48rE9zYJIyDFee0wkIPnPKgDVjVnk/+QO0lJqmlSA5DZq/AEiqoy7twMGGPUSRGAMm4NCzV9mJzA5XY5L7Z5NFEGjT8fty8CEQRy79WKFBLd17jVCA9i46qQlMaeV+A3cSMxd9pOna9gg5gMFLngLdQz2veaC5fTv2LLpJdWFEPIj8vdSLN8J7A6tYxJanPovdJRMhGu/pClH1roqGyJV21vskhMAAtCTi9yss8PvMTkdcEeHEzG6D0YsLNmdMWUv07dbv2ot2mWN/oLg1HBRekOdDJ/5xjJpISK9PY7TGYIXAnGBKHrKD/V eYeWrqAi HnXSbCLMqtr57o1kpN/Lcg+7FfzLOJJW6XwQ1SyjIaTsibCNrQ5HugkgvTRyEEdjWfjtZvyyVXq58y2Kf04esP+Z/pzhg+lSNTfj5MRR06xcrlfYOY9ol/UzQdX0d6td6sOiuYAGibogXoZOOdK72x7vcW+2bMQxiRRWvInTHAvOdQRKTqknXVyhEy8HEM3eAOJ0jnE2hnGyhybpMVgyFowuWJXfEjldfYw+gx57nV0elcCgRpGNu7LHIvEuONBFXSe9L5+E9x6vfBX3fsgApEtzyy4xKHYuwqgI3WvB6hRjSdQ5113Td4vjJi6Fpm/x/ZkjlYfASmmeJ+tsDW8yYx2+ByFfXbdDUWjzKReys6gmJEjA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023/10/22 22:52, Hyeonggon Yoo wrote: > On Sat, Oct 21, 2023 at 11:43 PM wrote: >> >> From: Chengming Zhou >> >> Changes in RFC v2: >> - Reuse PG_workingset bit to keep track of whether slub is on the >> per-node partial list, as suggested by Matthew Wilcox. >> - Fix OOM problem on kernel without CONFIG_SLUB_CPU_PARTIAL, which >> is caused by leak of partial slabs when get_partial_node(). >> - Add a patch to simplify acquire_slab(). >> - Reorder patches a little. >> - v1: https://lore.kernel.org/all/20231017154439.3036608-1-chengming.zhou@linux.dev/ > > I've picked [1] and tested this patch series and it passed a simple MM > & slab test > in 30 different SLUB configurations [2]. > > Also there's code coverage information [3] if you're interested :P > > For the series, > Tested-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Thank you! These are very helpful to me, I will also do more workloads stress testing with more configurations. > > Will review when I have free time ;) Ok, thanks for your time. > Thanks! > > [1] https://git.kerneltesting.org/slab-experimental/log/ > [2] https://jenkins.kerneltesting.org/job/slab-experimental/ > [3] https://coverage.kerneltesting.org/slab-experimental-6283c415/mm/index.html > >> Chengming Zhou (6): >> slub: Keep track of whether slub is on the per-node partial list >> slub: Prepare __slab_free() for unfrozen partial slab out of node >> partial list >> slub: Don't freeze slabs for cpu partial >> slub: Simplify acquire_slab() >> slub: Introduce get_cpu_partial() >> slub: Optimize deactivate_slab() >> >> include/linux/page-flags.h | 2 + >> mm/slab.h | 19 +++ >> mm/slub.c | 245 +++++++++++++++++++------------------ >> 3 files changed, 150 insertions(+), 116 deletions(-) >> >> -- >> 2.20.1 >>