From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CD73C4829E for ; Thu, 15 Feb 2024 10:55:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 196268D0019; Thu, 15 Feb 2024 05:55:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 146D58D0001; Thu, 15 Feb 2024 05:55:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2A408D0019; Thu, 15 Feb 2024 05:55:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DF79B8D0001 for ; Thu, 15 Feb 2024 05:55:24 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A4E2480FBF for ; Thu, 15 Feb 2024 10:55:24 +0000 (UTC) X-FDA: 81793731768.16.91F640A Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf15.hostedemail.com (Postfix) with ESMTP id 41DD0A001D for ; Thu, 15 Feb 2024 10:55:21 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Med1oLNB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1Q6pc7gW; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Med1oLNB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1Q6pc7gW; dmarc=none; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707994522; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EGovcSwKtSq7xWvCafXr0+DJqD0DGxnDBwIFF2je9d8=; b=Dfwum9rbsXBsWXM4jOiztHxsZLS7zUw3jrn0mw59LdRIkKkpAVExQ1krWi6nH4P/o7P42A poTKhadMFlQFB+x73H/P/Fk7AjbNV+NC/Ws+ssZ2Xdnlad2A3QiYvAkJ6aOsPiiC80GYal nv3sSUm3Vx+CLq4/D2Mr/VcmV10D6Vo= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Med1oLNB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1Q6pc7gW; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Med1oLNB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1Q6pc7gW; dmarc=none; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707994522; a=rsa-sha256; cv=none; b=J77Ux89Mlexsd5+9yCVxjpAahVirkJ7uLuaGpJp5GBQv2DU5AJg/iP0rs/VqkDVZaqH4Al bAInMt1PLxViNY7vY+ruhDmhZnrqjKhgwJt5DY/fq12PTUozBwk6sFftPsAObAnkoYLLcD rxrPfwbe6wHuo3h9ccsWBTye1WYBPlc= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7620121EAD; Thu, 15 Feb 2024 10:55:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1707994520; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EGovcSwKtSq7xWvCafXr0+DJqD0DGxnDBwIFF2je9d8=; b=Med1oLNBn8ZxJaQi8g8abR9bH07zjIDiqfHz5vVXZO+L7FZdhzXlUP8oSLf9mf9Nyq23gY KEZEEzbm66IGnQ5dlpl3PAo+dqQauhiczaI8OckRQZdXBTf4nMuaPnxlOfBMs5Sfs8zclj tiwZc2dN5rtc0Smzl9i9Mht9OS7ODGk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1707994520; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EGovcSwKtSq7xWvCafXr0+DJqD0DGxnDBwIFF2je9d8=; b=1Q6pc7gWYUiEcvWs+VGr5UkOJAPDG3idD38iOFbVW6Tx09REjnsWsYt6zh/xmFY49gJlsb EuzM+ZdnXD1mAVCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1707994520; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EGovcSwKtSq7xWvCafXr0+DJqD0DGxnDBwIFF2je9d8=; b=Med1oLNBn8ZxJaQi8g8abR9bH07zjIDiqfHz5vVXZO+L7FZdhzXlUP8oSLf9mf9Nyq23gY KEZEEzbm66IGnQ5dlpl3PAo+dqQauhiczaI8OckRQZdXBTf4nMuaPnxlOfBMs5Sfs8zclj tiwZc2dN5rtc0Smzl9i9Mht9OS7ODGk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1707994520; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EGovcSwKtSq7xWvCafXr0+DJqD0DGxnDBwIFF2je9d8=; b=1Q6pc7gWYUiEcvWs+VGr5UkOJAPDG3idD38iOFbVW6Tx09REjnsWsYt6zh/xmFY49gJlsb EuzM+ZdnXD1mAVCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6162813A53; Thu, 15 Feb 2024 10:55:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 1/hrF5jtzWXAMAAAD6G6ig (envelope-from ); Thu, 15 Feb 2024 10:55:20 +0000 Message-ID: <08a08ea2-6764-48af-8883-84639c732ce5@suse.cz> Date: Thu, 15 Feb 2024 11:55:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 3/7] mm,page_owner: Maintain own list of stack_records structs Content-Language: en-US To: Oscar Salvador , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Marco Elver , Andrey Konovalov , Alexander Potapenko References: <20240214170157.17530-1-osalvador@suse.de> <20240214170157.17530-4-osalvador@suse.de> From: Vlastimil Babka In-Reply-To: <20240214170157.17530-4-osalvador@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 41DD0A001D X-Stat-Signature: bqdcewx6wojqs7f9rfx754n776j1cr8e X-HE-Tag: 1707994521-259330 X-HE-Meta: U2FsdGVkX1+IHcNEpyuMZsCcO/ZvvHNPgug9qq6KYKs8Fk6YdD8TNwZUIdNqRg/UN+JtqUmx136eCDgg7E6PscuAx5jFF7LEbBKV97/v7qxeMuYZ5hth1F4wQIL9QfO0wQjWISJBcL3CTZFctwF+KZILafA46yaJSpGj56i08bZkOBvxCZbK41DnO3ofNAr57HcO/TVnBi08f5YksAaXEEN6iiaSk56/Fw0qspa0qOOyDSzu2JAyUk898a9tiwDWKgWnkwLUueO7Ej7NFnYSBAzgfWY9TjqAoNP0E8wIO/ptN+aMkCiKLetrsfQMfZkx1qaMQxm6fUscFiJqFIzZ+UiamYUgSKunsthZmrXS1tupZYqzcVGQ/9wr21eyJmpkzwxxWpRjxHH9eNnuQSeGZsZpTG8sByLo2UgGo3x2QX/Kva7UIqbRcJno2eyzfh+mPPgKUTo3I0Hi0HMv5dxf1DZZ2P4TpjuqnZzjlOywhvAG36KQM5Mvtq8faU/Y9riqKBADXYcYWtznU5KNgdrtycfo9YAQTqWNfEiSHF2e5ZLo4LQJnXHTiIx9QCeZBNYPMR015rxHYdN73xX+eYw2sjhhPPul7b1cSk0MWY//ZVaBGT5dkkO5wEHJTCLkTsBtntp0bp4E2SV9JK2fH28PBJxXeDQO/vlthMwPIrGN5E6FWVuJITsnljQdefJbYONqbH5ARMYEjYs3jcE+jWjUIyrlY1HZ/6c5uIYvd4fZ5sQT2qFs9C+Dwfh3RW7Pu4HWlh4rFQB/FnJ6btpe/QTTK8SK+6xC7DdDdeskSczcrz518t0huuBUTAqMp4Bf8n5+HFAPS9FYJdGeqDpIL7w03lMXv781xb2+/+2FYm/NtHBtwRk+7LBtZT1tEzDUO6L7hhGmBAi1Bdb8WbJDRIwkzwGE3mfB/Yw9JFHZcPffzWSwSTbkzRwiQRydL69y96r05DW2/U5VVSwkHRnjLbO JXRG36zW 944p4LniuK1+3hvpDqOK+d3O7RimQwgX2Zn4YKysjEfVYPCnQ1wpOUl/egFcOzotA47PsZHP9jFHHHRTF38hfh3Vpc7btLFzOzdXbPa4tNYdzMPo/x0MKZ8Nrvoy8HEaBHs2qA6I6XVMNe7fBzzmOUpaFJwOY2dKJH/QuGvvCnr+0cQM8AAqJioxNUcDvVgAsttUA+M2YlPZC54DqZVa22H3VI97YaQPXGVSSFLouh9TqlfhTKOHlNz0ny9A6FgewKxJ6u0kPvIPt53Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000046, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/14/24 18:01, Oscar Salvador wrote: > page_owner needs to increment a stack_record refcount when a new allocation > occurs, and decrement it on a free operation. > In order to do that, we need to have a way to get a stack_record from a > handle. > Implement __stack_depot_get_stack_record() which just does that, and make > it public so page_owner can use it. > > Also, traversing all stackdepot buckets comes with its own complexity, > plus we would have to implement a way to mark only those stack_records > that were originated from page_owner, as those are the ones we are > interested in. > For that reason, page_owner maintains its own list of stack_records, > because traversing that list is faster than traversing all buckets > while keeping at the same time a low complexity. > > For now, add to stack_list only the stack_records of dummy_handle and > failure_handle, and set their refcount of 1. > > Further patches will add code to increment or decrement stack_records > count on allocation and free operation. > > Signed-off-by: Oscar Salvador Reviewed-by: Vlastimil Babka