From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82A57C43381 for ; Tue, 19 Mar 2019 00:18:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2A7B9213F2 for ; Tue, 19 Mar 2019 00:18:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="AuNkqTaW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A7B9213F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C00716B0005; Mon, 18 Mar 2019 20:18:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB0576B0006; Mon, 18 Mar 2019 20:18:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9E476B0007; Mon, 18 Mar 2019 20:18:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-yw1-f69.google.com (mail-yw1-f69.google.com [209.85.161.69]) by kanga.kvack.org (Postfix) with ESMTP id 7B1EB6B0005 for ; Mon, 18 Mar 2019 20:18:03 -0400 (EDT) Received: by mail-yw1-f69.google.com with SMTP id z185so15138779ywd.8 for ; Mon, 18 Mar 2019 17:18:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Lldu1vG/QH2WxFVnpbDniVg4v7Xl0DVSsToxUgGZAEY=; b=GVL4XSoxYsS9BaVZOEcvr3nvPhPl8CVbufxK0rCMS1YhocdOulG9p+MiFWNVSpwNwW s7MePQJgyOOrEmkdM4NhnGw4Rt0sxdSZqwaUtFs3DKrncsY0oT54RhqtTnXjlN8aTa72 ZNXsIvEJjoZlLcFTYMXadI3Q7kwn1n7GMikxh1rC6RQppzRdwKqyE0Ar1nNcT1lSWx+C q4EcgDjonf/G6+57zbzZrduZ2QLEiBc3OioSvreUPrrtRunYnh/9+5RsFBe54GCTm9xa ZwZ/BB3iPhKpF0lO734ry5RQZ9F459qbq1eWOxiHaGKxcOE1G76avjsn4fWJ/gpRlU+E GUiA== X-Gm-Message-State: APjAAAWmoHvZK3mRthU1w8ElQX95OipcGaebzZFViFmILLrXjBkLpCeT pvQBanWnuFZgvsTyecCNZaFZwrMMJHUA4q++42PFD5nEYC38AzC3DhtsMQZaMIoNX2UL8p09ONf p/b748lgmnRUkF0G6jBs8BKwlnkJjx5BTc91PPvT3no1UH56P4zf281z+si2i50pfuw== X-Received: by 2002:a25:1e42:: with SMTP id e63mr16538122ybe.485.1552954683227; Mon, 18 Mar 2019 17:18:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqxixMEube2H5ASLbNg8m9Llt+9yjODD8ObVle5x2XLaK8hM0lFtVMAxqDgGxwNueNKJltKu X-Received: by 2002:a25:1e42:: with SMTP id e63mr16538081ybe.485.1552954682200; Mon, 18 Mar 2019 17:18:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552954682; cv=none; d=google.com; s=arc-20160816; b=sg2IzXupqMQ04YIETcqCzQlmLBmTZHNg0S3rfX+re3hYmoYP0qt9QbJaUYsgZqaO4S /zJw075TKXE8zT6AxoNpmL1UEvb23bRnsZMGlULlGzH3/b4VWyFmkKHQiB1BrkWZRC5u 3N4HsAWmM8NVbAnN8meKEV3L3vx/qdsQYbaS9G51CeEweV0MdQPVWrxjrVP1V3tiUEVQ UtwVj0GLfwoRMRXO7NWExKIi8/6zN6KPA3MAhTFbnHbxreGQ15Fi8qMYQLt8+c9bm/nP tiFTNd9+PHmwVptz9f8kuPBvaaq7jo7zKaY3YPPrAgcum6fztWK1SdtwSxq7l2V+MpQ4 eW0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :dkim-signature; bh=Lldu1vG/QH2WxFVnpbDniVg4v7Xl0DVSsToxUgGZAEY=; b=XnudJOX1vCnsUfUExAPR7FCeCoGldqt8YJ/iWBIOFTCcWduPMfsIgm1NZYuYMSS9Fi 27O4a1B+baied0lANWaqZ2t+gxPVr2Z0OgAI2Jhv3JdJ/7DoCYXyaJGb3y+xLIrcs6ss DnwRj1RkdYvMmqKQ/dc+lVNzPqIH9S2dSNHyFCBGOombrN9peDOnWPerPna4MGDypiP5 IEgrPCu8lWwiZA0t0PSZe43+JcsmcZv8B3ZCj5ZTHnMYnaNzoGUmbjKUk61hDlgEGS/c R0dklk3uyMAp+qnaiVbfbuaT8MuFuf18cVq4oLudO9Y40Z7YFPkTPTdOEogd0bsJQKC6 PEhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=AuNkqTaW; spf=pass (google.com: domain of mike.kravetz@oracle.com designates 156.151.31.85 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from userp2120.oracle.com (userp2120.oracle.com. [156.151.31.85]) by mx.google.com with ESMTPS id m128si2985366ywf.426.2019.03.18.17.18.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Mar 2019 17:18:02 -0700 (PDT) Received-SPF: pass (google.com: domain of mike.kravetz@oracle.com designates 156.151.31.85 as permitted sender) client-ip=156.151.31.85; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=AuNkqTaW; spf=pass (google.com: domain of mike.kravetz@oracle.com designates 156.151.31.85 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x2J04vYj144116; Tue, 19 Mar 2019 00:17:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=Lldu1vG/QH2WxFVnpbDniVg4v7Xl0DVSsToxUgGZAEY=; b=AuNkqTaWgAsBO97qvRjuPcAPyrz2oYRov0fO+QB5qRQvEEc8oYPvd5frhBaootArwSNO hftVfJmnQVg4vbXgVWqyWEDxgcBurBeX8FOVnMag5s0w0HSI5j/oFdQ9iKTgXRJcxDbq u880Vuub4Pir02Z1wPsX5L9u0uJSpRB5l8I5BYFjJ2y4FAMfzQSiodtZh+SBuIbIfem9 qsLMij9K8eNb9Yyrf+bPPkqtIrZWDm6y36mTPvKLotUX739qcjYz1rscLFdwi0RENMqp mm5H7nC99QoaJVfrTQByW864c6RVko+5R2NUIwF0vCN5BQ76GZzcUIJTfIjsIYEo5Gd0 iA== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2r8ssr9gys-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Mar 2019 00:17:46 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x2J0Hkca030025 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Mar 2019 00:17:46 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x2J0HjDJ020737; Tue, 19 Mar 2019 00:17:45 GMT Received: from [192.168.1.222] (/50.38.38.67) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 18 Mar 2019 17:17:45 -0700 Subject: Re: [PATCH] include/linux/hugetlb.h: Convert to use vm_fault_t To: Souptick Joarder , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, willy@infradead.org References: <20190318162604.GA31553@jordon-HP-15-Notebook-PC> From: Mike Kravetz Message-ID: <08a039da-6bc2-0da9-e83e-46cce6d7264b@oracle.com> Date: Mon, 18 Mar 2019 17:17:44 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190318162604.GA31553@jordon-HP-15-Notebook-PC> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9199 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903180166 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/18/19 9:26 AM, Souptick Joarder wrote: > kbuild produces the below warning -> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: 5453a3df2a5eb49bc24615d4cf0d66b2aae05e5f > commit 3d3539018d2c ("mm: create the new vm_fault_t type") > reproduce: > # apt-get install sparse > git checkout 3d3539018d2cbd12e5af4a132636ee7fd8d43ef0 > make ARCH=x86_64 allmodconfig > make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' > >>> mm/memory.c:3968:21: sparse: incorrect type in assignment (different >>> base types) @@ expected restricted vm_fault_t [usertype] ret @@ >>> got e] ret @@ > mm/memory.c:3968:21: expected restricted vm_fault_t [usertype] ret > mm/memory.c:3968:21: got int > > This patch will convert to return vm_fault_t type for hugetlb_fault() > when CONFIG_HUGETLB_PAGE =n. > > Signed-off-by: Souptick Joarder Thanks for fixing this. The BUG() here and in several other places in this file is unnecessary and IMO should be cleaned up. But that is beyond the scope of this fix. Added to my to do list. Reviewed-by: Mike Kravetz -- Mike Kravetz