From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89E28C001DC for ; Wed, 26 Jul 2023 07:14:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11192900002; Wed, 26 Jul 2023 03:14:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C2128D0001; Wed, 26 Jul 2023 03:14:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA457900002; Wed, 26 Jul 2023 03:14:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DA2448D0001 for ; Wed, 26 Jul 2023 03:14:05 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B338EA0327 for ; Wed, 26 Jul 2023 07:14:05 +0000 (UTC) X-FDA: 81052898850.02.9A4C227 Received: from out-20.mta0.migadu.com (out-20.mta0.migadu.com [91.218.175.20]) by imf29.hostedemail.com (Postfix) with ESMTP id E170512000E for ; Wed, 26 Jul 2023 07:14:03 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=oAdnd9nZ; spf=pass (imf29.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.20 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690355644; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PGcKZp3hFkU5xFrSCjAkw6H7DFoCu3eaWoJYWwGl/BE=; b=3ir643kMyjAw4bnNw3s5S8wperfhODgjToNo9F72KwfnNZmytSwjivnMV9Rygo3eHLdSPU slGjGsbQvuOaLZsvycXfBbdkE731bw/bh33J9QSUFL2wbAYTXwdXek0Pd2JzypuUrr8i4Z K2KEeotdlGYI/ZCs40ubBcvSb9sN+lg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690355644; a=rsa-sha256; cv=none; b=3IP+WN2gtus0YVDVtlzECIJ47ivoaH5ErSIdrI3jmy/IIlEZ+HxP6wpcR7R/dmIXbn+DD4 9ya+/xF8IXb7VUdET3YBDqrZ5uiA3dSSjq2eDmdfTSPDE89WqPworpDywe1Mzuvkk4ucCA 8m1JYjRN8m2M5gXfni8PkmZURuFKDac= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=oAdnd9nZ; spf=pass (imf29.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.20 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1690355641; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PGcKZp3hFkU5xFrSCjAkw6H7DFoCu3eaWoJYWwGl/BE=; b=oAdnd9nZjeI3kyPEsvbWMnutbGwA6A/dnneU8CJq7+Jt5loXWooRhnwIByjGtqjMSkXONA pNjiGN0aO6zYh0sGJrXLfhIGW2JwY9JyCA6cMT7CdHDW/adI6zyBptMVHroPA7pSViOJ/f hCfYb58R4eJqbPwcBX6PzM13HtrcK50= MIME-Version: 1.0 Subject: Re: [PATCH v2 21/47] mm: workingset: dynamically allocate the mm-shadow shrinker X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20230724094354.90817-22-zhengqi.arch@bytedance.com> Date: Wed, 26 Jul 2023 15:13:37 +0800 Cc: Andrew Morton , david@fromorbit.com, tkhai@ya.ru, Vlastimil Babka , Roman Gushchin , djwong@kernel.org, Christian Brauner , "Paul E. McKenney" , tytso@mit.edu, steven.price@arm.com, cel@kernel.org, Sergey Senozhatsky , yujie.liu@intel.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <08F2140B-0684-4FB0-8FB9-CEB88882F884@linux.dev> References: <20230724094354.90817-1-zhengqi.arch@bytedance.com> <20230724094354.90817-22-zhengqi.arch@bytedance.com> To: Qi Zheng X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: E170512000E X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 9ioamyixq5mip3jqmg6otnrf7wnzw1uu X-HE-Tag: 1690355643-7348 X-HE-Meta: U2FsdGVkX1/LfFCB+cL+bVGtGB4WsftzNAQ01d68T7K9p14BrBztGA66X65ghLtdlesGUA0z2nEg+PqjwKiwTqlSx0QJHLr4J5qgKgW/V7PS/NsS6AtIWpf7mFNGrb+GV7bUbapHCX7HnbJ1SQqb4pIwivAS8GlzTlLldhKKDHqjs9tfg1VDa8r9+7nGTCOTgvZSbYU3WGmQT1/GR8/B3YYUsAQv/iYcg8cpGKLQDgJR3SmP4+4BNUK2iJWyKgT15H4X7D241ThG30syZtd+LGhfvddojImakHQbQ9PgWi2IN1LgtRMqKvsWc5l0EvAPIf72UCtBdJ4izHMaBNrSkamPdUnzhipXIRQ++cA2L+hYxWiOn65R6LZo4Ne3nmzNlqAk6CVJx+meQZsVhtIC12aLEX2k+fw0BSaijV0mw2sB9/NaqAWezDpTaPDdnM9u3aTwc8KHSFIfQ0/GQF0zh1usHb7wJsc8SHzRenJF8nU7RQTdrksK0ZgeMDybh7NcQCSLCmZHVsdzenyNWbXdhI83plVzhL5IxIfJ8kVspNuW6eVTPnRtf1IvLLd14Py5+yTI1E2YDV2DTlirXw0cabVrNEvLpsLFY0aN5j9YkAWHBzuYhnCE2ZjwECLzOewJSRqGbxLyr0dNwft0+2TNGJ/GQGihArqr609V5wBD6fXOycFwRimlaaOdlR9nUj56cdk/HMiiEAZ5VzAaTKzyA/HUuLUKRykYDIBzK48A/3Rb+9uyI0TdAnrjN3ozDOiAsuMT/xMfqsNJt9o2FLsBVOMzFf1y5DenqW0/A4AR5+4YCNWbqkWaLHdVU5BSoOeUtIUYFWZQnzU/57Mv8tLVz4U0GvurxoNhQLrSFk3um9MPzo/k/GaowR+6w9c5UaJslQ34Z+ETn7rl/Vt48y/0Gk+P8KmChxM/J8VQlaK6bBrgohGxLbbjG1U1X/KxKVxbneS1sb7cWhVFq1Vofoy yzkHehK8 TbWTyvYCQEnR0q9QNnlWfRnbAUvGOUqLZLZoOT5YcC28j6YfX4PxsGij18bhMsD5VDqteHFARVOwo6KHn45QP4YZIBB2/RlooeEoKrFoR9EpI7E5PvGAhKWmO25a6LbbxT84X6efkwBSRKTFByRN7tp1dGA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Jul 24, 2023, at 17:43, Qi Zheng = wrote: >=20 > Use new APIs to dynamically allocate the mm-shadow shrinker. >=20 > Signed-off-by: Qi Zheng > --- > mm/workingset.c | 26 ++++++++++++++------------ > 1 file changed, 14 insertions(+), 12 deletions(-) >=20 > diff --git a/mm/workingset.c b/mm/workingset.c > index 4686ae363000..4bc85f739b13 100644 > --- a/mm/workingset.c > +++ b/mm/workingset.c > @@ -762,12 +762,7 @@ static unsigned long scan_shadow_nodes(struct = shrinker *shrinker, > NULL); > } >=20 > -static struct shrinker workingset_shadow_shrinker =3D { > - .count_objects =3D count_shadow_nodes, > - .scan_objects =3D scan_shadow_nodes, > - .seeks =3D 0, /* ->count reports only fully expendable nodes */ > - .flags =3D SHRINKER_NUMA_AWARE | SHRINKER_MEMCG_AWARE, > -}; > +static struct shrinker *workingset_shadow_shrinker; Same as patch #17.=