From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A560FC433E1 for ; Sat, 11 Jul 2020 00:15:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 408A1206E2 for ; Sat, 11 Jul 2020 00:15:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="sFCpMDdC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 408A1206E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7E8198D0002; Fri, 10 Jul 2020 20:15:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7986E8D0001; Fri, 10 Jul 2020 20:15:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AE808D0002; Fri, 10 Jul 2020 20:15:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0177.hostedemail.com [216.40.44.177]) by kanga.kvack.org (Postfix) with ESMTP id 526688D0001 for ; Fri, 10 Jul 2020 20:15:46 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C996E1DFA for ; Sat, 11 Jul 2020 00:15:45 +0000 (UTC) X-FDA: 77023876650.28.paint25_3509c9626ed2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 97E336D73 for ; Sat, 11 Jul 2020 00:15:45 +0000 (UTC) X-HE-Tag: paint25_3509c9626ed2 X-Filterd-Recvd-Size: 4480 Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Sat, 11 Jul 2020 00:15:45 +0000 (UTC) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06B0DJaf158543; Sat, 11 Jul 2020 00:15:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2020-01-29; bh=v1UFry32+YsdtPZ1psckNjwFVSv8EvNDK1mogxsw8Kc=; b=sFCpMDdCrGshxa2Gf+ulXvlvG/aD5gc6zHqU023F0vuZ5+QcnkvpKC0NBcHqVIgkZcPd ZozE3q0kTi7eXlHieSOx8oqBGiHIz5Yk/HG1qfQThj/JK25idsICDykZoIP3t/L1GLjy SlBQABQYfQrqiv2onrJqCD89Cz+mYsd/2NbTjMjZFyCTJj71ayjAlmBb9ahOedaU3J9A 26eIEo6rM0nTUkgXeFsVuU6ckq/GKKz4PRhegBBXHWZ1JjwDvmb35GiocHPXV8G9RqFd x0N6N5sl1fBO+8Vpu1q+LT68yK89Xe5MxcbzJQyj3DckFSDPklHYLBHaFSxuAq+Vyl/W rw== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 325y0at60u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 11 Jul 2020 00:15:35 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06B0DQd9155892; Sat, 11 Jul 2020 00:15:34 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 325k3kpc0y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 11 Jul 2020 00:15:34 +0000 Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 06B0FSsP018113; Sat, 11 Jul 2020 00:15:28 GMT Received: from [192.168.0.110] (/73.243.10.6) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 10 Jul 2020 17:15:27 -0700 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3645.0.6.2.4\)) Subject: Re: [PATCH 0/4] Remove/consolidate calls to find_get_entry From: William Kucharski In-Reply-To: <20200710202642.21794-1-willy@infradead.org> Date: Fri, 10 Jul 2020 18:15:27 -0600 Cc: linux-mm@kvack.org Content-Transfer-Encoding: quoted-printable Message-Id: <08A60502-E4C8-4C7A-9481-BD7A14931392@oracle.com> References: <20200710202642.21794-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" X-Mailer: Apple Mail (2.3645.0.6.2.4) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9678 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 mlxlogscore=999 bulkscore=0 spamscore=0 mlxscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007100160 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9678 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 priorityscore=1501 spamscore=0 phishscore=0 clxscore=1015 mlxlogscore=999 lowpriorityscore=0 malwarescore=0 bulkscore=0 suspectscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007100160 X-Rspamd-Queue-Id: 97E336D73 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Nice cleanups and bug fix. For the series: Reviewed-by: William Kucharski > On Jul 10, 2020, at 2:26 PM, Matthew Wilcox (Oracle) = wrote: >=20 > As part of the THP work, I audited the callers of find_get_entry() and > found one bug and three opportunities for optimisation. Patch 2 is = the > bugfix as it depends on using the same code as mincore_page(). >=20 > I don't really like having find_get_swap_page() in mincore.c, but I > can't find anywhere better to put it. >=20 > Matthew Wilcox (Oracle) (4): > mm: Factor find_get_swap_page out of mincore_page > mm: Use find_get_swap_page in memcontrol > mm: Optimise madvise WILLNEED > proc: Optimise smaps for shmem entries >=20 > fs/proc/task_mmu.c | 8 +----- > include/linux/pagemap.h | 1 + > mm/madvise.c | 20 +++++++------- > mm/memcontrol.c | 25 ++--------------- > mm/mincore.c | 59 +++++++++++++++++++++++------------------ > 5 files changed, 47 insertions(+), 66 deletions(-) >=20 > --=20 > 2.27.0 >=20 >=20